[ https://issues.apache.org/jira/browse/SOLR-17141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816644#comment-17816644 ]
Andrzej Bialecki edited comment on SOLR-17141 at 2/12/24 3:29 PM: ------------------------------------------------------------------ [~gus] and I discussed this issue - the way {{ThreadStats}} is used in SOLR-16986 gives incomplete results because it ignores nested queries (which use the stack in {{SolrRequestInfo}}). We would like to fix this as part of the SOLR-17138 refactoring, and to avoid potential confusion when logged CPU time is different than the CPU time limit set here. This can be done when both the {{CpuQueryTimeLimit}} and {{ThreadStats}} use the same starting point but keep track of nested requests. was (Author: ab): [~gus] and I discussed this issue - the way {{ThreadStats}} is used in SOLR-16986 gives incomplete results because it ignores nested queries (which use the stack in {{{}SolrRequestInfo{}}}. We would like to fix this as part of the SOLR-17138 refactoring, and to avoid potential confusion when logged CPU time is different than the CPU time limit set here. This can be done when both the {{CpuQueryTimeLimit}} and {{ThreadStats}} use the same starting point but keep track of nested requests. > Create CpuQueryLimit implementation > ----------------------------------- > > Key: SOLR-17141 > URL: https://issues.apache.org/jira/browse/SOLR-17141 > Project: Solr > Issue Type: Sub-task > Reporter: Andrzej Bialecki > Assignee: Andrzej Bialecki > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > This class will use `getThreadCpuTime` to determine when to signal > `shouldExit`. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org