[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-02-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815874#comment-17815874 ] ASF subversion and git services commented on SOLR-16858: Commit d

[jira] [Resolved] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-02-08 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter resolved SOLR-16858. --- Fix Version/s: 9.6.0 Resolution: Fixed thanks for all the review folks! > All

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-02-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815865#comment-17815865 ] ASF subversion and git services commented on SOLR-16858: Commit b

Re: [PR] SOLR-16858: new localparams for knn to override pre-filtering behavior: fq, includeTags, & excludeTags [solr]

2024-02-08 Thread via GitHub
asfgit closed pull request #2157: SOLR-16858: new localparams for knn to override pre-filtering behavior: fq, includeTags, & excludeTags URL: https://github.com/apache/solr/pull/2157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-02-08 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815862#comment-17815862 ] Noble Paul commented on SOLR-13350: --- I think this must be purely a request parameter. I

[jira] [Updated] (SOLR-17156) BJQParserTest failure

2024-02-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-17156: Attachment: second block is added with parent moved first.txt Status: Open (was: Op

[jira] [Commented] (SOLR-17148) Config API lies about setting cache enabled=false

2024-02-08 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815831#comment-17815831 ] Chris M. Hostetter commented on SOLR-17148: --- {quote}...we tend to be skeptical

[jira] [Updated] (SOLR-17156) BJQParserTest failure

2024-02-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-17156: Priority: Major (was: Minor) > BJQParserTest failure > -- > >

[jira] [Commented] (SOLR-17156) BJQParserTest failure

2024-02-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815826#comment-17815826 ] Mikhail Khludnev commented on SOLR-17156: - It's weird. Here's the first parent {{

[jira] [Updated] (SOLR-16203) Using SPI lookups of analysis components results in factories that don't get ResourceLoaderAware.inform called on them (When using ClassicIndexSchemaFactory)

2024-02-08 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-16203: -- Fix Version/s: 9.4.1 > Using SPI lookups of analysis components results in factories that don't

Re: [PR] SOLR-17066: Switch Http2SolrClient away from coreURLs [solr]

2024-02-08 Thread via GitHub
epugh commented on code in PR #2255: URL: https://github.com/apache/solr/pull/2255#discussion_r1483492801 ## solr/core/src/java/org/apache/solr/cli/PostLogsTool.java: ## @@ -89,9 +90,16 @@ public void runImpl(CommandLine cli) throws Exception { } public void runCommand(S

[PR] SOLR-17066: Switch Http2SolrClient away from coreURLs [solr]

2024-02-08 Thread via GitHub
gerlowskija opened a new pull request, #2255: URL: https://github.com/apache/solr/pull/2255 https://issues.apache.org/jira/browse/SOLR-17066 # Description SOLR-17066 introduced a `withDefaultCollection` builder method that can be used in lieu of providing a core URL as a "b

Re: [PR] SOLR-17066: Switch most SolrClients away from core URLs [solr]

2024-02-08 Thread via GitHub
gerlowskija commented on code in PR #2254: URL: https://github.com/apache/solr/pull/2254#discussion_r1483457600 ## solr/solrj/src/test/org/apache/solr/client/solrj/TestLBHttp2SolrClient.java: ## @@ -156,7 +158,7 @@ public void testSimple() throws Exception { // Start the

Re: [PR] SOLR-17066: Switch most SolrClients away from core URLs [solr]

2024-02-08 Thread via GitHub
epugh commented on code in PR #2254: URL: https://github.com/apache/solr/pull/2254#discussion_r1483374117 ## solr/core/src/test/org/apache/solr/client/solrj/impl/ConnectionReuseTest.java: ## @@ -83,7 +83,8 @@ private SolrClient buildClient(CloseableHttpClient httpClient, URL ur

[PR] SOLR-17066: Switch most SolrClients away from core URLs [solr]

2024-02-08 Thread via GitHub
gerlowskija opened a new pull request, #2254: URL: https://github.com/apache/solr/pull/2254 https://issues.apache.org/jira/browse/SOLR-17066 # Description SOLR-17066 introduced a `withDefaultCollection` builder method that can be used in lieu of providing a core URL as a "base"

[jira] [Commented] (SOLR-7187) SolrCloud does not fully clean collection after delete

2024-02-08 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815771#comment-17815771 ] Michael Gibney commented on SOLR-7187: -- This is still an issue; I encountered it whil

[jira] [Commented] (SOLR-17132) LTR model upload API issue

2024-02-08 Thread rajanimaski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815768#comment-17815768 ] rajanimaski commented on SOLR-17132: Thank you for looking into this one [~noble.paul

[jira] [Resolved] (SOLR-17132) LTR model upload API issue

2024-02-08 Thread rajanimaski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] rajanimaski resolved SOLR-17132. Resolution: Won't Fix > LTR model upload API issue > -- > >

Re: [PR] SOLR-16391: Tweak v2 'CREATECORE' API to be more REST-ful [solr]

2024-02-08 Thread via GitHub
gerlowskija commented on code in PR #2235: URL: https://github.com/apache/solr/pull/2235#discussion_r1483286529 ## solr/api/src/java/org/apache/solr/client/api/endpoint/CreateCoreApi.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Commented] (SOLR-17148) Config API lies about setting cache enabled=false

2024-02-08 Thread Sanjay Dutt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815761#comment-17815761 ] Sanjay Dutt commented on SOLR-17148: Also one more point, earlier If cache disabled i

Re: [PR] SOLR-17148: Fixing Config API overlay property enabling or disabling cache [solr]

2024-02-08 Thread via GitHub
iamsanjay commented on code in PR #2247: URL: https://github.com/apache/solr/pull/2247#discussion_r1483290620 ## solr/core/src/test/org/apache/solr/core/TestSolrConfigHandler.java: ## @@ -1011,4 +1011,61 @@ public static LinkedHashMapWriter getRespMap(String path, RestTestHarne

[jira] [Commented] (SOLR-17148) Config API lies about setting cache enabled=false

2024-02-08 Thread Sanjay Dutt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815757#comment-17815757 ] Sanjay Dutt commented on SOLR-17148: [~epugh]  Totally agree on robust integration te

Re: [PR] SOLR-17148: Fixing Config API overlay property enabling or disabling cache [solr]

2024-02-08 Thread via GitHub
epugh commented on code in PR #2247: URL: https://github.com/apache/solr/pull/2247#discussion_r1483277681 ## solr/core/src/test/org/apache/solr/core/TestSolrConfigHandler.java: ## @@ -1011,4 +1011,61 @@ public static LinkedHashMapWriter getRespMap(String path, RestTestHarness r

[jira] [Commented] (SOLR-17148) Config API lies about setting cache enabled=false

2024-02-08 Thread Sanjay Dutt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815755#comment-17815755 ] Sanjay Dutt commented on SOLR-17148: Added few test cases. Getting searcher object wa

[jira] [Commented] (SOLR-17148) Config API lies about setting cache enabled=false

2024-02-08 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815753#comment-17815753 ] Eric Pugh commented on SOLR-17148: -- [~duttsanjay] to give you some context, I don't know

[jira] [Commented] (SOLR-17066) Deprecate and remove core URLs in HttpSolrClient and friends

2024-02-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815751#comment-17815751 ] ASF subversion and git services commented on SOLR-17066: Commit 3

[jira] [Commented] (SOLR-17066) Deprecate and remove core URLs in HttpSolrClient and friends

2024-02-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815723#comment-17815723 ] ASF subversion and git services commented on SOLR-17066: Commit a

Re: [PR] SOLR-17066: Switch HttpSolrClient away from coreURLs, pt 3 [solr]

2024-02-08 Thread via GitHub
gerlowskija merged PR #2240: URL: https://github.com/apache/solr/pull/2240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[jira] [Commented] (SOLR-17156) BJQParserTest failure

2024-02-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815718#comment-17815718 ] Mikhail Khludnev commented on SOLR-17156: - perfect! Reproduced it locally. Thanks

[jira] [Updated] (SOLR-16466) Admin UI - Make it optional to sort list of commandline args

2024-02-08 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-16466: --- Fix Version/s: 9.6.0 > Admin UI - Make it optional to sort list of commandline args >

Re: [PR] SOLR-17066: Switch HttpSolrClient away from coreURLs, pt 3 [solr]

2024-02-08 Thread via GitHub
gerlowskija commented on PR #2240: URL: https://github.com/apache/solr/pull/2240#issuecomment-1934306939 > gradlew :solr:core:test --tests "org.apache.solr.cloud.TestPrepRecovery.testLeaderNotResponding" -Ptests.jvms=96 > [...] -Ptests.jvms=96 [...] 🤯 Man, easy to forget someti

Re: [PR] SOLR-17066: Switch HttpSolrClient away from coreURLs, pt 3 [solr]

2024-02-08 Thread via GitHub
epugh commented on code in PR #2240: URL: https://github.com/apache/solr/pull/2240#discussion_r1483120746 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttpSolrClient.java: ## @@ -122,10 +122,14 @@ protected HttpSolrClient makeSolrClient(String server) { HttpSo

Re: [PR] SOLR-17066: Switch HttpSolrClient away from coreURLs, pt 3 [solr]

2024-02-08 Thread via GitHub
epugh commented on PR #2240: URL: https://github.com/apache/solr/pull/2240#issuecomment-1934305634 This all LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] SOLR-17066: Switch HttpSolrClient away from coreURLs, pt 3 [solr]

2024-02-08 Thread via GitHub
epugh commented on code in PR #2240: URL: https://github.com/apache/solr/pull/2240#discussion_r1483121724 ## solr/core/src/test/org/apache/solr/cloud/AliasIntegrationTest.java: ## @@ -968,8 +968,7 @@ private void searchSeveralWays( // HttpSolrClient JettySolrRunner

Re: [PR] SOLR-17066: Switch HttpSolrClient away from coreURLs, pt 3 [solr]

2024-02-08 Thread via GitHub
gerlowskija commented on code in PR #2240: URL: https://github.com/apache/solr/pull/2240#discussion_r1483085322 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttpSolrClient.java: ## @@ -122,10 +122,14 @@ protected HttpSolrClient makeSolrClient(String server) {

[jira] [Commented] (SOLR-16858) Allow KnnQParser to selectively apply filters

2024-02-08 Thread Elia Porciani (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815682#comment-17815682 ] Elia Porciani commented on SOLR-16858: -- I've just gone through the code, and the cha

[jira] [Commented] (SOLR-17150) Create MemQueryLimit implementation

2024-02-08 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815673#comment-17815673 ] Andrzej Bialecki commented on SOLR-17150: - Here's the proposed approach to implem

[jira] [Created] (SOLR-17156) BJQParserTest failure

2024-02-08 Thread Mikhail Khludnev (Jira)
Mikhail Khludnev created SOLR-17156: --- Summary: BJQParserTest failure Key: SOLR-17156 URL: https://issues.apache.org/jira/browse/SOLR-17156 Project: Solr Issue Type: Bug Security Leve

Re: [PR] dev-docs + help: try-and-tweak 'Solr X Lucene' docs [solr]

2024-02-08 Thread via GitHub
cpoerschke merged PR #2223: URL: https://github.com/apache/solr/pull/2223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

Re: [PR] example/films: README.md and vectors tweaks [solr]

2024-02-08 Thread via GitHub
cpoerschke commented on PR #2238: URL: https://github.com/apache/solr/pull/2238#issuecomment-1933997390 > anything holding this up from being committed? soft blockers only i.e. * Solr 9.5 being released will make the link into the Solr Ref Guide work * am still exploring more on

[jira] [Commented] (SOLR-16466) Admin UI - Make it optional to sort list of commandline args

2024-02-08 Thread Vincenzo D'Amore (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815653#comment-17815653 ] Vincenzo D'Amore commented on SOLR-16466: - [~cpoerschke] [~elyograg]  just to let

[jira] [Commented] (SOLR-17152) UI: Cloud Graph misaligned

2024-02-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815584#comment-17815584 ] ASF subversion and git services commented on SOLR-17152: Commit 9

[jira] [Resolved] (SOLR-17152) UI: Cloud Graph misaligned

2024-02-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-17152. Fix Version/s: 9.6.0 Resolution: Fixed > UI: Cloud Graph misaligned > --

Re: [PR] SOLR-17152: Better alignment of Admin UI graph [solr]

2024-02-08 Thread via GitHub
janhoy merged PR #2249: URL: https://github.com/apache/solr/pull/2249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17152) UI: Cloud Graph misaligned

2024-02-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815583#comment-17815583 ] ASF subversion and git services commented on SOLR-17152: Commit 4