gerlowskija opened a new pull request, #2254: URL: https://github.com/apache/solr/pull/2254
https://issues.apache.org/jira/browse/SOLR-17066 # Description SOLR-17066 introduced a `withDefaultCollection` builder method that can be used in lieu of providing a core URL as a "base". (Core URLs are not ideal as they prevent clients from making core-agnostic requests.) However, Solr's own client usage still needs modified to use this new builder method. # Solution This commit migrates the majority of Solr's client implementations away from core URLs and towards using `withDefaultCollection`. It covers the Apache and Jetty versions of the "Concurrent Update" and "Load Balancing" clients. (Following this PR, the only client that still remains to be migrated is the Jetty "Http2SolrClient".) # Tests Existing tests continue to pass. No new tests needed, as this is "just" a refactor. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
