Re: [PR] Remove dot-files not needed and update .gitignore [solr]

2024-01-11 Thread via GitHub
dsmiley commented on code in PR #2189: URL: https://github.com/apache/solr/pull/2189#discussion_r1449688477 ## .gitignore: ## @@ -11,8 +11,6 @@ build/ **/*.ipr **/*.iws out/ -#IntelliJ creates this folder, ignore. -/dev-tools/missing-doclet/out/ Review Comment: obsole

[PR] Remove dot-files not needed and update .gitignore [solr]

2024-01-11 Thread via GitHub
dsmiley opened a new pull request, #2189: URL: https://github.com/apache/solr/pull/2189 These dot-files seem like not worth keeping. One of them was referenced in `.gitignore` so that brought my attention to remove some things there as well. Maybe could be another PR; I can split if

Re: [PR] Various asf.yaml updates [solr]

2024-01-11 Thread via GitHub
janhoy commented on code in PR #2185: URL: https://github.com/apache/solr/pull/2185#discussion_r1449570376 ## .asf.yaml: ## @@ -18,6 +18,18 @@ github: merge: false rebase: false + protected_branches: +main: {} Review Comment: I cannot see it documented. But

[jira] [Updated] (SOLR-16777) Schema Designer blindly "trusts" potentially malicious configset

2024-01-11 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-16777: -- Fix Version/s: 8.11.3 > Schema Designer blindly "trusts" potentially malicious configset >

[jira] [Commented] (SOLR-17066) Deprecate and remove core URLs in HttpSolrClient and friends

2024-01-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805792#comment-17805792 ] David Smiley commented on SOLR-17066: - The commit messages here speak of "data store"

Re: [PR] SOLR-17096: Cluster Singleton plugin support for immutable deployments [solr]

2024-01-11 Thread via GitHub
pjmcarthur commented on PR #2126: URL: https://github.com/apache/solr/pull/2126#issuecomment-1887907029 @pvcnt FYI - This PR has been updated to handle the replicaPlacementFactory declared in solr.xml in the same way as cluster singleton plugins. -- This is an automated message from the A

Re: [PR] SOLR-17096: Cluster Singleton plugin support for immutable deployments [solr]

2024-01-11 Thread via GitHub
pjmcarthur commented on code in PR #2126: URL: https://github.com/apache/solr/pull/2126#discussion_r1449148959 ## solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java: ## @@ -651,6 +651,27 @@ private static PluginInfo[] getBackupRepositoryPluginInfos(List cfg) return

[PR] SOLR-17116: Fix INSTALLSHARDDATA async reporting [solr]

2024-01-11 Thread via GitHub
gerlowskija opened a new pull request, #2188: URL: https://github.com/apache/solr/pull/2188 https://issues.apache.org/jira/browse/SOLR-17116 # Description Prior to this commit, failures in asynchronous 'INSTALLSHARDDATA' commands weren't properly detected. REQUESTSTATUS ca

Re: [PR] SOLR-17097: Upgrade Solr to use Lucene 9.9.1 [solr]

2024-01-11 Thread via GitHub
NazerkeBS commented on code in PR #2176: URL: https://github.com/apache/solr/pull/2176#discussion_r1448955485 ## solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java: ## @@ -109,9 +109,10 @@ public static LeafReader wrap(IndexReader reader) throws IOExceptio

[jira] [Updated] (SOLR-17116) Async INSTALLSHARDDATA requests never report failure

2024-01-11 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-17116: --- Attachment: reproduce.sh > Async INSTALLSHARDDATA requests never report failure > --

[jira] [Created] (SOLR-17116) Async INSTALLSHARDDATA requests never report failure

2024-01-11 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-17116: -- Summary: Async INSTALLSHARDDATA requests never report failure Key: SOLR-17116 URL: https://issues.apache.org/jira/browse/SOLR-17116 Project: Solr Issue

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

2024-01-11 Thread via GitHub
dsmiley commented on code in PR #2118: URL: https://github.com/apache/solr/pull/2118#discussion_r1448914616 ## solr/core/src/test/org/apache/solr/TestCpuTimeSearch.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

Re: [PR] Various asf.yaml updates [solr]

2024-01-11 Thread via GitHub
dsmiley commented on code in PR #2185: URL: https://github.com/apache/solr/pull/2185#discussion_r1448883424 ## .asf.yaml: ## @@ -18,6 +18,18 @@ github: merge: false rebase: false + protected_branches: +main: {} Review Comment: Is there a way to add `branch_

[jira] [Updated] (SOLR-17115) OTEL: Option to skip certain spans from being exported

2024-01-11 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-17115: --- Summary: OTEL: Option to skip certain spans from being exported (was: OTEL: Option to skip certain s

[jira] [Created] (SOLR-17115) OTEL: Option to skip certain spans from being exportd

2024-01-11 Thread Jira
Jan Høydahl created SOLR-17115: -- Summary: OTEL: Option to skip certain spans from being exportd Key: SOLR-17115 URL: https://issues.apache.org/jira/browse/SOLR-17115 Project: Solr Issue Type: Im