gerlowskija opened a new pull request, #2188: URL: https://github.com/apache/solr/pull/2188
https://issues.apache.org/jira/browse/SOLR-17116 # Description Prior to this commit, failures in asynchronous 'INSTALLSHARDDATA' commands weren't properly detected. REQUESTSTATUS calls checking on INSTALLSHARDDATA requests would find them always reported as 'completed', even when the asynchronous task definitely failed. Ultimately, this occurred because the overseer processing for this command ignored the output of per-core requests. Incorporating these responses into the overseer "results" allows task operation to be correctly classified and reported. # Solution This was happening because of an oversight in the InstallShardDataCmd code, where the responses of per-core requests weren't properly attached to the response NamedList. This commit appends these results to bring the error reporting into line with other collection-admin requests. # Tests New test cases added to AbstractInstallShardTest. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [x] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
