Re: [PR] SOLR-17096: Cluster Singleton plugin support for immutable deployments [solr]

2024-01-08 Thread via GitHub
dsmiley commented on code in PR #2126: URL: https://github.com/apache/solr/pull/2126#discussion_r1445581541 ## solr/core/src/java/org/apache/solr/core/NodeConfig.java: ## @@ -223,17 +221,23 @@ private NodeConfig( if (this.clusterSingletonPlugins != null && this.c

[jira] [Resolved] (SOLR-13612) Error 500 with update extract handler on Solr 7.4.0

2024-01-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-13612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-13612. Resolution: Won't Fix > Error 500 with update extract handler on Solr 7.4.0 > -

[I] Improve documentation for additional volumes [solr-operator]

2024-01-08 Thread via GitHub
mcarroll1 opened a new issue, #675: URL: https://github.com/apache/solr-operator/issues/675 Hello, I found it difficult to specify additional volumes in the `podOptions.volumes` values, specifically specifying a source for the volume. It appears @janhoy had a similar issue here: htt

[PR] Introduce stale bot [solr]

2024-01-08 Thread via GitHub
janhoy opened a new pull request, #2184: URL: https://github.com/apache/solr/pull/2184 Following Lucene's lead and adding a stale bot that will label open, non-draft PRs as `Stale` after 14 days of inactivity. It is almost identical fork of Lucene's config: https://github.com/apache/lucene

Re: [I] Run solr-operator and solr helm chart on openshift get error "would violate PodSecurity "restricted:v1.24"" [solr-operator]

2024-01-08 Thread via GitHub
aaronsuns commented on issue #671: URL: https://github.com/apache/solr-operator/issues/671#issuecomment-1881736950 Update: create a service account and SCC could run it on openshift without the above change in solr-operator. ``` # Service Account apiVersion: v1 kind: Servi

Re: [PR] Correct the log.error to include the file name instead of hard coded … [solr]

2024-01-08 Thread via GitHub
uschindler commented on PR #2183: URL: https://github.com/apache/solr/pull/2183#issuecomment-1881612565 It looks like all tests pass. Would you please add an entry to the CHANGES.txt file in the 9.5 section: https://github.com/apache/solr/blob/91a19404fc90929b70c8513a058cfb1d560496da/solr/C

[jira] [Commented] (SOLR-16397) Cosmetic improvements and migration to JAX-RS ("core" APIs)

2024-01-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804391#comment-17804391 ] ASF subversion and git services commented on SOLR-16397: Commit 1

Re: [PR] SOLR-17089: Upgrade Jersey to 3.1.5 [solr]

2024-01-08 Thread via GitHub
risdenk commented on PR #2178: URL: https://github.com/apache/solr/pull/2178#issuecomment-1881525273 So having the `swagger-jaxrs2-jakarta` is ok even though we are in theory on javax still with Jetty? I have a hard time wrapping my head around when javax vs jakarta matters :/ -- This is

[jira] [Commented] (SOLR-16397) Cosmetic improvements and migration to JAX-RS ("core" APIs)

2024-01-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804386#comment-17804386 ] ASF subversion and git services commented on SOLR-16397: Commit 9

Re: [PR] SOLR-16397: Modify v2 'MERGEINDEXES' API to be more REST-ful [solr]

2024-01-08 Thread via GitHub
gerlowskija merged PR #2128: URL: https://github.com/apache/solr/pull/2128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] Correct the log.error to include the file name instead of hard coded … [solr]

2024-01-08 Thread via GitHub
uschindler commented on code in PR #2183: URL: https://github.com/apache/solr/pull/2183#discussion_r1444777176 ## solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java: ## @@ -307,7 +307,8 @@ private static float[] getFloats(FileFloatSource ffs, IndexReader re

[jira] [Commented] (SOLR-17036) Lazy create VersionBucket in the update log to free memory.

2024-01-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804335#comment-17804335 ] ASF subversion and git services commented on SOLR-17036: Commit 2

[jira] [Commented] (SOLR-17036) Lazy create VersionBucket in the update log to free memory.

2024-01-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804334#comment-17804334 ] ASF subversion and git services commented on SOLR-17036: Commit a

Re: [PR] Correct the log.error to include the file name instead of hard coded … [solr]

2024-01-08 Thread via GitHub
haldmour-atypon commented on code in PR #2183: URL: https://github.com/apache/solr/pull/2183#discussion_r1444760037 ## solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java: ## @@ -307,7 +307,8 @@ private static float[] getFloats(FileFloatSource ffs, IndexRead

Re: [PR] Correct the log.error to include the file name instead of hard coded … [solr]

2024-01-08 Thread via GitHub
uschindler commented on code in PR #2183: URL: https://github.com/apache/solr/pull/2183#discussion_r1444750334 ## solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java: ## @@ -307,7 +307,8 @@ private static float[] getFloats(FileFloatSource ffs, IndexReader re

[PR] Correct the log.error to include the file name instead of hard coded … [solr]

2024-01-08 Thread via GitHub
haldmour-atypon opened a new pull request, #2183: URL: https://github.com/apache/solr/pull/2183 Correct the log.error to include the file name instead of the hard-coded value. `log.error("Error loading external value source + fileName + {}{}", var33, otherErrors < 10 ? "" : "\tSkippi

Re: [PR] SOLR-16397: Modify v2 'MERGEINDEXES' API to be more REST-ful [solr]

2024-01-08 Thread via GitHub
gerlowskija commented on code in PR #2128: URL: https://github.com/apache/solr/pull/2128#discussion_r1444641685 ## solr/api/src/java/org/apache/solr/client/api/model/MergeIndexesRequestBody.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] SOLR-16397: Modify v2 'MERGEINDEXES' API to be more REST-ful [solr]

2024-01-08 Thread via GitHub
gerlowskija commented on PR #2128: URL: https://github.com/apache/solr/pull/2128#issuecomment-1881015025 > I saw some APIs override the below method to mark it expensive. I believe, MERGEINDEXES is kind of expensive. +1 I think it makes sense to give `MergeIndexes` its own `isExpensiv

Re: [PR] SOLR-16397: Modify v2 'MERGEINDEXES' API to be more REST-ful [solr]

2024-01-08 Thread via GitHub
gerlowskija commented on code in PR #2128: URL: https://github.com/apache/solr/pull/2128#discussion_r1444641685 ## solr/api/src/java/org/apache/solr/client/api/model/MergeIndexesRequestBody.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[PR] Update org.apache.curator:* to v5.6.0 [solr]

2024-01-08 Thread via GitHub
solrbot opened a new pull request, #2182: URL: https://github.com/apache/solr/pull/2182 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.curator:curator-recipes](https://curator.apache.org) ([source](https://togithub.co