gerlowskija commented on code in PR #2128: URL: https://github.com/apache/solr/pull/2128#discussion_r1444641685
########## solr/api/src/java/org/apache/solr/client/api/model/MergeIndexesRequestBody.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.client.api.model; + +import com.fasterxml.jackson.annotation.JsonProperty; +import io.swagger.v3.oas.annotations.media.Schema; +import java.util.List; + +/** Request body for endpoints {@link org.apache.solr.client.api.endpoint.MergeIndexesApi} */ +public class MergeIndexesRequestBody { + @Schema(description = "Multi-valued, directories that would be merged.") + @JsonProperty + public List<String> indexDir; Review Comment: I think it makes sense to rename both. Backcompat doesn't apply to the v2 API yet, so it's best to improve this now while we have the chance. **EDIT**: You seemed open to going this route above, so to save you the work I've gone ahead and changed the JSON property names to match the Java variable names you chose. Happy to revert if you disagree, just figured it was easy enough while I had the code pulled up 🤷 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
