Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-08 Thread via GitHub
stillalex commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1848128863 > I do like the refCount==-1 during initialization idea I came up with but am unsure what you think. I think this would address the matter and be clear to reason about. thanks for c

Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-08 Thread via GitHub
dsmiley commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1848076667 I do like the refCount==-1 during initialization idea I came up with but am unsure what you think. I think this would address the matter and be clear to reason about. -- This is an autom

[jira] [Commented] (SOLR-16124) Solr Example should prompt for ZK port

2023-12-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794897#comment-17794897 ] David Smiley commented on SOLR-16124: - I think most likely, the user doesn't care tho

Re: [PR] SOLR-17096: Cluster Singleton plugin support for immutable deployments [solr]

2023-12-08 Thread via GitHub
dsmiley commented on PR #2126: URL: https://github.com/apache/solr/pull/2126#issuecomment-1848042217 Oh I totally missed an important concern that I raised with @pvcnt 's previous PR #2016. The configuration is very generic (the specific plugins are effectively untyped in solr.xml). I too

Re: [PR] SOLR-17096: Cluster Singleton plugin support for immutable deployments [solr]

2023-12-08 Thread via GitHub
dsmiley commented on code in PR #2126: URL: https://github.com/apache/solr/pull/2126#discussion_r1420976112 ## solr/core/src/java/org/apache/solr/api/ZkContainerPluginsSource.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[jira] [Commented] (SOLR-15960) Unified use of system properties and environment variables

2023-12-08 Thread Haythem Khiri (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794887#comment-17794887 ] Haythem Khiri commented on SOLR-15960: -- [~janhoy] I would like to work on this ticke

[jira] (SOLR-15960) Unified use of system properties and environment variables

2023-12-08 Thread Haythem Khiri (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15960 ] Haythem Khiri deleted comment on SOLR-15960: -- was (Author: haythemkh): [~janhoy] I would like to work on this ticket. > Unified use of system properties and environment variables > -

[jira] [Updated] (SOLR-16858) Allow KnnQParser to selectively apply filters

2023-12-08 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-16858: -- Attachment: SOLR-16858.patch Assignee: Chris M. Hostetter (was: Joel Bernstein)

Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-08 Thread via GitHub
stillalex commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1847923908 the failing test was caused by my change, so I had to reduce the open count check to this metric only. I had extended it eagerly to all 3 metrics for some idea of consistency, but that did

[jira] [Commented] (SOLR-14496) Add basic auth support to SolrCLI commands

2023-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794873#comment-17794873 ] ASF subversion and git services commented on SOLR-14496: Commit a

Re: [PR] SOLR-14496: Update the version in CHANGES.txt [solr]

2023-12-08 Thread via GitHub
epugh merged PR #2141: URL: https://github.com/apache/solr/pull/2141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-15857: Add AWS Secret Manager support for ZK ACL credentials [solr]

2023-12-08 Thread via GitHub
laminelam commented on code in PR #1994: URL: https://github.com/apache/solr/pull/1994#discussion_r1421052934 ## solr/server/scripts/cloud-scripts/zkcli.sh: ## @@ -23,6 +38,10 @@ solr_home="$sdir/../../solr" #... # -DzkDigestCredentialsFile=/path/to/zkDigestCredentialsFile.p

[jira] [Commented] (SOLR-17063) Do not buffer raw log params in LogWatcher

2023-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794865#comment-17794865 ] ASF subversion and git services commented on SOLR-17063: Commit 9

[PR] SOLR-14496: Update the version in CHANGES.txt [solr]

2023-12-08 Thread via GitHub
gerlowskija opened a new pull request, #2141: URL: https://github.com/apache/solr/pull/2141 https://issues.apache.org/jira/browse/SOLR-14496 # Description At the time of the original CHANGES.txt entry, the intention was that this would be backported and make it into a 9

[jira] [Resolved] (SOLR-14496) Add basic auth support to SolrCLI commands

2023-12-08 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-14496. -- Fix Version/s: main (10.0) Resolution: Fixed Worked on backporting this to 9x with [~gerlowskija

[jira] [Commented] (SOLR-17063) Do not buffer raw log params in LogWatcher

2023-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794859#comment-17794859 ] ASF subversion and git services commented on SOLR-17063: Commit 6

Re: [PR] SOLR-17063: Do not retain log param references in LogWatcher [solr]

2023-12-08 Thread via GitHub
magibney merged PR #2058: URL: https://github.com/apache/solr/pull/2058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o

Re: [PR] SOLR-15484 JWTAuthPluginIntegrationTest - dynamically generate the self-signed certificate using the localhost loopback address [solr]

2023-12-08 Thread via GitHub
janhoy commented on PR #2099: URL: https://github.com/apache/solr/pull/2099#issuecomment-1847852463 +1, feel free to merge when you wish -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] SOLR-15484 JWTAuthPluginIntegrationTest - dynamically generate the self-signed certificate using the localhost loopback address [solr]

2023-12-08 Thread via GitHub
jdyer1 commented on PR #2099: URL: https://github.com/apache/solr/pull/2099#issuecomment-1847836841 I think we actually do have test coverage with the things you mention. The way this test is working, it still goes out to both `https://{{host}}:{{port}}/default/.well-known/openid-configura

Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-08 Thread via GitHub
stillalex commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1847834842 > I played a bit with my idea but it wasn't working out; perhaps because internal complexities around searcher lifecycle. I hear you. as an aside if (at least) 3 people are trying to

Re: [PR] Update dependency org.apache.commons:commons-compress to v1.25.0 [solr]

2023-12-08 Thread via GitHub
janhoy merged PR #2138: URL: https://github.com/apache/solr/pull/2138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update dependency org.apache.commons:commons-lang3 to v3.14.0 [solr]

2023-12-08 Thread via GitHub
janhoy merged PR #2139: URL: https://github.com/apache/solr/pull/2139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update io.netty:* to v4.1.101.Final [solr]

2023-12-08 Thread via GitHub
janhoy merged PR #2134: URL: https://github.com/apache/solr/pull/2134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-08 Thread via GitHub
dsmiley commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1847711918 I played a bit with my idea but it wasn't working out; perhaps because internal complexities around searcher lifecycle. I still don't understand why `getOpenCount() <= 1;` could be cor

[jira] [Commented] (SOLR-13748) mm (min should match) param for {!bool} query parser

2023-12-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794835#comment-17794835 ] Mikhail Khludnev commented on SOLR-13748: - follow up SOLR-17101 > mm (min should

[jira] [Updated] (SOLR-17101) CoveringQuery support via {!bool should=only should=only ... mm=clausesReqField}

2023-12-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-17101: Summary: CoveringQuery support via {!bool should=only should=only ... mm=clausesReqField}

[jira] [Commented] (SOLR-17089) Extraction module causes Jersey code to throw NoClassDefFoundError

2023-12-08 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794825#comment-17794825 ] Eric Pugh commented on SOLR-17089: -- This is another argument for moving away from includ

[jira] [Commented] (SOLR-17089) Extraction module causes Jersey code to throw NoClassDefFoundError

2023-12-08 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794819#comment-17794819 ] Jason Gerlowski commented on SOLR-17089: Spent some time looking into this. Stil

Re: [PR] SOLR-15484 JWTAuthPluginIntegrationTest - dynamically generate the self-signed certificate using the localhost loopback address [solr]

2023-12-08 Thread via GitHub
janhoy commented on PR #2099: URL: https://github.com/apache/solr/pull/2099#issuecomment-1847522543 Yes, disabling the name check will of course work for the localhost case. Normally the plugin will always connect to an external IDP to fetch JWKs or well-known, and then it will enable valid

Re: [PR] Update org.glassfish.jersey*:* to v2.41 [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2054: URL: https://github.com/apache/solr/pull/2054#issuecomment-1847357365 ### ⚠ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, inc

Re: [PR] Update dependency org.apache.commons:commons-lang3 to v3.14.0 [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2139: URL: https://github.com/apache/solr/pull/2139#issuecomment-1847356960 ### ⚠ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, inc

Re: [PR] Update org.apache.calcite [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2140: URL: https://github.com/apache/solr/pull/2140#issuecomment-1847357083 ### ⚠ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, inc

[PR] Update org.apache.calcite [solr]

2023-12-08 Thread via GitHub
solrbot opened a new pull request, #2140: URL: https://github.com/apache/solr/pull/2140 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.calcite:calcite-linq4j](https://calcite.apache.org) ([source](https://togithub.com

[PR] Update dependency org.apache.commons:commons-lang3 to v3.14.0 [solr]

2023-12-08 Thread via GitHub
solrbot opened a new pull request, #2139: URL: https://github.com/apache/solr/pull/2139 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.commons:commons-lang3](https://commons.apache.org/proper/commons-lang/) ([source]

Re: [PR] Update org.eclipse.jetty*:* to v10.0.18 [solr]

2023-12-08 Thread via GitHub
janhoy merged PR #2065: URL: https://github.com/apache/solr/pull/2065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-16577) Core load issues are not always logged

2023-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794767#comment-17794767 ] ASF subversion and git services commented on SOLR-16577: Commit d

Re: [PR] Update org.eclipse.jetty*:* to v10.0.18 [solr]

2023-12-08 Thread via GitHub
risdenk commented on PR #2065: URL: https://github.com/apache/solr/pull/2065#issuecomment-1847349592 > Wdyt @risdenk ? either works - the commit is fine or waiting until the next release. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] SOLR-16577: Always log core load issues [solr]

2023-12-08 Thread via GitHub
dsmiley merged PR #1221: URL: https://github.com/apache/solr/pull/1221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[PR] Update dependency org.apache.commons:commons-compress to v1.25.0 [solr]

2023-12-08 Thread via GitHub
solrbot opened a new pull request, #2138: URL: https://github.com/apache/solr/pull/2138 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.commons:commons-compress](https://commons.apache.org/proper/commons-compress/) ([

Re: [PR] Update io.netty:* to v4.1.101.Final [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2134: URL: https://github.com/apache/solr/pull/2134#issuecomment-1847320794 ### ⚠ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, inc

[PR] Update dependency io.opentelemetry:opentelemetry-bom to v1.32.0 [solr]

2023-12-08 Thread via GitHub
solrbot opened a new pull request, #2137: URL: https://github.com/apache/solr/pull/2137 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.opentelemetry:opentelemetry-bom](https://togithub.com/open-telemetry/opentelemetry-java)

Re: [PR] Update dependency com.fasterxml.jackson:jackson-bom to v2.16.0 [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2135: URL: https://github.com/apache/solr/pull/2135#issuecomment-1847320963 ### ⚠ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, inc

[PR] Update dependency com.tdunning:t-digest to v3.3 [solr]

2023-12-08 Thread via GitHub
solrbot opened a new pull request, #2136: URL: https://github.com/apache/solr/pull/2136 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.tdunning:t-digest](https://togithub.com/tdunning/t-digest) | dependencies | minor | `3.1`

[PR] Update io.grpc:grpc-* to v1.59.1 [solr]

2023-12-08 Thread via GitHub
solrbot opened a new pull request, #2133: URL: https://github.com/apache/solr/pull/2133 This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [io.grpc:grpc-xds](https://togithub.com/grpc/grpc-java) | dependencies | patch |

Re: [PR] Update io.grpc:grpc-* to v1.59.1 [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2133: URL: https://github.com/apache/solr/pull/2133#issuecomment-1847320566 ### ⚠ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, inc

Re: [PR] Update dependency org.apache.commons:commons-compress to v1.25.0 [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2138: URL: https://github.com/apache/solr/pull/2138#issuecomment-1847321652 ### ⚠ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, inc

Re: [PR] Update io.dropwizard.metrics:* to v4.2.22 [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2132: URL: https://github.com/apache/solr/pull/2132#issuecomment-1847320344 ### ⚠ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, inc

Re: [PR] Update dependency org.jctools:jctools-core to v4.0.2 [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2131: URL: https://github.com/apache/solr/pull/2131#issuecomment-1847320143 ### ⚠ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, inc

Re: [PR] Update dependency io.opentelemetry:opentelemetry-bom to v1.32.0 [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2137: URL: https://github.com/apache/solr/pull/2137#issuecomment-1847321562 ### ⚠ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, inc

Re: [PR] Update dependency com.tdunning:t-digest to v3.3 [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2136: URL: https://github.com/apache/solr/pull/2136#issuecomment-1847321321 ### ⚠ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, inc

[PR] Update dependency com.fasterxml.jackson:jackson-bom to v2.16.0 [solr]

2023-12-08 Thread via GitHub
solrbot opened a new pull request, #2135: URL: https://github.com/apache/solr/pull/2135 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.fasterxml.jackson:jackson-bom](https://togithub.com/FasterXML/jackson-bom) | dependencie

[PR] Update io.netty:* to v4.1.101.Final [solr]

2023-12-08 Thread via GitHub
solrbot opened a new pull request, #2134: URL: https://github.com/apache/solr/pull/2134 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.netty:netty-transport-native-unix-common](https://netty.io/) ([source](https://togithub.co

[PR] Update io.dropwizard.metrics:* to v4.2.22 [solr]

2023-12-08 Thread via GitHub
solrbot opened a new pull request, #2132: URL: https://github.com/apache/solr/pull/2132 This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [io.dropwizard.metrics:metrics-jvm](https://metrics.dropwizard.io) ([source](htt

[PR] Update dependency org.jctools:jctools-core to v4.0.2 [solr]

2023-12-08 Thread via GitHub
solrbot opened a new pull request, #2131: URL: https://github.com/apache/solr/pull/2131 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.jctools:jctools-core](https://togithub.com/JCTools) ([source](https://togithub.com/JCTool

Re: [PR] Update dependency org.carrot2:carrot2-core to v4.5.3 [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2130: URL: https://github.com/apache/solr/pull/2130#issuecomment-1847320007 ### ⚠ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, inc

[PR] Update dependency org.carrot2:carrot2-core to v4.5.3 [solr]

2023-12-08 Thread via GitHub
solrbot opened a new pull request, #2130: URL: https://github.com/apache/solr/pull/2130 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.carrot2:carrot2-core](https://project.carrot2.org) ([source](https://togithub.com/carrot2

Re: [PR] Update dependency com.github.spotbugs:spotbugs-annotations to v4.8.2 [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2129: URL: https://github.com/apache/solr/pull/2129#issuecomment-1847319782 ### ⚠ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, inc

[PR] Update dependency com.github.spotbugs:spotbugs-annotations to v4.8.2 [solr]

2023-12-08 Thread via GitHub
solrbot opened a new pull request, #2129: URL: https://github.com/apache/solr/pull/2129 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.github.spotbugs:spotbugs-annotations](https://spotbugs.github.io/) ([source](https://togi

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-12-08 Thread via GitHub
murblanc merged PR #2039: URL: https://github.com/apache/solr/pull/2039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o

[jira] [Commented] (SOLR-16995) Refactor replica types to make it easier to add new ones

2023-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794747#comment-17794747 ] ASF subversion and git services commented on SOLR-16995: Commit 1

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-12-08 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1420516838 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#NRT

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-12-08 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1420509303 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java: ## @@ -135,6 +140,20 @@ public class CollectionHandlingUtils { } } + /**

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-12-08 Thread via GitHub
murblanc commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1420479790 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java: ## @@ -135,6 +140,20 @@ public class CollectionHandlingUtils { } } +

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-12-08 Thread via GitHub
murblanc commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1420472150 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-12-08 Thread via GitHub
murblanc commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1420468337 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -18,31 +18,92 @@ import java.util.Arrays; import java.util.EnumMap; +import java.util.Enu

Re: [PR] SOLR-16577: Always log core load issues [solr]

2023-12-08 Thread via GitHub
dsmiley commented on PR #1221: URL: https://github.com/apache/solr/pull/1221#issuecomment-1847186357 @risdenk I think your concerns have been addressed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] SOLR-16397: Modify v2 'MERGEINDEXES' API to be more REST-ful [solr]

2023-12-08 Thread via GitHub
iamsanjay commented on code in PR #2128: URL: https://github.com/apache/solr/pull/2128#discussion_r1420425223 ## solr/core/src/java/org/apache/solr/handler/admin/api/MergeIndexes.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[jira] [Updated] (SOLR-17101) CoveringQuery support for {!bool should=only should=only ... mm=clausesReqField}

2023-12-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-17101: Description: Lucene Sandbox has a pretty cool [CoveringQuery|https://lucene.apache.org/cor

[jira] [Created] (SOLR-17101) CoveringQuery support for {!bool should=only should=only ... mm=clausesReqField}

2023-12-08 Thread Mikhail Khludnev (Jira)
Mikhail Khludnev created SOLR-17101: --- Summary: CoveringQuery support for {!bool should=only should=only ... mm=clausesReqField} Key: SOLR-17101 URL: https://issues.apache.org/jira/browse/SOLR-17101

[jira] [Resolved] (SOLR-13748) mm (min should match) param for {!bool} query parser

2023-12-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev resolved SOLR-13748. - Resolution: Fixed Thanks Andrey! > mm (min should match) param for {!bool} query parser

[jira] [Updated] (SOLR-13748) mm (min should match) param for {!bool} query parser

2023-12-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-13748: Fix Version/s: 9.5 > mm (min should match) param for {!bool} query parser > ---

[jira] [Assigned] (SOLR-13748) mm (min should match) param for {!bool} query parser

2023-12-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev reassigned SOLR-13748: --- Assignee: Mikhail Khludnev > mm (min should match) param for {!bool} query parser >

[PR] SOLR-16397: Modify v2 'MERGEINDEXES' API to be more REST-ful [solr]

2023-12-08 Thread via GitHub
iamsanjay opened a new pull request, #2128: URL: https://github.com/apache/solr/pull/2128 https://issues.apache.org/jira/browse/SOLR-16397 # Description V2(JAX-RS) Endpoints for core admin op "MERGEINDEXES". # Solution This commit changes the v2 "MERGEI

Re: [PR] Update dependency io.swagger.core.v3:swagger-annotations to v2.2.19 [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2064: URL: https://github.com/apache/solr/pull/2064#issuecomment-1846912907 ### ⚠ Artifact update problem Renovate failed to update artifacts related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, inc

Re: [PR] Update org.apache.logging.log4j:* to v2.22.0 [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2047: URL: https://github.com/apache/solr/pull/2047#issuecomment-1846887507 ### ⚠ Artifact update problem Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, i

Re: [PR] Update dependency io.swagger.core.v3:swagger-annotations to v2.2.18 [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2064: URL: https://github.com/apache/solr/pull/2064#issuecomment-1846880924 ### Edited/Blocked Notification Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

Re: [PR] Update org.eclipse.jetty*:* to v10.0.18 [solr]

2023-12-08 Thread via GitHub
solrbot commented on PR #2065: URL: https://github.com/apache/solr/pull/2065#issuecomment-1846880937 ### Edited/Blocked Notification Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

[jira] [Commented] (SOLR-13748) mm (min should match) param for {!bool} query parser

2023-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794586#comment-17794586 ] ASF subversion and git services commented on SOLR-13748: Commit 5

Re: [PR] SOLR-13748: Add support for mm parameter to bool query parser (#2025) [solr]

2023-12-08 Thread via GitHub
mkhludnev merged PR #2127: URL: https://github.com/apache/solr/pull/2127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.