murblanc commented on code in PR #2039:
URL: https://github.com/apache/solr/pull/2039#discussion_r1420479790
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java:
##########
@@ -135,6 +140,20 @@ public class CollectionHandlingUtils {
}
}
+ /** Returns names of properties that are used to specify a number of
replicas of a given type. */
Review Comment:
I don't understand why you say "do not belong".
Except standard Java classes, these two static methods depend only on
`Replica.Type`.
If you don't want to put them in the `enum` put them in `Replica`, but move
them close to the code they're related to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
