Re: [PR] SOLR-17072: CLI package to print problem JSON Path [solr]

2023-11-18 Thread via GitHub
mkhludnev commented on PR #2074: URL: https://github.com/apache/solr/pull/2074#issuecomment-1817659982 oh gosh.. discovered one more error ``` com.jayway.jsonpath.InvalidPathException: Error in JSON Path:$['response'].['params'].['PKG_VERSIONS'].['question-answer']) at org.ap

Re: [PR] SOLR-17072: CLI package to print problem JSON Path [solr]

2023-11-18 Thread via GitHub
mkhludnev commented on code in PR #2074: URL: https://github.com/apache/solr/pull/2074#discussion_r1398277168 ## solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java: ## @@ -1094,9 +1102,8 @@ public Map getDeployedCollections(String packageName) {

Re: [PR] SOLR-17050: Save models as compacted json [solr]

2023-11-18 Thread via GitHub
holysleeper commented on code in PR #2030: URL: https://github.com/apache/solr/pull/2030#discussion_r1398163193 ## solr/CHANGES.txt: ## @@ -96,6 +96,8 @@ Improvements * SOLR-17041: Make CommitTracker currentTlogSize lazy (Alex Deparvu) +* SOLR-17050: Use compact JSON for Le

Re: [PR] SOLR-17050: Save models as compacted json [solr]

2023-11-18 Thread via GitHub
holysleeper commented on PR #2030: URL: https://github.com/apache/solr/pull/2030#issuecomment-1817457604 > The contribution looks good and it's interesting. I left some minor comments that should be addressed in my opinion. Not sure we want also some integration tests to verify we really st

Re: [PR] SOLR-17050: Save models as compacted json [solr]

2023-11-18 Thread via GitHub
holysleeper commented on code in PR #2030: URL: https://github.com/apache/solr/pull/2030#discussion_r1398161886 ## solr/core/src/test/org/apache/solr/util/TestUtils.java: ## @@ -294,4 +294,23 @@ public void testMergeJson() { assertEquals( 2L, Utils.getObjectByPath(