holysleeper commented on PR #2030: URL: https://github.com/apache/solr/pull/2030#issuecomment-1817457604
> The contribution looks good and it's interesting. I left some minor comments that should be addressed in my opinion. Not sure we want also some integration tests to verify we really store the stuff in Zookeeper as we want. Not a blocker though, Thanks! @alessandrobenedetti I also added a test to check the storage in zookeeper. @cpoerschke Thanks for adding the constant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
