[jira] [Commented] (SOLR-17066) Deprecate and remove core URLs in HttpSolrClient and friends

2023-11-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783831#comment-17783831 ] Jan Høydahl commented on SOLR-17066: There were some discussions in SOLR-10466 regard

[jira] [Commented] (SOLR-17069) Upgrade Jetty to 12.x

2023-11-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783828#comment-17783828 ] Jan Høydahl commented on SOLR-17069: Let's target it for Solr 10. Lucene seems to be

Re: [PR] [9.x] SOLR-17011 Add tracing spans to internal collection commands (#1979) [solr]

2023-11-07 Thread via GitHub
stillalex commented on PR #2067: URL: https://github.com/apache/solr/pull/2067#issuecomment-1800329512 This is the 9.x backport of https://github.com/apache/solr/pull/1979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[PR] [9.x] SOLR-17011 Add tracing spans to internal collection commands (#1979) [solr]

2023-11-07 Thread via GitHub
stillalex opened a new pull request, #2067: URL: https://github.com/apache/solr/pull/2067 https://issues.apache.org/jira/browse/SOLR-17011 # Description This is the 9.x backport of https://github.com/apache/solr/pull/1979 # Solution Please provide a sho

[jira] [Commented] (SOLR-10466) setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-11-07 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783821#comment-17783821 ] Ilan Ginzburg commented on SOLR-10466: -- I am not in favor of forbidding the use of {

Re: [PR] SOLR-16974: Global Circuit Breakers [solr]

2023-11-07 Thread via GitHub
janhoy commented on code in PR #1919: URL: https://github.com/apache/solr/pull/1919#discussion_r1385683982 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -33,39 +35,47 @@ * We depend on OperatingSystemMXBean which does not allow a confi

Re: [PR] SOLR-16974: Global Circuit Breakers [solr]

2023-11-07 Thread via GitHub
janhoy commented on code in PR #1919: URL: https://github.com/apache/solr/pull/1919#discussion_r1385670500 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java: ## @@ -111,43 +199,82 @@ public static String toErrorMessage(List circuitBreakerList

Re: [PR] SOLR-16974: Global Circuit Breakers [solr]

2023-11-07 Thread via GitHub
janhoy commented on code in PR #1919: URL: https://github.com/apache/solr/pull/1919#discussion_r1385668610 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -33,39 +35,47 @@ * We depend on OperatingSystemMXBean which does not allow a confi

Re: [PR] SOLR-16975: Remove loading of solr.xml from zookeeper (main branch only) [solr]

2023-11-07 Thread via GitHub
janhoy commented on PR #1920: URL: https://github.com/apache/solr/pull/1920#issuecomment-1800274875 So I fixed the last tests and back some ZK connection code to `NodeConfig`. It really does not belong there, but `ZkFailoverTest` uses it plus a sysProp to simulate cluster restart failure. I

Re: [PR] SOLR-13748: Add support for mm parameter to bool query parser [solr]

2023-11-07 Thread via GitHub
mkhludnev commented on code in PR #2025: URL: https://github.com/apache/solr/pull/2025#discussion_r1385654200 ## solr/core/src/java/org/apache/solr/search/join/FiltersQParser.java: ## @@ -61,6 +61,9 @@ protected BooleanQuery parseImpl() throws SyntaxError { for (Map.Entry c

Re: [PR] Fix typos and improve grammar in Query Guide [solr]

2023-11-07 Thread via GitHub
AndreyBozhko commented on PR #2024: URL: https://github.com/apache/solr/pull/2024#issuecomment-1800224603 Hi @epugh - bumping this PR for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] SOLR-13748: Add support for mm parameter to bool query parser [solr]

2023-11-07 Thread via GitHub
AndreyBozhko commented on code in PR #2025: URL: https://github.com/apache/solr/pull/2025#discussion_r1385621132 ## solr/core/src/java/org/apache/solr/search/join/FiltersQParser.java: ## @@ -61,6 +61,9 @@ protected BooleanQuery parseImpl() throws SyntaxError { for (Map.Entr

Re: [PR] SOLR-13748: Add support for mm parameter to bool query parser [solr]

2023-11-07 Thread via GitHub
AndreyBozhko commented on code in PR #2025: URL: https://github.com/apache/solr/pull/2025#discussion_r1385606641 ## solr/solr-ref-guide/modules/query-guide/pages/other-parsers.adoc: ## @@ -75,6 +75,16 @@ However, unlike `must`, the score of filter queries is ignored. Also, the

[jira] [Resolved] (SOLR-16907) Strange behaviour after upgrade to 9.x when security json has no longer existing permission

2023-11-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16907. Fix Version/s: 9.5 Resolution: Fixed > Strange behaviour after upgrade to 9.x when security

[jira] [Commented] (SOLR-16907) Strange behaviour after upgrade to 9.x when security json has no longer existing permission

2023-11-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783781#comment-17783781 ] ASF subversion and git services commented on SOLR-16907: Commit c

Re: [PR] SOLR-16397: Swap core v2 endpoints have been updated to be more REST-ful [solr]

2023-11-07 Thread via GitHub
gerlowskija commented on PR #2060: URL: https://github.com/apache/solr/pull/2060#issuecomment-1799778254 Thanks again @iamsanjay ; another API down! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Commented] (SOLR-16397) Cosmetic improvements and migration to JAX-RS ("core" APIs)

2023-11-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783770#comment-17783770 ] ASF subversion and git services commented on SOLR-16397: Commit d

[jira] [Commented] (SOLR-16397) Cosmetic improvements and migration to JAX-RS ("core" APIs)

2023-11-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783759#comment-17783759 ] ASF subversion and git services commented on SOLR-16397: Commit 8

Re: [PR] SOLR-16397: Swap core v2 endpoints have been updated to be more REST-ful [solr]

2023-11-07 Thread via GitHub
gerlowskija merged PR #2060: URL: https://github.com/apache/solr/pull/2060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[jira] [Commented] (SOLR-10466) setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-11-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783735#comment-17783735 ] David Smiley commented on SOLR-10466: - [~ilan] my proposal to use {{java.util.concur

Re: [PR] SOLR-16974: Global Circuit Breakers [solr]

2023-11-07 Thread via GitHub
cpoerschke commented on code in PR #1919: URL: https://github.com/apache/solr/pull/1919#discussion_r1385267122 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -33,39 +35,47 @@ * We depend on OperatingSystemMXBean which does not allow a c

Re: [PR] SOLR-16397: Swap core v2 endpoints have been updated to be more REST-ful [solr]

2023-11-07 Thread via GitHub
gerlowskija commented on code in PR #2060: URL: https://github.com/apache/solr/pull/2060#discussion_r1385226940 ## solr/CHANGES.txt: ## @@ -480,6 +480,9 @@ Improvements * SOLR-16397: Unload core v2 endpoints have been updated to be more REST-ful. UNLOAD is now available at `

Re: [PR] SOLR-16961 Remove deprecated CircuitBreakerManager in 10.0 [solr]

2023-11-07 Thread via GitHub
cpoerschke commented on code in PR #2059: URL: https://github.com/apache/solr/pull/2059#discussion_r1385256745 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java: ## @@ -54,14 +57,48 @@ public void init(NamedList args) { SolrPluginUtils.invokeSett

[jira] [Commented] (SOLR-16907) Strange behaviour after upgrade to 9.x when security json has no longer existing permission

2023-11-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783685#comment-17783685 ] ASF subversion and git services commented on SOLR-16907: Commit 2

Re: [PR] SOLR-16907: Reserve some 8.x security permission names [solr]

2023-11-07 Thread via GitHub
janhoy merged PR #2040: URL: https://github.com/apache/solr/pull/2040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-16975: Remove loading of solr.xml from zookeeper (main branch only) [solr]

2023-11-07 Thread via GitHub
janhoy commented on code in PR #1920: URL: https://github.com/apache/solr/pull/1920#discussion_r1385198853 ## solr/core/src/java/org/apache/solr/core/NodeConfig.java: ## @@ -218,44 +211,36 @@ private NodeConfig( } /** - * Get the NodeConfig whether stored on disk, in Z

[PR] SOLR-17066: Add 'defaultCollection' to SolrClients [solr]

2023-11-07 Thread via GitHub
gerlowskija opened a new pull request, #2066: URL: https://github.com/apache/solr/pull/2066 https://issues.apache.org/jira/browse/SOLR-17066 # Description CloudSolrClient has long had a 'defaultCollection' property. This property acts as a default, saving users who only intera

Re: [PR] SOLR-17016: Migrate tutorial content on ParamSets and Vectors into Ref Guide [solr]

2023-11-07 Thread via GitHub
epugh commented on PR #1988: URL: https://github.com/apache/solr/pull/1988#issuecomment-1799014969 Started this at Community over Code, and I think it's finally ready Very excited to have a nice example of using Streaming Expressions to calculate an average vector for movies someone h

[jira] [Resolved] (SOLR-16038) Rename PackageStore as Filestore

2023-11-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16038. Fix Version/s: 9.5 Resolution: Fixed > Rename PackageStore as Filestore > --

[jira] [Commented] (SOLR-16038) Rename PackageStore as Filestore

2023-11-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783658#comment-17783658 ] ASF subversion and git services commented on SOLR-16038: Commit f

Re: [PR] SOLR-16974: Global Circuit Breakers [solr]

2023-11-07 Thread via GitHub
janhoy commented on PR #1919: URL: https://github.com/apache/solr/pull/1919#issuecomment-1798650319 I think this is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Commented] (SOLR-16038) Rename PackageStore as Filestore

2023-11-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783651#comment-17783651 ] ASF subversion and git services commented on SOLR-16038: Commit b

Re: [PR] SOLR-16038: Rename PackageStore as Filestore [solr]

2023-11-07 Thread via GitHub
janhoy merged PR #1908: URL: https://github.com/apache/solr/pull/1908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-15782) Configure custom node/container handlers in solr.xml

2023-11-07 Thread Vincent Primault (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783649#comment-17783649 ] Vincent Primault commented on SOLR-15782: - [~dsmiley] I explored a bit what it wo

[jira] [Commented] (SOLR-10466) setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2023-11-07 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783627#comment-17783627 ] Ilan Ginzburg commented on SOLR-10466: -- I’ve inventoried uses of {{parallelStream()}

Re: [PR] Update Solr version tag in local_tutorial.md [solr-operator]

2023-11-07 Thread via GitHub
gerlowskija commented on PR #652: URL: https://github.com/apache/solr-operator/pull/652#issuecomment-1798532180 Trying to refresh my understanding: once merged to `main`, this needs pulled into the `gh-pages` branch for the https://apache.github.io/solr-operator/docs/ site to be updated, ri

[PR] Update Solr version tag in local_tutorial.md [solr-operator]

2023-11-07 Thread via GitHub
gerlowskija opened a new pull request, #652: URL: https://github.com/apache/solr-operator/pull/652 A contributor pointed out the tutorial no longer worked with operator 0.8.0 because some of the solr.xml changes made recently conflicted with the Solr version that the tutorial was using (8.3

Re: [PR] Support readOnlyRootFilesystem [solr-operator]

2023-11-07 Thread via GitHub
radu-gheorghe commented on PR #648: URL: https://github.com/apache/solr-operator/pull/648#issuecomment-1798488985 Sounds good, thanks @thomaswoeckinger ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (SOLR-17070) bin/solr post -h is odd message

2023-11-07 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-17070: Summary: bin/solr post -h is odd message Key: SOLR-17070 URL: https://issues.apache.org/jira/browse/SOLR-17070 Project: Solr Issue Type: Sub-task Component

[jira] [Commented] (SOLR-17068) Migrate Ref Guide content to using bin/solr post command

2023-11-07 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783611#comment-17783611 ] Eric Pugh commented on SOLR-17068: -- Agreed...I think I made things worse in my attem

Re: [PR] SOLR-17062: Create JS client for Admin UI use [solr]

2023-11-07 Thread via GitHub
epugh commented on code in PR #2050: URL: https://github.com/apache/solr/pull/2050#discussion_r1384773584 ## solr/api/build.gradle: ## @@ -17,6 +17,7 @@ plugins { id 'io.swagger.core.v3.swagger-gradle-plugin' version '2.2.2' + id "org.openapi.generator" version "6.0.1" R

Re: [PR] SOLR-17062: Create JS client for Admin UI use [solr]

2023-11-07 Thread via GitHub
epugh commented on PR #2050: URL: https://github.com/apache/solr/pull/2050#issuecomment-1798318944 I think your idea about not publishing it as an artifact till we've tried it out makes sense! -- This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Commented] (SOLR-17065) Migrate Sandbox CrossDC functionality into Solr

2023-11-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783571#comment-17783571 ] Jan Høydahl commented on SOLR-17065: Given the small footprint of the feature I'm not

Re: [PR] Support readOnlyRootFilesystem [solr-operator]

2023-11-07 Thread via GitHub
thomaswoeckinger commented on PR #648: URL: https://github.com/apache/solr-operator/pull/648#issuecomment-1798127176 I think so, i will test it on my side and give you feedback then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] SOLR-16907: Reserve some 8.x security permission names [solr]

2023-11-07 Thread via GitHub
janhoy commented on PR #2040: URL: https://github.com/apache/solr/pull/2040#issuecomment-1798119014 @risdenk, @noblepaul Please have another look. Now the logic is * First look for well-known permission name (as before) * If **not** a well-known name, and `path` is not specified, fail w

Re: [PR] SOLR-16038: Rename PackageStore as Filestore [solr]

2023-11-07 Thread via GitHub
janhoy commented on PR #1908: URL: https://github.com/apache/solr/pull/1908#issuecomment-1798111902 @epugh I also renamed the test method you mentioned. Think this is good to go now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] SOLR-16961 Remove deprecated CircuitBreakerManager in 10.0 [solr]

2023-11-07 Thread via GitHub
janhoy commented on PR #2059: URL: https://github.com/apache/solr/pull/2059#issuecomment-1798100140 Latest changes * Fail-early for invalid system property values in `solr.circuitbreaker.errorcode` * Parsing Integer from sysprop is now strict, not falling back to default 429 if not in

[jira] [Resolved] (SOLR-17067) SolrCloudTestCase activeClusterShape() should only consider active shards

2023-11-07 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilan Ginzburg resolved SOLR-17067. -- Fix Version/s: main (10.0) Resolution: Fixed > SolrCloudTestCase activeClusterShape() sh

[jira] [Commented] (SOLR-17067) SolrCloudTestCase activeClusterShape() should only consider active shards

2023-11-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783538#comment-17783538 ] ASF subversion and git services commented on SOLR-17067: Commit 0

Re: [PR] SOLR-17067 SolrCloudTestCase activeClusterShape() should only consider active shards [solr]

2023-11-07 Thread via GitHub
murblanc merged PR #2063: URL: https://github.com/apache/solr/pull/2063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o