gerlowskija opened a new pull request, #2066: URL: https://github.com/apache/solr/pull/2066
https://issues.apache.org/jira/browse/SOLR-17066 # Description CloudSolrClient has long had a 'defaultCollection' property. This property acts as a default, saving users who only interact with a single core from still needing to specify its name repetitiously. Unfortunately, this nicety is missing from many other client implementations. # Solution This PR adds `defaultCollection` as a protected field on the abstract `SolrClient` class. It adds the required plumbing in "Builder" classes and client constructors to allow users to set the value. And of course it modifies the `request()` implementation for each client to use the default when an explicit collection has not been specified. # Tests Tests are still needed and will be added prior to taking this out of 'draft' mode. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
