[jira] [Updated] (SOLR-16955) Tracing v2 apis breaks SecurityConfHandler

2023-08-29 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated SOLR-16955: Description: Tracing for v2 apis will eagerly consume the contentstream to find a good name for th

[jira] [Updated] (SOLR-16955) Tracing v2 apis breaks SecurityConfHandler

2023-08-29 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated SOLR-16955: Description: Tracing for v2 apis will eagerly consume the contentstream to find a good name for th

[jira] [Updated] (SOLR-16955) Tracing v2 apis breaks SecurityConfHandler

2023-08-29 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated SOLR-16955: Description: Tracing for v2 apis will eagerly consume the contentstream to find a good name for th

[jira] [Created] (SOLR-16955) Tracing v2 apis breaks SecurityConfHandler

2023-08-29 Thread Alex Deparvu (Jira)
Alex Deparvu created SOLR-16955: --- Summary: Tracing v2 apis breaks SecurityConfHandler Key: SOLR-16955 URL: https://issues.apache.org/jira/browse/SOLR-16955 Project: Solr Issue Type: Bug S

[jira] [Updated] (SOLR-16955) Tracing v2 apis breaks SecurityConfHandler

2023-08-29 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated SOLR-16955: Component/s: tracing > Tracing v2 apis breaks SecurityConfHandler > ---

[GitHub] [solr] dustinpeerce opened a new pull request, #1872: Fix configuration parameter stateCompressor in solr-xml reference doc

2023-08-29 Thread via GitHub
dustinpeerce opened a new pull request, #1872: URL: https://github.com/apache/solr/pull/1872 # Description The Solr Reference Guide for Configuring solr.xml contains an invalid parameter in the example file. # Solution I replaced the invalid parameter `compre

[GitHub] [solr] janhoy commented on a diff in pull request #1871: SOLR-16954 Make Circuit Breakers available for Update Requests

2023-08-29 Thread via GitHub
janhoy commented on code in PR #1871: URL: https://github.com/apache/solr/pull/1871#discussion_r1309302038 ## solr/core/src/java/org/apache/solr/handler/ContentStreamHandlerBase.java: ## @@ -63,6 +70,17 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rs

[GitHub] [solr-operator] HoustonPutman merged pull request #613: Integration Test improvements

2023-08-29 Thread via GitHub
HoustonPutman merged PR #613: URL: https://github.com/apache/solr-operator/pull/613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr-operator] HoustonPutman opened a new pull request, #613: Integration Test improvements

2023-08-29 Thread via GitHub
HoustonPutman opened a new pull request, #613: URL: https://github.com/apache/solr-operator/pull/613 - Save Solr Operator logs for each test (filtered to only the applicable lines for that test) - Print the log directory on failure - Include the KUBERNETES_VERSION on failure-retry scri

[jira] [Updated] (SOLR-16952) solr.DenseVectorField does not work on a collection with more than 1 shards

2023-08-29 Thread Qais Qadri (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qais Qadri updated SOLR-16952: -- Priority: Critical (was: Major) > solr.DenseVectorField does not work on a collection with more than 1

[GitHub] [solr] magibney commented on a diff in pull request #1351: SOLR-16654: Add support for node-level caches

2023-08-29 Thread via GitHub
magibney commented on code in PR #1351: URL: https://github.com/apache/solr/pull/1351#discussion_r1309075615 ## solr/test-framework/src/java/org/apache/solr/util/TestHarness.java: ## @@ -186,6 +187,9 @@ public TestHarness(NodeConfig config, CoresLocator coresLocator) { }

[jira] [Commented] (SOLR-15367) Convert "rid" functionality into a default Tracer

2023-08-29 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760018#comment-17760018 ] Alex Deparvu commented on SOLR-15367: - I have posted a 9.x version of this PR for rev

[jira] [Commented] (SOLR-16825) Generate Java bindings from OpenAPI spec

2023-08-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760015#comment-17760015 ] ASF subversion and git services commented on SOLR-16825: Commit e

[jira] [Commented] (SOLR-16825) Generate Java bindings from OpenAPI spec

2023-08-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1776#comment-1776 ] ASF subversion and git services commented on SOLR-16825: Commit 9

[GitHub] [solr] HoustonPutman merged pull request #1867: SOLR-16825: Fix response serialization bug

2023-08-29 Thread via GitHub
HoustonPutman merged PR #1867: URL: https://github.com/apache/solr/pull/1867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[GitHub] [solr] cpoerschke commented on a diff in pull request #1871: SOLR-16954 Make Circuit Breakers available for Update Requests

2023-08-29 Thread via GitHub
cpoerschke commented on code in PR #1871: URL: https://github.com/apache/solr/pull/1871#discussion_r1308917303 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java: ## @@ -64,13 +77,16 @@ public List checkTripped() { } /** - * Returns t

[GitHub] [solr] magibney commented on pull request #1351: SOLR-16654: Add support for node-level caches

2023-08-29 Thread via GitHub
magibney commented on PR #1351: URL: https://github.com/apache/solr/pull/1351#issuecomment-1697492086 Ah, just noticed the test suite is not quite ready to commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1867: SOLR-16825: Fix response serialization bug

2023-08-29 Thread via GitHub
HoustonPutman commented on code in PR #1867: URL: https://github.com/apache/solr/pull/1867#discussion_r1308858864 ## solr/solrj/src/java/org/apache/solr/common/util/TextWriter.java: ## @@ -88,7 +87,7 @@ default void writeVal(String name, Object val, boolean raw) throws IOExcept

[GitHub] [solr] janhoy opened a new pull request, #1871: SOLR-16954 Make Circuit Breakers available for Update Requests

2023-08-29 Thread via GitHub
janhoy opened a new pull request, #1871: URL: https://github.com/apache/solr/pull/1871 https://issues.apache.org/jira/browse/SOLR-16954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Created] (SOLR-16954) Circuit breaker for update requests

2023-08-29 Thread Jira
Jan Høydahl created SOLR-16954: -- Summary: Circuit breaker for update requests Key: SOLR-16954 URL: https://issues.apache.org/jira/browse/SOLR-16954 Project: Solr Issue Type: New Feature Se

[jira] [Commented] (SOLR-15474) pluggable support for custom circuit breakers

2023-08-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759950#comment-17759950 ] ASF subversion and git services commented on SOLR-15474: Commit 0

[jira] [Commented] (SOLR-15474) pluggable support for custom circuit breakers

2023-08-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759949#comment-17759949 ] ASF subversion and git services commented on SOLR-15474: Commit e

[GitHub] [solr] cpoerschke merged pull request #1870: SOLR-15474: three more code review tweaks

2023-08-29 Thread via GitHub
cpoerschke merged PR #1870: URL: https://github.com/apache/solr/pull/1870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

[GitHub] [solr] epugh commented on pull request #1851: SOLR-15771: bin/solr auth enable should model best practices for security.json

2023-08-29 Thread via GitHub
epugh commented on PR #1851: URL: https://github.com/apache/solr/pull/1851#issuecomment-1697342481 Ugh... test_ssl.bats failing.. thought it was ssl, but running not in ssl, I can create a collection with my user:password, but I can't query it!!! ``` curl -u name:password 'http:

[GitHub] [solr] gerlowskija commented on a diff in pull request #1867: SOLR-16825: Fix response serialization bug

2023-08-29 Thread via GitHub
gerlowskija commented on code in PR #1867: URL: https://github.com/apache/solr/pull/1867#discussion_r1308705653 ## solr/solrj/src/java/org/apache/solr/common/DelegateMapWriter.java: ## @@ -1,46 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more -

[GitHub] [solr] janhoy commented on a diff in pull request #1725: SOLR-15474 Make Circuit breakers pluggable (take 2)

2023-08-29 Thread via GitHub
janhoy commented on code in PR #1725: URL: https://github.com/apache/solr/pull/1725#discussion_r1308693783 ## solr/core/src/test/org/apache/solr/util/BaseTestCircuitBreaker.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [solr] cpoerschke commented on a diff in pull request #1725: SOLR-15474 Make Circuit breakers pluggable (take 2)

2023-08-29 Thread via GitHub
cpoerschke commented on code in PR #1725: URL: https://github.com/apache/solr/pull/1725#discussion_r1308670451 ## solr/core/src/test/org/apache/solr/util/BaseTestCircuitBreaker.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [solr] cpoerschke commented on a diff in pull request #1725: SOLR-15474 Make Circuit breakers pluggable (take 2)

2023-08-29 Thread via GitHub
cpoerschke commented on code in PR #1725: URL: https://github.com/apache/solr/pull/1725#discussion_r1308670451 ## solr/core/src/test/org/apache/solr/util/BaseTestCircuitBreaker.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [solr] cpoerschke opened a new pull request, #1870: SOLR-15474: three more code review tweaks

2023-08-29 Thread via GitHub
cpoerschke opened a new pull request, #1870: URL: https://github.com/apache/solr/pull/1870 https://issues.apache.org/jira/browse/SOLR-15474 Follow-up due to race condition on #1725 merge: https://github.com/apache/solr/pull/1725#discussion_r1308640769 -- This is an automated messag

[GitHub] [solr] janhoy commented on pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

2023-08-29 Thread via GitHub
janhoy commented on PR #1792: URL: https://github.com/apache/solr/pull/1792#issuecomment-1697241385 > > Eager to get this into 9.4. Let me know if we can help finalizing these two PRs > > @janhoy I should push a new commit sometime today. I have changed little bit your CSP patch, I j

[jira] [Commented] (SOLR-15474) pluggable support for custom circuit breakers

2023-08-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759912#comment-17759912 ] ASF subversion and git services commented on SOLR-15474: Commit d

[GitHub] [solr] janhoy commented on a diff in pull request #1725: SOLR-15474 Make Circuit breakers pluggable (take 2)

2023-08-29 Thread via GitHub
janhoy commented on code in PR #1725: URL: https://github.com/apache/solr/pull/1725#discussion_r1308640769 ## solr/core/src/test/org/apache/solr/util/BaseTestCircuitBreaker.java: ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Resolved] (SOLR-15474) pluggable support for custom circuit breakers

2023-08-29 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-15474. Fix Version/s: 9.4 Resolution: Fixed Thanks everyone, especially [~cpoerschke] for peristent

[GitHub] [solr] cpoerschke commented on a diff in pull request #1725: SOLR-15474 Make Circuit breakers pluggable (take 2)

2023-08-29 Thread via GitHub
cpoerschke commented on code in PR #1725: URL: https://github.com/apache/solr/pull/1725#discussion_r1308559589 ## solr/core/src/test-files/solr/collection1/conf/solrconfig-pluggable-circuitbreaker.xml: ## @@ -0,0 +1,95 @@ + + + + + + ${tests.luceneMatchVersion:LATEST} + ${solr

[jira] [Commented] (SOLR-15474) pluggable support for custom circuit breakers

2023-08-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759906#comment-17759906 ] ASF subversion and git services commented on SOLR-15474: Commit 4

[GitHub] [solr] janhoy merged pull request #1725: SOLR-15474 Make Circuit breakers pluggable (take 2)

2023-08-29 Thread via GitHub
janhoy merged PR #1725: URL: https://github.com/apache/solr/pull/1725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr] laminelam commented on pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

2023-08-29 Thread via GitHub
laminelam commented on PR #1792: URL: https://github.com/apache/solr/pull/1792#issuecomment-1697196130 > Eager to get this into 9.4. Let me know if we can help finalizing these two PRs @janhoy I should push a new commit sometime today. I have changed little bit your CSP patch, I just

[GitHub] [solr] epugh commented on a diff in pull request #1851: SOLR-15771: bin/solr auth enable should model best practices for security.json

2023-08-29 Thread via GitHub
epugh commented on code in PR #1851: URL: https://github.com/apache/solr/pull/1851#discussion_r1308523779 ## solr/core/src/resources/security.json: ## @@ -0,0 +1,74 @@ +{ + "authentication": { +"blockUnknown": false, +"class": "solr.BasicAuthPlugin", Review Comment:

[GitHub] [solr] epugh commented on pull request #1851: SOLR-15771: bin/solr auth enable should model best practices for security.json

2023-08-29 Thread via GitHub
epugh commented on PR #1851: URL: https://github.com/apache/solr/pull/1851#issuecomment-1697106268 @HoustonPutman this PR is getting close to be ready to merge, wanted to bug you on the ref guide "branch" magic links! -- This is an automated message from the Apache Git Service. To respond

[GitHub] [solr] epugh commented on a diff in pull request #1851: SOLR-15771: bin/solr auth enable should model best practices for security.json

2023-08-29 Thread via GitHub
epugh commented on code in PR #1851: URL: https://github.com/apache/solr/pull/1851#discussion_r1308500729 ## solr/core/src/java/org/apache/solr/cli/AuthTool.java: ## @@ -347,37 +352,21 @@ private int handleBasicAuth(CommandLine cli) throws Exception { boolean blockUn

[GitHub] [solr] epugh commented on a diff in pull request #1851: SOLR-15771: bin/solr auth enable should model best practices for security.json

2023-08-29 Thread via GitHub
epugh commented on code in PR #1851: URL: https://github.com/apache/solr/pull/1851#discussion_r1308498345 ## solr/core/src/resources/security.json: ## @@ -0,0 +1,74 @@ +{ + "authentication": { +"blockUnknown": false, +"class": "solr.BasicAuthPlugin", Review Comment:

[GitHub] [solr] psalagnac commented on pull request #1864: SOLR-16879: add dedicated thread pool for expensive admin operations

2023-08-29 Thread via GitHub
psalagnac commented on PR #1864: URL: https://github.com/apache/solr/pull/1864#issuecomment-1697060989 Thanks for you feedback. I added marked more operation as expensive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [solr] janhoy commented on pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

2023-08-29 Thread via GitHub
janhoy commented on PR #1792: URL: https://github.com/apache/solr/pull/1792#issuecomment-1697017083 Eager to get this into 9.4. Let me know if we can help finalizing these two PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Updated] (SOLR-16953) Wrong parsing when using pf parameter

2023-08-29 Thread Monica Marrero (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Monica Marrero updated SOLR-16953: -- Description: The parsing of the query for the _pf_ parameter is wrong. Reference to user maili

[GitHub] [solr] atris commented on pull request #1725: SOLR-15474 Make Circuit breakers pluggable (take 2)

2023-08-29 Thread via GitHub
atris commented on PR #1725: URL: https://github.com/apache/solr/pull/1725#issuecomment-1696936233 I took a look and it looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Created] (SOLR-16953) Wrong parsing when using pf parameter

2023-08-29 Thread Monica Marrero (Jira)
Monica Marrero created SOLR-16953: - Summary: Wrong parsing when using pf parameter Key: SOLR-16953 URL: https://issues.apache.org/jira/browse/SOLR-16953 Project: Solr Issue Type: Bug Se

[GitHub] [solr] janhoy commented on pull request #1725: SOLR-15474 Make Circuit breakers pluggable (take 2)

2023-08-29 Thread via GitHub
janhoy commented on PR #1725: URL: https://github.com/apache/solr/pull/1725#issuecomment-1696924284 Looking for at least one "+1" before I proceed with the merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL