magibney commented on code in PR #1351:
URL: https://github.com/apache/solr/pull/1351#discussion_r1309075615
##########
solr/test-framework/src/java/org/apache/solr/util/TestHarness.java:
##########
@@ -186,6 +187,9 @@ public TestHarness(NodeConfig config, CoresLocator
coresLocator) {
}
public static NodeConfig buildTestNodeConfig(Path solrHome) {
+ if ("true".equals(System.getProperty("solr.tests.loadSolrXml"))) {
+ return SolrXmlConfig.fromSolrHome(solrHome, new Properties());
+ }
Review Comment:
Just wanted to call this out -- am I missing something, is there a better
way to do this? I'd be surprised if this were the first time anyone wanted to
actually build and query a core in a way that calls for custom functionality in
`solr.xml` ... but I haven't been able to find any precedent.
There's lots of precedent for directly building a NodeConfig; but it looks
like the way TestHarness builds its NodeConfig (like, to support actual
indexing and querying) ignores `solr.xml` here in `buildTestNodeConfig()`.
Aside from this last minor question, this should now be ready to commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
