[jira] [Commented] (SOLR-16798) Remove the bin/solr -f pattern in favour of bin/solr start -f explicit command.

2023-05-12 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722304#comment-17722304 ] Eric Pugh commented on SOLR-16798: -- so, making the short form continue to be supported m

[jira] [Assigned] (SOLR-13931) Decommission Analytics component/handler

2023-05-12 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-13931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-13931: -- Assignee: Jan Høydahl > Decommission Analytics component/handler > ---

[jira] [Resolved] (SOLR-16661) Remove analytics component in 10.0

2023-05-12 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16661. Resolution: Fixed Wow, Solr just got 56,330 lines and 314 files lighter! > Remove analytics compon

[jira] [Commented] (SOLR-16661) Remove analytics component in 10.0

2023-05-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722298#comment-17722298 ] ASF subversion and git services commented on SOLR-16661: Commit 6

[GitHub] [solr] janhoy merged pull request #1622: SOLR-16661 Remove deprecated Analytics Component in 10.0

2023-05-12 Thread via GitHub
janhoy merged PR #1622: URL: https://github.com/apache/solr/pull/1622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-16798) Remove the bin/solr -f pattern in favour of bin/solr start -f explicit command.

2023-05-12 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722297#comment-17722297 ] Jan Høydahl commented on SOLR-16798: +1 to uniform cli syntax. But support the shortf

[GitHub] [solr] janhoy commented on a diff in pull request #1634: SOLR-6994: Integrate post tool into bin/solr and bin/solr.cmd

2023-05-12 Thread via GitHub
janhoy commented on code in PR #1634: URL: https://github.com/apache/solr/pull/1634#discussion_r1192812226 ## solr/core/src/java/org/apache/solr/cli/SimplePostTool.java: ## @@ -231,19 +235,13 @@ protected static SimplePostTool parseArgsAndInit(String[] args) { String p

[GitHub] [solr] mlbiscoc commented on a diff in pull request #1620: SOLR-16470: Create V2 equivalent of V1 Replication: Get IndexVersion

2023-05-12 Thread via GitHub
mlbiscoc commented on code in PR #1620: URL: https://github.com/apache/solr/pull/1620#discussion_r1192677449 ## solr/core/src/java/org/apache/solr/handler/replication/CoreReplicationAPI.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] mlbiscoc commented on pull request #1620: SOLR-16470: Create V2 equivalent of V1 Replication: Get IndexVersion

2023-05-12 Thread via GitHub
mlbiscoc commented on PR #1620: URL: https://github.com/apache/solr/pull/1620#issuecomment-1546119925 @gerlowskija I believe I have addressed all your comments above. Please feel free to review again if you think any other changes are necessary. -- This is an automated message from the Ap

[GitHub] [solr] mlbiscoc commented on a diff in pull request #1620: SOLR-16470: Create V2 equivalent of V1 Replication: Get IndexVersion

2023-05-12 Thread via GitHub
mlbiscoc commented on code in PR #1620: URL: https://github.com/apache/solr/pull/1620#discussion_r1192657522 ## solr/solr-ref-guide/modules/deployment-guide/pages/user-managed-index-replication.adoc: ## @@ -378,9 +378,26 @@ http://_leader_host:port_/solr/_core_name_/replication

[GitHub] [solr] mlbiscoc commented on a diff in pull request #1620: SOLR-16470: Create V2 equivalent of V1 Replication: Get IndexVersion

2023-05-12 Thread via GitHub
mlbiscoc commented on code in PR #1620: URL: https://github.com/apache/solr/pull/1620#discussion_r1192657177 ## solr/core/src/java/org/apache/solr/handler/replication/CoreReplicationAPI.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] mlbiscoc commented on a diff in pull request #1620: SOLR-16470: Create V2 equivalent of V1 Replication: Get IndexVersion

2023-05-12 Thread via GitHub
mlbiscoc commented on code in PR #1620: URL: https://github.com/apache/solr/pull/1620#discussion_r1192656511 ## solr/core/src/java/org/apache/solr/handler/replication/package-info.java: ## @@ -0,0 +1,19 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [solr] mlbiscoc commented on a diff in pull request #1620: SOLR-16470: Create V2 equivalent of V1 Replication: Get IndexVersion

2023-05-12 Thread via GitHub
mlbiscoc commented on code in PR #1620: URL: https://github.com/apache/solr/pull/1620#discussion_r1192656846 ## solr/core/src/test/org/apache/solr/handler/replication/CoreReplicationAPITest.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [solr] mlbiscoc commented on a diff in pull request #1620: SOLR-16470: Create V2 equivalent of V1 Replication: Get IndexVersion

2023-05-12 Thread via GitHub
mlbiscoc commented on code in PR #1620: URL: https://github.com/apache/solr/pull/1620#discussion_r1192654571 ## solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java: ## @@ -798,6 +777,38 @@ private void getFileList(SolrParams solrParams, SolrQueryResponse rsp) {

[jira] [Commented] (SOLR-16798) Remove the bin/solr -f pattern in favour of bin/solr start -f explicit command.

2023-05-12 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722252#comment-17722252 ] Jason Gerlowski commented on SOLR-16798: Fwiw, I like the idea of requiring "star

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

2023-05-12 Thread via GitHub
igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1192621167 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -971,7 +971,7 @@ protected void writeResponse( if (solrRsp.getException() != null) {

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

2023-05-12 Thread via GitHub
sonatype-lift[bot] commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1192589333 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -971,7 +971,7 @@ protected void writeResponse( if (solrRsp.getException() != nul

[jira] [Commented] (SOLR-16799) upgrade Solr to use Lucene 9.6.0

2023-05-12 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722233#comment-17722233 ] Alex Deparvu commented on SOLR-16799: - I'm interested in giving this a go, if no one

[GitHub] [solr] mlbiscoc commented on a diff in pull request #1627: SOLR-16273: Prometheus Metric Exporter is very slow when collecting large amounts of sample data

2023-05-12 Thread via GitHub
mlbiscoc commented on code in PR #1627: URL: https://github.com/apache/solr/pull/1627#discussion_r1192578929 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/collector/MetricSamples.java: ## @@ -47,7 +65,8 @@ public void addSampleIfMetricExists( return;

[GitHub] [solr-operator] HoustonPutman closed issue #564: operator crash on gcs backup start and then never ends

2023-05-12 Thread via GitHub
HoustonPutman closed issue #564: operator crash on gcs backup start and then never ends URL: https://github.com/apache/solr-operator/issues/564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [solr-operator] HoustonPutman merged pull request #565: Bump github.com/docker/distribution from 2.8.1+incompatible to 2.8.2+incompatible

2023-05-12 Thread via GitHub
HoustonPutman merged PR #565: URL: https://github.com/apache/solr-operator/pull/565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

2023-05-12 Thread via GitHub
igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1192534779 ## solr/core/src/java/org/apache/solr/rest/BaseSolrResource.java: ## @@ -143,7 +143,11 @@ protected void handleException(Logger log) { Exception exception = getSolrR

[jira] [Commented] (SOLR-16801) CoreContainer overrides context class loader

2023-05-12 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722214#comment-17722214 ] Houston Putman commented on SOLR-16801: --- Is your idea to save the previous thread c

[jira] [Comment Edited] (SOLR-14886) Suppress stack trace in Query response.

2023-05-12 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721002#comment-17721002 ] Isabelle Giguere edited comment on SOLR-14886 at 5/12/23 3:12 PM: -

[GitHub] [solr-operator] HoustonPutman commented on pull request #561: Add managed scale-down for SolrClouds

2023-05-12 Thread via GitHub
HoustonPutman commented on PR #561: URL: https://github.com/apache/solr-operator/pull/561#issuecomment-1545872689 Review request: @radu-gheorghe and @tflobbe. I'll finish this up today or Monday -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [solr] mlbiscoc commented on a diff in pull request #1627: SOLR-16273: Prometheus Metric Exporter is very slow when collecting large amounts of sample data

2023-05-12 Thread via GitHub
mlbiscoc commented on code in PR #1627: URL: https://github.com/apache/solr/pull/1627#discussion_r1192417543 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/collector/MetricSamples.java: ## @@ -19,24 +19,42 @@ import io.prometheus.client.Collector; import jav

[jira] [Commented] (SOLR-16801) CoreContainer overrides context class loader

2023-05-12 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722184#comment-17722184 ] Thomas Wöckinger commented on SOLR-16801: - [~houston] as you introduced the, you

[jira] [Commented] (SOLR-14886) Suppress stack trace in Query response.

2023-05-12 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722181#comment-17722181 ] Isabelle Giguere commented on SOLR-14886: - [~cpoerschke] {quote}Would be curious

[jira] [Created] (SOLR-16801) CoreContainer overrides context class loader

2023-05-12 Thread Jira
Thomas Wöckinger created SOLR-16801: --- Summary: CoreContainer overrides context class loader Key: SOLR-16801 URL: https://issues.apache.org/jira/browse/SOLR-16801 Project: Solr Issue Type: B

[GitHub] [solr] cpoerschke merged pull request #1640: NO JIRA: modules/ltr - mark FieldValueFeatureScorer.context private and final

2023-05-12 Thread via GitHub
cpoerschke merged PR #1640: URL: https://github.com/apache/solr/pull/1640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

2023-05-12 Thread via GitHub
igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1192381371 ## solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java: ## @@ -70,10 +90,13 @@ public static int getErrorInfo(Throwable ex, NamedList info, Logger log)

[GitHub] [solr] gerlowskija commented on a diff in pull request #1620: SOLR-16470: Create V2 equivalent of V1 Replication: Get IndexVersion

2023-05-12 Thread via GitHub
gerlowskija commented on code in PR #1620: URL: https://github.com/apache/solr/pull/1620#discussion_r1192313804 ## solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java: ## @@ -798,6 +777,38 @@ private void getFileList(SolrParams solrParams, SolrQueryResponse rsp)

[jira] [Created] (SOLR-16800) Allow create_collection to use -url instead of -c and work with remote solr.

2023-05-12 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-16800: Summary: Allow create_collection to use -url instead of -c and work with remote solr. Key: SOLR-16800 URL: https://issues.apache.org/jira/browse/SOLR-16800 Project: Solr

[GitHub] [solr] aruggero commented on a diff in pull request #1586: SOLR-16759: Introducing logAll parameter in the feature logger

2023-05-12 Thread via GitHub
aruggero commented on code in PR #1586: URL: https://github.com/apache/solr/pull/1586#discussion_r1192255064 ## solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java: ## @@ -71,8 +71,13 @@ public class LTRFeatureLoggerTransforme

[jira] [Created] (SOLR-16799) upgrade Solr to use Lucene 9.6.0

2023-05-12 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-16799: -- Summary: upgrade Solr to use Lucene 9.6.0 Key: SOLR-16799 URL: https://issues.apache.org/jira/browse/SOLR-16799 Project: Solr Issue Type: Task

[GitHub] [solr] cpoerschke commented on a diff in pull request #1557: SOLR-16677: Updated Solr to use new Lucene 9.5 storedFields() API

2023-05-12 Thread via GitHub
cpoerschke commented on code in PR #1557: URL: https://github.com/apache/solr/pull/1557#discussion_r1192221051 ## solr/modules/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java: ## @@ -166,18 +167,23 @@ public FeatureScorer scorer(LeafReaderContext context) throws

[GitHub] [solr] cpoerschke opened a new pull request, #1640: NO JIRA: modules/ltr - mark FieldValueFeatureScorer.context private and final

2023-05-12 Thread via GitHub
cpoerschke opened a new pull request, #1640: URL: https://github.com/apache/solr/pull/1640 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [solr] cpoerschke commented on a diff in pull request #1557: SOLR-16677: Updated Solr to use new Lucene 9.5 storedFields() API

2023-05-12 Thread via GitHub
cpoerschke commented on code in PR #1557: URL: https://github.com/apache/solr/pull/1557#discussion_r1192199410 ## solr/modules/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java: ## @@ -166,18 +167,23 @@ public FeatureScorer scorer(LeafReaderContext context) throws

[GitHub] [solr] alessandrobenedetti commented on pull request #1586: SOLR-16759: Introducing logAll parameter in the feature logger

2023-05-12 Thread via GitHub
alessandrobenedetti commented on PR #1586: URL: https://github.com/apache/solr/pull/1586#issuecomment-1545500360 Running checks, merging on monday! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [solr] cpoerschke commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

2023-05-12 Thread via GitHub
cpoerschke commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1192139537 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -296,6 +296,8 @@ && getZkController().getOverseer() != null private final Set allowPaths; +

[jira] [Commented] (SOLR-14886) Suppress stack trace in Query response.

2023-05-12 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722099#comment-17722099 ] Christine Poerschke commented on SOLR-14886: Thanks [~igiguere] for working o

[GitHub] [solr] cpoerschke commented on a diff in pull request #1627: SOLR-16273: Prometheus Metric Exporter is very slow when collecting large amounts of sample data

2023-05-12 Thread via GitHub
cpoerschke commented on code in PR #1627: URL: https://github.com/apache/solr/pull/1627#discussion_r1192075956 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/collector/MetricSamples.java: ## @@ -19,24 +19,42 @@ import io.prometheus.client.Collector; import j

[GitHub] [solr-operator] MikeMichel commented on issue #564: operator crash on gcs backup start and then never ends

2023-05-12 Thread via GitHub
MikeMichel commented on issue #564: URL: https://github.com/apache/solr-operator/issues/564#issuecomment-1545331164 i can confirm in 0.7.0 it works. thx @HoustonPutman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t