mlbiscoc commented on code in PR #1620:
URL: https://github.com/apache/solr/pull/1620#discussion_r1192654571


##########
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java:
##########
@@ -798,6 +777,38 @@ private void getFileList(SolrParams solrParams, 
SolrQueryResponse rsp) {
     }
   }
 
+  public CoreReplicationAPI.IndexVersionResponse getIndexVersionResponse() 
throws IOException {

Review Comment:
   Personally I wouldn't create public getters for those fields just for the V2 
API. If at some point all the logic is moved then that should go in that PR.
   
   But if you feel strongly about it, I can definitely move it just lmk.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to