[
https://issues.apache.org/jira/browse/SOLR-16167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-16167:
-
Attachment: StaticInitializerReferencesSubClass-1.xml
> Review static initializers that reference
[
https://issues.apache.org/jira/browse/SOLR-16167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated SOLR-16167:
-
Attachment: (was: StaticInitializerReferencesSubClass-1.xml)
> Review static initializers tha
noblepaul commented on PR #1267:
URL: https://github.com/apache/solr/pull/1267#issuecomment-1373160070
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
noblepaul commented on PR #1276:
URL: https://github.com/apache/solr/pull/1276#issuecomment-1373156890
> It there a need for test coverage?
there is one added in #1277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
madrob commented on code in PR #1225:
URL: https://github.com/apache/solr/pull/1225#discussion_r1063055366
##
solr/bin/solr:
##
@@ -2153,16 +2160,17 @@ function start_solr() {
SOLR_JETTY_ADDL_CONFIG="$3"
# define default GC_TUNE
- if [ -z ${GC_TUNE+x} ]; then # I think
janhoy commented on PR #1225:
URL: https://github.com/apache/solr/pull/1225#issuecomment-1373026516
I'm ready to merge this. I ran `gradlew integrationTests` to exercise the
script with BATS tests, and all 34 passed. That's a good sign.
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/SOLR-16475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655197#comment-17655197
]
ASF subversion and git services commented on SOLR-16475:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-16475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-16475.
Fix Version/s: 9.2
Resolution: Fixed
> Ability to change the default replica placement plugi
[
https://issues.apache.org/jira/browse/SOLR-16475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655195#comment-17655195
]
ASF subversion and git services commented on SOLR-16475:
Commit 1
janhoy merged PR #1089:
URL: https://github.com/apache/solr/pull/1089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
sonatype-lift[bot] commented on code in PR #1089:
URL: https://github.com/apache/solr/pull/1089#discussion_r1063021252
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##
@@ -2841,8 +2836,10 @@ static CollectionAdminResponse getStatusResp
janhoy commented on code in PR #1089:
URL: https://github.com/apache/solr/pull/1089#discussion_r1063021233
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##
@@ -2841,8 +2836,10 @@ static CollectionAdminResponse getStatusResponse(String
janhoy commented on PR #1272:
URL: https://github.com/apache/solr/pull/1272#issuecomment-1372959927
This is now ready after some final edits, and addition of refGuide
major-changes note for 10.0.
+21 lines and −1,084 lines. Love it :)
I'll merge whenever I get a +1 or if silent,
[
https://issues.apache.org/jira/browse/SOLR-16535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-16535:
---
Description:
For version 10, we remove this module, to get rid of the deprecated and stale
jaeger-cl
janhoy commented on code in PR #1272:
URL: https://github.com/apache/solr/pull/1272#discussion_r1062994944
##
versions.lock:
##
@@ -239,7 +237,6 @@ org.apache.sis.core:sis-referencing:1.2 (3 constraints:
4829fae1)
org.apache.sis.core:sis-utility:1.2 (4 constraints: 0b35ce5b)
[
https://issues.apache.org/jira/browse/SOLR-16534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-16534.
Fix Version/s: 9.2
Resolution: Fixed
> Deprecate Jaegertracer-Configurator
> ---
[
https://issues.apache.org/jira/browse/SOLR-16534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655167#comment-17655167
]
ASF subversion and git services commented on SOLR-16534:
Commit 5
[
https://issues.apache.org/jira/browse/SOLR-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655165#comment-17655165
]
Jan Høydahl commented on SOLR-16532:
The other PR [GitHub Pull Request
#1275|https:/
[
https://issues.apache.org/jira/browse/SOLR-16534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655166#comment-17655166
]
ASF subversion and git services commented on SOLR-16534:
Commit 0
janhoy merged PR #1270:
URL: https://github.com/apache/solr/pull/1270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655164#comment-17655164
]
ASF subversion and git services commented on SOLR-16532:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655158#comment-17655158
]
David Smiley commented on SOLR-10466:
-
These are compatible ideas provided that the c
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655157#comment-17655157
]
David Smiley commented on SOLR-16567:
-
At the *very* least, run. {{gw precommit}}
[
https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655154#comment-17655154
]
Jan Høydahl commented on SOLR-10466:
We now have [63
methods|https://github.com/apac
dsmiley commented on PR #1278:
URL: https://github.com/apache/solr/pull/1278#issuecomment-1372883940
Nonetheless I liked some of the minor code improvements in this PR so I
think we should bring them in. Feel free to push them to Nazerke's PR.
--
This is an automated message from the Apa
dsmiley commented on code in PR #1239:
URL: https://github.com/apache/solr/pull/1239#discussion_r1062955249
##
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java:
##
@@ -238,9 +238,14 @@ public List getAllConfigFiles(String configName)
throws IOException {
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655145#comment-17655145
]
Alessandro Benedetti commented on SOLR-16567:
-
the cherry pick was not in syn
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655144#comment-17655144
]
ASF subversion and git services commented on SOLR-16567:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655138#comment-17655138
]
Uwe Schindler commented on SOLR-15254:
--
In case you want the hot fix in next Solr bu
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655137#comment-17655137
]
ASF subversion and git services commented on SOLR-16567:
Commit e
alessandrobenedetti commented on code in PR #1255:
URL: https://github.com/apache/solr/pull/1255#discussion_r1062893565
##
solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java:
##
@@ -124,18 +124,18 @@ public KnnVectorsFormat
getKnnVectorsFormatForField(String field)
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655133#comment-17655133
]
Alessandro Benedetti commented on SOLR-16567:
-
Hi Kevin, my bad, I thought it
risdenk commented on code in PR #1239:
URL: https://github.com/apache/solr/pull/1239#discussion_r1062881305
##
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java:
##
@@ -238,9 +238,14 @@ public List getAllConfigFiles(String configName)
throws IOException {
risdenk closed pull request #1278: SOLR-15787: Fix Windows
URL: https://github.com/apache/solr/pull/1278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
risdenk commented on PR #1278:
URL: https://github.com/apache/solr/pull/1278#issuecomment-1372723904
Sigh well there are assumptions all over ConfigSetService that use `/` so
maybe https://github.com/apache/solr/pull/1239 is the right way to go. I have
no idea if we normalize to `/` if Wind
[
https://issues.apache.org/jira/browse/SOLR-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655122#comment-17655122
]
Shawn Heisey commented on SOLR-16603:
-
The embedded server is used for a lot of the t
[
https://issues.apache.org/jira/browse/SOLR-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655120#comment-17655120
]
Shawn Heisey commented on SOLR-16603:
-
The reason we don't recommend using it in prod
[
https://issues.apache.org/jira/browse/SOLR-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655114#comment-17655114
]
Michael Gibney commented on SOLR-15254:
---
This is good to know; thanks for fixing, a
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655107#comment-17655107
]
Kevin Risden commented on SOLR-16567:
-
[~abenedetti] bump on this - this is failing b
[
https://issues.apache.org/jira/browse/SOLR-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655085#comment-17655085
]
Uwe Schindler edited comment on SOLR-15254 at 1/5/23 6:20 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655085#comment-17655085
]
Uwe Schindler commented on SOLR-15254:
--
At least this was the last deadlock regardin
[
https://issues.apache.org/jira/browse/SOLR-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655076#comment-17655076
]
Uwe Schindler commented on SOLR-15254:
--
Yes, from the first response I figured, too.
hiteshk25 commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1062680961
##
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##
@@ -488,4 +494,27 @@ public interface CollectionStateProps {
String SHARDS = "shards";
[
https://issues.apache.org/jira/browse/SOLR-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655026#comment-17655026
]
Michael Gibney commented on SOLR-15254:
---
cross-posting on this issue as a heads-up:
risdenk commented on code in PR #1239:
URL: https://github.com/apache/solr/pull/1239#discussion_r1062653536
##
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java:
##
@@ -238,9 +238,14 @@ public List getAllConfigFiles(String configName)
throws IOException {
risdenk opened a new pull request, #1278:
URL: https://github.com/apache/solr/pull/1278
https://issues.apache.org/jira/browse/SOLR-15787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
[
https://issues.apache.org/jira/browse/SOLR-15787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655025#comment-17655025
]
Kevin Risden commented on SOLR-15787:
-
[~nazerke] re: testing on Windows - I have a W
risdenk commented on code in PR #1239:
URL: https://github.com/apache/solr/pull/1239#discussion_r1062648382
##
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java:
##
@@ -238,9 +238,14 @@ public List getAllConfigFiles(String configName)
throws IOException {
dsmiley commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1062644575
##
solr/core/src/test-files/solr/solr.xml:
##
@@ -35,11 +35,6 @@
${connTimeout:15000}
-
Review Comment:
I could imagine your asks of me snow-balling to fu
dsmiley commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1062636982
##
solr/core/src/test-files/solr/solr.xml:
##
@@ -35,11 +35,6 @@
${connTimeout:15000}
-
Review Comment:
Even for expert/undocumented? There are no hard &
[
https://issues.apache.org/jira/browse/SOLR-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16612:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Workaround IBM Java check in H
[
https://issues.apache.org/jira/browse/SOLR-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655010#comment-17655010
]
ASF subversion and git services commented on SOLR-16612:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16612:
Fix Version/s: main (10.0)
9.2
> Workaround IBM Java check in Hadoop
> -
[
https://issues.apache.org/jira/browse/SOLR-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655009#comment-17655009
]
ASF subversion and git services commented on SOLR-16612:
Commit 0
risdenk merged PR #1271:
URL: https://github.com/apache/solr/pull/1271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655006#comment-17655006
]
Jeb Nix commented on SOLR-16603:
Thank you that's exactly what I need. I'd say it's ready
uschindler commented on PR #1271:
URL: https://github.com/apache/solr/pull/1271#issuecomment-1372366236
> Those other tests complain about the private key not working, right? I
thought this was also related to hadoop's kerberos library?
Sorry, thats home-made:
```
org.apache
uschindler commented on PR #1271:
URL: https://github.com/apache/solr/pull/1271#issuecomment-1372364292
Those other tests complain about the private key not working, right? I
thought this was also related to hadoop's kerberos library?
--
This is an automated message from the Apache Git Se
[
https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655002#comment-17655002
]
ASF subversion and git services commented on SOLR-16438:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17655000#comment-17655000
]
ASF subversion and git services commented on SOLR-16438:
Commit 5
risdenk commented on PR #1271:
URL: https://github.com/apache/solr/pull/1271#issuecomment-1372357089
I ran this locally for a bunch of tests with openj9 on Mac - The Hadoop
tests at least pass now. I haven't gotten to these yet but they are a separate
root cause from what I can tell:
[
https://issues.apache.org/jira/browse/SOLR-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16612:
Status: Patch Available (was: Open)
> Workaround IBM Java check in Hadoop
> --
Kevin Risden created SOLR-16612:
---
Summary: Workaround IBM Java check in Hadoop
Key: SOLR-16612
URL: https://issues.apache.org/jira/browse/SOLR-16612
Project: Solr
Issue Type: Task
Securit
risdenk commented on code in PR #1271:
URL: https://github.com/apache/solr/pull/1271#discussion_r1062570823
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/Constants.java:
##
@@ -25,4 +25,15 @@ public class Constants {
public static final boolean JRE_IS_MINIMUM_JAVA1
risdenk commented on PR #1271:
URL: https://github.com/apache/solr/pull/1271#issuecomment-1372327459
> Do you have an issue already opened at Hadoop?
https://issues.apache.org/jira/browse/HADOOP-18329 was already opened and
should be in 3.3.5 or 3.4.0 or later.
--
This is an autom
uschindler commented on code in PR #1271:
URL: https://github.com/apache/solr/pull/1271#discussion_r1062567032
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/Constants.java:
##
@@ -25,4 +25,15 @@ public class Constants {
public static final boolean JRE_IS_MINIMUM_JA
uschindler commented on code in PR #1271:
URL: https://github.com/apache/solr/pull/1271#discussion_r1062559127
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/Constants.java:
##
@@ -25,4 +25,15 @@ public class Constants {
public static final boolean JRE_IS_MINIMUM_JA
uschindler commented on code in PR #1271:
URL: https://github.com/apache/solr/pull/1271#discussion_r1062559127
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/Constants.java:
##
@@ -25,4 +25,15 @@ public class Constants {
public static final boolean JRE_IS_MINIMUM_JA
risdenk commented on code in PR #1271:
URL: https://github.com/apache/solr/pull/1271#discussion_r1062527490
##
solr/modules/hdfs/src/test/org/apache/hadoop/util/PlatformName.java:
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
epugh commented on PR #1273:
URL: https://github.com/apache/solr/pull/1273#issuecomment-1372265611
I get that... Does it deal properly with the multiple line thing?
```
$ bin/java
SOMEOUTPUT
```
and the copy only grabs `bin/java`?
--
This is an automated message fr
risdenk commented on PR #1273:
URL: https://github.com/apache/solr/pull/1273#issuecomment-1372260525
I think we should use `console` then to make the code blocks explicit. Right
now the indents make it hard to tell when editing the adoc if its actually a
code block or not.
--
This is an
epugh commented on PR #1273:
URL: https://github.com/apache/solr/pull/1273#issuecomment-1372161901
I read the docs, but didn't find this section... ;-) Stumble across an
example and then figured it out by just trialing... Great to see the
explanation of how it works!
--
This is an a
uschindler commented on PR #1271:
URL: https://github.com/apache/solr/pull/1271#issuecomment-1372158333
As said before, for reads, the native varhandles can be used. There is also
no separate "longBitsToRawDouble". What was the reason to add the latest commit?
--
This is an automated mess
uschindler commented on PR #1271:
URL: https://github.com/apache/solr/pull/1271#issuecomment-1372151473
In general for Java 17+ there is no longer a IBM "variant" available. For
Java 11 I am not 100% sure, but I think they already switched to OpenJDK code
base after Java 8. So maybe the che
noblepaul commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1062416508
##
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##
@@ -465,7 +467,11 @@ public boolean isPerReplicaState() {
}
public PerReplicaStates ge
noblepaul commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1062416203
##
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##
@@ -488,4 +494,27 @@ public interface CollectionStateProps {
String SHARDS = "shards";
uschindler commented on PR #1271:
URL: https://github.com/apache/solr/pull/1271#issuecomment-1372147570
Do you have an issue already opened at Hadoop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
uschindler commented on PR #1271:
URL: https://github.com/apache/solr/pull/1271#issuecomment-1372146618
But on the long term, both Hadoop and also Solr should just check, which of
both classes are available. Relying on system properties should be avoided if
possible as this is just text. Wh
janhoy commented on PR #1275:
URL: https://github.com/apache/solr/pull/1275#issuecomment-1371955037
@dsmiley Regarding the hope of excluding some dependencies, we received a
reply in
https://github.com/open-telemetry/opentelemetry-java/discussions/5079#discussioncomment-4595701,
so it seem
janhoy commented on code in PR #1168:
URL: https://github.com/apache/solr/pull/1168#discussion_r1062247311
##
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (A
janhoy commented on code in PR #1168:
URL: https://github.com/apache/solr/pull/1168#discussion_r1062246728
##
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/ClosableTracerShim.java:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
janhoy opened a new pull request, #1275:
URL: https://github.com/apache/solr/pull/1275
https://issues.apache.org/jira/browse/SOLR-16532
I created a new PR where we can gather all followup cleanups that may arrive
after the initial merge in #1168
--
This is an automated message fro
henrik242 commented on code in PR #1255:
URL: https://github.com/apache/solr/pull/1255#discussion_r1062245190
##
solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java:
##
@@ -124,18 +124,18 @@ public KnnVectorsFormat
getKnnVectorsFormatForField(String field) {
uschindler commented on PR #1271:
URL: https://github.com/apache/solr/pull/1271#issuecomment-1371923674
Maybe just check if one or the other class exists in runtime?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
janhoy commented on code in PR #1168:
URL: https://github.com/apache/solr/pull/1168#discussion_r1062223079
##
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (A
85 matches
Mail list logo
