risdenk commented on code in PR #1271:
URL: https://github.com/apache/solr/pull/1271#discussion_r1062570823
##########
solr/solrj/src/java/org/apache/solr/client/solrj/util/Constants.java:
##########
@@ -25,4 +25,15 @@ public class Constants {
public static final boolean JRE_IS_MINIMUM_JAVA11 = true;
// Future, enable if needed...
// public static final boolean JRE_IS_MINIMUM_JAVA17 =
Runtime.version().feature() >= 17;
+
+ public static final boolean IS_IBM_JAVA = isIBMJava();
+
+ private static boolean isIBMJava() {
+ try {
+ Class.forName("com.ibm.security.auth.module.Krb5LoginModule", false,
null);
+ return true;
+ } catch (ClassNotFoundException e) {
Review Comment:
yea `this.getClass().getClassLoader()` won't work with the static variable.
`Constants.class.getClassLoader()` does.
##########
solr/solrj/src/java/org/apache/solr/client/solrj/util/Constants.java:
##########
@@ -25,4 +25,15 @@ public class Constants {
public static final boolean JRE_IS_MINIMUM_JAVA11 = true;
// Future, enable if needed...
// public static final boolean JRE_IS_MINIMUM_JAVA17 =
Runtime.version().feature() >= 17;
+
+ public static final boolean IS_IBM_JAVA = isIBMJava();
+
+ private static boolean isIBMJava() {
+ try {
+ Class.forName("com.ibm.security.auth.module.Krb5LoginModule", false,
null);
+ return true;
+ } catch (ClassNotFoundException e) {
Review Comment:
Fixed in e258862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
