[jira] [Commented] (SOLR-16567) java.lang.StackOverflowError when combining KnnQParser and FunctionRangeQParser

2022-12-16 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648839#comment-17648839 ] Alessandro Benedetti commented on SOLR-16567: - Reading here: https://solr.apa

[GitHub] [solr] stillalex commented on pull request #1232: SOLR-13243: Correct initial capacity of ops

2022-12-16 Thread GitBox
stillalex commented on PR #1232: URL: https://github.com/apache/solr/pull/1232#issuecomment-1355867779 I think @madrob's proposal fits better, a List.of() looks cleaner to me too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [solr] stillalex commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

2022-12-16 Thread GitBox
stillalex commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1051253430 ## solr/core/src/java/org/apache/solr/core/SolrCores.java: ## @@ -193,9 +165,9 @@ List getCores() { * @return An unsorted list. This list is a new copy, it can be mo

[GitHub] [solr] stillalex commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

2022-12-16 Thread GitBox
stillalex commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1051253089 ## solr/core/src/java/org/apache/solr/core/SolrCores.java: ## @@ -114,11 +94,8 @@ protected void close() { synchronized (modifyLock) { // make a copy of

[GitHub] [solr] stillalex commented on pull request #1155: [SOLR-16497] Allow finer grained locking in SolrCores

2022-12-16 Thread GitBox
stillalex commented on PR #1155: URL: https://github.com/apache/solr/pull/1155#issuecomment-1355742412 @debe I have finally had some time to update the benchmark to remove mockito and only use pure SolrCore code for verification. I think I have taken all the noise out of it, but unfortunate

[GitHub] [solr-operator] HoustonPutman commented on pull request #473: Add a podDisruptionBudget for the whole cloud

2022-12-16 Thread GitBox
HoustonPutman commented on PR #473: URL: https://github.com/apache/solr-operator/pull/473#issuecomment-1355694054 No there is not currently. @endzyme would you mind creating a ticket for that? Should be pretty easy to implement if you also want to take a stab at it 🙂 -- This is an

[GitHub] [solr-operator] HoustonPutman opened a new pull request, #507: Start e2e/integration testing functionality.

2022-12-16 Thread GitBox
HoustonPutman opened a new pull request, #507: URL: https://github.com/apache/solr-operator/pull/507 Resolves #134 This is the first of hopefully many integration testing tickets, mostly to build the start of a framework so that other work can be done iteratively. Goals/Progres

[GitHub] [solr] epugh commented on pull request #1213: SOLR-16574: Demonstrate Dense Vectors and KNN as part of the Films example

2022-12-16 Thread GitBox
epugh commented on PR #1213: URL: https://github.com/apache/solr/pull/1213#issuecomment-1355601919 This is looking really cool...I wonder, is it worth docuemnting running the python scripts? -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (SOLR-16438) Shard split should be able to set preferred leaders on other replicas

2022-12-16 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648777#comment-17648777 ] Kevin Risden commented on SOLR-16438: - [~broustant] did you mean to merge the commit

[GitHub] [solr] epugh commented on pull request #1213: SOLR-16574: Demonstrate Dense Vectors and KNN as part of the Films example

2022-12-16 Thread GitBox
epugh commented on PR #1213: URL: https://github.com/apache/solr/pull/1213#issuecomment-1355341463 `bin/solr start -example films` no longer creates all the fields -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Updated] (SOLR-16592) films tutorial should be documented in Ref Guide

2022-12-16 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16592: - Description: The /solr/examples/films/README.md has grown to be a full on tutorial, including a new patc

[jira] [Commented] (SOLR-16592) films tutorial should be documented in Ref Guide

2022-12-16 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648732#comment-17648732 ] Eric Pugh commented on SOLR-16592: -- now the content is kind of orphaned ;) > films tuto

[jira] [Created] (SOLR-16592) films tutorial should be documented in Ref Guide

2022-12-16 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-16592: Summary: films tutorial should be documented in Ref Guide Key: SOLR-16592 URL: https://issues.apache.org/jira/browse/SOLR-16592 Project: Solr Issue Type: Improvement

[jira] [Commented] (SOLR-16438) Shard split should be able to set preferred leaders on other replicas

2022-12-16 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648731#comment-17648731 ] Bruno Roustant commented on SOLR-16438: --- Thanks [~krisden]. I missed it after resol

[GitHub] [solr] epugh commented on pull request #1213: SOLR-16574: Demonstrate Dense Vectors and KNN as part of the Films example

2022-12-16 Thread GitBox
epugh commented on PR #1213: URL: https://github.com/apache/solr/pull/1213#issuecomment-1355201400 @gabrielmagno how do you want to be credited in `CHANGES.txt`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (SOLR-5707) Lucene Expressions in Solr

2022-12-16 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648679#comment-17648679 ] Kevin Risden commented on SOLR-5707: For what it is worth - I'm looking at this relate

[GitHub] [solr] risdenk opened a new pull request, #1244: SOLR-5707: Lucene Expressions in Solr

2022-12-16 Thread GitBox
risdenk opened a new pull request, #1244: URL: https://github.com/apache/solr/pull/1244 https://issues.apache.org/jira/browse/SOLR-5707 This is me taking Hoss's VSP patch from https://issues.apache.org/jira/browse/SOLR-5707 and trying to look at it again. -- This is an automated me

[jira] [Resolved] (SOLR-16589) Large fields with large="true" can be truncated when using unicode values

2022-12-16 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved SOLR-16589. - Resolution: Fixed > Large fields with large="true" can be truncated when using unicode values > -

[jira] [Commented] (SOLR-16589) Large fields with large="true" can be truncated when using unicode values

2022-12-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648635#comment-17648635 ] ASF subversion and git services commented on SOLR-16589: Commit a

[jira] [Commented] (SOLR-16589) Large fields with large="true" can be truncated when using unicode values

2022-12-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648634#comment-17648634 ] ASF subversion and git services commented on SOLR-16589: Commit 0

[jira] [Commented] (SOLR-16589) Large fields with large="true" can be truncated when using unicode values

2022-12-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648632#comment-17648632 ] ASF subversion and git services commented on SOLR-16589: Commit b

[jira] [Commented] (SOLR-16589) Large fields with large="true" can be truncated when using unicode values

2022-12-16 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648631#comment-17648631 ] Kevin Risden commented on SOLR-16589: - Alright so ran `./gradlew -p solr/core beast -

[jira] [Commented] (SOLR-16589) Large fields with large="true" can be truncated when using unicode values

2022-12-16 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648619#comment-17648619 ] Kevin Risden commented on SOLR-16589: - Ah so found a sneaky method in the test that i

[GitHub] [solr-operator] vipul-06 opened a new issue, #506: solr cloud backup gcs

2022-12-16 Thread GitBox
vipul-06 opened a new issue, #506: URL: https://github.com/apache/solr-operator/issues/506 I have created solrcloud using the yaml defined below ``` `apiVersion: solr.apache.org/v1beta1 kind: SolrCloud metadata: name: example namespace: dev-backend spec: backupRe

[jira] [Comment Edited] (SOLR-16589) Large fields with large="true" can be truncated when using unicode values

2022-12-16 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648617#comment-17648617 ] Kevin Risden edited comment on SOLR-16589 at 12/16/22 1:02 PM:

[jira] [Reopened] (SOLR-16589) Large fields with large="true" can be truncated when using unicode values

2022-12-16 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reopened SOLR-16589: - Well another reproducing seed: {code:java} ./gradlew test --tests LargeFieldTest.test -Dtests.seed=A

[jira] [Commented] (SOLR-16438) Shard split should be able to set preferred leaders on other replicas

2022-12-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648611#comment-17648611 ] ASF subversion and git services commented on SOLR-16438: Commit e

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2022-12-16 Thread GitBox
sonatype-lift[bot] commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1050663419 ## solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java: ## @@ -268,19 +270,21 @@ public Map getPackagesDeployedAsClusterLevelPlugins Mul

[GitHub] [solr] bszabo97 commented on pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2022-12-16 Thread GitBox
bszabo97 commented on PR #1182: URL: https://github.com/apache/solr/pull/1182#issuecomment-1354572598 I have added some more commits where I was trying to migrate from apache client to the jetty client, but right now I am a bit stuck and I would need a little guidance. With the curre

[GitHub] [solr] bruno-roustant closed pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

2022-12-16 Thread GitBox
bruno-roustant closed pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command. URL: https://github.com/apache/solr/pull/1048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [solr] bruno-roustant commented on pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

2022-12-16 Thread GitBox
bruno-roustant commented on PR #1048: URL: https://github.com/apache/solr/pull/1048#issuecomment-1354539553 Thanks for the review! Merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Resolved] (SOLR-16438) Shard split should be able to set preferred leaders on other replicas

2022-12-16 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved SOLR-16438. --- Fix Version/s: 9.2 Resolution: Fixed Thanks [~dsmiley] for the review! > Shard split

[jira] [Commented] (SOLR-16438) Shard split should be able to set preferred leaders on other replicas

2022-12-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648557#comment-17648557 ] ASF subversion and git services commented on SOLR-16438: Commit 0