[
https://issues.apache.org/jira/browse/SOLR-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629249#comment-17629249
]
David Smiley commented on SOLR-16524:
-
Not sure if you explored improving on HashQPar
dsmiley commented on code in PR #1154:
URL: https://github.com/apache/solr/pull/1154#discussion_r1014559245
##
solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java:
##
@@ -590,52 +592,79 @@ private void setFilters(ResponseBuilder rb, Elevation
eleva
rseitz commented on code in PR #1154:
URL: https://github.com/apache/solr/pull/1154#discussion_r1014542480
##
solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java:
##
@@ -590,52 +592,79 @@ private void setFilters(ResponseBuilder rb, Elevation
elevat
dsmiley commented on PR #1158:
URL: https://github.com/apache/solr/pull/1158#issuecomment-1304287579
> should I resolve comments as I follow up with them, or just leave them
open till the end and maybe reply with a "Done" or "Dealt with"?? Whats the
best process?
IMO simply saying "D
dsmiley commented on code in PR #1154:
URL: https://github.com/apache/solr/pull/1154#discussion_r1014484618
##
solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java:
##
@@ -553,6 +560,82 @@ private void setQuery(ResponseBuilder rb, Elevation
elevatio
dsmiley commented on code in PR #1154:
URL: https://github.com/apache/solr/pull/1154#discussion_r1014458212
##
solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java:
##
@@ -590,52 +592,79 @@ private void setFilters(ResponseBuilder rb, Elevation
eleva
[
https://issues.apache.org/jira/browse/SOLR-16523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629197#comment-17629197
]
Jan Høydahl commented on SOLR-16523:
What do we miss out on by not having very latest
janhoy commented on PR #1161:
URL: https://github.com/apache/solr/pull/1161#issuecomment-1304270595
> As far as what this PR needs. Since this PR has no change for the user a
CHANGES.txt record is not needed. Also docs are unchanged.
The new jar deserves a changes entry, some users ma
janhoy commented on code in PR #1161:
URL: https://github.com/apache/solr/pull/1161#discussion_r1014473410
##
solr/solr-ref-guide/modules/deployment-guide/pages/solrj.adoc:
##
@@ -56,6 +56,8 @@ compile group: 'org.apache.solr', name: 'solr-solrj',
version: '{solr-full-versi
AAnakhe commented on PR #1080:
URL: https://github.com/apache/solr/pull/1080#issuecomment-1304264336
Thank you Jason, you do the same.
On Sat, Oct 15, 2022 at 8:51 PM sonatype-lift[bot] ***@***.***>
wrote:
> ⚠️ *314 God Classes* were detected by Lift in this project. Visit th
[
https://issues.apache.org/jira/browse/SOLR-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-16524:
--
Description:
Both Streaming Expressions and Spark-Solr currently rely on query time hash
parti
[
https://issues.apache.org/jira/browse/SOLR-16524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-16524:
--
Description:
Both Streaming Expressions and Spark-Solr currently rely on query time hash
parti
Joel Bernstein created SOLR-16524:
-
Summary: Index time hash partitioning
Key: SOLR-16524
URL: https://issues.apache.org/jira/browse/SOLR-16524
Project: Solr
Issue Type: Improvement
Sec
[
https://issues.apache.org/jira/browse/SOLR-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-16510:
--
Fix Version/s: main (10.0)
9.2
> StreamDecoratorTest.testParallelTerminating
[
https://issues.apache.org/jira/browse/SOLR-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-16510:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
> StreamDecoratorTest.testPa
[
https://issues.apache.org/jira/browse/SOLR-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629187#comment-17629187
]
ASF subversion and git services commented on SOLR-16510:
Commit 0
joel-bernstein commented on PR #1162:
URL: https://github.com/apache/solr/pull/1162#issuecomment-1304133481
I'll check those other streams, I believe they are ok as written though as I
don't think there is an iterator involved.
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/SOLR-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629185#comment-17629185
]
ASF subversion and git services commented on SOLR-16510:
Commit 1
joel-bernstein merged PR #1162:
URL: https://github.com/apache/solr/pull/1162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.ap
[
https://issues.apache.org/jira/browse/SOLR-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16510:
Status: Patch Available (was: Open)
> StreamDecoratorTest.testParallelTerminatingDaemonUpdateStrea
risdenk commented on PR #1162:
URL: https://github.com/apache/solr/pull/1162#issuecomment-1304114264
Change makes sense - does it make sense to check these other cases
potentially too?
```
git grep -F Collections.synchronizedMap -- solr/solrj-streaming/
solr/solrj-streaming/src
gerlowskija merged PR #1163:
URL: https://github.com/apache/solr/pull/1163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
gerlowskija commented on code in PR #1080:
URL: https://github.com/apache/solr/pull/1080#discussion_r1014416757
##
solr/core/src/java/org/apache/solr/handler/admin/api/RenameCollectionAPI.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
gerlowskija commented on code in PR #1080:
URL: https://github.com/apache/solr/pull/1080#discussion_r1014393162
##
solr/core/src/java/org/apache/solr/handler/admin/api/RenameCollectionAPI.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
rseitz commented on code in PR #1154:
URL: https://github.com/apache/solr/pull/1154#discussion_r1014411718
##
solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java:
##
@@ -553,6 +560,82 @@ private void setQuery(ResponseBuilder rb, Elevation
elevation
rseitz commented on code in PR #1154:
URL: https://github.com/apache/solr/pull/1154#discussion_r1014403344
##
solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java:
##
@@ -553,6 +560,82 @@ private void setQuery(ResponseBuilder rb, Elevation
elevation
epugh commented on PR #1158:
URL: https://github.com/apache/solr/pull/1158#issuecomment-1304060117
@dsmiley @risdenk should I resolve comments as I follow up with them, or
just leave them open till the end and maybe reply with a "Done" or "Dealt
with"?? Whats the best process?
--
This
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1014396292
##
solr/core/src/test/org/apache/solr/schema/TestCloudManagedSchema.java:
##
@@ -53,12 +54,11 @@ public void test() throws Exception {
QueryRequest request = new QueryR
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1014392413
##
solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperTest.java:
##
@@ -63,13 +63,14 @@ public static void setupBeforeClass() throws E
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1014386128
##
solr/solrj/src/test/org/apache/solr/client/solrj/TestSolrJErrorHandling.java:
##
@@ -102,16 +102,19 @@ public void showExceptions() throws Exception {
@Test
publi
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1014385111
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientTest.java:
##
@@ -542,7 +557,32 @@ public void testUpdate() throws Exception {
}
@Test
- pub
risdenk commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1014379583
##
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleJettyTest.java:
##
@@ -72,15 +65,15 @@ public void testBadSetup() {
@Test
public void testA
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1014378171
##
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleJettyTest.java:
##
@@ -72,15 +65,15 @@ public void testBadSetup() {
@Test
public void testArb
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1014374236
##
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##
@@ -2872,9 +2872,16 @@ public static LBHttpSolrClient
getLBHttpSolrClient(String... solrUrls)
}
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1014373636
##
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##
@@ -2562,20 +2562,20 @@ public static Object skewed(Object likely, Object
unlikely) {
* A varian
gerlowskija opened a new pull request, #1163:
URL: https://github.com/apache/solr/pull/1163
Was unintentionally added in c23ecd6.
# Description
A previous commit (c23ecd6) inadvertently added `sourceCompatibility` and
`targetCompatibility` settings to build.gradle. These a
[
https://issues.apache.org/jira/browse/SOLR-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629167#comment-17629167
]
Joel Bernstein commented on SOLR-16510:
---
A PR is up:
https://github.com/apache/sol
[
https://issues.apache.org/jira/browse/SOLR-16523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629166#comment-17629166
]
Houston Putman commented on SOLR-16523:
---
We run {{apt-get update}} then {{apt-get i
[
https://issues.apache.org/jira/browse/SOLR-16515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-16515:
Fix Version/s: 9.2
Resolution: Fixed
Status: Resolved (was: Patch Available)
Gre
[
https://issues.apache.org/jira/browse/SOLR-16515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629158#comment-17629158
]
ASF subversion and git services commented on SOLR-16515:
Commit e
HoustonPutman commented on PR #1115:
URL: https://github.com/apache/solr/pull/1115#issuecomment-1303995329
Not sure if this was discussed, but can we take `/commands` out of the path
for this? `/replace` alone is pretty self-explanatory.
--
This is an automated message from the Apache Git
dsmiley commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1014351333
##
solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java:
##
@@ -156,8 +160,7 @@ public synchronized SolrClient getSolrClient() {
public SolrClient create
joel-bernstein opened a new pull request, #1162:
URL: https://github.com/apache/solr/pull/1162
…currentModificationException
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with thi
[
https://issues.apache.org/jira/browse/SOLR-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629150#comment-17629150
]
Joel Bernstein commented on SOLR-16510:
---
I think I see the issue. I'll put up a PR
gerlowskija commented on PR #1115:
URL: https://github.com/apache/solr/pull/1115#issuecomment-1303955756
Hi @joshgog - just wanted to summarize where we are on this. I think at
this point you've addressed everything I (and Noble) brought up in review so
far. Unless I'm missing something?
risdenk commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1014303007
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrClientTest.java:
##
@@ -476,9 +484,20 @@ public void testUpdate() throws Exception {
// parame
gerlowskija commented on code in PR #1115:
URL: https://github.com/apache/solr/pull/1115#discussion_r1014306588
##
solr/core/src/java/org/apache/solr/handler/admin/api/ReplaceNodeAPI.java:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
rseitz commented on code in PR #1154:
URL: https://github.com/apache/solr/pull/1154#discussion_r1014305574
##
solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java:
##
@@ -553,6 +560,82 @@ private void setQuery(ResponseBuilder rb, Elevation
elevation
rseitz commented on code in PR #1154:
URL: https://github.com/apache/solr/pull/1154#discussion_r1014304329
##
solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java:
##
@@ -553,6 +560,82 @@ private void setQuery(ResponseBuilder rb, Elevation
elevation
Jdurham2843 commented on PR #1126:
URL: https://github.com/apache/solr/pull/1126#issuecomment-1303901999
1. Awesome, sounds good! The new syntax definitely looks better (and may be
easier to parse if someone were using the API from another program), but it's
probably a good idea to get cons
[
https://issues.apache.org/jira/browse/SOLR-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein reassigned SOLR-16510:
-
Assignee: Joel Bernstein
> StreamDecoratorTest.testParallelTerminatingDaemonUpdateStream
[
https://issues.apache.org/jira/browse/SOLR-16510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629112#comment-17629112
]
Joel Bernstein commented on SOLR-16510:
---
I'll take a look at this.
> StreamDecorat
gerlowskija commented on PR #1126:
URL: https://github.com/apache/solr/pull/1126#issuecomment-1303884400
Recent changes (`@Schema` documentation, failure-case unit tests, API class
renaming) all look great.
To summarize where we are, I think there's two remaining items to clear up
be
gerlowskija commented on code in PR #1126:
URL: https://github.com/apache/solr/pull/1126#discussion_r1014259104
##
solr/core/src/java/org/apache/solr/handler/admin/CoreAdminOperation.java:
##
@@ -278,31 +276,28 @@ public enum CoreAdminOperation implements CoreAdminOp {
LI
risdenk commented on code in PR #1161:
URL: https://github.com/apache/solr/pull/1161#discussion_r1014248482
##
solr/solrj/build.gradle:
##
@@ -47,7 +45,6 @@ dependencies {
testImplementation project(':solr:test-framework')
Review Comment:
After line 45 we need a new line
risdenk commented on PR #1099:
URL: https://github.com/apache/solr/pull/1099#issuecomment-1303860976
backport to branch_9x here: https://github.com/apache/solr/pull/1161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
gerlowskija commented on code in PR #862:
URL: https://github.com/apache/solr/pull/862#discussion_r1014216626
##
build.gradle:
##
@@ -207,3 +207,5 @@ apply from: file('gradle/ant-compat/solr.post-jar.gradle')
apply from: file('gradle/node.gradle')
+sourceCompatibility = Jav
[
https://issues.apache.org/jira/browse/SOLR-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629063#comment-17629063
]
Patson Luk commented on SOLR-16414:
---
[~magibney] that's very true that we don't seem to
risdenk commented on PR #585:
URL: https://github.com/apache/solr/pull/585#issuecomment-1303802256
The above failures also happen on `main` branch so at least it is nothing
new added from this PR for nightly tests.
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/SOLR-16099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629060#comment-17629060
]
Houston Putman commented on SOLR-16099:
---
Note, this is why some tests fail frequent
[
https://issues.apache.org/jira/browse/SOLR-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629050#comment-17629050
]
Michael Gibney commented on SOLR-16414:
---
Thank you for the in-depth analysis, Patso
Ritchie Gu created SOLR-16523:
-
Summary: gosu binary version
Key: SOLR-16523
URL: https://issues.apache.org/jira/browse/SOLR-16523
Project: Solr
Issue Type: Improvement
Security Level: Publ
joel-bernstein commented on PR #1161:
URL: https://github.com/apache/solr/pull/1161#issuecomment-1303687435
As far as what this PR needs. Since this PR has no change for the user a
CHANGES.txt record is not needed. Also docs are unchanged.
So I think the main thing in this PR is ensur
[
https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629027#comment-17629027
]
Joel Bernstein commented on SOLR-15733:
---
[~krisden] the backport PR is up:
https:/
joel-bernstein opened a new pull request, #1161:
URL: https://github.com/apache/solr/pull/1161
* SOLR-15733: Initial commit WIP
* SOLR-15733: Move solrj.client.io
* SOLR-15733: Fix directories
* SOLR-15733: Move tests
* SOLR-15733: Remove commons math from main sol
risdenk commented on PR #585:
URL: https://github.com/apache/solr/pull/585#issuecomment-1303654102
I haven't looked at these yet or see if they reproduce.
```
./gradlew check -Pvalidation.errorprone=true -Ptests.filter=@Nightly
...
ERROR: The following test(s) have failed:
risdenk commented on PR #585:
URL: https://github.com/apache/solr/pull/585#issuecomment-1303609905
@markrmiller do you have any concerns on the current state of this PR? I'm
hoping to merge it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
[
https://issues.apache.org/jira/browse/SOLR-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629005#comment-17629005
]
David Smiley commented on SOLR-16367:
-
Notice I created a sub-task https://issues.apa
[
https://issues.apache.org/jira/browse/SOLR-16515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629000#comment-17629000
]
ASF subversion and git services commented on SOLR-16515:
Commit 5
dsmiley merged PR #1156:
URL: https://github.com/apache/solr/pull/1156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on code in PR #1053:
URL: https://github.com/apache/solr/pull/1053#discussion_r1014014058
##
solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java:
##
@@ -1298,19 +1298,25 @@ public Map execute(
V2ApiUtils.squashIntoSolrResponseWit
dsmiley commented on code in PR #1053:
URL: https://github.com/apache/solr/pull/1053#discussion_r1014010860
##
solr/core/src/test/org/apache/solr/handler/admin/api/DeleteReplicaPropertyAPITest.java:
##
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
[
https://issues.apache.org/jira/browse/SOLR-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628965#comment-17628965
]
Bence Szabó commented on SOLR-16367:
I have seen that we make of a {{defaultHttpClien
dsmiley commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1013976253
##
solr/core/src/test/org/apache/solr/schema/TestCloudManagedSchema.java:
##
@@ -53,12 +54,11 @@ public void test() throws Exception {
QueryRequest request = new Quer
[
https://issues.apache.org/jira/browse/SOLR-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628937#comment-17628937
]
Fredrik Rodland commented on SOLR-16502:
Thanks [~cpoerschke] !
> Multiple CopyF
[
https://issues.apache.org/jira/browse/SOLR-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-16502:
---
Fix Version/s: 9.1
(was: 9.2)
> Multiple CopyField should not
[
https://issues.apache.org/jira/browse/SOLR-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628935#comment-17628935
]
ASF subversion and git services commented on SOLR-16502:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628934#comment-17628934
]
ASF subversion and git services commented on SOLR-16502:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628928#comment-17628928
]
ASF subversion and git services commented on SOLR-16502:
Commit 4
79 matches
Mail list logo
