[jira] [Commented] (SOLR-16425) NullPointerException in SimplePlacementFactory: PlacementRequest.getCollection() is null

2022-10-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619264#comment-17619264 ] Ishan Chattopadhyaya commented on SOLR-16425: - [~hossman], are these tests co

[jira] [Commented] (SOLR-16425) NullPointerException in SimplePlacementFactory: PlacementRequest.getCollection() is null

2022-10-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619263#comment-17619263 ] Ishan Chattopadhyaya commented on SOLR-16425: - I tried beasting locally, but

[jira] [Commented] (SOLR-16451) PRS: Don't fetch the prs state, while registering the collection watch

2022-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619245#comment-17619245 ] ASF subversion and git services commented on SOLR-16451: Commit 6

[jira] [Commented] (SOLR-16451) PRS: Don't fetch the prs state, while registering the collection watch

2022-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619244#comment-17619244 ] ASF subversion and git services commented on SOLR-16451: Commit c

[jira] [Commented] (SOLR-16453) overseer doesn't handle prs messages properly

2022-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619240#comment-17619240 ] ASF subversion and git services commented on SOLR-16453: Commit f

[jira] [Commented] (SOLR-16453) overseer doesn't handle prs messages properly

2022-10-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619241#comment-17619241 ] Ishan Chattopadhyaya commented on SOLR-16453: - Thanks [~jsweene2], [~hiteshkh

[jira] [Resolved] (SOLR-16453) overseer doesn't handle prs messages properly

2022-10-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya resolved SOLR-16453. - Resolution: Fixed > overseer doesn't handle prs messages properly > -

[jira] [Assigned] (SOLR-16453) overseer doesn't handle prs messages properly

2022-10-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya reassigned SOLR-16453: --- Assignee: Ishan Chattopadhyaya (was: Noble Paul) > overseer doesn't handle

[jira] [Commented] (SOLR-16453) overseer doesn't handle prs messages properly

2022-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619238#comment-17619238 ] ASF subversion and git services commented on SOLR-16453: Commit 3

[jira] [Commented] (SOLR-16453) overseer doesn't handle prs messages properly

2022-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619237#comment-17619237 ] ASF subversion and git services commented on SOLR-16453: Commit b

[GitHub] [solr] asfgit closed pull request #1055: SOLR-16453: Overseer doesn't handle prs messages properly

2022-10-17 Thread GitBox
asfgit closed pull request #1055: SOLR-16453: Overseer doesn't handle prs messages properly URL: https://github.com/apache/solr/pull/1055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (SOLR-16452) Keep prs state of latest version

2022-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619229#comment-17619229 ] ASF subversion and git services commented on SOLR-16452: Commit d

[jira] [Commented] (SOLR-16452) Keep prs state of latest version

2022-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619228#comment-17619228 ] ASF subversion and git services commented on SOLR-16452: Commit 8

[jira] [Commented] (SOLR-16452) Keep prs state of latest version

2022-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619227#comment-17619227 ] ASF subversion and git services commented on SOLR-16452: Commit 3

[GitHub] [solr] risdenk commented on a diff in pull request #953: SOLR-16311: Simplify assert statement

2022-10-17 Thread GitBox
risdenk commented on code in PR #953: URL: https://github.com/apache/solr/pull/953#discussion_r997711826 ## solr/modules/sql/src/test/org/apache/solr/handler/sql/TestSQLHandler.java: ## @@ -287,13 +286,13 @@ public void testBasicSelect() throws Exception { tuple = tuples.ge

[GitHub] [solr] risdenk commented on pull request #953: SOLR-16311: Simplify assert statement

2022-10-17 Thread GitBox
risdenk commented on PR #953: URL: https://github.com/apache/solr/pull/953#issuecomment-1281800456 merged main and addressed remaining simplifications of asserts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [solr] dsmiley commented on pull request #1084: Remove gpg and wget binaries from image, slimming it down some 8,5Mb

2022-10-17 Thread GitBox
dsmiley commented on PR #1084: URL: https://github.com/apache/solr/pull/1084#issuecomment-1281785959 Shaving MB usually gets my approval :-) (I have no clue RE `dirmngr`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [solr] stillalex commented on pull request #1078: SOLR-16160 UpdateXmlMessages duplicate data when data is removed and …

2022-10-17 Thread GitBox
stillalex commented on PR #1078: URL: https://github.com/apache/solr/pull/1078#issuecomment-1281730889 thanks a lot @risdenk! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [solr] risdenk merged pull request #1062: Fix wording in taking-solr-to-production.adoc

2022-10-17 Thread GitBox
risdenk merged PR #1062: URL: https://github.com/apache/solr/pull/1062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] risdenk commented on pull request #1062: Fix wording in taking-solr-to-production.adoc

2022-10-17 Thread GitBox
risdenk commented on PR #1062: URL: https://github.com/apache/solr/pull/1062#issuecomment-1281685114 Thanks @jebnix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[jira] [Commented] (SOLR-16300) Migrate from deprecated assertThat() to org.hamcrest.MatcherAssert.assertThat()

2022-10-17 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619170#comment-17619170 ] Eric Pugh commented on SOLR-16300: -- Testcontainerplugin dailing on branch, will try agai

[jira] [Updated] (SOLR-16160) UpdateXmlMessages duplicate data when data is removed and then added in the same message

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16160: Fix Version/s: 9.2 Resolution: Fixed Status: Resolved (was: Patch Available) Tha

[jira] [Commented] (SOLR-16160) UpdateXmlMessages duplicate data when data is removed and then added in the same message

2022-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619161#comment-17619161 ] ASF subversion and git services commented on SOLR-16160: Commit f

[GitHub] [solr] risdenk commented on a diff in pull request #522: SOLR-15415 Use Embedded ZK in Tests

2022-10-17 Thread GitBox
risdenk commented on code in PR #522: URL: https://github.com/apache/solr/pull/522#discussion_r997605900 ## solr/test-framework/src/java/org/apache/solr/cloud/ZkTestServer.java: ## @@ -509,191 +438,67 @@ public void run() throws InterruptedException, IOException { public v

[jira] [Updated] (SOLR-16300) Migrate from deprecated assertThat() to org.hamcrest.MatcherAssert.assertThat()

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16300: Status: Patch Available (was: Reopened) > Migrate from deprecated assertThat() to > org.hamcrest.

[jira] [Reopened] (SOLR-16300) Migrate from deprecated assertThat() to org.hamcrest.MatcherAssert.assertThat()

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reopened SOLR-16300: - make sure to backport to branch_9x > Migrate from deprecated assertThat() to > org.hamcrest.Matcher

[GitHub] [solr] risdenk commented on pull request #1078: SOLR-16160 UpdateXmlMessages duplicate data when data is removed and …

2022-10-17 Thread GitBox
risdenk commented on PR #1078: URL: https://github.com/apache/solr/pull/1078#issuecomment-1281648314 Thanks @stillalex -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[jira] [Updated] (SOLR-16160) UpdateXmlMessages duplicate data when data is removed and then added in the same message

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16160: Fix Version/s: main (10.0) > UpdateXmlMessages duplicate data when data is removed and then added i

[jira] [Commented] (SOLR-16160) UpdateXmlMessages duplicate data when data is removed and then added in the same message

2022-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619157#comment-17619157 ] ASF subversion and git services commented on SOLR-16160: Commit 0

[GitHub] [solr] risdenk merged pull request #1078: SOLR-16160 UpdateXmlMessages duplicate data when data is removed and …

2022-10-17 Thread GitBox
risdenk merged PR #1078: URL: https://github.com/apache/solr/pull/1078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-16450) Proper handling on watcher registration failure in `ZkStateReader#waitForState

2022-10-17 Thread Hitesh Khamesra (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619155#comment-17619155 ] Hitesh Khamesra commented on SOLR-16450: Thanks, looks like we need to cover one

[jira] [Commented] (SOLR-16451) PRS: Don't fetch the prs state, while registering the collection watch

2022-10-17 Thread Hitesh Khamesra (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619154#comment-17619154 ] Hitesh Khamesra commented on SOLR-16451: Thanks. we may want to remove unused fun

[jira] [Commented] (SOLR-16452) Keep prs state of latest version

2022-10-17 Thread Hitesh Khamesra (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619151#comment-17619151 ] Hitesh Khamesra commented on SOLR-16452: Looks like we need to set cversion to 0

[jira] [Comment Edited] (SOLR-16455) Migrate Jira to Github Issues and Github Projects

2022-10-17 Thread Jeb Nix (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619112#comment-17619112 ] Jeb Nix edited comment on SOLR-16455 at 10/17/22 9:40 PM: -- Hey C

[jira] [Commented] (SOLR-16455) Migrate Jira to Github Issues and Github Projects

2022-10-17 Thread Jeb Nix (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619112#comment-17619112 ] Jeb Nix commented on SOLR-16455: Hey Chris As for the GitHub TOS, that's a good point, bu

[GitHub] [solr] jebnix commented on pull request #1062: Fix documentation irrelevant minor mistake

2022-10-17 Thread GitBox
jebnix commented on PR #1062: URL: https://github.com/apache/solr/pull/1062#issuecomment-1281518066 @risdenk I liked your proposal. Committed changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (SOLR-16150) Many tools try to connect to embedded ZK on IPV6

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16150: Component/s: Integration Tests Tests > Many tools try to connect to embedded ZK on

[jira] [Assigned] (SOLR-16150) Many tools try to connect to embedded ZK on IPV6

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-16150: --- Assignee: Kevin Risden > Many tools try to connect to embedded ZK on IPV6 >

[jira] [Updated] (SOLR-16300) Migrate from deprecated assertThat() to org.hamcrest.MatcherAssert.assertThat()

2022-10-17 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16300: - Resolution: Fixed Status: Resolved (was: Patch Available) > Migrate from deprecated assertThat()

[jira] [Updated] (SOLR-16300) Migrate from deprecated assertThat() to org.hamcrest.MatcherAssert.assertThat()

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16300: Fix Version/s: main (10.0) > Migrate from deprecated assertThat() to > org.hamcrest.MatcherAssert.

[jira] [Assigned] (SOLR-16300) Migrate from deprecated assertThat() to org.hamcrest.MatcherAssert.assertThat()

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-16300: --- Assignee: Eric Pugh > Migrate from deprecated assertThat() to > org.hamcrest.MatcherAssert.

[jira] [Commented] (SOLR-16300) Migrate from deprecated assertThat() to org.hamcrest.MatcherAssert.assertThat()

2022-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619103#comment-17619103 ] ASF subversion and git services commented on SOLR-16300: Commit 8

[GitHub] [solr] epugh merged pull request #947: SOLR-16300: migrate assert to non deprecated version

2022-10-17 Thread GitBox
epugh merged PR #947: URL: https://github.com/apache/solr/pull/947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org F

[GitHub] [solr] epugh commented on pull request #953: SOLR-16311: Simplify assert statement

2022-10-17 Thread GitBox
epugh commented on PR #953: URL: https://github.com/apache/solr/pull/953#issuecomment-1281424613 Going to merge this after #947 gets in I think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [solr] epugh commented on pull request #947: SOLR-16300: migrate assert to non deprecated version

2022-10-17 Thread GitBox
epugh commented on PR #947: URL: https://github.com/apache/solr/pull/947#issuecomment-1281421975 Okay, this time things ran! Thanks for the fixes @risdenk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [solr] janhoy commented on pull request #1084: Remove gpg and wget binaries from image, slimming it down some 8,5Mb

2022-10-17 Thread GitBox
janhoy commented on PR #1084: URL: https://github.com/apache/solr/pull/1084#issuecomment-1281417709 I see that `Dockerfile.body.template` includes this line at the bottom: ```bash apt-get -y install acl dirmngr lsof procps wget netcat gosu tini jattach; \ ``` ...which

[GitHub] [solr] janhoy opened a new pull request, #1084: Remove gpg and wget binaries from image, slimming it down some 8,5Mb

2022-10-17 Thread GitBox
janhoy opened a new pull request, #1084: URL: https://github.com/apache/solr/pull/1084 No JIRA Just throwing this idea out there. Cannot see any reason to keep wget, gpg, dirmngr in the image? ``` After this operation, 3,579 kB disk space will be freed. After this operati

[jira] [Commented] (SOLR-16455) Migrate Jira to Github Issues and Github Projects

2022-10-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619066#comment-17619066 ] David Smiley commented on SOLR-16455: - There is always our email list -- issues@solr.

[jira] [Commented] (SOLR-15636) Robust support for running Solr with an embedded zookeeper

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619059#comment-17619059 ] Kevin Risden commented on SOLR-15636: - SOLR-16422 upgraded to Zookeeper 3.8.0 - so th

[jira] [Commented] (SOLR-16154) ZKEventListenerThread leaks from tests

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619056#comment-17619056 ] Kevin Risden commented on SOLR-16154: - Since May this hasn't failed on main/branch_9x

[jira] [Updated] (SOLR-16154) ZKEventListenerThread leaks from tests

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16154: Fix Version/s: 9.1 main (10.0) Resolution: Fixed Status: Resolv

[jira] [Updated] (SOLR-16150) Many tools try to connect to embedded ZK on IPV6

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16150: Status: Patch Available (was: Open) > Many tools try to connect to embedded ZK on IPV6 > -

[jira] [Assigned] (SOLR-16160) UpdateXmlMessages duplicate data when data is removed and then added in the same message

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-16160: --- Assignee: Kevin Risden > UpdateXmlMessages duplicate data when data is removed and then adde

[jira] [Updated] (SOLR-16160) UpdateXmlMessages duplicate data when data is removed and then added in the same message

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16160: Affects Version/s: 9.0 9.1 > UpdateXmlMessages duplicate data when data is r

[jira] [Updated] (SOLR-16160) UpdateXmlMessages duplicate data when data is removed and then added in the same message

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16160: Priority: Major (was: Blocker) > UpdateXmlMessages duplicate data when data is removed and then ad

[jira] [Updated] (SOLR-16160) UpdateXmlMessages duplicate data when data is removed and then added in the same message

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16160: Status: Patch Available (was: Open) > UpdateXmlMessages duplicate data when data is removed and th

[GitHub] [solr] stillalex commented on pull request #1078: SOLR-16160 UpdateXmlMessages duplicate data when data is removed and …

2022-10-17 Thread GitBox
stillalex commented on PR #1078: URL: https://github.com/apache/solr/pull/1078#issuecomment-1281300277 @risdenk thanks for taking a look. updated the CHANGES file too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [solr] epugh commented on pull request #947: SOLR-16300: migrate assert to non deprecated version

2022-10-17 Thread GitBox
epugh commented on PR #947: URL: https://github.com/apache/solr/pull/947#issuecomment-1281294752 I was on the wrong branch, and just was testing out ` java.lang.AssertionError: One of the overrides of setUp does not propagate the call.` these as well... -- This is an automated message fr

[jira] [Commented] (SOLR-16425) NullPointerException in SimplePlacementFactory: PlacementRequest.getCollection() is null

2022-10-17 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619044#comment-17619044 ] Mike Drob commented on SOLR-16425: -- [~ichattopadhyaya] , [~noble.paul]  - looks like the

[GitHub] [solr] risdenk commented on pull request #1076: Disable lift god classes

2022-10-17 Thread GitBox
risdenk commented on PR #1076: URL: https://github.com/apache/solr/pull/1076#issuecomment-1281276781 Well interestingly https://github.com/apache/solr/pull/1083 doesn't have this god classes message. So maybe it is disabled but some PRs pickup the old changes... -- This is an automated m

[GitHub] [solr] risdenk commented on pull request #1076: Disable lift god classes

2022-10-17 Thread GitBox
risdenk commented on PR #1076: URL: https://github.com/apache/solr/pull/1076#issuecomment-1281262377 @TomMD @chriswininger can either of you help with why this change didn't disable the god classes comment from Lift? This PR https://github.com/apache/solr/pull/1082 was created 2 hrs

[GitHub] [solr] risdenk commented on a diff in pull request #1062: Fix documentation irrelevant minor mistake

2022-10-17 Thread GitBox
risdenk commented on code in PR #1062: URL: https://github.com/apache/solr/pull/1062#discussion_r997340586 ## solr/solr-ref-guide/modules/deployment-guide/pages/taking-solr-to-production.adoc: ## @@ -455,7 +455,7 @@ Ideally this would mean more machines, but budget constraints

[GitHub] [solr] risdenk commented on a diff in pull request #1062: Fix documentation irrelevant minor mistake

2022-10-17 Thread GitBox
risdenk commented on code in PR #1062: URL: https://github.com/apache/solr/pull/1062#discussion_r997339925 ## solr/solr-ref-guide/modules/deployment-guide/pages/taking-solr-to-production.adoc: ## @@ -455,7 +455,7 @@ Ideally this would mean more machines, but budget constraints

[GitHub] [solr] risdenk commented on pull request #1062: Fix documentation irrelevant minor mistake

2022-10-17 Thread GitBox
risdenk commented on PR #1062: URL: https://github.com/apache/solr/pull/1062#issuecomment-1281227639 @jebnix I left a comment about maybe just punting on rewording that confusing section and putting something different in its place. Hopefully to avoid the confusion. -- This is an automat

[jira] [Commented] (SOLR-16455) Migrate Jira to Github Issues and Github Projects

2022-10-17 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619027#comment-17619027 ] Chris M. Hostetter commented on SOLR-16455: --- My feelings on this have not chang

[jira] [Commented] (SOLR-16467) semver4j fails with some locales

2022-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619026#comment-17619026 ] ASF subversion and git services commented on SOLR-16467: Commit 1

[GitHub] [solr] risdenk merged pull request #1083: SOLR-16467: Add check for working locale in TestSolrVersion

2022-10-17 Thread GitBox
risdenk merged PR #1083: URL: https://github.com/apache/solr/pull/1083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-16436) DirectSolrSpellChecher: maxQueryFrequency bug in multi-shard

2022-10-17 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619017#comment-17619017 ] Chris M. Hostetter commented on SOLR-16436: --- {quote}should we include this to 9

[jira] [Updated] (SOLR-16464) Upgrade commons-text to 1.10.0

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16464: Fix Version/s: 8.11.3 > Upgrade commons-text to 1.10.0 > -- > >

[jira] [Commented] (SOLR-16464) Upgrade commons-text to 1.10.0

2022-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619014#comment-17619014 ] ASF subversion and git services commented on SOLR-16464: Commit 5

[jira] [Updated] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List

2022-10-17 Thread Sanjay Dutt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjay Dutt updated SOLR-16470: --- Parent: SOLR-15737 Issue Type: Sub-task (was: Improvement) Security: (was: Public)

[jira] [Created] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List

2022-10-17 Thread Sanjay Dutt (Jira)
Sanjay Dutt created SOLR-16470: -- Summary: Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List Key: SOLR-16470 URL: https://issues.apache.org/jira/browse/SOLR-16470 Pro

[GitHub] [solr] risdenk commented on pull request #1078: SOLR-16160 UpdateXmlMessages duplicate data when data is removed and …

2022-10-17 Thread GitBox
risdenk commented on PR #1078: URL: https://github.com/apache/solr/pull/1078#issuecomment-1281190565 @stillalex thanks this looks good. Can you add an entry to `solr/CHANGES.txt`? I'm not sure how you want to be credited there. I can also add the solr/CHANGES.txt if you want. -- This is

[GitHub] [solr] risdenk commented on pull request #1082: Fixed typos on reindexing guide page

2022-10-17 Thread GitBox
risdenk commented on PR #1082: URL: https://github.com/apache/solr/pull/1082#issuecomment-1281187854 Thanks @stillalex -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [solr] risdenk merged pull request #1082: Fixed typos on reindexing guide page

2022-10-17 Thread GitBox
risdenk merged PR #1082: URL: https://github.com/apache/solr/pull/1082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] risdenk commented on pull request #1083: SOLR-16467: Add check for working locale in TestSolrVersion

2022-10-17 Thread GitBox
risdenk commented on PR #1083: URL: https://github.com/apache/solr/pull/1083#issuecomment-1281186915 Whoops missed adding `@SuppressWarnings("AssertionFailureIgnored")` which errorprone found. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Created] (SOLR-16469) On some systems ​ is inserted after every comma

2022-10-17 Thread dmitri maziuk (Jira)
dmitri maziuk created SOLR-16469: Summary: On some systems ​ is inserted after every comma Key: SOLR-16469 URL: https://issues.apache.org/jira/browse/SOLR-16469 Project: Solr Issue Type: Bug

[jira] [Created] (SOLR-16468) Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (collection level)

2022-10-17 Thread Sanjay Dutt (Jira)
Sanjay Dutt created SOLR-16468: -- Summary: Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (collection level) Key: SOLR-16468 URL: https://issues.apache.org/jira/browse/SOLR-16468

[GitHub] [solr] sonatype-lift[bot] commented on pull request #1082: Fixed typos on reindexing guide page

2022-10-17 Thread GitBox
sonatype-lift[bot] commented on PR #1082: URL: https://github.com/apache/solr/pull/1082#issuecomment-1281179469 :warning: **314 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/solr/01GFKBQSHDR0FWQRYV887E81

[jira] [Commented] (SOLR-16462) Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

2022-10-17 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619006#comment-17619006 ] Jason Gerlowski commented on SOLR-16462: It's all yours [~jdurham]; thanks for ta

[GitHub] [solr-operator] HoustonPutman opened a new pull request, #481: Fix bug with named PVCs

2022-10-17 Thread GitBox
HoustonPutman opened a new pull request, #481: URL: https://github.com/apache/solr-operator/pull/481 Fixes #479 Also updating some descriptions in the SolrCloud CRD. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (SOLR-16464) Upgrade commons-text to 1.10.0

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619004#comment-17619004 ] Kevin Risden commented on SOLR-16464: - branch_8_11 PR - https://github.com/apache/luc

[jira] [Commented] (SOLR-16461) Create v2 equivalent of v1 'BACKUP' (A backup API for user managed cluster or single node installation)

2022-10-17 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619003#comment-17619003 ] Jason Gerlowski commented on SOLR-16461: Hi [~duttsanjay] - thanks for trying out

[GitHub] [solr] risdenk opened a new pull request, #1083: SOLR-16467: Add check for working locale in TestSolrVersion

2022-10-17 Thread GitBox
risdenk opened a new pull request, #1083: URL: https://github.com/apache/solr/pull/1083 https://issues.apache.org/jira/browse/SOLR-16467 Short term workaround in tests until https://github.com/semver4j/semver4j/pull/85 is merged and can upgrade semver4j version. -- This is an auto

[jira] [Updated] (SOLR-16467) semver4j fails with some locales

2022-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16467: Priority: Major (was: Minor) > semver4j fails with some locales >

[GitHub] [solr-operator] HoustonPutman commented on issue #479: Operator in CrashLoop with panic

2022-10-17 Thread GitBox
HoustonPutman commented on issue #479: URL: https://github.com/apache/solr-operator/issues/479#issuecomment-1281160330 Thanks for finding this bug! You can fix it yourself locally by not setting a custom name for your data PVCs, but we will get a fix in as soon as possible. Not sure when th

[GitHub] [solr-operator] HoustonPutman commented on issue #478: Reg: Solr No Space Left Issue

2022-10-17 Thread GitBox
HoustonPutman commented on issue #478: URL: https://github.com/apache/solr-operator/issues/478#issuecomment-1281148015 Are you using the Solr Operator? If so, how much space are you giving the persistent volume? Or are you using ephemeral storage. -- This is an automated message from the

[GitHub] [solr] markrmiller commented on pull request #387: SOLR-15561: Write escaped strings in JsonTextWriter to a StringBuilder before the writer.

2022-10-17 Thread GitBox
markrmiller commented on PR #387: URL: https://github.com/apache/solr/pull/387#issuecomment-1281132585 Yeah, Yonik has some really heavy json faceting tests that are easy to look at. Some rare honest tests - far from quick, doing a lot of legitimate work, not bogarting the hardware. One of

[jira] [Comment Edited] (SOLR-15749) Create a v2 equivalent of v1 'RENAME'

2022-10-17 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17618989#comment-17618989 ] Jason Gerlowski edited comment on SOLR-15749 at 10/17/22 4:20 PM: -

[jira] [Comment Edited] (SOLR-15749) Create a v2 equivalent of v1 'RENAME'

2022-10-17 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17618989#comment-17618989 ] Jason Gerlowski edited comment on SOLR-15749 at 10/17/22 4:19 PM: -

[jira] [Commented] (SOLR-15749) Create a v2 equivalent of v1 'RENAME'

2022-10-17 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17618989#comment-17618989 ] Jason Gerlowski commented on SOLR-15749: bq. can I send a PR for review while wor

[GitHub] [solr] stillalex opened a new pull request, #1082: Fixed typos on reindexing guide page

2022-10-17 Thread GitBox
stillalex opened a new pull request, #1082: URL: https://github.com/apache/solr/pull/1082 Fixed a few typos on the guid. as changes are very small I did not create a jira ticket. # Description Please provide a short description of the changes you're making with this

[GitHub] [solr] gerlowskija commented on a diff in pull request #1080: SOLR 15749 created a v2 equivalent of v1 'rename'

2022-10-17 Thread GitBox
gerlowskija commented on code in PR #1080: URL: https://github.com/apache/solr/pull/1080#discussion_r997255652 ## solr/core/src/java/org/apache/solr/handler/admin/api/RenameClusterAPI.java: ## @@ -0,0 +1,46 @@ +package org.apache.solr.handler.admin.api; Review Comment: [-1]

[GitHub] [solr] gerlowskija commented on a diff in pull request #1080: SOLR 15749 created a v2 equivalent of v1 'rename'

2022-10-17 Thread GitBox
gerlowskija commented on code in PR #1080: URL: https://github.com/apache/solr/pull/1080#discussion_r997255652 ## solr/core/src/java/org/apache/solr/handler/admin/api/RenameClusterAPI.java: ## @@ -0,0 +1,46 @@ +package org.apache.solr.handler.admin.api; Review Comment: [-1]

[GitHub] [solr] gerlowskija commented on a diff in pull request #1080: SOLR 15749 created a v2 equivalent of v1 'rename'

2022-10-17 Thread GitBox
gerlowskija commented on code in PR #1080: URL: https://github.com/apache/solr/pull/1080#discussion_r997139202 ## solr/core/src/java/org/apache/solr/handler/admin/api/RenameClusterAPI.java: ## @@ -0,0 +1,46 @@ +package org.apache.solr.handler.admin.api; + +import org.apache.solr

[GitHub] [solr] risdenk commented on pull request #947: SOLR-16300: migrate assert to non deprecated version

2022-10-17 Thread GitBox
risdenk commented on PR #947: URL: https://github.com/apache/solr/pull/947#issuecomment-1281091689 I'm getting a bunch of failures... ``` ERROR: The following test(s) have failed: - org.apache.solr.util.configuration.SSLConfigurationsTest.testGetKeyStorePasswordFromHadoopCrede

[GitHub] [solr] risdenk commented on pull request #1054: Fix IndexOutOfBounds in RecursiveNumericEvaluator

2022-10-17 Thread GitBox
risdenk commented on PR #1054: URL: https://github.com/apache/solr/pull/1054#issuecomment-1281089307 I do see a https://github.com/apache/solr/blob/main/solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/eval/RecursiveEvaluatorTest.java, but no `RecursiveNumericEvaluatorTest` so tak

[GitHub] [solr] risdenk commented on pull request #1054: Fix IndexOutOfBounds in RecursiveNumericEvaluator

2022-10-17 Thread GitBox
risdenk commented on PR #1054: URL: https://github.com/apache/solr/pull/1054#issuecomment-1281087268 @acsbendi https://github.com/apache/solr/blob/main/solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/StreamExpressionTest.java potentially or one of the other existing classes under

[GitHub] [solr] HoustonPutman commented on pull request #387: SOLR-15561: Write escaped strings in JsonTextWriter to a StringBuilder before the writer.

2022-10-17 Thread GitBox
HoustonPutman commented on PR #387: URL: https://github.com/apache/solr/pull/387#issuecomment-1281065044 @markrmiller did you find this when profiling something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (SOLR-16305) MODIFYCOLLECTION with 'property.*' changes can't change values used in config file variables (even though they can be set during collection CREATE)

2022-10-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17618945#comment-17618945 ] David Smiley commented on SOLR-16305: - Keeping them in DocCollection is indeed conven

  1   2   >