[ 
https://issues.apache.org/jira/browse/SOLR-15749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17618989#comment-17618989
 ] 

Jason Gerlowski edited comment on SOLR-15749 at 10/17/22 4:20 PM:
------------------------------------------------------------------

bq. can I send a PR for review while working on the test method? 

Sure!  There's no rule that PRs have to be totally "ready" before you push them 
- in fact, on bigger changes it's often really important to get feedback as 
early as you can to avoid going down the wrong path, etc.  And in this case in 
particular, it'd be really hard for anyone here to make suggestions or help 
with your test issue without being able to see your test code for ourselves!

That said, when you "push early" it's important to make sure you're clear what 
parts of the PR are ready for review - saves others time as they review and 
saves you time in not having to reply to feedback on something you planned on 
changing anyways :P


was (Author: gerlowskija):
bq. can I send a PR for review while working on the test method? 

Sure!  There's no rule that PRs have to be totally "ready" before you push them 
- in fact, on bigger changes it's often really important to get feedback as 
early as you can to avoid going down the wrong path, etc.

That said, when you "push early" it's important to make sure you're clear what 
parts of the PR are ready for review - saves others time as they review and 
saves you time in not having to reply to feedback on something you planned on 
changing anyways :P

> Create a v2 equivalent of v1 'RENAME'
> -------------------------------------
>
>                 Key: SOLR-15749
>                 URL: https://issues.apache.org/jira/browse/SOLR-15749
>             Project: Solr
>          Issue Type: Sub-task
>          Components: v2 API
>            Reporter: Jason Gerlowski
>            Assignee: Jason Gerlowski
>            Priority: Major
>              Labels: V2
>
> Solr's 'RENAME' command under the v1 \{{/solr/admin/collections}} endpoint 
> has no v2 equivalent. This should be remedied to inch v2 closer to parity 
> with v1 in preparation for eventual v1 deprecation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to