sonatype-lift[bot] commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r968926308
##
solr/solrj/src/java/org/apache/solr/client/solrj/ResponseParser.java:
##
@@ -34,11 +37,22 @@ public abstract class ResponseParser {
* A well behaved Respons
dsmiley commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r968926145
##
solr/solrj/src/java/org/apache/solr/client/solrj/ResponseParser.java:
##
@@ -34,11 +37,22 @@ public abstract class ResponseParser {
* A well behaved ResponseParser wil
dsmiley commented on PR #975:
URL: https://github.com/apache/solr/pull/975#issuecomment-1244371524
Definitely really close :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
[
https://issues.apache.org/jira/browse/SOLR-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603242#comment-17603242
]
David Smiley commented on SOLR-16192:
-
Okay; thanks.
> Add ZK credentials injectors
dsmiley commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r968884674
##
solr/core/src/java/org/apache/solr/jersey/container/ContainerRequestUtils.java:
##
@@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/SOLR-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lamine updated SOLR-16192:
--
Description:
TLTR;
This PR adds _ZkCredentialsInjector_ support. What is a
{_}ZkCredentialsInjector{_}? I
[
https://issues.apache.org/jira/browse/SOLR-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lamine updated SOLR-16192:
--
Description:
TLTR;
This PR adds _ZkCredentialsInjector_ support. What is a
{_}ZkCredentialsInjector{_}? I
[
https://issues.apache.org/jira/browse/SOLR-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lamine updated SOLR-16192:
--
Description:
TLTR;
This PR adds _ZkCredentialsInjector_ support. What is a
{_}ZkCredentialsInjector{_}? I
[
https://issues.apache.org/jira/browse/SOLR-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lamine updated SOLR-16192:
--
Description:
TLTR;
This PR adds _ZkCredentialsInjector_ support. What is a
{_}ZkCredentialsInjector{_}? I
[
https://issues.apache.org/jira/browse/SOLR-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lamine updated SOLR-16192:
--
Description:
TLTR;
This PR adds _ZkCredentialsInjector_ support. What is a
{_}ZkCredentialsInjector{_}? I
[
https://issues.apache.org/jira/browse/SOLR-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603238#comment-17603238
]
Lamine edited comment on SOLR-16192 at 9/12/22 7:44 PM:
Hi [~dsmi
[
https://issues.apache.org/jira/browse/SOLR-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603238#comment-17603238
]
Lamine edited comment on SOLR-16192 at 9/12/22 7:43 PM:
Hi [~dsmi
[
https://issues.apache.org/jira/browse/SOLR-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603238#comment-17603238
]
Lamine commented on SOLR-16192:
---
Hi [~dsmiley] Updated the description.
There was an [old
[
https://issues.apache.org/jira/browse/SOLR-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lamine updated SOLR-16192:
--
Description:
TLTR;
This PR adds _ZkCredentialsInjector_ support. What is a
{_}ZkCredentialsInjector{_}? It’s
[
https://issues.apache.org/jira/browse/SOLR-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lamine updated SOLR-16192:
--
Description:
TLTR;
This PR adds _ZkCredentialsInjector_ support. What is a
{_}ZkCredentialsInjector{_}? It’s
dsmiley commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r968839919
##
solr/core/src/java/org/apache/solr/jersey/SolrJerseyResponse.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
dsmiley commented on PR #980:
URL: https://github.com/apache/solr/pull/980#issuecomment-1244209575
Let's close this or fundamentally change it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/SOLR-16192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603231#comment-17603231
]
David Smiley commented on SOLR-16192:
-
There's no JIRA issue description; really it s
dsmiley commented on PR #1004:
URL: https://github.com/apache/solr/pull/1004#issuecomment-1244201570
Your changes explicitly refer to `BaseHttpSolrClient` but that's kind of sad
to me; I view this class as an implementation detail to a subclass. Can you
undo that? As I look at BaseHttpSol
[
https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603208#comment-17603208
]
David Smiley commented on SOLR-15730:
-
As of this writing, we have a SolrJ-Zookeeper
[
https://issues.apache.org/jira/browse/SOLR-16369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-16369:
Fix Version/s: 9.1
> avoid xpath in parsing elevate.xml
> --
>
>
[
https://issues.apache.org/jira/browse/SOLR-16369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-16369.
-
Resolution: Fixed
Thanks [~haythemkh]!
> avoid xpath in parsing elevate.xml
> --
[
https://issues.apache.org/jira/browse/SOLR-16369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603204#comment-17603204
]
ASF subversion and git services commented on SOLR-16369:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-16369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603203#comment-17603203
]
ASF subversion and git services commented on SOLR-16369:
Commit 6
dsmiley merged PR #1002:
URL: https://github.com/apache/solr/pull/1002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-16343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16343:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Handle MDC snapshot being null
[
https://issues.apache.org/jira/browse/SOLR-16343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16343:
Fix Version/s: 9.1
main (10.0)
> Handle MDC snapshot being null
> --
[
https://issues.apache.org/jira/browse/SOLR-16343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603140#comment-17603140
]
ASF subversion and git services commented on SOLR-16343:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-16343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16343:
Description:
Using slf4j 2 with the jdk14 adapter, SLF4J uses the NOPMDCAdapter:
[https://www.slf4
risdenk closed pull request #978: SOLR-16343: Handle MDC snapshot being null
URL: https://github.com/apache/solr/pull/978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
risdenk commented on PR #978:
URL: https://github.com/apache/solr/pull/978#issuecomment-1243884397
Merged in
https://github.com/apache/solr/commit/ae242ff033720dd7a9664c1750dcd02a9a2efed6
- Thanks @dee42
--
This is an automated message from the Apache Git Service.
To respond to the mess
[
https://issues.apache.org/jira/browse/SOLR-16343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603136#comment-17603136
]
ASF subversion and git services commented on SOLR-16343:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-16343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16343:
Status: Patch Available (was: Open)
> Handle MDC snapshot being null
> ---
[
https://issues.apache.org/jira/browse/SOLR-16343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16343:
Priority: Minor (was: Major)
> Handle MDC snapshot being null
> --
>
>
[
https://issues.apache.org/jira/browse/SOLR-16343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16343:
Summary: Handle MDC snapshot being null (was: When using slf4j 2 and a
custom filter, calling chai
[
https://issues.apache.org/jira/browse/SOLR-16343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden reassigned SOLR-16343:
---
Assignee: Kevin Risden
> When using slf4j 2 and a custom filter, calling chain.doFilter caus
risdenk commented on PR #978:
URL: https://github.com/apache/solr/pull/978#issuecomment-1243866970
I checked the Javadoc for
https://www.slf4j.org/api/org/slf4j/MDC.html#getCopyOfContextMap-- and says it
can return null.
--
This is an automated message from the Apache Git Service.
To res
[
https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603111#comment-17603111
]
Uwe Schindler commented on SOLR-16141:
--
In general, CVE or issues in 3rd party compo
[
https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603109#comment-17603109
]
Uwe Schindler commented on SOLR-16141:
--
Hi,
Solr does not directly depend on Apache
[
https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603109#comment-17603109
]
Uwe Schindler edited comment on SOLR-16141 at 9/12/22 2:19 PM:
[
https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603076#comment-17603076
]
Ishan Chattopadhyaya edited comment on SOLR-15715 at 9/12/22 2:05 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603095#comment-17603095
]
Ishan Chattopadhyaya commented on SOLR-15715:
-
bq. Can you pretend that I'm a
[
https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603076#comment-17603076
]
Ishan Chattopadhyaya edited comment on SOLR-15715 at 9/12/22 1:43 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603092#comment-17603092
]
Kevin Risden commented on SOLR-16141:
-
[~sourabhsparkala] no idea. There is nothing f
[
https://issues.apache.org/jira/browse/SOLR-16406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16406:
Status: Patch Available (was: Open)
> Module loading does not work when using SOLR_MODULES in solr
risdenk commented on code in PR #1006:
URL: https://github.com/apache/solr/pull/1006#discussion_r968435775
##
solr/bin/solr.in.sh:
##
@@ -280,4 +280,4 @@
# SOLR_OPTS="$SOLR_OPTS -Dlog4j2.formatMsgNoLookups=true"
# The bundled plugins in the "modules" folder can easily be ena
[
https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603084#comment-17603084
]
Mike Drob commented on SOLR-15715:
--
bq. It is clear that the heap usage on data nodes (p
[
https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603083#comment-17603083
]
Ishan Chattopadhyaya commented on SOLR-15715:
-
I plan to merge the PR #996 so
[
https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603076#comment-17603076
]
Ishan Chattopadhyaya edited comment on SOLR-15715 at 9/12/22 1:13 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-16406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Wöckinger updated SOLR-16406:
Labels: pull-request-available (was: )
> Module loading does not work when using SOLR_MODU
[
https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603076#comment-17603076
]
Ishan Chattopadhyaya edited comment on SOLR-15715 at 9/12/22 1:09 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603076#comment-17603076
]
Ishan Chattopadhyaya edited comment on SOLR-15715 at 9/12/22 1:08 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603076#comment-17603076
]
Ishan Chattopadhyaya edited comment on SOLR-15715 at 9/12/22 1:07 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603076#comment-17603076
]
Ishan Chattopadhyaya edited comment on SOLR-15715 at 9/12/22 1:06 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603076#comment-17603076
]
Ishan Chattopadhyaya commented on SOLR-15715:
-
Here are final benchmark numbe
[
https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ishan Chattopadhyaya updated SOLR-15715:
Attachment: coordinator-vs-data-nodes.jpg
> Dedicated query coordinator nodes in th
noblepaul commented on PR #994:
URL: https://github.com/apache/solr/pull/994#issuecomment-1243647749
refer #1002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
noblepaul closed pull request #994: SOLR-16369: avoid xpath in parsing
elevate.xml
URL: https://github.com/apache/solr/pull/994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
epugh commented on PR #1007:
URL: https://github.com/apache/solr/pull/1007#issuecomment-1243629287
From a "does this fix the problem" view, the changes LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
thomaswoeckinger commented on code in PR #1006:
URL: https://github.com/apache/solr/pull/1006#discussion_r968305685
##
solr/bin/solr.in.sh:
##
@@ -280,4 +280,4 @@
# SOLR_OPTS="$SOLR_OPTS -Dlog4j2.formatMsgNoLookups=true"
# The bundled plugins in the "modules" folder can easi
[
https://issues.apache.org/jira/browse/SOLR-16406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603051#comment-17603051
]
Thomas Wöckinger commented on SOLR-16406:
-
[~janhoy] I added pull request but ha
thomaswoeckinger opened a new pull request, #1007:
URL: https://github.com/apache/solr/pull/1007
https://issues.apache.org/jira/browse/SOLR-X
# Description
SOLR_MODULES (provided by solr.in.sh) is currently ignored.
# Solution
Take SOLR_MODULES into
[
https://issues.apache.org/jira/browse/SOLR-16230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603001#comment-17603001
]
Marco commented on SOLR-16230:
--
[~janhoy] Thank you - I like the wording so far!
> JWT-Auth
col-panic commented on code in PR #890:
URL: https://github.com/apache/solr/pull/890#discussion_r968152823
##
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java:
##
@@ -598,12 +599,48 @@ protected JWTAuthenticationResponse authenticate(String
authori
chongma commented on PR #890:
URL: https://github.com/apache/solr/pull/890#issuecomment-1243418944
Thanks for looking at this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
65 matches
Mail list logo
