[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #986: SOLR-16337: implement Zk metrics

2022-08-25 Thread GitBox
sonatype-lift[bot] commented on code in PR #986: URL: https://github.com/apache/solr/pull/986#discussion_r955667146 ## solr/core/src/java/org/apache/solr/core/ZkContainer.java: ## @@ -152,6 +157,23 @@ public void initZooKeeper(final CoreContainer cc, CloudConfig config) {

[jira] [Commented] (SOLR-16348) New SplitShard UpdateRequestProcessor

2022-08-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585153#comment-17585153 ] David Smiley commented on SOLR-16348: - bq. I wonder about the bulk data-loading scena

[GitHub] [solr] noblepaul commented on pull request #965: SOLR-16328 : intern() strings in DocCollection to reduce memory footp…

2022-08-25 Thread GitBox
noblepaul commented on PR #965: URL: https://github.com/apache/solr/pull/965#issuecomment-1228047371 @madrob I'm testing with a modified code that uses a weakmap interner and the results are better -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [solr] noblepaul commented on pull request #972: SOLR-16337: implement Zk metrics

2022-08-25 Thread GitBox
noblepaul commented on PR #972: URL: https://github.com/apache/solr/pull/972#issuecomment-1228046225 #986 is opened after merging with main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [solr] noblepaul closed pull request #972: SOLR-16337: implement Zk metrics

2022-08-25 Thread GitBox
noblepaul closed pull request #972: SOLR-16337: implement Zk metrics URL: https://github.com/apache/solr/pull/972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [solr] noblepaul opened a new pull request, #986: SOLR-16337: implement Zk metrics

2022-08-25 Thread GitBox
noblepaul opened a new pull request, #986: URL: https://github.com/apache/solr/pull/986 implement metrics for ZK ops ### How to use? - start your servers - hit the end point `http://localhost:8983/solr/admin/metrics?key=solr.node:CONTAINER.zkClient` sample output

[GitHub] [solr] dsmiley commented on pull request #983: SOLR-16353: SplitShardCmd.checkDiskSpace can fail for transient core

2022-08-25 Thread GitBox
dsmiley commented on PR #983: URL: https://github.com/apache/solr/pull/983#issuecomment-1228041762 Since it's a known issue that this check doesn't make sense for HDFS, we could document that in the ref guide for an HDFS page. -- This is an automated message from the Apache Git Service. T

[jira] [Commented] (SOLR-14251) Shard Split on HDFS

2022-08-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585134#comment-17585134 ] David Smiley commented on SOLR-14251: - FYI the linked SOLR-16353 adds a boolean syste

[jira] [Comment Edited] (SOLR-16350) http response is delayed when solr is running in slow/restricted network environment

2022-08-25 Thread Shubanker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585107#comment-17585107 ] Shubanker edited comment on SOLR-16350 at 8/26/22 2:54 AM: --- I f

[jira] [Commented] (SOLR-16350) http response is delayed when solr is running in slow/restricted network environment

2022-08-25 Thread Shubanker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585107#comment-17585107 ] Shubanker commented on SOLR-16350: -- I faced this issue in an environment where SOLR was

[jira] [Commented] (SOLR-16079) New solrj-apachehttp module

2022-08-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585097#comment-17585097 ] David Smiley commented on SOLR-16079: - bq. Instead we can make an "empty" module that

[jira] [Commented] (SOLR-15342) Separate out a SolrJ-Zookeeper module

2022-08-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585096#comment-17585096 ] David Smiley commented on SOLR-15342: - When we release Solr 9.1 and craft the release

[jira] [Commented] (SOLR-16078) New solrj-core module

2022-08-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585093#comment-17585093 ] David Smiley commented on SOLR-16078: - Is this needed at all?  What's wrong with the

[jira] [Resolved] (SOLR-15342) Separate out a SolrJ-Zookeeper module

2022-08-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15342. - Fix Version/s: 9.1 Assignee: David Smiley Resolution: Fixed > Separate out a Solr

[jira] [Commented] (SOLR-15342) Separate out a SolrJ-Zookeeper module

2022-08-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585091#comment-17585091 ] ASF subversion and git services commented on SOLR-15342: Commit d

[jira] [Resolved] (SOLR-13431) Efficient updates with shared storage

2022-08-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-13431. - Resolution: Won't Fix > Efficient updates with shared storage > -

[jira] [Commented] (SOLR-15342) Separate out a SolrJ-Zookeeper module

2022-08-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585042#comment-17585042 ] ASF subversion and git services commented on SOLR-15342: Commit 8

[GitHub] [solr] dsmiley merged pull request #943: SOLR-15342: Separate out a SolrJ-Zookeeper module

2022-08-25 Thread GitBox
dsmiley merged PR #943: URL: https://github.com/apache/solr/pull/943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-16350) http response is delayed when solr is running in slow/restricted network environment

2022-08-25 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585028#comment-17585028 ] Gus Heck commented on SOLR-16350: - Maybe the tool you are using just interferes with all

[jira] [Assigned] (SOLR-16358) Can't create SOLR collection using V2 API

2022-08-25 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-16358: Assignee: Eric Pugh > Can't create SOLR collection using V2 API >

[GitHub] [solr] epugh commented on pull request #947: SOLR-16300: migrate assert to non deprecated version

2022-08-25 Thread GitBox
epugh commented on PR #947: URL: https://github.com/apache/solr/pull/947#issuecomment-1227689974 Thanks for approving the changes @uschindler! I'm waiting on @cpoerschke to finish her review, and the SolrJ-Zookeeper to get merged, and then I'll merge this one! -- This is an automated me

[jira] [Commented] (SOLR-16358) Can't create SOLR collection using V2 API

2022-08-25 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585004#comment-17585004 ] Eric Pugh commented on SOLR-16358: -- I suspect that this is a configuration issue A

[GitHub] [solr] HoustonPutman commented on pull request #984: SOLR-16340 Provide a cluster_id label for all metrics exposed by the Solr Prometheus Exporter

2022-08-25 Thread GitBox
HoustonPutman commented on PR #984: URL: https://github.com/apache/solr/pull/984#issuecomment-1227665586 @janhoy I added a PR that removed the use of the static variable, and also added zk_host and base_url labels to the scrapingErrors metric. Feel free to revert if you don't like it!

[GitHub] [solr] HoustonPutman commented on a diff in pull request #984: SOLR-16340 Provide a cluster_id label for all metrics exposed by the Solr Prometheus Exporter

2022-08-25 Thread GitBox
HoustonPutman commented on code in PR #984: URL: https://github.com/apache/solr/pull/984#discussion_r954295709 ## solr/prometheus-exporter/bin/solr-exporter.cmd: ## @@ -82,6 +82,7 @@ IF NOT "%SCRAPE_INTERVAL%"=="" set EXPORTER_ARGS=%EXPORTER_ARGS% -s %SCRAPE_INTE IF NOT "%NUM_

[jira] [Commented] (SOLR-16358) Can't create SOLR collection using V2 API

2022-08-25 Thread sagnik ray choudhury (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584986#comment-17584986 ] sagnik ray choudhury commented on SOLR-16358: - I see the same problem when us

[GitHub] [solr-operator] HoustonPutman commented on pull request #468: Release 0.6

2022-08-25 Thread GitBox
HoustonPutman commented on PR #468: URL: https://github.com/apache/solr-operator/pull/468#issuecomment-1227639766 @arnoldmashava could you fix the typo in your fork and make a PR against `main`? I think there was a mixup because this is trying to merge `release-0.6` (a divergent branch) int

[jira] [Updated] (SOLR-16358) Can't create SOLR collection using V2 API

2022-08-25 Thread sagnik ray choudhury (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sagnik ray choudhury updated SOLR-16358: Attachment: screenshot-1.png > Can't create SOLR collection using V2 API >

[GitHub] [solr] uschindler commented on pull request #947: SOLR-16300: migrate assert to non deprecated version

2022-08-25 Thread GitBox
uschindler commented on PR #947: URL: https://github.com/apache/solr/pull/947#issuecomment-1227484119 We can delay this to a separate PR. I also need try and error for this, because @dweiss implemented that Gradle code which picks the signatures files from that folder. -- This is an auto

[GitHub] [solr-operator] arnoldmashava opened a new pull request, #468: Release 0.6

2022-08-25 Thread GitBox
arnoldmashava opened a new pull request, #468: URL: https://github.com/apache/solr-operator/pull/468 Just a minor typographical correction in the descriptive title pertaining to one of the Helm Charts: A SolrCloud cluser running on Kubernetes via the Solr Operator. URL: https://artifacthub.

[GitHub] [solr] stillalex commented on pull request #985: SOLR-16357 CaffeineCache ramBytes incorrect accounting on updates and deletes

2022-08-25 Thread GitBox
stillalex commented on PR #985: URL: https://github.com/apache/solr/pull/985#issuecomment-1227460587 thanks @madrob! updated the changes file too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-25 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r954969780 ## solr/core/src/java/org/apache/solr/handler/configsets/ListConfigsetsResponse.java: ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [solr] madrob commented on pull request #985: SOLR-16357 CaffeineCache ramBytes incorrect accounting on updates and deletes

2022-08-25 Thread GitBox
madrob commented on PR #985: URL: https://github.com/apache/solr/pull/985#issuecomment-1227237388 This looks good to me, can you add an entry to CHANGES.txt (probably under 9.1 section) and then we'll be good to merge. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [solr] epugh commented on pull request #947: SOLR-16300: migrate assert to non deprecated version

2022-08-25 Thread GitBox
epugh commented on PR #947: URL: https://github.com/apache/solr/pull/947#issuecomment-1227220289 I gave it a stab of adding it to forbiddenapis, but didn't quite get it to work... There are *some* places that it's okay, like in the LTR module... May need a pairing session to grok this!

[jira] [Commented] (SOLR-16354) Migrate from Jaeger to OTEL tracing

2022-08-25 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584710#comment-17584710 ] Jan Høydahl commented on SOLR-16354: I think it is more feasable to do this stepwise