sonatype-lift[bot] commented on code in PR #753:
URL: https://github.com/apache/solr/pull/753#discussion_r914326117
##
solr/webapp/web/js/angular/controllers/schema.js:
##
@@ -289,6 +302,42 @@ solrAdminApp.controller('SchemaController',
}
});
ackepenek commented on PR #753:
URL: https://github.com/apache/solr/pull/753#issuecomment-1175665038
@epugh I fixed the PR as you mentioned. You can see new screenshots below:
--
This is an automated message from the Apache Git Service.
To respond to th
HoustonPutman commented on PR #453:
URL: https://github.com/apache/solr-operator/pull/453#issuecomment-1175419928
@johgoe if you have time, please take a look at this PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
HoustonPutman commented on issue #427:
URL: https://github.com/apache/solr-operator/issues/427#issuecomment-1175419265
Note, it looks like there is a difference between the `http` and `http2`
**appProtocol**. We will default to `http` now for unsecured services, but we
might want to look in
HoustonPutman opened a new pull request, #453:
URL: https://github.com/apache/solr-operator/pull/453
Resolves #427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
[
https://issues.apache.org/jira/browse/SOLR-16276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-16276.
--
Fix Version/s: 9.1
main (10.0)
Resolution: Fixed
> Review redundant local var
epugh merged PR #924:
URL: https://github.com/apache/solr/pull/924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
F
[
https://issues.apache.org/jira/browse/SOLR-16276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562794#comment-17562794
]
ASF subversion and git services commented on SOLR-16276:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-16276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562789#comment-17562789
]
ASF subversion and git services commented on SOLR-16276:
Commit e
HoustonPutman opened a new pull request, #452:
URL: https://github.com/apache/solr-operator/pull/452
Resolves #437
- Use old option to default new
`Spec.solrAddressability.external.ingressTLSTermination.tlsSecret`.
- Deprecate old
`Spec.solrAddressability.external.ingressTLSTermin
cpoerschke commented on code in PR #929:
URL: https://github.com/apache/solr/pull/929#discussion_r914001900
##
solr/core/src/test/org/apache/solr/schema/TestPointFields.java:
##
@@ -5289,9 +5289,9 @@ private void doTestSetQueries(String fieldName, String[]
values, boolean multi
risdenk commented on PR #585:
URL: https://github.com/apache/solr/pull/585#issuecomment-1175293623
Is there more to do here? I know @anshumg asked that Jetty 9.4.x upgrade be
superseded by this change. There have been a few more Jetty 9.4.x and 10.x
releases.
--
This is an automated mess
[
https://issues.apache.org/jira/browse/SOLR-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562759#comment-17562759
]
Uwe Schindler commented on SOLR-16221:
--
It looks like the Lucene Job passed. So cong
epugh commented on PR #924:
URL: https://github.com/apache/solr/pull/924#issuecomment-1175236948
running all the tests again, and tjhen will merge. Thanks @cpoerschke for
the efforts!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/SOLR-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562727#comment-17562727
]
Uwe Schindler commented on SOLR-16221:
--
Ok, one job is starting
> Solr Jenkins
[
https://issues.apache.org/jira/browse/SOLR-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562726#comment-17562726
]
Uwe Schindler commented on SOLR-16221:
--
Now all nodes are down, the label "lucene||s
cpoerschke commented on code in PR #924:
URL: https://github.com/apache/solr/pull/924#discussion_r913939802
##
solr/core/src/test/org/apache/solr/schema/TestCloudSchemaless.java:
##
@@ -63,7 +63,8 @@ protected String getCloudSolrConfig() {
@Override
public SortedMap getE
cpoerschke commented on code in PR #924:
URL: https://github.com/apache/solr/pull/924#discussion_r913914168
##
solr/core/src/test/org/apache/solr/update/PeerSyncWithIndexFingerprintCachingTest.java:
##
@@ -110,6 +110,6 @@ void assertSync(SolrClient client, int numVersions, boole
cpoerschke commented on code in PR #924:
URL: https://github.com/apache/solr/pull/924#discussion_r913913233
##
solr/core/src/test/org/apache/solr/update/PeerSyncWithBufferUpdatesTest.java:
##
@@ -227,6 +227,6 @@ void assertSync(SolrClient client, int numVersions, boolean
expect
cpoerschke commented on code in PR #924:
URL: https://github.com/apache/solr/pull/924#discussion_r913912286
##
solr/core/src/test/org/apache/solr/update/MaxSizeAutoCommitTest.java:
##
@@ -204,46 +201,44 @@ public void testDeletes() throws Exception {
updateHandler,
epugh commented on code in PR #932:
URL: https://github.com/apache/solr/pull/932#discussion_r913892056
##
solr/core/src/test/org/apache/solr/handler/admin/V2ApiMappingTest.java:
##
@@ -204,11 +204,12 @@ public String getHttpMethod() {
return queryRequestCaptor.getValue().ge
epugh commented on code in PR #932:
URL: https://github.com/apache/solr/pull/932#discussion_r913890551
##
solr/core/src/java/org/apache/solr/handler/BlobHandler.java:
##
@@ -22,6 +22,7 @@
import static org.apache.solr.common.params.CommonParams.SORT;
import static org.apache.s
epugh commented on code in PR #932:
URL: https://github.com/apache/solr/pull/932#discussion_r913888965
##
solr/core/src/java/org/apache/solr/api/ApiBag.java:
##
@@ -58,6 +35,18 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.io.IOException;
+import j
epugh commented on code in PR #932:
URL: https://github.com/apache/solr/pull/932#discussion_r913888507
##
solr/core/src/java/org/apache/solr/api/ApiBag.java:
##
@@ -17,37 +17,14 @@
package org.apache.solr.api;
-import static org.apache.solr.client.solrj.SolrRequest.SUPPORTE
gerlowskija opened a new pull request, #932:
URL: https://github.com/apache/solr/pull/932
# Description
Solr is in the process of moving away from 'apispec' defined v2 APIs, and
towards annotated-based APIs. Only a few apispec files remain.
# Solution
This commit remov
HoustonPutman merged PR #449:
URL: https://github.com/apache/solr-operator/pull/449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
HoustonPutman closed issue #443: Upgrade the Zookeeper Operator dependency to
0.2.14
URL: https://github.com/apache/solr-operator/issues/443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
epugh commented on PR #924:
URL: https://github.com/apache/solr/pull/924#issuecomment-1175010725
Thanks @cpoerschke for the reivew, I think you are most of the way but not
all the way through right??? I *think* I've respnded toall of your feedback
items.
--
This is an automated message
epugh commented on code in PR #924:
URL: https://github.com/apache/solr/pull/924#discussion_r913746653
##
solr/core/src/test/org/apache/solr/update/processor/UUIDUpdateProcessorFallbackTest.java:
##
@@ -155,17 +155,17 @@ SolrInputDocument doc(SolrInputField... fields) {
}
epugh commented on code in PR #924:
URL: https://github.com/apache/solr/pull/924#discussion_r913729702
##
solr/core/src/test/org/apache/solr/update/processor/UUIDUpdateProcessorFallbackTest.java:
##
@@ -155,17 +155,17 @@ SolrInputDocument doc(SolrInputField... fields) {
}
epugh commented on code in PR #924:
URL: https://github.com/apache/solr/pull/924#discussion_r913714990
##
solr/core/src/test/org/apache/solr/handler/component/StatsComponentTest.java:
##
@@ -1248,17 +1248,16 @@ public void testMiscQueryStats() throws Exception {
// force
epugh commented on code in PR #924:
URL: https://github.com/apache/solr/pull/924#discussion_r913712611
##
solr/core/src/test/org/apache/solr/schema/TestCloudSchemaless.java:
##
@@ -63,7 +63,8 @@ protected String getCloudSolrConfig() {
@Override
public SortedMap getExtraS
epugh commented on code in PR #924:
URL: https://github.com/apache/solr/pull/924#discussion_r913697233
##
solr/core/src/test/org/apache/solr/cloud/PeerSyncReplicationTest.java:
##
@@ -289,15 +288,13 @@ private CloudJettyRunner
forceNodeFailureAndDoPeerSync(boolean disableFinger
[
https://issues.apache.org/jira/browse/SOLR-16275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562610#comment-17562610
]
Eric Pugh commented on SOLR-16275:
--
I made the change globablly where it makes sense.
epugh merged PR #930:
URL: https://github.com/apache/solr/pull/930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
F
cpoerschke commented on code in PR #924:
URL: https://github.com/apache/solr/pull/924#discussion_r913655672
##
solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java:
##
@@ -87,6 +87,7 @@
public class TestReplicationHandler extends SolrTestCaseJ4 {
private
[
https://issues.apache.org/jira/browse/SOLR-16275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562602#comment-17562602
]
Eric Pugh commented on SOLR-16275:
--
Thanks for your comment [~mdrob] Should I co
[
https://issues.apache.org/jira/browse/SOLR-16281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-16281.
--
Fix Version/s: 9.1
main (10.0)
Resolution: Fixed
> Review boxing/unboxing opp
[
https://issues.apache.org/jira/browse/SOLR-16281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562601#comment-17562601
]
ASF subversion and git services commented on SOLR-16281:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-16281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562600#comment-17562600
]
ASF subversion and git services commented on SOLR-16281:
Commit 4
markrmiller merged PR #25:
URL: https://github.com/apache/solr-sandbox/pull/25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.a
ijioio opened a new pull request, #931:
URL: https://github.com/apache/solr/pull/931
https://issues.apache.org/jira/browse/SOLR-16282
# Description
At the moment implementing custom actions for `CoreAdminHandler` implies
subsclassing of the `CoreAdminHandler` and overridng `han
[
https://issues.apache.org/jira/browse/SOLR-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562400#comment-17562400
]
Nayana Thorat edited comment on SOLR-16221 at 7/5/22 7:05 AM:
-
[
https://issues.apache.org/jira/browse/SOLR-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562400#comment-17562400
]
Nayana Thorat commented on SOLR-16221:
--
[~uschindler] For s390x nodes, puppet is not
45 matches
Mail list logo
