epugh commented on code in PR #924:
URL: https://github.com/apache/solr/pull/924#discussion_r913746653
##########
solr/core/src/test/org/apache/solr/update/processor/UUIDUpdateProcessorFallbackTest.java:
##########
@@ -155,17 +155,17 @@ SolrInputDocument doc(SolrInputField... fields) {
}
/** Convenience method for building up SolrInputFields */
- SolrInputField field(String name, float boost, Object... values) {
+ SolrInputField field(String name, Object... values) {
SolrInputField f = new SolrInputField(name);
for (Object v : values) {
f.addValue(v);
}
return f;
}
- /** Convenience method for building up SolrInputFields with default boost */
+ /** Convenience method for building up SolrInputFields */
SolrInputField f(String name, Object... values) {
- return field(name, 1.0F, values);
+ return field(name, values);
}
Review Comment:
So, I removed the `field` method since `f` is used everywhere....
I suspect that this pattern is spread across lots of tests, and it seems
like moving some methods into some unit testing helpers might be good...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
