[jira] [Commented] (SOLR-16129) Solr specific InputStreamResponseListener to prevent client threads from hanging forever

2022-03-30 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515068#comment-17515068 ] Ishan Chattopadhyaya commented on SOLR-16129: - Awesome, I'll test this ASAP!

[GitHub] [solr] CaoManhDat commented on pull request #779: SOLR-16127 Ordered Executor orphans locks

2022-03-30 Thread GitBox
CaoManhDat commented on pull request #779: URL: https://github.com/apache/solr/pull/779#issuecomment-1083993308 Looks good to me as well. It is always better to make utility classes safer and reliable. -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Commented] (SOLR-16129) Solr specific InputStreamResponseListener to prevent client threads from hanging forever

2022-03-30 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515005#comment-17515005 ] Chris M. Hostetter commented on SOLR-16129: --- I should mention: Even if the bug

[jira] [Commented] (SOLR-16099) HTTP Client threads can hang in Jetty's InputStreamResponseListener when using HTTP2 - impacts intra-node communication

2022-03-30 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515004#comment-17515004 ] Chris M. Hostetter commented on SOLR-16099: --- bq. One thing we may want to consi

[jira] [Updated] (SOLR-16129) Solr specific InputStreamResponseListener to prevent client threads from hanging forever

2022-03-30 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-16129: -- Attachment: SOLR-16129.patch Status: Open (was: Open) The attached patch imple

[jira] [Created] (SOLR-16129) Solr specific InputStreamResponseListener to prevent client threads from hanging forever

2022-03-30 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-16129: - Summary: Solr specific InputStreamResponseListener to prevent client threads from hanging forever Key: SOLR-16129 URL: https://issues.apache.org/jira/browse/SOLR-16129

[GitHub] [solr] janhoy commented on pull request #769: SOLR-15898 Upgrade-notes and major-changes for 9.0

2022-03-30 Thread GitBox
janhoy commented on pull request #769: URL: https://github.com/apache/solr/pull/769#issuecomment-1083854152 I think I'm done with the "Upgrade Prerequisites" and "Rolling Upgrades" chapters. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [solr] janhoy commented on a change in pull request #769: SOLR-15898 Upgrade-notes and major-changes for 9.0

2022-03-30 Thread GitBox
janhoy commented on a change in pull request #769: URL: https://github.com/apache/solr/pull/769#discussion_r839068571 ## File path: solr/solr-ref-guide/modules/deployment-guide/pages/authentication-and-authorization-plugins.adoc ## @@ -207,12 +207,13 @@ Solr has a built-in `PK

[jira] [Created] (SOLR-16128) Rename prometheus key solr_metrics_core_replication_master as solr_metrics_core_replication_leader

2022-03-30 Thread Jira
Jan Høydahl created SOLR-16128: -- Summary: Rename prometheus key solr_metrics_core_replication_master as solr_metrics_core_replication_leader Key: SOLR-16128 URL: https://issues.apache.org/jira/browse/SOLR-16128

[GitHub] [solr] janhoy opened a new pull request #780: Add git pull for the 'gradlew documentation' todo

2022-03-30 Thread GitBox
janhoy opened a new pull request #780: URL: https://github.com/apache/solr/pull/780 This is the first test done before building the release artifacts from release branch, so it should make sure the local branch is up to date with remote. Discovered during 9.0 release. Tested locally

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-03-30 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r838951458 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -118,10 +122,22 @@ private final int queryResultMaxDocsCached; priv

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-03-30 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r838950285 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -935,22 +956,96 @@ private DocSet getAndCacheDocSet(Query query) throws

[jira] [Updated] (SOLR-16127) OrderedExecutor can orphan permits and leak locks

2022-03-30 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-16127: - Status: Patch Available (was: Open) > OrderedExecutor can orphan permits and leak locks > --

[GitHub] [solr] madrob commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-03-30 Thread GitBox
madrob commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r838897149 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -935,22 +956,96 @@ private DocSet getAndCacheDocSet(Query query) throws IO

[GitHub] [solr] madrob commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-03-30 Thread GitBox
madrob commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r838891491 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -118,10 +122,22 @@ private final int queryResultMaxDocsCached; privat

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-03-30 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r838873317 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -118,10 +122,22 @@ private final int queryResultMaxDocsCached; priv

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-03-30 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r838856353 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -118,10 +122,22 @@ private final int queryResultMaxDocsCached; priv

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-03-30 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r838851191 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -935,22 +956,96 @@ private DocSet getAndCacheDocSet(Query query) throws

[jira] [Resolved] (SOLR-15045) 2x latency of synchronous commits due to serial execution on local and distributed leaders

2022-03-30 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney resolved SOLR-15045. --- Fix Version/s: 9.1 (was: main (10.0)) Resolution: Fixed > 2x la

[GitHub] [solr] madrob commented on pull request #779: SOLR-16127 Ordered Executor orphans locks

2022-03-30 Thread GitBox
madrob commented on pull request #779: URL: https://github.com/apache/solr/pull/779#issuecomment-1083447511 If fails because I explicitly check for a leaked thread. But it's not leaked by the delegate executor, it's just a thread that never finished executing because it never gets submitte

[GitHub] [solr] HoustonPutman commented on pull request #776: Attempt to fix various testing thread leaks

2022-03-30 Thread GitBox
HoustonPutman commented on pull request #776: URL: https://github.com/apache/solr/pull/776#issuecomment-1083445507 The failing tests are threads leaking in `TestCancellableCollector` and `OrderedExecutorTest`. I can't reproduce the failures locally, but it seems like a harmless addi

[jira] [Commented] (SOLR-16127) OrderedExecutor can orphan permits and leak locks

2022-03-30 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514868#comment-17514868 ] Mike Drob commented on SOLR-16127: -- cc: [~caomanhdat] what was the original intent of th

[GitHub] [solr] HoustonPutman commented on pull request #779: SOLR-16127 Ordered Executor orphans locks

2022-03-30 Thread GitBox
HoustonPutman commented on pull request #779: URL: https://github.com/apache/solr/pull/779#issuecomment-1083442162 Does the test fail or does it have leaking threads? My fixes wouldn't fix anything other than leaking threads -- This is an automated message from the Apache Git Service. To

[GitHub] [solr] madrob opened a new pull request #779: SOLR-16127 Ordered Executor orphans locks

2022-03-30 Thread GitBox
madrob opened a new pull request #779: URL: https://github.com/apache/solr/pull/779 https://issues.apache.org/jira/browse/SOLR-16127 I'm not sure if the changes in #776 will fix this or not, but this is a test that fails with the current code. -- This is an automated message from

[jira] [Commented] (SOLR-15045) 2x latency of synchronous commits due to serial execution on local and distributed leaders

2022-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514860#comment-17514860 ] ASF subversion and git services commented on SOLR-15045: Commit c

[jira] [Created] (SOLR-16127) OrderedExecutor can orphan permits and leak locks

2022-03-30 Thread Mike Drob (Jira)
Mike Drob created SOLR-16127: Summary: OrderedExecutor can orphan permits and leak locks Key: SOLR-16127 URL: https://issues.apache.org/jira/browse/SOLR-16127 Project: Solr Issue Type: Bug

[GitHub] [solr] dsmiley commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-03-30 Thread GitBox
dsmiley commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r838794953 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -118,10 +122,22 @@ private final int queryResultMaxDocsCached; priva

[GitHub] [solr] dsmiley commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-03-30 Thread GitBox
dsmiley commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r838791801 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -935,22 +956,96 @@ private DocSet getAndCacheDocSet(Query query) throws I

[GitHub] [solr] cpoerschke commented on a change in pull request #767: SOLR-16120: optimise hl.fl expansion

2022-03-30 Thread GitBox
cpoerschke commented on a change in pull request #767: URL: https://github.com/apache/solr/pull/767#discussion_r838787803 ## File path: solr/core/src/java/org/apache/solr/highlight/SolrHighlighter.java ## @@ -88,32 +88,28 @@ protected boolean emptyArray(String[] arr) { }

[GitHub] [solr] cpoerschke opened a new pull request #778: Forbid 'String.matches(String)' API.

2022-03-30 Thread GitBox
cpoerschke opened a new pull request #778: URL: https://github.com/apache/solr/pull/778 In favour of reusable compiled patterns. No JIRA issue as yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (SOLR-15045) 2x latency of synchronous commits due to serial execution on local and distributed leaders

2022-03-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514825#comment-17514825 ] David Smiley commented on SOLR-15045: - No; go for it! > 2x latency of synchronous co

[GitHub] [solr] magibney commented on pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-03-30 Thread GitBox
magibney commented on pull request #592: URL: https://github.com/apache/solr/pull/592#issuecomment-1083391036 I'm hoping to commit this this week. I did want first to specifically call out that _after_ @dsmiley's PR approval, there were changes to the way the liveDocs DocSet is cache

[GitHub] [solr] magibney opened a new pull request #777: SOLR-16126: Allow FiltersQParser (`{!filters param=[...]}`) to tolerate empty `param` args

2022-03-30 Thread GitBox
magibney opened a new pull request #777: URL: https://github.com/apache/solr/pull/777 See: [SOLR-16126](https://issues.apache.org/jira/browse/SOLR-16126) in practice `{!filters}` qparser is convenient to use, e.g., to bundle `fq` params together. If there are no `fq` clauses, why wou

[jira] [Created] (SOLR-16126) Allow FiltersQParser (`{!filters param=[...]}`) to tolerate empty `param` args

2022-03-30 Thread Michael Gibney (Jira)
Michael Gibney created SOLR-16126: - Summary: Allow FiltersQParser (`{!filters param=[...]}`) to tolerate empty `param` args Key: SOLR-16126 URL: https://issues.apache.org/jira/browse/SOLR-16126 Projec

[GitHub] [solr] HoustonPutman opened a new pull request #776: Attempt to fix various testing thread leaks

2022-03-30 Thread GitBox
HoustonPutman opened a new pull request #776: URL: https://github.com/apache/solr/pull/776 Will create a JIRA if people think it's worth it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] (SOLR-15072) Support building and testing Solr on ARM64 architecture

2022-03-30 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15072 ] Houston Putman deleted comment on SOLR-15072: --- was (Author: JIRAUSER287318): My greetings, Right here is the file that you should view down below. I hope that you will find it beneficial!

[jira] [Commented] (SOLR-15072) Support building and testing Solr on ARM64 architecture

2022-03-30 Thread Islem (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514783#comment-17514783 ] Islem commented on SOLR-15072: -- My greetings, Right here is the file that you should view d

[jira] [Commented] (SOLR-16097) Batch updates when creating test indices

2022-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514751#comment-17514751 ] ASF subversion and git services commented on SOLR-16097: Commit b

[GitHub] [solr] madrob merged pull request #744: SOLR-16097 Batch add docs when starting tests

2022-03-30 Thread GitBox
madrob merged pull request #744: URL: https://github.com/apache/solr/pull/744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[jira] [Updated] (SOLR-10837) JSON facetting to support Mean reciprocal rank

2022-03-30 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-10837: - Fix Version/s: (was: 9.0) (was: 8.1) > JSON facetting to support Mean reciproc

[jira] [Resolved] (SOLR-10697) Improve defaults for maxConnectionsPerHost

2022-03-30 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-10697. -- Resolution: Fixed > Improve defaults for maxConnectionsPerHost > --

[jira] [Updated] (SOLR-16125) Tutorial commands should be copiable

2022-03-30 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-16125: - Priority: Minor (was: Major) > Tutorial commands should be copiable > --

[jira] [Resolved] (SOLR-16125) Tutorial commands should be copiable

2022-03-30 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-16125. -- Fix Version/s: 9.0 Assignee: Mike Drob Resolution: Fixed > Tutorial commands should be

[jira] [Commented] (SOLR-16125) Tutorial commands should be copiable

2022-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514728#comment-17514728 ] ASF subversion and git services commented on SOLR-16125: Commit 6

[jira] [Resolved] (SOLR-16120) optimise glob-free hl.fl expansion

2022-03-30 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-16120. Fix Version/s: 9.1 main (10.0) Resolution: Fixed * glob-f

[GitHub] [solr] cpoerschke commented on a change in pull request #757: SOLR-16111: hl.queryFieldPattern support (advanced alternative to hl.requireFieldMatch)

2022-03-30 Thread GitBox
cpoerschke commented on a change in pull request #757: URL: https://github.com/apache/solr/pull/757#discussion_r838478595 ## File path: solr/solr-ref-guide/modules/query-guide/pages/highlighting.adoc ## @@ -116,6 +116,17 @@ If set to `true`, only query terms aligning with the f

[GitHub] [solr] cpoerschke commented on a change in pull request #757: SOLR-16111: hl.queryFieldPattern support (advanced alternative to hl.requireFieldMatch)

2022-03-30 Thread GitBox
cpoerschke commented on a change in pull request #757: URL: https://github.com/apache/solr/pull/757#discussion_r838479132 ## File path: solr/core/src/java/org/apache/solr/search/SolrDocumentFetcher.java ## @@ -219,6 +221,28 @@ public boolean isLazyFieldLoadingEnabled() { }

[GitHub] [solr] cpoerschke commented on a change in pull request #757: SOLR-16111: hl.queryFieldPattern support (advanced alternative to hl.requireFieldMatch)

2022-03-30 Thread GitBox
cpoerschke commented on a change in pull request #757: URL: https://github.com/apache/solr/pull/757#discussion_r838479555 ## File path: solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java ## @@ -431,14 +435,27 @@ protected Locale parseLocale(String languag

[jira] (SOLR-14397) Vector Search in Solr

2022-03-30 Thread Steven Chou (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14397 ] Steven Chou deleted comment on SOLR-14397: was (Author: sing10407): I would like to propose an new approach: 1. Leverage [SuperBit|https://github.com/tdebatty/java-LSH] hash to de-dimension

[jira] [Commented] (SOLR-16120) optimise glob-free hl.fl expansion

2022-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514567#comment-17514567 ] ASF subversion and git services commented on SOLR-16120: Commit 5

[jira] [Commented] (SOLR-16120) optimise glob-free hl.fl expansion

2022-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514561#comment-17514561 ] ASF subversion and git services commented on SOLR-16120: Commit 2

[GitHub] [solr] cpoerschke merged pull request #767: SOLR-16120: optimise hl.fl expansion

2022-03-30 Thread GitBox
cpoerschke merged pull request #767: URL: https://github.com/apache/solr/pull/767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (SOLR-16110) Using Schema/Config API breaks the File-Upload of Config Set File

2022-03-30 Thread Steffen Moldenhauer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514497#comment-17514497 ] Steffen Moldenhauer commented on SOLR-16110: [~epugh] I created the PR with t