dsmiley commented on a change in pull request #592:
URL: https://github.com/apache/solr/pull/592#discussion_r838794953
##########
File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java
##########
@@ -118,10 +122,22 @@
private final int queryResultMaxDocsCached;
private final boolean useFilterForSortedQuery;
+ /** Special-case cache to handle the lazy-init of {@link #liveDocs}. */
+ @SuppressWarnings({"unchecked", "rawtypes"})
+ private final CompletableFuture<BitDocSet>[] liveDocsCache = new
CompletableFuture[1];
Review comment:
I would declare it to be simply Future and not specifically
CompletableFuture as it's an implementation detail that can be local to the
only method that uses it.
BTW is any of that SuppressWarnings actually appropriate here? I don't see
either occuring. There was a big effort to scrub the codebase of needless
suppressions and also declaring things better so that we needn't have a warning
in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
