[jira] [Commented] (SOLR-16061) Decouple CloudSolrClient from ZkStateReader

2022-03-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505928#comment-17505928 ] Jan Høydahl commented on SOLR-16061: Thanks for taking it the last mile. Looks solid

[jira] [Commented] (SOLR-16096) Expose createNodeSet parameter in the Create Collection UI

2022-03-13 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505909#comment-17505909 ] Eric Pugh commented on SOLR-16096: -- This I think is ready for review! > Expose createNo

[GitHub] [solr] epugh commented on pull request #745: SOLR-16096: Add createNodeSet to Advanced Collection Creation Options

2022-03-13 Thread GitBox
epugh commented on pull request #745: URL: https://github.com/apache/solr/pull/745#issuecomment-1066175533 Also, I'd love help on how to exclude the css file from being validated? ``` > Task :solr:webapp:validateSourcePatterns FAILED @author javadoc tag: /Users/epugh/Documents/

[GitHub] [solr] epugh commented on pull request #745: SOLR-16096: Add createNodeSet to Advanced Collection Creation Options

2022-03-13 Thread GitBox
epugh commented on pull request #745: URL: https://github.com/apache/solr/pull/745#issuecomment-1066175351 I noticed the the file `/solr/webapp/build.gradle` excludes some Angular files, however I didn't follow the pattern and add the `selectize.js` or `angular-selectize.js` files to the l

[GitHub] [solr] epugh opened a new pull request #745: SOLR-16096: Add createNodeSet to Advanced Collection Creation Options

2022-03-13 Thread GitBox
epugh opened a new pull request #745: URL: https://github.com/apache/solr/pull/745 https://issues.apache.org/jira/browse/SOLR-16096 # Description The `createNodeSet` parameter is hidden from the admin gui, and we need it for a project ;-). # Solution I dither

[jira] [Updated] (SOLR-16096) Expose createNodeSet parameter in the Create Collection UI

2022-03-13 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16096: - Attachment: screenshot-2.png > Expose createNodeSet parameter in the Create Collection UI > -

[jira] [Commented] (SOLR-16096) Expose createNodeSet parameter in the Create Collection UI

2022-03-13 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505907#comment-17505907 ] Eric Pugh commented on SOLR-16096: -- !screenshot-2.png! I couldn't figure out the CSS

[GitHub] [solr] janhoy commented on a change in pull request #708: SOLR-16061: CloudSolrClient changes, hide ZooKeeper

2022-03-13 Thread GitBox
janhoy commented on a change in pull request #708: URL: https://github.com/apache/solr/pull/708#discussion_r825473708 ## File path: solr/CHANGES.txt ## @@ -639,6 +639,8 @@ and each individual module's jar will be included in its directory's lib/ folder * SOLR-15223: Depreca

[jira] [Commented] (SOLR-15223) Deprecate HttpSolrClient and friends in 9.0

2022-03-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505449#comment-17505449 ] David Smiley commented on SOLR-15223: - Now that I'm "seeing" the results of this in m