epugh opened a new pull request #745: URL: https://github.com/apache/solr/pull/745
https://issues.apache.org/jira/browse/SOLR-16096 # Description The `createNodeSet` parameter is hidden from the admin gui, and we need it for a project ;-). # Solution I dithered about adding the magic `EMPTY` value or the related `createNodeSet.shuffle` parameter, but didn't need it for my specific itch. I introduced the selectize.js library as it supports multiple select... A thought for the future would be to remove the use of the chosen.js library? One thing I don't love is that I duplicated the lookup of the available `nodeSets` but couldn't quite figure out how to extract it as a proper function, would love a suggestion ;-) I'd like to back port this to the 8.11 line.... # Tests Manual testing. # Checklist Please review the following and check all that apply: - [X ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ X] I have created a Jira issue and added the issue ID to my pull request title. - [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ X] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
