[jira] [Resolved] (SOLR-15985) Update mock-oauth test server version

2022-02-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-15985. Resolution: Duplicate > Update mock-oauth test server version > ---

[GitHub] [solr] janhoy commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

2022-02-07 Thread GitBox
janhoy commented on a change in pull request #606: URL: https://github.com/apache/solr/pull/606#discussion_r801343173 ## File path: solr/modules/jwt-auth/build.gradle ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[jira] [Commented] (SOLR-15984) Ensure all used dependencies are declared

2022-02-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488618#comment-17488618 ] Dawid Weiss commented on SOLR-15984: Also, check shouldn't pass when you add a new tr

[jira] [Commented] (SOLR-15984) Ensure all used dependencies are declared

2022-02-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488613#comment-17488613 ] Dawid Weiss commented on SOLR-15984: All these transitive dependencies are present in

[GitHub] [solr] madrob commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

2022-02-07 Thread GitBox
madrob commented on a change in pull request #606: URL: https://github.com/apache/solr/pull/606#discussion_r801249798 ## File path: solr/licenses/bcutil-LICENSE-MIT.txt ## @@ -0,0 +1,15 @@ +Copyright (c) 2000-2010 The Legion Of The Bouncy Castle (http://www.bouncycastle.org)

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-07 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r799881581 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -866,8 +876,48 @@ public BitDocSet getLiveDocSet() throws IOException {

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-07 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r801241165 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -866,8 +876,48 @@ public BitDocSet getLiveDocSet() throws IOException {

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-07 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r801240516 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -2281,6 +2455,11 @@ public void initializeMetrics(SolrMetricsContext par

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-07 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r801238955 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -865,9 +929,31 @@ public BitDocSet getLiveDocSet() throws IOException {

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-07 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r801238310 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -1299,6 +1385,47 @@ public DocList getDocList(Query query, List filterLi

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-07 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r801237620 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -854,8 +868,58 @@ private DocSet getAndCacheDocSet(Query query) throws I

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

2022-02-07 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #606: URL: https://github.com/apache/solr/pull/606#discussion_r801215314 ## File path: solr/modules/jwt-auth/build.gradle ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [solr] madrob closed pull request #603: SOLR-15985 update mock-oauth-server version

2022-02-07 Thread GitBox
madrob closed pull request #603: URL: https://github.com/apache/solr/pull/603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] janhoy commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

2022-02-07 Thread GitBox
janhoy commented on a change in pull request #606: URL: https://github.com/apache/solr/pull/606#discussion_r801208411 ## File path: solr/core/src/java/org/apache/solr/security/AuthenticationPlugin.java ## @@ -95,11 +95,11 @@ public final boolean authenticate(HttpServletRequest

[GitHub] [solr] janhoy commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

2022-02-07 Thread GitBox
janhoy commented on a change in pull request #606: URL: https://github.com/apache/solr/pull/606#discussion_r801207711 ## File path: solr/core/build.gradle ## @@ -39,6 +39,9 @@ dependencies { api "org.apache.lucene:lucene-analysis-common" api "org.apache.lucene:lucene-quer

[jira] [Commented] (SOLR-15907) Move JWT auth plugin to contrib

2022-02-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488543#comment-17488543 ] Jan Høydahl commented on SOLR-15907: New [PR#606|https://github.com/apache/solr/pull/

[GitHub] [solr] janhoy commented on pull request #603: SOLR-15985 update mock-oauth-server version

2022-02-07 Thread GitBox
janhoy commented on pull request #603: URL: https://github.com/apache/solr/pull/603#issuecomment-1032131323 See #606 and [SOLR-15907](https://issues.apache.org/jira/browse/SOLR-15907), where JWTAuthPlugin is moved to a module. I ported over the other changes from this PR to that one, and

[GitHub] [solr] janhoy commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

2022-02-07 Thread GitBox
janhoy commented on a change in pull request #606: URL: https://github.com/apache/solr/pull/606#discussion_r801204596 ## File path: solr/modules/jwt-auth/README.md ## @@ -0,0 +1,25 @@ +Apache Solr JWT Authentication Plugin += + +Introduction

[GitHub] [solr] janhoy commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

2022-02-07 Thread GitBox
janhoy commented on a change in pull request #606: URL: https://github.com/apache/solr/pull/606#discussion_r801204477 ## File path: gradle/documentation/render-javadoc.gradle ## @@ -118,6 +118,15 @@ configure(project(":solr:modules:analysis-extras")) { } } +configure(proj

[GitHub] [solr] madrob commented on a change in pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

2022-02-07 Thread GitBox
madrob commented on a change in pull request #606: URL: https://github.com/apache/solr/pull/606#discussion_r801196551 ## File path: versions.lock ## @@ -175,9 +175,10 @@ org.apache.zookeeper:zookeeper-jute:3.7.0 (1 constraints: 8a0d3a28) org.apiguardian:apiguardian-api:1.1.0

[GitHub] [solr] janhoy closed pull request #518: SOLR-15907 Move JWT auth plugin to contrib

2022-02-07 Thread GitBox
janhoy closed pull request #518: URL: https://github.com/apache/solr/pull/518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] janhoy commented on pull request #518: SOLR-15907 Move JWT auth plugin to contrib

2022-02-07 Thread GitBox
janhoy commented on pull request #518: URL: https://github.com/apache/solr/pull/518#issuecomment-1032107261 Closing, please see #606 instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [solr] janhoy opened a new pull request #606: SOLR-15907 JWTAuthPlugin move to module, new package

2022-02-07 Thread GitBox
janhoy opened a new pull request #606: URL: https://github.com/apache/solr/pull/606 https://issues.apache.org/jira/browse/SOLR-15907 This is a rework of #518 with these improvemnts * Contrib -> module * New package name `org.apache.solr.security.jwt` * Separate commit for mov

[jira] [Commented] (SOLR-15587) Replicas end up with base_url as http on client side even if cluster state says https when using the HttpClusterStateProvider

2022-02-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488512#comment-17488512 ] ASF subversion and git services commented on SOLR-15587: Commit 9

[jira] [Resolved] (SOLR-15587) Replicas end up with base_url as http on client side even if cluster state says https when using the HttpClusterStateProvider

2022-02-07 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter resolved SOLR-15587. --- Resolution: Fixed > Replicas end up with base_url as http on client side even if cluster stat

[jira] [Commented] (SOLR-15959) Deprecate loading of solr.xml from ZK

2022-02-07 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488479#comment-17488479 ] Chris M. Hostetter commented on SOLR-15959: --- I don't really remember having str

[GitHub] [solr] risdenk commented on a change in pull request #604: SOLR-15984: Ensure all used dependencies are declared

2022-02-07 Thread GitBox
risdenk commented on a change in pull request #604: URL: https://github.com/apache/solr/pull/604#discussion_r801113230 ## File path: solr/modules/gcs-repository/build.gradle ## @@ -55,6 +59,9 @@ dependencies { implementation('io.opencensus:opencensus-api') { transitive = f

[jira] [Commented] (SOLR-15949) Use Java 17 in docker

2022-02-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488456#comment-17488456 ] David Smiley commented on SOLR-15949: - +1 to eclipse-temurin:17-jre. > Use Java 17 i

[GitHub] [solr] risdenk commented on a change in pull request #604: SOLR-15984: Ensure all used dependencies are declared

2022-02-07 Thread GitBox
risdenk commented on a change in pull request #604: URL: https://github.com/apache/solr/pull/604#discussion_r801114199 ## File path: solr/modules/analysis-extras/build.gradle ## @@ -15,25 +15,33 @@ * limitations under the License. */ - apply plugin: 'java-library' des

[jira] [Resolved] (SOLR-13138) Remove deprecated code prior to 9.0

2022-02-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-13138. - Resolution: Fixed Marking resolved.  If someone wishes to file more PRs – go for it!  I may.  No

[GitHub] [solr] risdenk commented on a change in pull request #604: SOLR-15984: Ensure all used dependencies are declared

2022-02-07 Thread GitBox
risdenk commented on a change in pull request #604: URL: https://github.com/apache/solr/pull/604#discussion_r801113230 ## File path: solr/modules/gcs-repository/build.gradle ## @@ -55,6 +59,9 @@ dependencies { implementation('io.opencensus:opencensus-api') { transitive = f

[GitHub] [solr] dsmiley commented on a change in pull request #604: SOLR-15984: Ensure all used dependencies are declared

2022-02-07 Thread GitBox
dsmiley commented on a change in pull request #604: URL: https://github.com/apache/solr/pull/604#discussion_r801090172 ## File path: solr/modules/gcs-repository/build.gradle ## @@ -55,6 +59,9 @@ dependencies { implementation('io.opencensus:opencensus-api') { transitive = f

[jira] [Commented] (SOLR-15984) Ensure all used dependencies are declared

2022-02-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488453#comment-17488453 ] David Smiley commented on SOLR-15984: - I suppose this will help but only for direct d

[GitHub] [solr] HoustonPutman opened a new pull request #605: 15556: Migrate the Ref Guide to use Antora

2022-02-07 Thread GitBox
HoustonPutman opened a new pull request #605: URL: https://github.com/apache/solr/pull/605 https://issues.apache.org/jira/browse/15556 Really I think the only thing we need to do for this is: - [ ] Figure out where the `src/old-pages` go - [ ] Create landing pages that don't

[jira] [Updated] (SOLR-13685) Update the leader term in ZK on the condition that the replica is still the leader

2022-02-07 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-13685: - Fix Version/s: (was: 8.3) > Update the leader term in ZK on the condition that the replica is still t

[jira] [Commented] (SOLR-13989) Move all hadoop related code to a contrib module

2022-02-07 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488394#comment-17488394 ] Mike Drob commented on SOLR-13989: -- Is this a duplicate of SOLR-14660, or is the intent

[jira] [Commented] (SOLR-14290) Fix NPE in SolrTestCaseJ4 breaking external usage for master/9.x

2022-02-07 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488384#comment-17488384 ] Mike Drob commented on SOLR-14290: -- Hoss even documented way back in SOLR-4853 that SOUR

[jira] [Commented] (SOLR-14290) Fix NPE in SolrTestCaseJ4 breaking external usage for master/9.x

2022-02-07 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488382#comment-17488382 ] Mike Drob commented on SOLR-14290: -- I'm fine with adding the null check to SolrTestCaseJ

[GitHub] [solr] janhoy commented on a change in pull request #596: SOLR-15557 Script to generate refguide page .htaccess redirects

2022-02-07 Thread GitBox
janhoy commented on a change in pull request #596: URL: https://github.com/apache/solr/pull/596#discussion_r800984488 ## File path: dev-tools/scripts/refguide/gen-refguide-redirects.py ## @@ -0,0 +1,134 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +# Licensed to the Apac

[jira] [Commented] (SOLR-15983) ClassCastException in UpdateLog$LogReplayer.doReplay

2022-02-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488380#comment-17488380 ] David Smiley commented on SOLR-15983: - Hmm; you're right; I'm not sure.  Looks like a

[jira] [Resolved] (SOLR-15964) Transient cores should not be unloaded/evicted while it's being used

2022-02-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15964. - Fix Version/s: 9.1 Resolution: Fixed > Transient cores should not be unloaded/evicted whil

[jira] [Commented] (SOLR-15985) Update mock-oauth test server version

2022-02-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488366#comment-17488366 ] Jan Høydahl commented on SOLR-15985: Such test dependencies should not need LICENSE f

[jira] [Resolved] (SOLR-12901) Make UnifiedHighlighter the default

2022-02-07 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-12901. -- Resolution: Fixed Looks like there was a later commit that addressed this failure that I didn't have l

[jira] [Reopened] (SOLR-12901) Make UnifiedHighlighter the default

2022-02-07 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reopened SOLR-12901: -- I'm seeing a reproducible test failure after commit 101296f606f on main: {{gradlew :solr:core:test --tests

[jira] [Commented] (SOLR-15964) Transient cores should not be unloaded/evicted while it's being used

2022-02-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488333#comment-17488333 ] ASF subversion and git services commented on SOLR-15964: Commit c

[jira] [Updated] (SOLR-15984) Ensure all used dependencies are declared

2022-02-07 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15984: Status: Patch Available (was: Open) > Ensure all used dependencies are declared >

[GitHub] [solr] HoustonPutman commented on a change in pull request #596: SOLR-15557 Script to generate refguide page .htaccess redirects

2022-02-07 Thread GitBox
HoustonPutman commented on a change in pull request #596: URL: https://github.com/apache/solr/pull/596#discussion_r800922847 ## File path: dev-tools/scripts/refguide/gen-refguide-redirects.py ## @@ -0,0 +1,134 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +# Licensed to t

[jira] [Commented] (SOLR-15964) Transient cores should not be unloaded/evicted while it's being used

2022-02-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488299#comment-17488299 ] ASF subversion and git services commented on SOLR-15964: Commit f

[GitHub] [solr] HoustonPutman commented on a change in pull request #596: SOLR-15557 Script to generate refguide page .htaccess redirects

2022-02-07 Thread GitBox
HoustonPutman commented on a change in pull request #596: URL: https://github.com/apache/solr/pull/596#discussion_r800922350 ## File path: dev-tools/scripts/refguide/gen-refguide-redirects.py ## @@ -0,0 +1,134 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +# Licensed to t

[GitHub] [solr] risdenk commented on a change in pull request #604: SOLR-15984: Ensure all used dependencies are declared

2022-02-07 Thread GitBox
risdenk commented on a change in pull request #604: URL: https://github.com/apache/solr/pull/604#discussion_r800916297 ## File path: gradle/validation/dependency-analyze.gradle ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [solr] risdenk commented on a change in pull request #604: SOLR-15984: Ensure all used dependencies are declared

2022-02-07 Thread GitBox
risdenk commented on a change in pull request #604: URL: https://github.com/apache/solr/pull/604#discussion_r800915222 ## File path: gradle/validation/dependency-analyze.gradle ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [solr] risdenk commented on a change in pull request #604: SOLR-15984: Ensure all used dependencies are declared

2022-02-07 Thread GitBox
risdenk commented on a change in pull request #604: URL: https://github.com/apache/solr/pull/604#discussion_r800913777 ## File path: solr/modules/analysis-extras/build.gradle ## @@ -15,25 +15,33 @@ * limitations under the License. */ - apply plugin: 'java-library' des

[GitHub] [solr] madrob commented on a change in pull request #604: SOLR-15984: Ensure all used dependencies are declared

2022-02-07 Thread GitBox
madrob commented on a change in pull request #604: URL: https://github.com/apache/solr/pull/604#discussion_r800912256 ## File path: gradle/validation/dependency-analyze.gradle ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[GitHub] [solr] risdenk commented on a change in pull request #604: SOLR-15984: Ensure all used dependencies are declared

2022-02-07 Thread GitBox
risdenk commented on a change in pull request #604: URL: https://github.com/apache/solr/pull/604#discussion_r800909247 ## File path: gradle/validation/dependency-analyze.gradle ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [solr] janhoy commented on a change in pull request #596: SOLR-15557 Script to generate refguide page .htaccess redirects

2022-02-07 Thread GitBox
janhoy commented on a change in pull request #596: URL: https://github.com/apache/solr/pull/596#discussion_r800909120 ## File path: dev-tools/scripts/refguide/gen-refguide-redirects.py ## @@ -0,0 +1,134 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +# Licensed to the Apac

[GitHub] [solr] risdenk commented on a change in pull request #604: SOLR-15984: Ensure all used dependencies are declared

2022-02-07 Thread GitBox
risdenk commented on a change in pull request #604: URL: https://github.com/apache/solr/pull/604#discussion_r800907816 ## File path: gradle/validation/dependency-analyze.gradle ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [solr] risdenk commented on a change in pull request #604: SOLR-15984: Ensure all used dependencies are declared

2022-02-07 Thread GitBox
risdenk commented on a change in pull request #604: URL: https://github.com/apache/solr/pull/604#discussion_r800906506 ## File path: solr/modules/analysis-extras/build.gradle ## @@ -15,25 +15,33 @@ * limitations under the License. */ - apply plugin: 'java-library' des

[GitHub] [solr] madrob commented on a change in pull request #604: SOLR-15984: Ensure all used dependencies are declared

2022-02-07 Thread GitBox
madrob commented on a change in pull request #604: URL: https://github.com/apache/solr/pull/604#discussion_r800892265 ## File path: gradle/validation/dependency-analyze.gradle ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[GitHub] [solr] janhoy commented on a change in pull request #596: SOLR-15557 Script to generate refguide page .htaccess redirects

2022-02-07 Thread GitBox
janhoy commented on a change in pull request #596: URL: https://github.com/apache/solr/pull/596#discussion_r800898706 ## File path: dev-tools/scripts/refguide/gen-refguide-redirects.py ## @@ -0,0 +1,134 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +# Licensed to the Apac

[GitHub] [solr] cpoerschke commented on a change in pull request #595: SOLR-15982: Add end time value to backup response

2022-02-07 Thread GitBox
cpoerschke commented on a change in pull request #595: URL: https://github.com/apache/solr/pull/595#discussion_r800892888 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/BackupCmd.java ## @@ -138,6 +138,15 @@ public void call(ClusterState state, ZkNodePr

[GitHub] [solr] risdenk commented on pull request #604: SOLR-15984: Ensure all used dependencies are declared

2022-02-07 Thread GitBox
risdenk commented on pull request #604: URL: https://github.com/apache/solr/pull/604#issuecomment-1031728692 I spot checked all these changes and for each case I was able to find classes that imported from these jars so the dependencies were missing. This runs during `./gradlew check` so i

[GitHub] [solr] risdenk opened a new pull request #604: SOLR-15984: Ensure all used dependencies are declared

2022-02-07 Thread GitBox
risdenk opened a new pull request #604: URL: https://github.com/apache/solr/pull/604 * Add missing dependencies that are used in compile and test * LTR module - remove jetty-servlet dependency since it wasn't used https://issues.apache.org/jira/browse/SOLR-15984 - [x] I have

[jira] [Commented] (SOLR-15964) Transient cores should not be unloaded/evicted while it's being used

2022-02-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488264#comment-17488264 ] ASF subversion and git services commented on SOLR-15964: Commit e

[GitHub] [solr] dsmiley merged pull request #580: SOLR-15964: Transient cores: don't evict open ones

2022-02-07 Thread GitBox
dsmiley merged pull request #580: URL: https://github.com/apache/solr/pull/580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [solr] madrob opened a new pull request #603: SOLR-15985 update mock-oauth-server version

2022-02-07 Thread GitBox
madrob opened a new pull request #603: URL: https://github.com/apache/solr/pull/603 https://issues.apache.org/jira/browse/SOLR-15985 This brings in a lot of other dependency changes, I'm actually a little scared to do this. -- This is an automated message from the Apache Git Servi

[jira] [Commented] (SOLR-15587) Replicas end up with base_url as http on client side even if cluster state says https when using the HttpClusterStateProvider

2022-02-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488263#comment-17488263 ] ASF subversion and git services commented on SOLR-15587: Commit 7

[jira] [Created] (SOLR-15985) Update mock-oauth test server version

2022-02-07 Thread Mike Drob (Jira)
Mike Drob created SOLR-15985: Summary: Update mock-oauth test server version Key: SOLR-15985 URL: https://issues.apache.org/jira/browse/SOLR-15985 Project: Solr Issue Type: Task Repor

[jira] [Commented] (SOLR-15484) Frequent test failures for JWTAuthPluginIntegrationTest

2022-02-07 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488262#comment-17488262 ] Mike Drob commented on SOLR-15484: -- I'm not sure if updating the version of the test ser

[GitHub] [solr] thelabdude merged pull request #602: SOLR-15587: Don't use the UrlScheme singleton on the client-side

2022-02-07 Thread GitBox
thelabdude merged pull request #602: URL: https://github.com/apache/solr/pull/602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr] thelabdude opened a new pull request #602: SOLR-15587: Don't use the UrlScheme singleton on the client-side

2022-02-07 Thread GitBox
thelabdude opened a new pull request #602: URL: https://github.com/apache/solr/pull/602 https://issues.apache.org/jira/browse/SOLR-15587 Backport of https://github.com/apache/solr/pull/600 to 9.0 -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [solr] HoustonPutman commented on a change in pull request #596: SOLR-15557 Script to generate refguide page .htaccess redirects

2022-02-07 Thread GitBox
HoustonPutman commented on a change in pull request #596: URL: https://github.com/apache/solr/pull/596#discussion_r800841395 ## File path: dev-tools/scripts/refguide/gen-refguide-redirects.py ## @@ -0,0 +1,134 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +# Licensed to t

[jira] [Commented] (SOLR-15587) Replicas end up with base_url as http on client side even if cluster state says https when using the HttpClusterStateProvider

2022-02-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488239#comment-17488239 ] ASF subversion and git services commented on SOLR-15587: Commit 3

[GitHub] [solr] thelabdude merged pull request #600: SOLR-15587: Don't use the UrlScheme singleton on the client-side

2022-02-07 Thread GitBox
thelabdude merged pull request #600: URL: https://github.com/apache/solr/pull/600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr] cpoerschke closed pull request #597: SOLR-15983: synchronise LogUpdateProcessor's members use

2022-02-07 Thread GitBox
cpoerschke closed pull request #597: URL: https://github.com/apache/solr/pull/597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr] cpoerschke commented on pull request #597: SOLR-15983: synchronise LogUpdateProcessor's members use

2022-02-07 Thread GitBox
cpoerschke commented on pull request #597: URL: https://github.com/apache/solr/pull/597#issuecomment-1031654414 closing in favour of alternative changes e.g. #601 (or something else still) -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (SOLR-15983) ClassCastException in UpdateLog$LogReplayer.doReplay

2022-02-07 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488224#comment-17488224 ] Christine Poerschke commented on SOLR-15983: Thanks for that [~dsmiley]! Yes,

[GitHub] [solr] madrob commented on pull request #529: SOLR-12336 Remove Filter from Solr

2022-02-07 Thread GitBox
madrob commented on pull request #529: URL: https://github.com/apache/solr/pull/529#issuecomment-1031647210 `gradlew :solr:core:test --tests "org.apache.solr.search.TestSolrQueryParser.testFilter" -Ptests.jvms=16 -Ptests.jvmargs=-XX:TieredStopAtLevel=1 -Ptests.seed=6B406B744E68E8EE -Ptest

[GitHub] [solr] cpoerschke opened a new pull request #601: SOLR-15983: parallel log replay now uses separate UpdateRequestProcessor objects

2022-02-07 Thread GitBox
cpoerschke opened a new pull request #601: URL: https://github.com/apache/solr/pull/601 https://issues.apache.org/jira/browse/SOLR-15983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [solr] thelabdude opened a new pull request #600: SOLR-15587: Don't use the UrlScheme singleton on the client-side

2022-02-07 Thread GitBox
thelabdude opened a new pull request #600: URL: https://github.com/apache/solr/pull/600 https://issues.apache.org/jira/browse/SOLR-15587 Backport of https://github.com/apache/solr/pull/460 to 9x -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [solr] madrob commented on a change in pull request #599: Refactor code to minimize access to SolrCore

2022-02-07 Thread GitBox
madrob commented on a change in pull request #599: URL: https://github.com/apache/solr/pull/599#discussion_r800802908 ## File path: solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java ## @@ -172,7 +172,7 @@ public void handleRequestBody(SolrQueryRequest req

[jira] [Commented] (SOLR-12336) Remove Filter from Solr

2022-02-07 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488193#comment-17488193 ] Mike Drob commented on SOLR-12336: -- I looked through the ref guide and didn't see anythi

[jira] [Assigned] (SOLR-15982) Add endTime value to the backup result

2022-02-07 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-15982: -- Assignee: Jason Gerlowski > Add endTime value to the backup result > -

[jira] [Updated] (SOLR-15984) Ensure all used dependencies are declared

2022-02-07 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15984: Description: Solr uses a bunch of dependencies that are not declared inside build.gradle files. Th

[jira] [Created] (SOLR-15984) Ensure all used dependencies are declared

2022-02-07 Thread Kevin Risden (Jira)
Kevin Risden created SOLR-15984: --- Summary: Ensure all used dependencies are declared Key: SOLR-15984 URL: https://issues.apache.org/jira/browse/SOLR-15984 Project: Solr Issue Type: Task S

[jira] [Commented] (SOLR-15950) Create SOLR_HOME/filestore lazily on first use

2022-02-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488139#comment-17488139 ] Jan Høydahl commented on SOLR-15950: The PR is ready. What will happen now is that if

[GitHub] [solr] janhoy commented on a change in pull request #556: SOLR-15949: Docker, use Java 17

2022-02-07 Thread GitBox
janhoy commented on a change in pull request #556: URL: https://github.com/apache/solr/pull/556#discussion_r80065 ## File path: solr/docker/build.gradle ## @@ -27,7 +27,7 @@ apply plugin: 'base' def dockerImageRepo = propertyOrEnvOrDefault("solr.docker.imageRepo", "SOLR_D

[jira] [Commented] (SOLR-13138) Remove deprecated code prior to 9.0

2022-02-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488077#comment-17488077 ] Jan Høydahl commented on SOLR-13138: Can we close this "umbrella" jira now, or are we

[jira] [Comment Edited] (SOLR-15949) Use Java 17 in docker

2022-02-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488070#comment-17488070 ] Jan Høydahl edited comment on SOLR-15949 at 2/7/22, 12:42 PM: -

[jira] [Commented] (SOLR-15949) Use Java 17 in docker

2022-02-07 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488070#comment-17488070 ] Jan Høydahl commented on SOLR-15949: I'm not going to veto your suggestion, just want

[GitHub] [solr] janhoy commented on a change in pull request #593: SOLR-15950 Create SOLR_HOME/filestore lazily on first use

2022-02-07 Thread GitBox
janhoy commented on a change in pull request #593: URL: https://github.com/apache/solr/pull/593#discussion_r800588783 ## File path: solr/core/src/java/org/apache/solr/filestore/DistribPackageStore.java ## @@ -572,7 +578,16 @@ private void ensurePackageStoreDir(Path solrHome) {

[GitHub] [solr] janhoy commented on pull request #596: SOLR-15557 Script to generate refguide page .htaccess redirects

2022-02-07 Thread GitBox
janhoy commented on pull request #596: URL: https://github.com/apache/solr/pull/596#issuecomment-1031388101 Separate htaccess did not play out as intended. Going back to using top-level one. Also merged the sub-path renames into larger regex lines, and separated 8_11 guide redirects into i

[GitHub] [solr-site] janhoy commented on pull request #70: SOLR-15557 Old refguide page redirects

2022-02-07 Thread GitBox
janhoy commented on pull request #70: URL: https://github.com/apache/solr-site/pull/70#issuecomment-1031368022 I also converted the 8_11 redirects into one line: > RedirectMatch ^/guide/(adding-custom-plugins-in-solrcloud-mode|blob-store-api|cdcr-api|cdcr-architecture|cdcr-config|cdcr-op

[GitHub] [solr-site] janhoy commented on pull request #70: SOLR-15557 Old refguide page redirects

2022-02-07 Thread GitBox
janhoy commented on pull request #70: URL: https://github.com/apache/solr-site/pull/70#issuecomment-1031362017 One regex `redirectMatch` per sub folder in the new guide could be doable. I tweaked the script, and here is a sample output for "query-guide": >RedirectMatch ^/guide/(anal

[GitHub] [solr-site] uschindler commented on pull request #70: SOLR-15557 Old refguide page redirects

2022-02-07 Thread GitBox
uschindler commented on pull request #70: URL: https://github.com/apache/solr-site/pull/70#issuecomment-1031265377 OK, let's keep with a single htaccess file on root level. We will see if INFRA complains about slowness. Maintenance is another fact (but how long do we need to geep the redir

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #599: Refactor code to minimize access to SolrCore

2022-02-07 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #599: URL: https://github.com/apache/solr/pull/599#discussion_r800455154 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CategoryRoutedAlias.java ## @@ -225,7 +225,7 @@ public String computeInitial

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #598: Refactor code to minimize access to SolrCore

2022-02-07 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #598: URL: https://github.com/apache/solr/pull/598#discussion_r800421624 ## File path: solr/contrib/analytics/src/java/org/apache/solr/handler/component/AnalyticsComponent.java ## @@ -109,7 +108,7 @@ public int distribut