[jira] [Resolved] (SOLR-14857) Parallelize Solr Docker tests

2021-07-08 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter resolved SOLR-14857. --- Fix Version/s: main (9.0) Resolution: Fixed > Parallelize Solr Docker tests >

[jira] [Commented] (SOLR-14857) Parallelize Solr Docker tests

2021-07-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377650#comment-17377650 ] ASF subversion and git services commented on SOLR-14857: Commit 5

[jira] [Commented] (SOLR-14857) Parallelize Solr Docker tests

2021-07-08 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377651#comment-17377651 ] Chris M. Hostetter commented on SOLR-14857: --- LGTM, thanks for the additions! >

[jira] [Commented] (SOLR-15524) Fix Solr Docker test cleanup

2021-07-08 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377649#comment-17377649 ] Chris M. Hostetter commented on SOLR-15524: --- Houston: I'm confused by your chan

[jira] [Commented] (SOLR-15428) Integrate the OpenJDK JMH micro benchmark framework for micro benchmarks and performance comparisons and investigation.

2021-07-08 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377647#comment-17377647 ] Mark Robert Miller commented on SOLR-15428: --- some notes * For quick-play, you

[GitHub] [solr] athrog commented on pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-07-08 Thread GitBox
athrog commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-876816844 Thank you @madrob for the review. I fixed some of the low hanging fruit, will circle back later for the other comments (that will require testing after changes) -- This is an autom

[GitHub] [solr] athrog commented on a change in pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-07-08 Thread GitBox
athrog commented on a change in pull request #120: URL: https://github.com/apache/solr/pull/120#discussion_r666586850 ## File path: solr/contrib/blob-repository/src/java/org/apache/solr/s3/AdobeMockS3StorageClient.java ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Softwar

[jira] [Commented] (SOLR-15428) Integrate the OpenJDK JMH micro benchmark framework for micro benchmarks and performance comparisons and investigation.

2021-07-08 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377640#comment-17377640 ] Mark Robert Miller commented on SOLR-15428: --- I would wait for the pr - I starte

[GitHub] [solr] madrob commented on a change in pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-07-08 Thread GitBox
madrob commented on a change in pull request #120: URL: https://github.com/apache/solr/pull/120#discussion_r666573826 ## File path: solr/contrib/blob-repository/src/java/org/apache/solr/blob/client/S3OutputStream.java ## @@ -0,0 +1,250 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [solr] madrob commented on a change in pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-07-08 Thread GitBox
madrob commented on a change in pull request #120: URL: https://github.com/apache/solr/pull/120#discussion_r666567722 ## File path: solr/contrib/blob-repository/src/java/org/apache/solr/s3/S3IndexInput.java ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-07-08 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #120: URL: https://github.com/apache/solr/pull/120#discussion_r666555684 ## File path: solr/contrib/blob-repository/src/java/org/apache/solr/s3/S3BackupRepository.java ## @@ -0,0 +1,349 @@ +/* + * Licensed to the Apache

[GitHub] [solr] athrog commented on pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-07-08 Thread GitBox
athrog commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-876768134 Also, I'm not sure if it's a problem with my setup or maybe I missed some gradle setting somewhere, but just doing a `./gradlew assemble` doesn't seem to put our new `blob-repository`

[GitHub] [solr] madrob commented on a change in pull request #207: SOLR-15385 RawTypes Part VI

2021-07-08 Thread GitBox
madrob commented on a change in pull request #207: URL: https://github.com/apache/solr/pull/207#discussion_r666539176 ## File path: solr/core/src/java/org/apache/solr/metrics/reporters/SolrSlf4jReporter.java ## @@ -85,7 +85,7 @@ public void report() { } @Override -

[GitHub] [solr] athrog commented on pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-07-08 Thread GitBox
athrog commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-876766387 Just pushed a merge commit @HoustonPutman, along with an update for our README. Let me know if you have any trouble testing locally, I can add more documentation if needed. -- This

[GitHub] [solr] madrob commented on a change in pull request #207: SOLR-15385 RawTypes Part VI

2021-07-08 Thread GitBox
madrob commented on a change in pull request #207: URL: https://github.com/apache/solr/pull/207#discussion_r666532912 ## File path: solr/core/src/java/org/apache/solr/handler/admin/SolrInfoMBeanHandler.java ## @@ -233,14 +232,14 @@ else if (r != null) { } return out;

[GitHub] [solr] madrob commented on a change in pull request #207: SOLR-15385 RawTypes Part VI

2021-07-08 Thread GitBox
madrob commented on a change in pull request #207: URL: https://github.com/apache/solr/pull/207#discussion_r666532753 ## File path: solr/core/src/java/org/apache/solr/handler/admin/BaseHandlerApiSupport.java ## @@ -159,9 +159,7 @@ private Object getParams0(String param) {

[GitHub] [solr] madrob commented on a change in pull request #207: SOLR-15385 RawTypes Part VI

2021-07-08 Thread GitBox
madrob commented on a change in pull request #207: URL: https://github.com/apache/solr/pull/207#discussion_r666531293 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -2339,8 +2339,7 @@ public IndexFingerprint getIndexFingerprint(SolrIndexSearcher sear

[GitHub] [solr] HoustonPutman commented on pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-07-08 Thread GitBox
HoustonPutman commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-876711210 @psalagnac could you merge this with `main`? I'm trying to build it and test it out locally, but I believe you are haven't captured the changes that fix the lucene version to a

[jira] [Commented] (SOLR-15524) Fix Solr Docker test cleanup

2021-07-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377576#comment-17377576 ] ASF subversion and git services commented on SOLR-15524: Commit 1

[jira] [Resolved] (SOLR-15524) Fix Solr Docker test cleanup

2021-07-08 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-15524. --- Fix Version/s: main (9.0) Resolution: Fixed > Fix Solr Docker test cleanup > -

[jira] [Created] (SOLR-15524) Fix Solr Docker test cleanup

2021-07-08 Thread Houston Putman (Jira)
Houston Putman created SOLR-15524: - Summary: Fix Solr Docker test cleanup Key: SOLR-15524 URL: https://issues.apache.org/jira/browse/SOLR-15524 Project: Solr Issue Type: Test Security L

[jira] [Updated] (SOLR-14857) Parallelize Solr Docker tests

2021-07-08 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-14857: -- Attachment: SOLR-14857.patch > Parallelize Solr Docker tests > - >

[jira] [Commented] (SOLR-14857) Parallelize Solr Docker tests

2021-07-08 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377574#comment-17377574 ] Houston Putman commented on SOLR-14857: --- [~hossman], thanks for taking this up! I m

[GitHub] [solr] cpoerschke commented on a change in pull request #207: SOLR-15385 RawTypes Part VI

2021-07-08 Thread GitBox
cpoerschke commented on a change in pull request #207: URL: https://github.com/apache/solr/pull/207#discussion_r666448816 ## File path: solr/core/src/java/org/apache/solr/handler/admin/BaseHandlerApiSupport.java ## @@ -159,9 +159,7 @@ private Object getParams0(String param) {

[jira] [Resolved] (SOLR-15185) Improve "hash" QParser

2021-07-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15185. - Assignee: David Smiley (was: Joel Bernstein) Resolution: Fixed > Improve "hash" QParser >

[jira] [Commented] (SOLR-14444) Ref Guide Redesign Phase 2: Page Organization Overhaul

2021-07-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377495#comment-17377495 ] ASF subversion and git services commented on SOLR-1: Commit d

[GitHub] [solr] ctargett merged pull request #208: SOLR-14444: add required/default tables to all params, part I

2021-07-08 Thread GitBox
ctargett merged pull request #208: URL: https://github.com/apache/solr/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [solr-operator] HoustonPutman closed issue #281: Enable scheduled restarts of Solr Clouds

2021-07-08 Thread GitBox
HoustonPutman closed issue #281: URL: https://github.com/apache/solr-operator/issues/281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr-operator] HoustonPutman merged pull request #279: Ability to provide a cron-schedule for automatic restarts

2021-07-08 Thread GitBox
HoustonPutman merged pull request #279: URL: https://github.com/apache/solr-operator/pull/279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[jira] [Commented] (SOLR-15185) Improve "hash" QParser

2021-07-08 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377484#comment-17377484 ] Mike Drob commented on SOLR-15185: -- Good to resolve here? I don't see this test showing

[jira] [Issue Comment Deleted] (SOLR-15406) Reliably Failing Seed for testParallelPriorityStream

2021-07-08 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-15406: - Comment: was deleted (was: Good to resolve here? I don't see this test showing up on Hoss's reports anym

[jira] [Commented] (SOLR-15406) Reliably Failing Seed for testParallelPriorityStream

2021-07-08 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377483#comment-17377483 ] Mike Drob commented on SOLR-15406: -- Good to resolve here? I don't see this test showing

[GitHub] [solr-operator] HoustonPutman commented on issue #277: Use v1 of the k8s networking and extension APIs

2021-07-08 Thread GitBox
HoustonPutman commented on issue #277: URL: https://github.com/apache/solr-operator/issues/277#issuecomment-876532088 Note, when we make 1.19 the minimum kubernetes version supported, we can officially add support for the [Pod Topology Spread Constraints](https://kubernetes.io/docs/concept

[GitHub] [solr] gerlowskija commented on pull request #204: SOLR-15490: /cluster v2 API parameter mapping tests

2021-07-08 Thread GitBox
gerlowskija commented on pull request #204: URL: https://github.com/apache/solr/pull/204#issuecomment-876461154 Fair enough, re: "complexity". If you see anything concrete that you'd improve, lmk. I'm not married to any particular way of doing this, I just want _something_ to make sure t

[GitHub] [solr] ctargett opened a new pull request #208: SOLR-14444: add required/default tables to all params, part I

2021-07-08 Thread GitBox
ctargett opened a new pull request #208: URL: https://github.com/apache/solr/pull/208 https://issues.apache.org/jira/browse/SOLR-1 # Description As part of the Ref Guide reorg, I introduced a new structure for parameters to add a short table at the start of all parameter d

[GitHub] [solr] madrob opened a new pull request #207: SOLR-15385 RawTypes Part VI

2021-07-08 Thread GitBox
madrob opened a new pull request #207: URL: https://github.com/apache/solr/pull/207 https://issues.apache.org/jira/browse/SOLR-15385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (SOLR-15505) Upgrade ICU4J to 67.1+

2021-07-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved SOLR-15505. Resolution: Won't Fix Your security scanning tool is broken. Please fix it. Please, at least read

[jira] [Commented] (SOLR-15519) reduce getCircuitBreakerManager calls in SearchHandler

2021-07-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377335#comment-17377335 ] ASF subversion and git services commented on SOLR-15519: Commit 3

[GitHub] [solr] cpoerschke commented on a change in pull request #193: SOLR-15474: Support Pluggable Circuit Breakers

2021-07-08 Thread GitBox
cpoerschke commented on a change in pull request #193: URL: https://github.com/apache/solr/pull/193#discussion_r666081011 ## File path: solr/solr-ref-guide/src/circuit-breakers.adoc ## @@ -27,23 +27,16 @@ If circuit breakers are enabled, requests may be rejected under the cond

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2021-07-08 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377294#comment-17377294 ] Christine Poerschke commented on SOLR-14588: {quote}... creating a new Jira t

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2021-07-08 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377286#comment-17377286 ] Atri Sharma commented on SOLR-14588: [~cpoerschke] Thanks! Just to be clear, I plan o

[jira] [Commented] (SOLR-15519) reduce getCircuitBreakerManager calls in SearchHandler

2021-07-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377282#comment-17377282 ] ASF subversion and git services commented on SOLR-15519: Commit e

[GitHub] [solr] cpoerschke merged pull request #203: SOLR-15519: reduce SolrCore.getCircuitBreakerManager() calls in SearchHandler.handleRequestBody()

2021-07-08 Thread GitBox
cpoerschke merged pull request #203: URL: https://github.com/apache/solr/pull/203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr] cpoerschke commented on pull request #193: SOLR-15474: Support Pluggable Circuit Breakers

2021-07-08 Thread GitBox
cpoerschke commented on pull request #193: URL: https://github.com/apache/solr/pull/193#issuecomment-876313952 > ... This branch has conflicts that must be resolved ... I'll have a go at resolving them. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2021-07-08 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377281#comment-17377281 ] Christine Poerschke commented on SOLR-14588: bq. ... to revert the commit and

[jira] [Commented] (SOLR-14588) Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker

2021-07-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377280#comment-17377280 ] ASF subversion and git services commented on SOLR-14588: Commit c