[ 
https://issues.apache.org/jira/browse/SOLR-15524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377649#comment-17377649
 ] 

Chris M. Hostetter commented on SOLR-15524:
-------------------------------------------

Houston: I'm confused by your changes...

I understand removing {{container_cleanup "$container_name-copier"}} from most 
of the tests where it exists – since it appears to be a copy/paste mistake from 
{{user_volume/test.sh}} ... but why did you make every test call 
{{container_cleanup "$container_name"}} immediately after sourcing 
{{shared.sh}} (which already calls {{container_cleanup "$container_name"}}) ?

 

> Fix Solr Docker test cleanup
> ----------------------------
>
>                 Key: SOLR-15524
>                 URL: https://issues.apache.org/jira/browse/SOLR-15524
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Docker
>            Reporter: Houston Putman
>            Assignee: Houston Putman
>            Priority: Major
>             Fix For: main (9.0)
>
>
> The cleanup of each tests uses the incorrect container name, which causes 
> issues when re-trying tests that fail.
> Easy fix to merely make the container names correct.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to