[jira] [Commented] (SOLR-15390) Deprecate "segmentTerminateEarly" in favor of "minExactCount"

2021-06-14 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363372#comment-17363372 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-15390: -- I haven't be

[GitHub] [solr] dsmiley commented on a change in pull request #108: SOLR-15051: Pull files from the repository when BlobDirectory is created.

2021-06-14 Thread GitBox
dsmiley commented on a change in pull request #108: URL: https://github.com/apache/solr/pull/108#discussion_r651431012 ## File path: solr/contrib/blob-directory/src/java/org/apache/solr/blob/BlobStoreConnection.java ## @@ -152,11 +180,66 @@ private void createDirectories(URI b

[GitHub] [solr] dsmiley commented on a change in pull request #108: SOLR-15051: Pull files from the repository when BlobDirectory is created.

2021-06-14 Thread GitBox
dsmiley commented on a change in pull request #108: URL: https://github.com/apache/solr/pull/108#discussion_r651425759 ## File path: solr/contrib/blob-directory/src/java/org/apache/solr/blob/BlobDirectory.java ## @@ -61,20 +62,33 @@ private final Object lock = new Object();

[jira] [Resolved] (SOLR-15362) Improve the view of menu collection and dropdown list

2021-06-14 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh resolved SOLR-15362. Fix Version/s: main (9.0) Resolution: Fixed Took part of the original patch that see

[jira] [Commented] (SOLR-15362) Improve the view of menu collection and dropdown list

2021-06-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363213#comment-17363213 ] ASF subversion and git services commented on SOLR-15362: Commit b

[GitHub] [solr] epugh merged pull request #90: SOLR-15362: allow drop down box to float wider to support long core/collection names

2021-06-14 Thread GitBox
epugh merged pull request #90: URL: https://github.com/apache/solr/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] [solr-operator] HoustonPutman opened a new pull request #276: Introduce a Helm chart for Solr Cloud

2021-06-14 Thread GitBox
HoustonPutman opened a new pull request #276: URL: https://github.com/apache/solr-operator/pull/276 Resolves #112 This is a WIP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [solr] madrob commented on a change in pull request #169: SOLR-15385 RawTypes Part III, contrib and solrj

2021-06-14 Thread GitBox
madrob commented on a change in pull request #169: URL: https://github.com/apache/solr/pull/169#discussion_r651278650 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java ## @@ -77,38 +77,26 @@ public Tuple() { * A copy constructor. * @param fiel

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-06-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363202#comment-17363202 ] ASF subversion and git services commented on SOLR-14920: Commit 6

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-06-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363196#comment-17363196 ] ASF subversion and git services commented on SOLR-14920: Commit d

[GitHub] [solr] cpoerschke merged pull request #162: SOLR-14920: contrib/jaegertracer-configurator: apply & enforce 'spotless' code formatting

2021-06-14 Thread GitBox
cpoerschke merged pull request #162: URL: https://github.com/apache/solr/pull/162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [solr] cpoerschke commented on a change in pull request #169: SOLR-15385 RawTypes Part III, contrib and solrj

2021-06-14 Thread GitBox
cpoerschke commented on a change in pull request #169: URL: https://github.com/apache/solr/pull/169#discussion_r651258643 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java ## @@ -77,38 +77,26 @@ public Tuple() { * A copy constructor. * @param

[GitHub] [solr] madrob commented on a change in pull request #169: SOLR-15385 RawTypes Part III, contrib and solrj

2021-06-14 Thread GitBox
madrob commented on a change in pull request #169: URL: https://github.com/apache/solr/pull/169#discussion_r651254173 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java ## @@ -77,38 +77,26 @@ public Tuple() { * A copy constructor. * @param fiel

[GitHub] [solr] madrob commented on a change in pull request #169: SOLR-15385 RawTypes Part III, contrib and solrj

2021-06-14 Thread GitBox
madrob commented on a change in pull request #169: URL: https://github.com/apache/solr/pull/169#discussion_r651250943 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java ## @@ -226,7 +214,7 @@ public Double getDouble(Object key) { /** * Return al

[jira] [Commented] (SOLR-15454) remove Lucene commits from .git-blame-ignore-revs

2021-06-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363182#comment-17363182 ] ASF subversion and git services commented on SOLR-15454: Commit b

[GitHub] [solr] cpoerschke merged pull request #163: SOLR-15454: retain and explain Lucene commits in .git-blame-ignore-revs

2021-06-14 Thread GitBox
cpoerschke merged pull request #163: URL: https://github.com/apache/solr/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [solr] dsmiley commented on a change in pull request #17: SOLR-14341: Move configName into DocCollection class

2021-06-14 Thread GitBox
dsmiley commented on a change in pull request #17: URL: https://github.com/apache/solr/pull/17#discussion_r651237184 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java ## @@ -560,10 +559,16 @@ public static void createCollectionZkN

[GitHub] [solr] cpoerschke commented on a change in pull request #169: SOLR-15385 RawTypes Part III, contrib and solrj

2021-06-14 Thread GitBox
cpoerschke commented on a change in pull request #169: URL: https://github.com/apache/solr/pull/169#discussion_r651225518 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/Tuple.java ## @@ -226,7 +214,7 @@ public Double getDouble(Object key) { /** * Retur

[GitHub] [solr] dsmiley commented on a change in pull request #17: SOLR-14341: Move configName into DocCollection class

2021-06-14 Thread GitBox
dsmiley commented on a change in pull request #17: URL: https://github.com/apache/solr/pull/17#discussion_r651233427 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java ## @@ -370,7 +369,7 @@ public void call(ClusterState clusterStat

[jira] [Commented] (SOLR-15371) Backups randomly fail sometimes

2021-06-14 Thread Roy Perkins (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363174#comment-17363174 ] Roy Perkins commented on SOLR-15371: [~gerlowskija] Yes, I have verified the mount ex

[jira] [Commented] (SOLR-15371) Backups randomly fail sometimes

2021-06-14 Thread Roy Perkins (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363173#comment-17363173 ] Roy Perkins commented on SOLR-15371: [~gerlowskija] I may have forgot to mention, but

[jira] [Commented] (SOLR-15371) Backups randomly fail sometimes

2021-06-14 Thread Roy Perkins (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363167#comment-17363167 ] Roy Perkins commented on SOLR-15371: Checked back through out ELK logs for Solr and f

[jira] [Commented] (SOLR-15371) Backups randomly fail sometimes

2021-06-14 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363166#comment-17363166 ] Jason Gerlowski commented on SOLR-15371: There may well be a bug you're hitting,

[jira] [Comment Edited] (SOLR-15371) Backups randomly fail sometimes

2021-06-14 Thread Roy Perkins (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363163#comment-17363163 ] Roy Perkins edited comment on SOLR-15371 at 6/14/21, 7:20 PM: -

[jira] [Comment Edited] (SOLR-15371) Backups randomly fail sometimes

2021-06-14 Thread Roy Perkins (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363163#comment-17363163 ] Roy Perkins edited comment on SOLR-15371 at 6/14/21, 7:20 PM: -

[jira] [Commented] (SOLR-15371) Backups randomly fail sometimes

2021-06-14 Thread Roy Perkins (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363163#comment-17363163 ] Roy Perkins commented on SOLR-15371: Like I said, it can be hard to reproduce.  It se

[jira] [Commented] (SOLR-15371) Backups randomly fail sometimes

2021-06-14 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363157#comment-17363157 ] Jason Gerlowski commented on SOLR-15371: Hey Roy, do you have Solr logs handy tha

[GitHub] [solr] thelabdude commented on a change in pull request #173: SOLR-15460: Implement LIKE, IS NOT NULL, IS NULL, and support wildcard * in equals string literal

2021-06-14 Thread GitBox
thelabdude commented on a change in pull request #173: URL: https://github.com/apache/solr/pull/173#discussion_r651204998 ## File path: solr/core/src/java/org/apache/solr/handler/sql/SolrFilter.java ## @@ -69,34 +78,81 @@ public void implement(Implementor implementor) { pr

[jira] [Updated] (SOLR-15371) Backups randomly fail sometimes

2021-06-14 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-15371: --- Affects Version/s: 8.5.2 > Backups randomly fail sometimes > ---

[jira] [Resolved] (SOLR-143) Support for PMD and Clover

2021-06-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-143. --- Resolution: Won't Fix RE PMD: we use error-prone. RE Clover: this was implemented but didn't survive t

[GitHub] [solr] HoustonPutman commented on a change in pull request #173: SOLR-15460: Implement LIKE, IS NOT NULL, IS NULL, and support wildcard * in equals string literal

2021-06-14 Thread GitBox
HoustonPutman commented on a change in pull request #173: URL: https://github.com/apache/solr/pull/173#discussion_r651185894 ## File path: solr/core/src/java/org/apache/solr/handler/sql/SolrFilter.java ## @@ -69,34 +78,81 @@ public void implement(Implementor implementor) {

[GitHub] [solr] madrob commented on a change in pull request #173: SOLR-15460: Implement LIKE, IS NOT NULL, IS NULL, and support wildcard * in equals string literal

2021-06-14 Thread GitBox
madrob commented on a change in pull request #173: URL: https://github.com/apache/solr/pull/173#discussion_r651180874 ## File path: solr/core/src/java/org/apache/solr/handler/sql/SolrFilter.java ## @@ -69,34 +78,81 @@ public void implement(Implementor implementor) { privat

[GitHub] [solr] madrob commented on a change in pull request #169: SOLR-15385 RawTypes Part III, contrib and solrj

2021-06-14 Thread GitBox
madrob commented on a change in pull request #169: URL: https://github.com/apache/solr/pull/169#discussion_r651179192 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/ClassificationEvaluation.java ## @@ -36,28 +36,26 @@ public void count(int actual, int predic

[GitHub] [solr] madrob commented on a change in pull request #169: SOLR-15385 RawTypes Part III, contrib and solrj

2021-06-14 Thread GitBox
madrob commented on a change in pull request #169: URL: https://github.com/apache/solr/pull/169#discussion_r651178061 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/ClassificationEvaluation.java ## @@ -36,28 +36,26 @@ public void count(int actual, int predic

[jira] [Commented] (SOLR-15469) start/stop script fails on multiple instance

2021-06-14 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363117#comment-17363117 ] Mike Drob commented on SOLR-15469: -- Can you be more specific as to what fails? {noformat

[GitHub] [solr] thelabdude commented on a change in pull request #173: SOLR-15460: Implement LIKE, IS NOT NULL, IS NULL, and support wildcard * in equals string literal

2021-06-14 Thread GitBox
thelabdude commented on a change in pull request #173: URL: https://github.com/apache/solr/pull/173#discussion_r651156752 ## File path: solr/solr-ref-guide/src/parallel-sql-interface.adoc ## @@ -240,16 +240,20 @@ The parallel SQL interface supports and pushes down most common

[GitHub] [solr] thelabdude commented on a change in pull request #173: SOLR-15460: Implement LIKE, IS NOT NULL, IS NULL, and support wildcard * in equals string literal

2021-06-14 Thread GitBox
thelabdude commented on a change in pull request #173: URL: https://github.com/apache/solr/pull/173#discussion_r651153308 ## File path: solr/solr-ref-guide/src/parallel-sql-interface.adoc ## @@ -240,16 +240,20 @@ The parallel SQL interface supports and pushes down most common

[GitHub] [solr] madrob commented on a change in pull request #173: SOLR-15460: Implement LIKE, IS NOT NULL, IS NULL, and support wildcard * in equals string literal

2021-06-14 Thread GitBox
madrob commented on a change in pull request #173: URL: https://github.com/apache/solr/pull/173#discussion_r651149156 ## File path: solr/solr-ref-guide/src/parallel-sql-interface.adoc ## @@ -240,16 +240,20 @@ The parallel SQL interface supports and pushes down most common SQL

[jira] [Commented] (SOLR-15390) Deprecate "segmentTerminateEarly" in favor of "minExactCount"

2021-06-14 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363106#comment-17363106 ] Mike Drob commented on SOLR-15390: -- [~tflobbe] - what's the status of this? > Deprecate

[GitHub] [solr] madrob commented on a change in pull request #162: SOLR-14920: contrib/jaegertracer-configurator: apply & enforce 'spotless' code formatting

2021-06-14 Thread GitBox
madrob commented on a change in pull request #162: URL: https://github.com/apache/solr/pull/162#discussion_r651146459 ## File path: solr/contrib/jaegertracer-configurator/src/java/org/apache/solr/jaeger/JaegerTracerConfigurator.java ## @@ -31,7 +31,5 @@ public Tracer getTracer

[GitHub] [solr] madrob commented on a change in pull request #176: SOLR-15476: Facilitate 'shards.info' content customisation.

2021-06-14 Thread GitBox
madrob commented on a change in pull request #176: URL: https://github.com/apache/solr/pull/176#discussion_r651120975 ## File path: solr/core/src/java/org/apache/solr/handler/component/ResponseBuilder.java ## @@ -175,6 +177,26 @@ public void addRequest(SearchComponent me, Shar

[GitHub] [solr] cpoerschke commented on a change in pull request #169: SOLR-15385 RawTypes Part III, contrib and solrj

2021-06-14 Thread GitBox
cpoerschke commented on a change in pull request #169: URL: https://github.com/apache/solr/pull/169#discussion_r651135768 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/ClassificationEvaluation.java ## @@ -36,28 +36,26 @@ public void count(int actual, int pr

[GitHub] [solr] dsmiley commented on pull request #81: SOLR-15351: Convert /v2/c/ APIs to POJO impl

2021-06-14 Thread GitBox
dsmiley commented on pull request #81: URL: https://github.com/apache/solr/pull/81#issuecomment-860850526 Ok that's fine. BTW this PR is just awesomeness! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [solr] madrob commented on pull request #176: SOLR-15476: Facilitate 'shards.info' content customisation.

2021-06-14 Thread GitBox
madrob commented on pull request #176: URL: https://github.com/apache/solr/pull/176#issuecomment-860837631 > I've placed use illustrations on the JIRA ticket, does that help? That's not to say we can't have unit test coverage too of course. Yea, those are helpful. Test coverage will

[GitHub] [solr] epugh commented on pull request #90: SOLR-15362: allow drop down box to float wider to support long core/collection names

2021-06-14 Thread GitBox
epugh commented on pull request #90: URL: https://github.com/apache/solr/pull/90#issuecomment-860832769 > @epugh Do you want to merge this? Thanks for the ping. I'll go ahead and do one more look and then merge it. -- This is an automated message from the Apache Git Service. To r

[jira] [Commented] (SOLR-15471) Replace use of whitelist in language identification contrib

2021-06-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363068#comment-17363068 ] ASF subversion and git services commented on SOLR-15471: Commit 7

[jira] [Resolved] (SOLR-15471) Replace use of whitelist in language identification contrib

2021-06-14 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-15471. -- Fix Version/s: main (9.0) Assignee: Mike Drob Resolution: Fixed > Replace use of whitel

[GitHub] [solr] madrob merged pull request #172: SOLR-15471 Rename parameter to langid.allowlist

2021-06-14 Thread GitBox
madrob merged pull request #172: URL: https://github.com/apache/solr/pull/172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please conta

[GitHub] [solr] madrob commented on pull request #90: SOLR-15362: allow drop down box to float wider to support long core/collection names

2021-06-14 Thread GitBox
madrob commented on pull request #90: URL: https://github.com/apache/solr/pull/90#issuecomment-860828797 @epugh Do you want to merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [solr] madrob commented on pull request #53: CDPD-24223 Eliminate repetitive index size calculation for Solr metrics

2021-06-14 Thread GitBox
madrob commented on pull request #53: URL: https://github.com/apache/solr/pull/53#issuecomment-860826448 @asalamon74 can you file a SOLR JIRA issue for this? It looks like this is based on some other internal tracker. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [solr] madrob merged pull request #54: renamed solritas repo

2021-06-14 Thread GitBox
madrob merged pull request #54: URL: https://github.com/apache/solr/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[jira] [Resolved] (SOLR-15280) Misleading error message in HdfsDirectoryFactory

2021-06-14 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-15280. -- Fix Version/s: main (9.0) Assignee: Mike Drob Resolution: Fixed > Misleading error mess

[jira] [Commented] (SOLR-15152) Export Tool should export nested docs cleanly in .json, .jsonl, and javabin

2021-06-14 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363040#comment-17363040 ] Mike Drob commented on SOLR-15152: -- [~epugh] - what is the status here? The PR might nee

[jira] [Commented] (SOLR-15280) Misleading error message in HdfsDirectoryFactory

2021-06-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363039#comment-17363039 ] ASF subversion and git services commented on SOLR-15280: Commit b

[GitHub] [solr] madrob merged pull request #44: SOLR-15280 Misleading error message in HdfsDirectoryFactory

2021-06-14 Thread GitBox
madrob merged pull request #44: URL: https://github.com/apache/solr/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] [solr] cpoerschke commented on a change in pull request #176: SOLR-15476: Add ResponseBuilder.(newShardsInfo|addShardInfo) methods to facilitate 'shards.info' content customisation.

2021-06-14 Thread GitBox
cpoerschke commented on a change in pull request #176: URL: https://github.com/apache/solr/pull/176#discussion_r651065963 ## File path: solr/core/src/java/org/apache/solr/handler/component/ResponseBuilder.java ## @@ -175,6 +175,23 @@ public void addRequest(SearchComponent me,

[GitHub] [solr] cpoerschke commented on pull request #176: SOLR-15476: Add ResponseBuilder.(newShardsInfo|addShardInfo) methods to facilitate 'shards.info' content customisation.

2021-06-14 Thread GitBox
cpoerschke commented on pull request #176: URL: https://github.com/apache/solr/pull/176#issuecomment-860787505 > I'm having trouble understanding how this is used in practice, can you add a unit test showing an example override implementation? I've placed use illustrations on the JIR

[GitHub] [solr] madrob commented on a change in pull request #176: SOLR-15476: Add ResponseBuilder.(newShardsInfo|addShardInfo) methods to facilitate 'shards.info' content customisation.

2021-06-14 Thread GitBox
madrob commented on a change in pull request #176: URL: https://github.com/apache/solr/pull/176#discussion_r651060611 ## File path: solr/core/src/java/org/apache/solr/handler/component/ResponseBuilder.java ## @@ -175,6 +175,23 @@ public void addRequest(SearchComponent me, Shar

[GitHub] [solr] madrob commented on pull request #176: SOLR-15476: Add ResponseBuilder.(newShardsInfo|addShardInfo) methods to facilitate 'shards.info' content customisation.

2021-06-14 Thread GitBox
madrob commented on pull request #176: URL: https://github.com/apache/solr/pull/176#issuecomment-860783598 I'm having trouble understanding how this is used in practice, can you add a unit test showing an example override implementation? -- This is an automated message from the Apache Gi

[GitHub] [solr] cpoerschke opened a new pull request #176: SOLR-15476: Add ResponseBuilder.(newShardsInfo|addShardInfo) methods to facilitate 'shards.info' content customisation.

2021-06-14 Thread GitBox
cpoerschke opened a new pull request #176: URL: https://github.com/apache/solr/pull/176 SOLR-15476: Add ResponseBuilder.(newShardsInfo|addShardInfo) methods to facilitate 'shards.info' content customisation. https://issues.apache.org/jira/browse/SOLR-15476 -- This is an automated

[jira] [Created] (SOLR-15477) Logging Performance

2021-06-14 Thread Mark Robert Miller (Jira)
Mark Robert Miller created SOLR-15477: - Summary: Logging Performance Key: SOLR-15477 URL: https://issues.apache.org/jira/browse/SOLR-15477 Project: Solr Issue Type: Improvement Secu

[jira] [Commented] (SOLR-15476) Add ResponseBuilder.(newShardsInfo|addShardInfo) methods to facilitate 'shards.info' content customisation.

2021-06-14 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363032#comment-17363032 ] Christine Poerschke commented on SOLR-15476: * customisation illustrations:

[jira] [Commented] (SOLR-15476) Add ResponseBuilder.(newShardsInfo|addShardInfo) methods to facilitate 'shards.info' content customisation.

2021-06-14 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363030#comment-17363030 ] Christine Poerschke commented on SOLR-15476: * solrconfig.xml snippet: {code}

[jira] [Created] (SOLR-15476) Add ResponseBuilder.(newShardsInfo|addShardInfo) methods to facilitate 'shards.info' content customisation.

2021-06-14 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-15476: -- Summary: Add ResponseBuilder.(newShardsInfo|addShardInfo) methods to facilitate 'shards.info' content customisation. Key: SOLR-15476 URL: https://issues.apache.org/jir

[jira] [Created] (SOLR-15475) Solr SQL should support COUNT(distinct field)

2021-06-14 Thread Timothy Potter (Jira)
Timothy Potter created SOLR-15475: - Summary: Solr SQL should support COUNT(distinct field) Key: SOLR-15475 URL: https://issues.apache.org/jira/browse/SOLR-15475 Project: Solr Issue Type: Impr

[jira] [Updated] (SOLR-9963) Add Apache Calcite Avatica handler to Solr

2021-06-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-9963: - Labels: RobustSQL (was: ) > Add Apache Calcite Avatica handler to Solr >

[jira] [Comment Edited] (SOLR-15378) Reproducible failure in TestRestoreCore in branch_8x

2021-06-14 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362986#comment-17362986 ] Jason Gerlowski edited comment on SOLR-15378 at 6/14/21, 2:15 PM: -

[jira] [Commented] (SOLR-15378) Reproducible failure in TestRestoreCore in branch_8x

2021-06-14 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362986#comment-17362986 ] Jason Gerlowski commented on SOLR-15378: Awesome, thanks [~bszabo97]! I wouldn't

[GitHub] [solr] gerlowskija edited a comment on pull request #81: SOLR-15351: Convert /v2/c/ APIs to POJO impl

2021-06-14 Thread GitBox
gerlowskija edited a comment on pull request #81: URL: https://github.com/apache/solr/pull/81#issuecomment-860611843 > BTW I would have reviewed if you prompted me. It was on the back of my mind already. Oh, my bad. I thought about pinging you, but didn't want to be a bother (I'd t

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #20: SOLR-15051 Blob, DRAFT WIP

2021-06-14 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #20: URL: https://github.com/apache/solr/pull/20#discussion_r650963320 ## File path: solr/contrib/blob-directory/build.gradle ## @@ -0,0 +1,27 @@ +/* Review comment: *Moderate OSS Vulnerability:*   ### pkg:mav

[GitHub] [solr] bruno-roustant commented on a change in pull request #108: SOLR-15051: Pull files from the repository when BlobDirectory is created.

2021-06-14 Thread GitBox
bruno-roustant commented on a change in pull request #108: URL: https://github.com/apache/solr/pull/108#discussion_r650928808 ## File path: solr/contrib/blob-directory/src/java/org/apache/solr/blob/BlobStoreConnection.java ## @@ -152,11 +180,66 @@ private void createDirectorie

[GitHub] [solr] bruno-roustant commented on a change in pull request #108: SOLR-15051: Pull files from the repository when BlobDirectory is created.

2021-06-14 Thread GitBox
bruno-roustant commented on a change in pull request #108: URL: https://github.com/apache/solr/pull/108#discussion_r650927486 ## File path: solr/contrib/blob-directory/src/java/org/apache/solr/blob/BlobStoreConnection.java ## @@ -166,4 +249,12 @@ public void close() { T

[GitHub] [solr] bruno-roustant commented on a change in pull request #108: SOLR-15051: Pull files from the repository when BlobDirectory is created.

2021-06-14 Thread GitBox
bruno-roustant commented on a change in pull request #108: URL: https://github.com/apache/solr/pull/108#discussion_r650926535 ## File path: solr/contrib/blob-directory/src/java/org/apache/solr/blob/BlobStoreConnection.java ## @@ -152,11 +180,66 @@ private void createDirectorie

[GitHub] [solr] bruno-roustant commented on a change in pull request #108: SOLR-15051: Pull files from the repository when BlobDirectory is created.

2021-06-14 Thread GitBox
bruno-roustant commented on a change in pull request #108: URL: https://github.com/apache/solr/pull/108#discussion_r650913372 ## File path: solr/contrib/blob-directory/src/java/org/apache/solr/blob/BlobStoreConnection.java ## @@ -26,21 +29,30 @@ import java.io.Closeable; i

[GitHub] [solr] bruno-roustant commented on a change in pull request #108: SOLR-15051: Pull files from the repository when BlobDirectory is created.

2021-06-14 Thread GitBox
bruno-roustant commented on a change in pull request #108: URL: https://github.com/apache/solr/pull/108#discussion_r650910694 ## File path: solr/contrib/blob-directory/src/test/org/apache/solr/blob/BlobDirectoryTest.java ## @@ -190,4 +211,23 @@ private void checkFileContent(St

[jira] [Commented] (SOLR-15371) Backups randomly fail sometimes

2021-06-14 Thread Roy Perkins (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362924#comment-17362924 ] Roy Perkins commented on SOLR-15371: Problem still persists in 8.8.2.  Have tried sev

[jira] [Updated] (SOLR-15371) Backups randomly fail sometimes

2021-06-14 Thread Roy Perkins (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roy Perkins updated SOLR-15371: --- Affects Version/s: (was: 8.5.2) 8.8.2 > Backups randomly fail sometimes >

[GitHub] [solr] gerlowskija commented on pull request #81: SOLR-15351: Convert /v2/c/ APIs to POJO impl

2021-06-14 Thread GitBox
gerlowskija commented on pull request #81: URL: https://github.com/apache/solr/pull/81#issuecomment-860611843 > BTW I would have reviewed if you prompted me. It was on the back of my mind already. Oh, my bad. I thought about pinging you, but didn't want to be a bother (I'd tagged y

[jira] [Commented] (SOLR-15378) Reproducible failure in TestRestoreCore in branch_8x

2021-06-14 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362863#comment-17362863 ] Bence Szabó commented on SOLR-15378: I have opened a PR for this which adds the menti

[GitHub] [solr] NazerkeBS commented on pull request #17: SOLR-14341: Move configName into DocCollection class

2021-06-14 Thread GitBox
NazerkeBS commented on pull request #17: URL: https://github.com/apache/solr/pull/17#issuecomment-860184768 I tested backward compatibility manually in my local env. Initially I started solr `8.8.2` with embedded zk cluster and I created a collection with sample_techproducts_configs. Th

[GitHub] [solr] cpoerschke commented on a change in pull request #166: SOLR-15450 add PrefetchingFieldValueFeature

2021-06-14 Thread GitBox
cpoerschke commented on a change in pull request #166: URL: https://github.com/apache/solr/pull/166#discussion_r650443475 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/PrefetchingFieldValueFeature.java ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache S

[GitHub] [solr] madrob commented on a change in pull request #169: SOLR-15385 RawTypes Part III, contrib and solrj

2021-06-14 Thread GitBox
madrob commented on a change in pull request #169: URL: https://github.com/apache/solr/pull/169#discussion_r650535730 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/beans/DocumentObjectBinder.java ## @@ -408,28 +406,28 @@ private Object getFieldValue(SolrDocume

[GitHub] [solr] dsmiley opened a new pull request #175: SOLR-15185: fix hashCode

2021-06-14 Thread GitBox
dsmiley opened a new pull request #175: URL: https://github.com/apache/solr/pull/175 https://issues.apache.org/jira/browse/SOLR-15185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [solr] dsmiley commented on pull request #175: SOLR-15185: fix hashCode

2021-06-14 Thread GitBox
dsmiley commented on pull request #175: URL: https://github.com/apache/solr/pull/175#issuecomment-860093197 @joel-bernstein Interestingly I couldn't make you an official reviewer in GitHub. Any way, I think this PR fixes the issue. I ran the test with both seeds in https://issues.

[GitHub] [solr] NazerkeBS commented on a change in pull request #17: SOLR-14341: Move configName into DocCollection class

2021-06-14 Thread GitBox
NazerkeBS commented on a change in pull request #17: URL: https://github.com/apache/solr/pull/17#discussion_r650494573 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java ## @@ -560,10 +559,16 @@ public static void createCollectionZ

[GitHub] [solr] cpoerschke commented on a change in pull request #169: SOLR-15385 RawTypes Part III, contrib and solrj

2021-06-14 Thread GitBox
cpoerschke commented on a change in pull request #169: URL: https://github.com/apache/solr/pull/169#discussion_r650383669 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/DbscanEvaluator.java ## @@ -90,8 +88,7 @@ public Object doWork(Object... values) thr

[GitHub] [solr] tomglk commented on pull request #166: SOLR-15450 add PrefetchingFieldValueFeature

2021-06-14 Thread GitBox
tomglk commented on pull request #166: URL: https://github.com/apache/solr/pull/166#issuecomment-860246850 Hi @cpoerschke , rereading our conversation over the last two days made clear that we have quite some open constructions sites. To not lose the overview about them (especially wi

[GitHub] [solr] cpoerschke edited a comment on pull request #169: SOLR-15385 RawTypes Part III, contrib and solrj

2021-06-14 Thread GitBox
cpoerschke edited a comment on pull request #169: URL: https://github.com/apache/solr/pull/169#issuecomment-860038881 Strange, the [mark file as viewed](https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull

[GitHub] [solr] markrmiller commented on a change in pull request #155: SOLR-15438: Simplify SolrDispatchFilter.destroy

2021-06-14 Thread GitBox
markrmiller commented on a change in pull request #155: URL: https://github.com/apache/solr/pull/155#discussion_r650569434 ## File path: solr/core/src/java/org/apache/solr/client/solrj/embedded/JettySolrRunner.java ## @@ -611,27 +608,11 @@ public void stop() throws Exception {

[GitHub] [solr] dsmiley merged pull request #143: SOLR-15044: JSON Loading: nested docs don't need ID

2021-06-14 Thread GitBox
dsmiley merged pull request #143: URL: https://github.com/apache/solr/pull/143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please cont

[GitHub] [solr] tomglk commented on a change in pull request #166: SOLR-15450 add PrefetchingFieldValueFeature

2021-06-14 Thread GitBox
tomglk commented on a change in pull request #166: URL: https://github.com/apache/solr/pull/166#discussion_r650366702 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/PrefetchingFieldValueFeature.java ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Softw

[GitHub] [solr] cpoerschke commented on pull request #169: SOLR-15385 RawTypes Part III, contrib and solrj

2021-06-14 Thread GitBox
cpoerschke commented on pull request #169: URL: https://github.com/apache/solr/pull/169#issuecomment-860038881 Strange, the [mark file as viewed](https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-reques

[GitHub] [solr-operator] HoustonPutman opened a new pull request #275: Various small fixes for the tutorial and upgrade notes.

2021-06-14 Thread GitBox
HoustonPutman opened a new pull request #275: URL: https://github.com/apache/solr-operator/pull/275 Thanks @thelabdude and @sigram for noticing the issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [solr] cpoerschke commented on a change in pull request #162: SOLR-14920: contrib/jaegertracer-configurator: apply & enforce 'spotless' code formatting

2021-06-14 Thread GitBox
cpoerschke commented on a change in pull request #162: URL: https://github.com/apache/solr/pull/162#discussion_r650094150 ## File path: solr/contrib/jaegertracer-configurator/src/java/org/apache/solr/jaeger/JaegerTracerConfigurator.java ## @@ -31,7 +31,5 @@ public Tracer getTr

[GitHub] [solr] dsmiley commented on pull request #81: SOLR-15351: Convert /v2/c/ APIs to POJO impl

2021-06-14 Thread GitBox
dsmiley commented on pull request #81: URL: https://github.com/apache/solr/pull/81#issuecomment-859841902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [solr] wrunderwood commented on pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2021-06-14 Thread GitBox
wrunderwood commented on pull request #96: URL: https://github.com/apache/solr/pull/96#issuecomment-859667485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries ab

[GitHub] [solr] atris commented on a change in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2021-06-14 Thread GitBox
atris commented on a change in pull request #96: URL: https://github.com/apache/solr/pull/96#discussion_r650081537 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java ## @@ -40,12 +41,15 @@ * solution. There will be a follow up wit

[GitHub] [solr] cpoerschke commented on a change in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2021-06-14 Thread GitBox
cpoerschke commented on a change in pull request #96: URL: https://github.com/apache/solr/pull/96#discussion_r650089050 ## File path: solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java ## @@ -40,12 +41,15 @@ * solution. There will be a follow u

[GitHub] [solr-operator] HoustonPutman merged pull request #275: Various small fixes for the tutorial and upgrade notes.

2021-06-14 Thread GitBox
HoustonPutman merged pull request #275: URL: https://github.com/apache/solr-operator/pull/275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servi

[GitHub] [solr] piuma commented on pull request #170: SOLR-15469: start/stop script fails on multiple instances

2021-06-14 Thread GitBox
piuma commented on pull request #170: URL: https://github.com/apache/solr/pull/170#issuecomment-859602284 @madrob I don't know because I don't use windows, sorry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

  1   2   >