cpoerschke commented on a change in pull request #176:
URL: https://github.com/apache/solr/pull/176#discussion_r651065963
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/ResponseBuilder.java
##########
@@ -175,6 +175,23 @@ public void addRequest(SearchComponent me, ShardRequest
sreq) {
}
}
+ /**
+ * Override this method and the {@link ResponseBuilder#addShardInfo(Object,
String, NamedList)}
+ * method e.g. if you wish to return a list instead of a map container.
+ */
+ protected Object newShardsInfo() {
Review comment:
> Should this return some interface instead of an Object?
Yes, that's a good idea, thank you. It would also avoid the _"if you changed
this method you must also change the other method"_ stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
