[GitHub] [solr] tomglk commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

2021-05-27 Thread GitBox
tomglk commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r641305470 ## File path: solr/core/src/java/org/apache/solr/handler/component/ShardFieldSortedHitQueueWithSameShardCompareSkip.java ## @@ -0,0 +1,48 @@ +/* + * Licensed t

[jira] [Commented] (SOLR-15241) Mention Docker in main README file

2021-05-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352959#comment-17352959 ] David Smiley commented on SOLR-15241: - BTW you needn't create JIRA issues for this ki

[GitHub] [solr] dsmiley commented on a change in pull request #135: SOLR-15421 ConfigSetService.checkConfigExists accepts empty configs

2021-05-27 Thread GitBox
dsmiley commented on a change in pull request #135: URL: https://github.com/apache/solr/pull/135#discussion_r641221511 ## File path: solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java ## @@ -62,7 +62,12 @@ public String configSetName(CoreDescriptor cd) {

[GitHub] [solr] dsmiley opened a new pull request #155: SOLR-15438: Simplify SolrDispatchFilter.destroy

2021-05-27 Thread GitBox
dsmiley opened a new pull request #155: URL: https://github.com/apache/solr/pull/155 and JettySolrRunner.stop. CoreContainer.shutdown should no-op if already shut down. Don't null out things; not needed. closeOnDestroy not needed Use FilterHolder.stop; simplifies our logic.

[GitHub] [solr] cpoerschke commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

2021-05-27 Thread GitBox
cpoerschke commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r640946517 ## File path: solr/core/src/java/org/apache/solr/handler/component/ShardFieldSortedHitQueueWithSameShardCompareSkip.java ## @@ -0,0 +1,48 @@ +/* + * Licens

[jira] [Commented] (SOLR-15442) Syncronize the port and host variables for Solr

2021-05-27 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352705#comment-17352705 ] Anshum Gupta commented on SOLR-15442: - I really like this, Houston. It standardizes

[jira] [Created] (SOLR-15442) Syncronize the port and host variables for Solr

2021-05-27 Thread Houston Putman (Jira)
Houston Putman created SOLR-15442: - Summary: Syncronize the port and host variables for Solr Key: SOLR-15442 URL: https://issues.apache.org/jira/browse/SOLR-15442 Project: Solr Issue Type: Im

[jira] [Resolved] (SOLR-15256) Unable to see features and models uploaded to SOLR LTRInbox

2021-05-27 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-15256. Resolution: Information Provided Thanks [~kaessmann] for sharing re: your solr-dock

[jira] [Assigned] (SOLR-12697) pure DocValues support for FieldValueFeature

2021-05-27 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke reassigned SOLR-12697: -- Assignee: Christine Poerschke > pure DocValues support for FieldValueFeature >

[jira] [Commented] (SOLR-12697) pure DocValues support for FieldValueFeature

2021-05-27 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352670#comment-17352670 ] Christine Poerschke commented on SOLR-12697: w.r.t. the _"FieldValueFeature s

[jira] [Commented] (SOLR-12697) pure DocValues support for FieldValueFeature

2021-05-27 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352666#comment-17352666 ] Christine Poerschke commented on SOLR-12697: Hi [~TomGilke], thanks for the q

[jira] [Commented] (SOLR-7976) Jetty http and https connectors use different property names for host/port

2021-05-27 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352615#comment-17352615 ] Houston Putman commented on SOLR-7976: -- {{solr.jetty.host}} is now the solr binding h

[jira] [Commented] (SOLR-7977) SOLR_HOST in solr.in.sh doesn't apply to Jetty's host property

2021-05-27 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352604#comment-17352604 ] Houston Putman commented on SOLR-7977: -- Ah, so just looked and apparently when Gus in

[jira] [Commented] (SOLR-15256) Unable to see features and models uploaded to SOLR LTRInbox

2021-05-27 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352549#comment-17352549 ] Tobias Kässmann commented on SOLR-15256: Hey [~beviah], we run successfully LTR b

[jira] [Comment Edited] (SOLR-15437) ReRanking/LTR does not work in combination with custom sort and SolrCloud

2021-05-27 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352531#comment-17352531 ] Tobias Kässmann edited comment on SOLR-15437 at 5/27/21, 2:39 PM: -

[jira] [Commented] (SOLR-15437) ReRanking/LTR does not work in combination with custom sort and SolrCloud

2021-05-27 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352531#comment-17352531 ] Tobias Kässmann commented on SOLR-15437: [~TomGilke], [~tboeghk] and I submitted

[jira] [Updated] (SOLR-15441) Solr.cmd fails when SOLR_LOGS_DIR contains a space

2021-05-27 Thread Jelle Bekker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jelle Bekker updated SOLR-15441: Description: When the SOLR_LOGS_DIR (set through an environment variable) contains a space, the so

[jira] [Updated] (SOLR-15441) Solr.cmd fails when SOLR_LOGS_DIR contains a space

2021-05-27 Thread Jelle Bekker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jelle Bekker updated SOLR-15441: Priority: Minor (was: Major) > Solr.cmd fails when SOLR_LOGS_DIR contains a space > --

[jira] [Updated] (SOLR-15441) Solr.cmd fails when SOLR_LOGS_DIR contains a space

2021-05-27 Thread Jelle Bekker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jelle Bekker updated SOLR-15441: Attachment: SOLR-15441.patch > Solr.cmd fails when SOLR_LOGS_DIR contains a space > ---

[jira] [Updated] (SOLR-15441) Solr.cmd fails when SOLR_LOGS_DIR contains a space

2021-05-27 Thread Jelle Bekker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jelle Bekker updated SOLR-15441: Description: When the SOLR_LOGS_DIR (set through an environment variable) contains a space, the cm

[jira] [Created] (SOLR-15441) Solr.cmd fails when SOLR_LOGS_DIR contains a space

2021-05-27 Thread Jelle Bekker (Jira)
Jelle Bekker created SOLR-15441: --- Summary: Solr.cmd fails when SOLR_LOGS_DIR contains a space Key: SOLR-15441 URL: https://issues.apache.org/jira/browse/SOLR-15441 Project: Solr Issue Type: Bug

[GitHub] [solr] tomglk commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

2021-05-27 Thread GitBox
tomglk commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r640664451 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ## @@ -999,20 +1013,34 @@ protected void mergeIds(ResponseBuilder rb, Sh

[GitHub] [solr] tomglk commented on a change in pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

2021-05-27 Thread GitBox
tomglk commented on a change in pull request #151: URL: https://github.com/apache/solr/pull/151#discussion_r640649136 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ## @@ -999,20 +1013,34 @@ protected void mergeIds(ResponseBuilder rb, Sh

[jira] [Commented] (SOLR-15440) contrib/ltr FieldValueFeature: DocValues use for stored fields

2021-05-27 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352391#comment-17352391 ] Christine Poerschke commented on SOLR-15440: Sketched out below is one way th

[jira] [Created] (SOLR-15440) contrib/ltr FieldValueFeature: DocValues use for stored fields

2021-05-27 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-15440: -- Summary: contrib/ltr FieldValueFeature: DocValues use for stored fields Key: SOLR-15440 URL: https://issues.apache.org/jira/browse/SOLR-15440 Project: Sol

[GitHub] [solr] janhoy opened a new pull request #154: Upgrade jose4j

2021-05-27 Thread GitBox
janhoy opened a new pull request #154: URL: https://github.com/apache/solr/pull/154 https://issues.apache.org/jira/browse/SOLR-15439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (SOLR-15439) Upgrade jose4j to v0.7.7

2021-05-27 Thread Jira
Jan Høydahl created SOLR-15439: -- Summary: Upgrade jose4j to v0.7.7 Key: SOLR-15439 URL: https://issues.apache.org/jira/browse/SOLR-15439 Project: Solr Issue Type: Improvement Security Leve

[GitHub] [solr] janhoy opened a new pull request #153: SOLR-15397 Remove "exemplar" setting for the new zookeeper grafana graph

2021-05-27 Thread GitBox
janhoy opened a new pull request #153: URL: https://github.com/apache/solr/pull/153 https://issues.apache.org/jira/browse/SOLR-15397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Commented] (SOLR-15421) ConfigSetService.checkConfigExists accepts empty configs

2021-05-27 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17352312#comment-17352312 ] Andras Salamon commented on SOLR-15421: --- Uploaded a new version. I removed the conf

[GitHub] [solr] janhoy commented on a change in pull request #116: SOLR-15397 Expose zookeeper status in the exporter, and in grafana da…

2021-05-27 Thread GitBox
janhoy commented on a change in pull request #116: URL: https://github.com/apache/solr/pull/116#discussion_r640362329 ## File path: solr/contrib/prometheus-exporter/conf/grafana-solr-dashboard.json ## @@ -226,6 +226,131 @@ "alignLevel": null } }, +{ +

[GitHub] [solr] asalamon74 commented on a change in pull request #135: SOLR-15421 ConfigSetService.checkConfigExists accepts empty configs

2021-05-27 Thread GitBox
asalamon74 commented on a change in pull request #135: URL: https://github.com/apache/solr/pull/135#discussion_r640361672 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkConfigSetService.java ## @@ -151,6 +151,19 @@ public boolean checkConfigExists(String configName) t