Re: [PR] PARQUET-2471: Add geometry logical type [parquet-format]

2024-12-15 Thread via GitHub
wgtmac commented on PR #240: URL: https://github.com/apache/parquet-format/pull/240#issuecomment-2544597033 @emkornfield The PoC implementations are https://github.com/apache/arrow/pull/43977 and https://github.com/apache/parquet-java/pull/2971 -- This is an automated message from the A

Re: [PR] Simplify Variant shredding and refactor for clarity [parquet-format]

2024-12-15 Thread via GitHub
emkornfield commented on code in PR #461: URL: https://github.com/apache/parquet-format/pull/461#discussion_r1886161262 ## VariantShredding.md: ## @@ -25,290 +25,320 @@ The Variant type is designed to store and process semi-structured data efficiently, even with heterogeneous

Re: [PR] PARQUET-2471: Add geometry logical type [parquet-format]

2024-12-15 Thread via GitHub
emkornfield commented on PR #240: URL: https://github.com/apache/parquet-format/pull/240#issuecomment-2544585774 @wgtmac separate from the spec it might be good to start discussions on what the implementation for GeoParquet might look like (e.g. what new dependencies do we plan on taking on

Re: [PR] GH-473: Add shredding version [parquet-format]

2024-12-15 Thread via GitHub
emkornfield commented on code in PR #474: URL: https://github.com/apache/parquet-format/pull/474#discussion_r1882488101 ## src/main/thrift/parquet.thrift: ## @@ -384,6 +384,11 @@ struct BsonType { * Embedded Variant logical type annotation */ struct VariantType { + // If t