Re: [PR] HDDS-12905. Move field declarations to start of class in ozone-common module [ozone]

2025-04-27 Thread via GitHub
adoroszlai commented on PR #8342: URL: https://github.com/apache/ozone/pull/8342#issuecomment-2833587010 Thanks @ivanzlenko for the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Updated] (HDDS-12905) Rearrange code for ozone-common module

2025-04-27 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12905: Fix Version/s: 2.1.0 Resolution: Done Status: Resolved (was: Patch Availa

Re: [PR] HDDS-12905. Move field declarations to start of class in ozone-common module [ozone]

2025-04-27 Thread via GitHub
adoroszlai merged PR #8342: URL: https://github.com/apache/ozone/pull/8342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

[jira] [Created] (HDDS-12915) Intermittent failure in testCreatePipelineThrowErrorWithDataNodeLimit

2025-04-27 Thread Attila Doroszlai (Jira)
Attila Doroszlai created HDDS-12915: --- Summary: Intermittent failure in testCreatePipelineThrowErrorWithDataNodeLimit Key: HDDS-12915 URL: https://issues.apache.org/jira/browse/HDDS-12915 Project: Ap

[jira] [Updated] (HDDS-12915) Intermittent failure in testCreatePipelineThrowErrorWithDataNodeLimit

2025-04-27 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12915: Description: {code} Tests run: 11, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.811

Re: [PR] HDDS-11658. Skip known tombstones when scanning rocksdb deletedtable in KeyDeletingService [ozone]

2025-04-27 Thread via GitHub
ashishkumar50 commented on PR #7436: URL: https://github.com/apache/ozone/pull/7436#issuecomment-2834046300 @guohao-rosicky are you planning to work on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Resolved] (HDDS-11640) Deletion services in SCM, OM and DN should have consistent metrics

2025-04-27 Thread Tejaskriya Madhan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tejaskriya Madhan resolved HDDS-11640. -- Resolution: Done > Deletion services in SCM, OM and DN should have consistent metrics >

Re: [PR] HDDS-11141. Avoid pipeline Action CLOSE log flood in datanode XceiverServerRatis [ozone]

2025-04-27 Thread via GitHub
priyeshkaratha commented on code in PR #8325: URL: https://github.com/apache/ozone/pull/8325#discussion_r2062945130 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineCloseLogsFlood.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Ap

Re: [PR] HDDS-11141. Avoid pipeline Action CLOSE log flood in datanode XceiverServerRatis [ozone]

2025-04-27 Thread via GitHub
priyeshkaratha commented on code in PR #8325: URL: https://github.com/apache/ozone/pull/8325#discussion_r2062945422 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineCloseLogsFlood.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Ap

Re: [PR] HDDS-11141. Avoid pipeline Action CLOSE log flood in datanode XceiverServerRatis [ozone]

2025-04-27 Thread via GitHub
priyeshkaratha commented on code in PR #8325: URL: https://github.com/apache/ozone/pull/8325#discussion_r2062947950 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineCloseLogsFlood.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Ap

[PR] HDDS-12892. OM Tagging Request is incorrectly setting full path as key name [ozone]

2025-04-27 Thread via GitHub
ivandika3 opened a new pull request, #8345: URL: https://github.com/apache/ozone/pull/8345 ## What changes were proposed in this pull request? These requests S3PutObjectTaggingResponseWithFSO and S3DeleteObjectTaggingRequestWithFSO are setting the key name for FSO bucket keys as full

[jira] [Updated] (HDDS-12892) OM Tagging Request is incorrectly setting full path as key name

2025-04-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-12892: -- Labels: pull-request-available (was: ) > OM Tagging Request is incorrectly setting full path a

Re: [PR] HDDS-12870. Fix listObjects corner cases [ozone]

2025-04-27 Thread via GitHub
Jimmyweng006 commented on code in PR #8307: URL: https://github.com/apache/ozone/pull/8307#discussion_r2062491345 ## hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java: ## @@ -292,6 +294,14 @@ public Response get( return Response.ok

Re: [PR] HDDS-12902. Shutdown executor in CloseContainerCommandHandler and ECReconstructionCoordinator [ozone]

2025-04-27 Thread via GitHub
peterxcli commented on PR #8341: URL: https://github.com/apache/ozone/pull/8341#issuecomment-2833271672 Thanks @jojochuang for the review, @adoroszlai for correcting the title and merging PR! -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] HDDS-12912. Remove deprecated `PipelineManager#closePipeline(Pipeline, boolean)` [ozone]

2025-04-27 Thread via GitHub
adoroszlai commented on PR #8340: URL: https://github.com/apache/ozone/pull/8340#issuecomment-284170 Thanks @chiacyu for the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Commented] (HDDS-12728) [Ozone 2.0] Add Ozone 2.0.0 to compatibility acceptance tests

2025-04-27 Thread Chia-Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947588#comment-17947588 ] Chia-Chuan Yu commented on HDDS-12728: -- [~weichiu]  I'm currently checking on this

Re: [PR] HDDS-12905. Move field declarations to start of class in ozone-common module [ozone]

2025-04-27 Thread via GitHub
ivanzlenko commented on PR #8342: URL: https://github.com/apache/ozone/pull/8342#issuecomment-2833595192 @adoroszlai thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] HDDS-12808. Implement OM entities of lifecycle configurations [ozone]

2025-04-27 Thread via GitHub
ChenSammi merged PR #8275: URL: https://github.com/apache/ozone/pull/8275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apach

[jira] [Resolved] (HDDS-12808) Implement OM entities of lifecycle configurations

2025-04-27 Thread Sammi Chen (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sammi Chen resolved HDDS-12808. --- Fix Version/s: 2.1.0 Resolution: Fixed > Implement OM entities of lifecycle configurations > -

[PR] HDDS-12906. Move field declarations to start of class in ozone-manager module [ozone]

2025-04-27 Thread via GitHub
ivanzlenko opened a new pull request, #8343: URL: https://github.com/apache/ozone/pull/8343 ## What changes were proposed in this pull request? Code for the ozone-manager module made compliant with PMD.FieldDeclarationsShouldBeAtStartOfClass verification rule. It is done before ena

[jira] [Updated] (HDDS-12906) Rearrange code for ozone-manager module

2025-04-27 Thread Ivan Zlenko (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zlenko updated HDDS-12906: --- Status: Patch Available (was: Open) > Rearrange code for ozone-manager module >

Re: [PR] HDDS-12878. Move field declarations to start of class in tests [ozone]

2025-04-27 Thread via GitHub
adoroszlai commented on code in PR #8308: URL: https://github.com/apache/ozone/pull/8308#discussion_r2062526565 ## hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/client/ObjectStoreStub.java: ## @@ -39,6 +39,12 @@ */ public class ObjectStoreStub extends ObjectSto

Re: [PR] HDDS-12878. Move field declarations to start of class in tests [ozone]

2025-04-27 Thread via GitHub
ivanzlenko commented on code in PR #8308: URL: https://github.com/apache/ozone/pull/8308#discussion_r2062625934 ## hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/client/ObjectStoreStub.java: ## @@ -39,6 +39,12 @@ */ public class ObjectStoreStub extends ObjectSto

Re: [PR] HDDS-12878. Move field declarations to start of class in tests [ozone]

2025-04-27 Thread via GitHub
ivanzlenko commented on code in PR #8308: URL: https://github.com/apache/ozone/pull/8308#discussion_r2062626101 ## hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/lock/TestOzoneLockProvider.java: ## @@ -42,6 +42,10 @@ public class TestOzoneLockProvider { p

[PR] HDDS-12905. Move field declarations to start of class in ozone-common module [ozone]

2025-04-27 Thread via GitHub
ivanzlenko opened a new pull request, #8342: URL: https://github.com/apache/ozone/pull/8342 ## What changes were proposed in this pull request? Code for the ozone-common module made compliant with PMD.FieldDeclarationsShouldBeAtStartOfClass verification rule. It is done before enab

[jira] [Updated] (HDDS-12903) Separate OM namespace and blockspace into separate Column Families

2025-04-27 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-12903: --- Description: Currently when OM list keys, it needs to create a RocksDB iterator which will load both

[jira] [Updated] (HDDS-12905) Rearrange code for ozone-common module

2025-04-27 Thread Ivan Zlenko (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zlenko updated HDDS-12905: --- Status: Patch Available (was: Open) > Rearrange code for ozone-common module > -

Re: [PR] HDDS-12912. Remove deprecated `PipelineManager#closePipeline(Pipeline, boolean)` [ozone]

2025-04-27 Thread via GitHub
adoroszlai merged PR #8340: URL: https://github.com/apache/ozone/pull/8340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

Re: [PR] HDDS-12889. Enable AppendCharacterWithChar PMD rule [ozone]

2025-04-27 Thread via GitHub
ivanzlenko commented on PR #8324: URL: https://github.com/apache/ozone/pull/8324#issuecomment-2833362463 @adoroszlai thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] HDDS-12870. Fix listObjects corner cases [ozone]

2025-04-27 Thread via GitHub
Jimmyweng006 commented on code in PR #8307: URL: https://github.com/apache/ozone/pull/8307#discussion_r2062571621 ## hadoop-ozone/dist/src/main/smoketest/s3/maxkeys_validation.robot: ## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# con

Re: [PR] HDDS-12904. Move field declarations to start of class in hdds modules [ozone]

2025-04-27 Thread via GitHub
ivanzlenko commented on PR #8336: URL: https://github.com/apache/ozone/pull/8336#issuecomment-2833362599 @adoroszlai thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] HDDS-12907. Enable FieldDeclarationsShouldBeAtStartOfClass PMD rule [ozone]

2025-04-27 Thread via GitHub
ivanzlenko opened a new pull request, #8344: URL: https://github.com/apache/ozone/pull/8344 ## What changes were proposed in this pull request? This PR enables FieldDeclarationsShouldBeAtStartOfClass PMD rule and provides fixes for all remaining issues. ## What is the link to t

[jira] [Assigned] (HDDS-12606) Enable UnusedFormalParameter check in PMD

2025-04-27 Thread Ivan Zlenko (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zlenko reassigned HDDS-12606: -- Assignee: Ivan Zlenko (was: Maksim Myskov) > Enable UnusedFormalParameter check in PMD >

[jira] [Assigned] (HDDS-12605) Enable UnusedAssignment check in PMD

2025-04-27 Thread Ivan Zlenko (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zlenko reassigned HDDS-12605: -- Assignee: Ivan Zlenko (was: Maksim Myskov) > Enable UnusedAssignment check in PMD > -

Re: [PR] HDDS-12878. Move field declarations to start of class in tests [ozone]

2025-04-27 Thread via GitHub
adoroszlai merged PR #8308: URL: https://github.com/apache/ozone/pull/8308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

Re: [PR] HDDS-12878. Move field declarations to start of class in tests [ozone]

2025-04-27 Thread via GitHub
adoroszlai commented on PR #8308: URL: https://github.com/apache/ozone/pull/8308#issuecomment-2833537987 Thanks @ivanzlenko for the patch, @myskov for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HDDS-12878. Move field declarations to start of class in tests [ozone]

2025-04-27 Thread via GitHub
ivanzlenko commented on PR #8308: URL: https://github.com/apache/ozone/pull/8308#issuecomment-2833538339 @adoroszlai @myskov thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (HDDS-12878) Rearrange code in test files

2025-04-27 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12878: Fix Version/s: 2.1.0 Resolution: Done Status: Resolved (was: Patch Availa

[jira] [Updated] (HDDS-12906) Rearrange code for ozone-manager module

2025-04-27 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12906: Fix Version/s: 2.1.0 Resolution: Done Status: Resolved (was: Patch Availa

Re: [PR] HDDS-12906. Move field declarations to start of class in ozone-manager module [ozone]

2025-04-27 Thread via GitHub
adoroszlai commented on PR #8343: URL: https://github.com/apache/ozone/pull/8343#issuecomment-2833563097 Thanks @ivanzlenko for the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] HDDS-12906. Move field declarations to start of class in ozone-manager module [ozone]

2025-04-27 Thread via GitHub
adoroszlai merged PR #8343: URL: https://github.com/apache/ozone/pull/8343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

Re: [PR] HDDS-12906. Move field declarations to start of class in ozone-manager module [ozone]

2025-04-27 Thread via GitHub
ivanzlenko commented on PR #8343: URL: https://github.com/apache/ozone/pull/8343#issuecomment-2833570748 @adoroszlai thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Updated] (HDDS-12892) OM Tagging Request is incorrectly setting full path as key name

2025-04-27 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-12892: --- Summary: OM Tagging Request is incorrectly setting full path as key name (was: S3PutObjectTaggingRes

Re: [PR] HDDS-12848. Create new submodule for ozone admin [ozone]

2025-04-27 Thread via GitHub
nandakumar131 commented on PR #8292: URL: https://github.com/apache/ozone/pull/8292#issuecomment-2834093597 The initial idea for having separate block space layer (HDDS) is so that we can write multiple namespace layer (like OzoneManager) on top of HDDS layer to provide different services.

Re: [PR] HDDS-12900. Use OMDBDefinition in OmMetadataManagerImpl. [ozone]

2025-04-27 Thread via GitHub
adoroszlai commented on code in PR #8337: URL: https://github.com/apache/ozone/pull/8337#discussion_r2062696846 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java: ## @@ -257,61 +260,73 @@ public class OmMetadataManagerImpl implemen

Re: [PR] HDDS-12346 Reduce code duplication among TestNSSummaryTask classes [ozone]

2025-04-27 Thread via GitHub
priyeshkaratha commented on PR #8287: URL: https://github.com/apache/ozone/pull/8287#issuecomment-2834028640 Thanks @ArafatKhan2198 for the review. @devmadhuu can you review and merge the changes? -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] HDDS-12900. Use OMDBDefinition in OmMetadataManagerImpl. [ozone]

2025-04-27 Thread via GitHub
szetszwo commented on code in PR #8337: URL: https://github.com/apache/ozone/pull/8337#discussion_r2062727370 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java: ## @@ -257,61 +260,73 @@ public class OmMetadataManagerImpl implements