Re: [PR] HDDS-12413. Make hdds-container-service compliant with FieldDeclarationsShouldBeAtStartOfClass [ozone]

2025-04-17 Thread via GitHub
ivanzlenko commented on code in PR #7968: URL: https://github.com/apache/ozone/pull/7968#discussion_r2049238524 ## hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/ScmTestMock.java: ## @@ -57,6 +57,15 @@ public class ScmTestMock implements St

Re: [PR] HDDS-12350. Reduce duplication between OmBucketReadWrite tests [ozone]

2025-04-17 Thread via GitHub
adoroszlai commented on PR #8241: URL: https://github.com/apache/ozone/pull/8241#issuecomment-2813430994 Thanks @priyeshkaratha for the patch, @tanvipenumudy for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HDDS-12697. Ozone debug CLI command to display details of a single container [ozone]

2025-04-17 Thread via GitHub
aryangupta1998 commented on code in PR #8264: URL: https://github.com/apache/ozone/pull/8264#discussion_r2049254810 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/containerlog/parser/ContainerDatanodeDatabase.java: ## @@ -233,5 +237,173 @@ private void dropTable(Str

[jira] [Resolved] (HDDS-12350) Reduce duplication between OmBucketReadWrite tests

2025-04-17 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-12350. - Fix Version/s: 2.1.0 Resolution: Done > Reduce duplication between OmBucketReadWri

Re: [PR] HDDS-12583. Skip Fields in protobuf while deserializing protobuf [ozone]

2025-04-17 Thread via GitHub
swamirishi closed pull request #8068: HDDS-12583. Skip Fields in protobuf while deserializing protobuf URL: https://github.com/apache/ozone/pull/8068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HDDS-12350. Reduce duplication between OmBucketReadWrite tests [ozone]

2025-04-17 Thread via GitHub
adoroszlai merged PR #8241: URL: https://github.com/apache/ozone/pull/8241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

Re: [PR] HDDS-12846. Log DatanodeDetails instead of DatanodeDetails.getUuidString [ozone]

2025-04-17 Thread via GitHub
adoroszlai commented on code in PR #8295: URL: https://github.com/apache/ozone/pull/8295#discussion_r2049157035 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java: ## @@ -440,7 +440,7 @@ public RegisteredCommand register( if (upd

[jira] [Updated] (HDDS-12723) Volume scanner should fail volume if rocksDB is inaccessible

2025-04-17 Thread Ethan Rose (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ethan Rose updated HDDS-12723: -- Parent Issue: HDDS-8387 (was: HDDS-12564) > Volume scanner should fail volume if rocksDB is inaccessib

Re: [PR] HDDS-12413. Make hdds-container-service compliant with FieldDeclarationsShouldBeAtStartOfClass [ozone]

2025-04-17 Thread via GitHub
adoroszlai commented on code in PR #7968: URL: https://github.com/apache/ozone/pull/7968#discussion_r2049137118 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/CopyContainerCompression.java: ## @@ -51,18 +51,16 @@ public OutputStream

[jira] [Updated] (HDDS-11734) S3 unit test failures with maven-compiler-plugin 3.10+

2025-04-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-11734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-11734: -- Labels: pull-request-available (was: ) > S3 unit test failures with maven-compiler-plugin 3.10

Re: [PR] HDDS-12413. Make hdds-container-service compliant with FieldDeclarationsShouldBeAtStartOfClass [ozone]

2025-04-17 Thread via GitHub
adoroszlai commented on code in PR #7968: URL: https://github.com/apache/ozone/pull/7968#discussion_r2049137118 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/CopyContainerCompression.java: ## @@ -51,18 +51,16 @@ public OutputStream

Re: [PR] HDDS-12808. Implement OM entities of lifecycle configurations [ozone]

2025-04-17 Thread via GitHub
xichen01 commented on code in PR #8275: URL: https://github.com/apache/ozone/pull/8275#discussion_r2049295419 ## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLCRule.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

Re: [PR] HDDS-12560. Reclaimable Filter for Snaphost Garbage Collections [ozone]

2025-04-17 Thread via GitHub
swamirishi commented on code in PR #8053: URL: https://github.com/apache/ozone/pull/8053#discussion_r2049297466 ## hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/filter/TestAbstractReclaimableFilter.java: ## @@ -0,0 +1,325 @@ +/* + * Licensed to the

Re: [PR] HDDS-12562. Reclaimable Directory entry filter for reclaiming deleted directory entries [ozone]

2025-04-17 Thread via GitHub
swamirishi commented on code in PR #8055: URL: https://github.com/apache/ozone/pull/8055#discussion_r2049311015 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java: ## @@ -731,6 +732,33 @@ public List> getRenamesKeyEntries( } } +

[jira] [Resolved] (HDDS-12840) Avoid long containerId in KeyValueContainer

2025-04-17 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze resolved HDDS-12840. --- Fix Version/s: 2.1.0 Resolution: Fixed The pull request is merged. > Avoid long containerId i

Re: [PR] HDDS-12840. Avoid long containerId in KeyValueContainer [ozone]

2025-04-17 Thread via GitHub
szetszwo commented on PR #8291: URL: https://github.com/apache/ozone/pull/8291#issuecomment-2813513377 @swamirishi , thanks a lot for reviewing this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HDDS-12413. Make hdds-container-service compliant with FieldDeclarationsShouldBeAtStartOfClass [ozone]

2025-04-17 Thread via GitHub
ivanzlenko commented on code in PR #7968: URL: https://github.com/apache/ozone/pull/7968#discussion_r2049352875 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java: ## @@ -627,142 +545,162 @@ public void

Re: [PR] HDDS-4677. Document Ozone Ports and Connection End Points. [ozone]

2025-04-17 Thread via GitHub
szetszwo commented on code in PR #8226: URL: https://github.com/apache/ozone/pull/8226#discussion_r2049342439 ## hadoop-hdds/docs/content/concept/OzonePorts.md: ## @@ -0,0 +1,96 @@ +--- +title: "Network Ports used by Apache Ozone" +date: "2025-04-03" +weight: 9 +menu: + main:

[jira] [Updated] (HDDS-12152) Stop testing with Hadoop 3.1.2

2025-04-17 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12152: Fix Version/s: 2.1.0 Resolution: Done Status: Resolved (was: Patch Availa

[jira] [Resolved] (HDDS-8802) [Snapshot] Implement List SnapshotDiff jobs pagination

2025-04-17 Thread Hemant Kumar (Jira)
[ https://issues.apache.org/jira/browse/HDDS-8802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hemant Kumar resolved HDDS-8802. Target Version/s: 2.1.0 Resolution: Fixed > [Snapshot] Implement List SnapshotDiff jobs pa

Re: [PR] HDDS-8802. Added pagination support for ListSnapshotDiff jobs [ozone]

2025-04-17 Thread via GitHub
hemantk-12 merged PR #8124: URL: https://github.com/apache/ozone/pull/8124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

[jira] [Updated] (HDDS-10555) Add a layout feature before upgrading to RocksDB 9.x

2025-04-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HDDS-10555: --- Epic Link: HDDS-12863 > Add a layout feature before upgrading to RocksDB 9.x > --

[jira] [Updated] (HDDS-12246) Set Compaction priority to MinOverlappingRatio for all column families

2025-04-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HDDS-12246: --- Epic Link: HDDS-12863 (was: HDDS-12189) > Set Compaction priority to MinOverlappingRatio for

[jira] [Updated] (HDDS-12695) Remove BlockBasedTableFormat default values when .ini file configures rocksDB

2025-04-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HDDS-12695: --- Epic Link: HDDS-12863 (was: HDDS-12189) > Remove BlockBasedTableFormat default values when .

[jira] [Updated] (HDDS-12857) Add config option to specify configuration ini files for OM component

2025-04-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HDDS-12857: --- Epic Link: HDDS-12863 (was: HDDS-12189) > Add config option to specify configuration ini fil

[jira] [Updated] (HDDS-12429) Add upper bound ReadOptions to iterator

2025-04-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HDDS-12429: --- Epic Link: HDDS-12863 (was: HDDS-12189) > Add upper bound ReadOptions to iterator >

[jira] [Updated] (HDDS-12392) Update to RocksDB 9

2025-04-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HDDS-12392: --- Epic Link: HDDS-12863 (was: HDDS-12189) > Update to RocksDB 9 > --- > >

Re: [PR] HDDS-11981. Add annotation for registering feature validator based on a generic version [ozone]

2025-04-17 Thread via GitHub
swamirishi commented on PR #7603: URL: https://github.com/apache/ozone/pull/7603#issuecomment-2814177903 @fapifta If you think there are anymore review comments to be addressed can I address them in the next patch? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] HDDS-12207. Unify output of `ozone debug replicas verify` checks [ozone]

2025-04-17 Thread via GitHub
errose28 commented on code in PR #8248: URL: https://github.com/apache/ozone/pull/8248#discussion_r2049743412 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/replicas/ReplicaVerifier.java: ## @@ -17,12 +17,14 @@ package org.apache.hadoop.ozone.debug.replicas

Re: [PR] HDDS-12723. Handle Volume Db failure in volume scanner [ozone]

2025-04-17 Thread via GitHub
errose28 commented on code in PR #8256: URL: https://github.com/apache/ozone/pull/8256#discussion_r2049610694 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java: ## @@ -288,6 +306,40 @@ public synchronized VolumeCheckRe

[jira] [Commented] (HDDS-12189) Improve RocksDB compaction in Ozone

2025-04-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945489#comment-17945489 ] Wei-Chiu Chuang commented on HDDS-12189: I'm putting a closure on this epic. Most

[jira] [Updated] (HDDS-12484) Allow ColumnFamilyOptions to be configured through ini files for RocksDB

2025-04-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HDDS-12484: --- Status: Patch Available (was: Open) > Allow ColumnFamilyOptions to be configured through ini

Re: [PR] HDDS-12742. Make RDBStoreAbstractIterator Return Reference-Counted KeyValues to Improve Consistency and Performance [ozone]

2025-04-17 Thread via GitHub
swamirishi commented on code in PR #8203: URL: https://github.com/apache/ozone/pull/8203#discussion_r2049491576 ## hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreAbstractIterator.java: ## @@ -78,32 +82,44 @@ final RAW getPrefix() { @Override

[jira] [Commented] (HDDS-12695) Remove BlockBasedTableFormat default values when .ini file configures rocksDB

2025-04-17 Thread Jira
[ https://issues.apache.org/jira/browse/HDDS-12695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945363#comment-17945363 ] Szabolcs Gál commented on HDDS-12695: - [~kiruozone] Are you plan to work on this? Upd

[jira] [Updated] (HDDS-12347) Fix spotbugs warnings in integration tests

2025-04-17 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12347: Target Version/s: 2.1.0 > Fix spotbugs warnings in integration tests >

[jira] [Updated] (HDDS-12858) Add config option to specify configuration ini files for SCM component

2025-04-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HDDS-12858: --- Epic Link: HDDS-12863 (was: HDDS-12189) > Add config option to specify configuration ini fil

[jira] [Updated] (HDDS-12208) Give `ozone debug replicas verify` options for OM container location cache behavior

2025-04-17 Thread Ethan Rose (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ethan Rose updated HDDS-12208: -- Summary: Give `ozone debug replicas verify` options for OM container location cache behavior (was: Add

[jira] [Updated] (HDDS-12834) Improve performance of auto-compaction of tables by the background service.

2025-04-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HDDS-12834: --- Epic Link: HDDS-12863 (was: HDDS-12189) > Improve performance of auto-compaction of tables b

[jira] [Updated] (HDDS-12850) Compact tables by priority in the background service

2025-04-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HDDS-12850: --- Epic Link: HDDS-12863 (was: HDDS-12189) > Compact tables by priority in the background servi

[jira] [Created] (HDDS-12860) Find a centralized way to pick the IP for each service in acceptance test cluster

2025-04-17 Thread Peter Lee (Jira)
Peter Lee created HDDS-12860: Summary: Find a centralized way to pick the IP for each service in acceptance test cluster Key: HDDS-12860 URL: https://issues.apache.org/jira/browse/HDDS-12860 Project: Apac

Re: [PR] HDDS-12113. Move HAProxy test to HA environment [ozone]

2025-04-17 Thread via GitHub
peterxcli commented on PR #8271: URL: https://github.com/apache/ozone/pull/8271#issuecomment-2811999135 > @peterxcli Thanks for the improvement. LGTM +1. Just left one nit. > > Not familiar with HAProxy configuration, but all the IP mappings looks good. > > It will be nice if w

Re: [PR] HDDS-12113. Move HAProxy test to HA environment [ozone]

2025-04-17 Thread via GitHub
ivandika3 commented on code in PR #8271: URL: https://github.com/apache/ozone/pull/8271#discussion_r2048191740 ## hadoop-ozone/dist/src/main/compose/ozone-ha/test-haproxy-s3g.sh: ## @@ -15,16 +15,26 @@ # See the License for the specific language governing permissions and # lim

Re: [PR] HDDS-10284. Replace GenericTestUtils temp dir in MiniOzoneCluster [ozone]

2025-04-17 Thread via GitHub
myskov commented on code in PR #8300: URL: https://github.com/apache/ozone/pull/8300#discussion_r2050135430 ## hadoop-hdds/test-utils/src/test/java/org/apache/ozone/test/GenericTestUtils.java: ## @@ -133,7 +107,7 @@ public static String getTempPath(String subpath) { * @throw

Re: [PR] HDDS-11734. Bump maven-compiler-plugin to 3.14.0 [ozone]

2025-04-17 Thread via GitHub
adoroszlai commented on code in PR #8299: URL: https://github.com/apache/ozone/pull/8299#discussion_r2050092639 ## hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java: ## @@ -277,6 +277,7 @@ public final class OzoneConsts { public static final String S3_

[jira] [Updated] (HDDS-12413) Move field declarations to start of class in hdds-container-service

2025-04-17 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12413: Summary: Move field declarations to start of class in hdds-container-service (was: Rearran

Re: [PR] HDDS-12413. Move field declarations to start of class in hdds-container-service [ozone]

2025-04-17 Thread via GitHub
adoroszlai merged PR #7968: URL: https://github.com/apache/ozone/pull/7968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

[jira] [Updated] (HDDS-12413) Rearrange code accordingly in hdds-container-service

2025-04-17 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12413: Fix Version/s: 2.1.0 Resolution: Done Status: Resolved (was: Patch Availa

[jira] [Updated] (HDDS-12347) Fix spotbugs warnings in integration tests

2025-04-17 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12347: Status: Patch Available (was: In Progress) > Fix spotbugs warnings in integration tests >

Re: [PR] HDDS-11409. Bump pipeline and client cache configuration defaults [ozone]

2025-04-17 Thread via GitHub
github-actions[bot] closed pull request #7151: HDDS-11409. Bump pipeline and client cache configuration defaults URL: https://github.com/apache/ozone/pull/7151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (HDDS-7000) Create CI troubleshooting guide

2025-04-17 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-7000. Resolution: Won't Do I guess Copilot is useful for that. https://docs.github.com/en/actions

Re: [PR] HDDS-12152. Stop testing with Hadoop 3.1.2 [ozone]

2025-04-17 Thread via GitHub
jojochuang merged PR #7773: URL: https://github.com/apache/ozone/pull/7773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

Re: [PR] HDDS-11734. Bump maven-compiler-plugin to 3.14.0 [ozone]

2025-04-17 Thread via GitHub
Jimmyweng006 commented on PR #8299: URL: https://github.com/apache/ozone/pull/8299#issuecomment-2813608075 Sure let me add it, thanks for remind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Assigned] (HDDS-12394) config browser does not reflect reconfigured values

2025-04-17 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai reassigned HDDS-12394: --- Assignee: Roland Elek (was: Attila Doroszlai) > config browser does not reflect rec

Re: [PR] HDDS-11734. Bump maven-compiler-plugin to 3.14.0 [ozone]

2025-04-17 Thread via GitHub
adoroszlai commented on code in PR #8299: URL: https://github.com/apache/ozone/pull/8299#discussion_r2049398760 ## hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ListMultipartUploadsResult.java: ## @@ -27,13 +27,14 @@ import javax.xml.bind.annotation.a

Re: [PR] HDDS-11650. ContainerId list to track all containers created in a datanode [ozone]

2025-04-17 Thread via GitHub
swamirishi commented on code in PR #7402: URL: https://github.com/apache/ozone/pull/7402#discussion_r2049404842 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerSet.java: ## @@ -85,22 +103,64 @@ public void setRecoveringTimeou

Re: [PR] HDDS-11650. ContainerId list to track all containers created in a datanode [ozone]

2025-04-17 Thread via GitHub
swamirishi commented on code in PR #7402: URL: https://github.com/apache/ozone/pull/7402#discussion_r2049404842 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerSet.java: ## @@ -85,22 +103,64 @@ public void setRecoveringTimeou

Re: [PR] HDDS-12742. Make RDBStoreAbstractIterator Return Reference-Counted KeyValues to Improve Consistency and Performance [ozone]

2025-04-17 Thread via GitHub
swamirishi commented on PR #8203: URL: https://github.com/apache/ozone/pull/8203#issuecomment-2813656612 > > ThreadLocal will not work. > > It will work. > > > Moreover ThreadLocal will end up creating too many buffers which IMO is very wasteful. > > No, it won't. >

[jira] [Assigned] (HDDS-12656) Description is empty in config browser

2025-04-17 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai reassigned HDDS-12656: --- Assignee: Roland Elek (was: Attila Doroszlai) > Description is empty in config brow

Re: [PR] HDDS-12152. Stop testing with Hadoop 3.1.2 [ozone]

2025-04-17 Thread via GitHub
adoroszlai commented on PR #7773: URL: https://github.com/apache/ozone/pull/7773#issuecomment-2813629590 Thanks @jojochuang for reviewing and merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HDDS-12742. Make RDBStoreAbstractIterator Return Reference-Counted KeyValues to Improve Consistency and Performance [ozone]

2025-04-17 Thread via GitHub
swamirishi commented on code in PR #8203: URL: https://github.com/apache/ozone/pull/8203#discussion_r2047944009 ## hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreCodecBufferIterator.java: ## @@ -84,38 +92,77 @@ CodecBuffer getFromDb() { } }

Re: [PR] HDDS-12742. Make RDBStoreAbstractIterator Return Reference-Counted KeyValues to Improve Consistency and Performance [ozone]

2025-04-17 Thread via GitHub
swamirishi commented on code in PR #8203: URL: https://github.com/apache/ozone/pull/8203#discussion_r2049431347 ## hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreAbstractIterator.java: ## @@ -78,32 +82,44 @@ final RAW getPrefix() { @Override

Re: [PR] HDDS-12704. Add missing audit logs for SCM client operations [ozone]

2025-04-17 Thread via GitHub
adoroszlai merged PR #8251: URL: https://github.com/apache/ozone/pull/8251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

Re: [PR] HDDS-12704. Add missing audit logs for SCM client operations [ozone]

2025-04-17 Thread via GitHub
adoroszlai commented on PR #8251: URL: https://github.com/apache/ozone/pull/8251#issuecomment-2813713424 Thanks @priyeshkaratha for the patch, @peterxcli for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Resolved] (HDDS-12704) Ensure SCM access logged to audit

2025-04-17 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-12704. - Fix Version/s: 2.1.0 Resolution: Fixed > Ensure SCM access logged to audit > -

[jira] [Updated] (HDDS-12254) Enable RocksDB auto compaction upon deletion threshold

2025-04-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HDDS-12254: --- Epic Link: HDDS-12863 (was: HDDS-12189) > Enable RocksDB auto compaction upon deletion thres

Re: [PR] HDDS-12560. Reclaimable Filter for Snaphost Garbage Collections [ozone]

2025-04-17 Thread via GitHub
swamirishi commented on code in PR #8053: URL: https://github.com/apache/ozone/pull/8053#discussion_r2049227618 ## hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/util/CheckedFunction.java: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] HDDS-11734. S3 unit test failures with maven-compiler-plugin 3.10+ [ozone]

2025-04-17 Thread via GitHub
adoroszlai commented on code in PR #8299: URL: https://github.com/apache/ozone/pull/8299#discussion_r2049068895 ## pom.xml: ## @@ -148,7 +148,7 @@ 3.7.1 3.6.0 3.4.0 -3.9.0 +3.10.0 Review Comment: Let's try bumping to the latest version: ```sugge

[jira] [Updated] (HDDS-12862) Recon frontend build may not be reproducible

2025-04-17 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12862: Attachment: repro.log build.log > Recon frontend build may not be reproduci

Re: [PR] HDDS-12742. Make RDBStoreAbstractIterator Return Reference-Counted KeyValues to Improve Consistency and Performance [ozone]

2025-04-17 Thread via GitHub
szetszwo commented on code in PR #8203: URL: https://github.com/apache/ozone/pull/8203#discussion_r2049466909 ## hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreAbstractIterator.java: ## @@ -78,32 +82,44 @@ final RAW getPrefix() { @Override pu

Re: [PR] HDDS-11734. Bump maven-compiler-plugin to 3.14.0 [ozone]

2025-04-17 Thread via GitHub
ivandika3 commented on code in PR #8299: URL: https://github.com/apache/ozone/pull/8299#discussion_r2049929222 ## hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/CompleteMultipartUploadRequest.java: ## @@ -51,10 +51,10 @@ public void setPartList(List par

Re: [PR] HDDS-11734. Bump maven-compiler-plugin to 3.14.0 [ozone]

2025-04-17 Thread via GitHub
ivandika3 commented on code in PR #8299: URL: https://github.com/apache/ozone/pull/8299#discussion_r2049922694 ## hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java: ## @@ -277,6 +277,7 @@ public final class OzoneConsts { public static final String S3_G

Re: [PR] HDDS-7417. [Design] Ozone Transparent Data Compression Support [ozone]

2025-04-17 Thread via GitHub
github-actions[bot] closed pull request #3890: HDDS-7417. [Design] Ozone Transparent Data Compression Support URL: https://github.com/apache/ozone/pull/3890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HDDS-11734. Bump maven-compiler-plugin to 3.14.0 [ozone]

2025-04-17 Thread via GitHub
ivandika3 commented on PR #8299: URL: https://github.com/apache/ozone/pull/8299#issuecomment-2814401132 I also noticed that we already set the `@XmlSchema` annotations, which should have automatically annotated all the XML related with the default namespace. Not sure why the default namespa

Re: [PR] HDDS-12561. Reclaimable Rename entry filter for reclaiming renaming entries [ozone]

2025-04-17 Thread via GitHub
swamirishi commented on code in PR #8054: URL: https://github.com/apache/ozone/pull/8054#discussion_r2049302520 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/filter/ReclaimableRenameEntryFilter.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the A

Re: [PR] HDDS-11403. PartialTableCache optimize for cleanup [ozone]

2025-04-17 Thread via GitHub
github-actions[bot] commented on PR #7147: URL: https://github.com/apache/ozone/pull/7147#issuecomment-2814247124 Thank you very much for the patch. I am closing this PR __temporarily__ as there was no activity recently and it is waiting for response from its author. It doesn't mean t

Re: [PR] HDDS-11403. PartialTableCache optimize for cleanup [ozone]

2025-04-17 Thread via GitHub
github-actions[bot] closed pull request #7147: HDDS-11403. PartialTableCache optimize for cleanup URL: https://github.com/apache/ozone/pull/7147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] HDDS-9384. Update OpenTelemetry traces in the write path [ozone]

2025-04-17 Thread via GitHub
github-actions[bot] commented on PR #5468: URL: https://github.com/apache/ozone/pull/5468#issuecomment-2814247171 Thank you very much for the patch. I am closing this PR __temporarily__ as there was no activity recently and it is waiting for response from its author. It doesn't mean t

Re: [PR] HDDS-7417. [Design] Ozone Transparent Data Compression Support [ozone]

2025-04-17 Thread via GitHub
github-actions[bot] commented on PR #3890: URL: https://github.com/apache/ozone/pull/3890#issuecomment-2814247216 Thank you very much for the patch. I am closing this PR __temporarily__ as there was no activity recently and it is waiting for response from its author. It doesn't mean t

Re: [PR] HDDS-12560. Reclaimable Filter for Snaphost Garbage Collections [ozone]

2025-04-17 Thread via GitHub
swamirishi commented on code in PR #8053: URL: https://github.com/apache/ozone/pull/8053#discussion_r2049188123 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/filter/ReclaimableFilter.java: ## @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Soft

Re: [PR] HDDS-12560. Reclaimable Filter for Snaphost Garbage Collections [ozone]

2025-04-17 Thread via GitHub
swamirishi commented on code in PR #8053: URL: https://github.com/apache/ozone/pull/8053#discussion_r2049192032 ## hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/filter/TestReclaimableFilter.java: ## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache

Re: [PR] HDDS-11734. Bump maven-compiler-plugin to 3.14.0 [ozone]

2025-04-17 Thread via GitHub
Jimmyweng006 commented on PR #8299: URL: https://github.com/apache/ozone/pull/8299#issuecomment-2813367298 Thanks @adoroszlai for review. I have pushed the new commit for constants. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] HDDS-12742. Make RDBStoreAbstractIterator Return Reference-Counted KeyValues to Improve Consistency and Performance [ozone]

2025-04-17 Thread via GitHub
szetszwo commented on PR #8203: URL: https://github.com/apache/ozone/pull/8203#issuecomment-2813378576 > ThreadLocal will not work. It will work. > Moreover ThreadLocal will end up creating too many buffers which IMO is very wasteful. No, it won't. @swamirishi , S

Re: [PR] HDDS-12742. Make RDBStoreAbstractIterator Return Reference-Counted KeyValues to Improve Consistency and Performance [ozone]

2025-04-17 Thread via GitHub
szetszwo commented on code in PR #8203: URL: https://github.com/apache/ozone/pull/8203#discussion_r2049216706 ## hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreAbstractIterator.java: ## @@ -78,32 +82,44 @@ final RAW getPrefix() { @Override pu

Re: [PR] HDDS-12413. Make hdds-container-service compliant with FieldDeclarationsShouldBeAtStartOfClass [ozone]

2025-04-17 Thread via GitHub
ivanzlenko commented on code in PR #7968: URL: https://github.com/apache/ozone/pull/7968#discussion_r2049141272 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/CopyContainerCompression.java: ## @@ -51,18 +51,16 @@ public OutputStream

Re: [PR] HDDS-11734. Bump maven-compiler-plugin to 3.14.0 [ozone]

2025-04-17 Thread via GitHub
adoroszlai commented on PR #8299: URL: https://github.com/apache/ozone/pull/8299#issuecomment-2813381546 > I have pushed the new commit for constants. Thanks. I really intended it to be a follow-up, because there are some classes not touched in this PR which use the same hard-coded n

Re: [PR] HDDS-12413. Make hdds-container-service compliant with FieldDeclarationsShouldBeAtStartOfClass [ozone]

2025-04-17 Thread via GitHub
ivanzlenko commented on code in PR #7968: URL: https://github.com/apache/ozone/pull/7968#discussion_r2049236359 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerMetadataInspector.java: ## @@ -74,10 +74,13 @@ * log4j.app

Re: [PR] HDDS-12413. Make hdds-container-service compliant with FieldDeclarationsShouldBeAtStartOfClass [ozone]

2025-04-17 Thread via GitHub
ivanzlenko commented on code in PR #7968: URL: https://github.com/apache/ozone/pull/7968#discussion_r2049241567 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/CopyContainerCompression.java: ## @@ -51,18 +51,16 @@ public OutputStream

Re: [PR] HDDS-12413. Make hdds-container-service compliant with FieldDeclarationsShouldBeAtStartOfClass [ozone]

2025-04-17 Thread via GitHub
ivanzlenko commented on code in PR #7968: URL: https://github.com/apache/ozone/pull/7968#discussion_r2049234844 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java: ## @@ -627,10 +585,50 @@ public void s

[jira] [Created] (HDDS-12862) Recon frontend build may not be reproducible

2025-04-17 Thread Attila Doroszlai (Jira)
Attila Doroszlai created HDDS-12862: --- Summary: Recon frontend build may not be reproducible Key: HDDS-12862 URL: https://issues.apache.org/jira/browse/HDDS-12862 Project: Apache Ozone Issue

Re: [PR] HDDS-12413. Make hdds-container-service compliant with FieldDeclarationsShouldBeAtStartOfClass [ozone]

2025-04-17 Thread via GitHub
adoroszlai commented on code in PR #7968: URL: https://github.com/apache/ozone/pull/7968#discussion_r2049322687 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java: ## @@ -627,142 +545,162 @@ public void

Re: [PR] HDDS-12561. Reclaimable Rename entry filter for reclaiming renaming entries [ozone]

2025-04-17 Thread via GitHub
swamirishi commented on code in PR #8054: URL: https://github.com/apache/ozone/pull/8054#discussion_r2049306490 ## hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/filter/TestReclaimableRenameEntryFilter.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to

Re: [PR] HDDS-12840. Avoid long containerId in KeyValueContainer [ozone]

2025-04-17 Thread via GitHub
szetszwo merged PR #8291: URL: https://github.com/apache/ozone/pull/8291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache

Re: [PR] HDDS-12413. Move field declarations to start of class in hdds-container-service [ozone]

2025-04-17 Thread via GitHub
adoroszlai commented on PR #7968: URL: https://github.com/apache/ozone/pull/7968#issuecomment-2813945869 I still think formatting changes in `DatanodeConfiguration` are unnecessary, but OK once. Please try to avoid it next time. :) -- This is an automated message from the Apache Git Serv

[jira] [Created] (HDDS-12865) Handle automatic container cache refresh for replica verification

2025-04-17 Thread Ethan Rose (Jira)
Ethan Rose created HDDS-12865: - Summary: Handle automatic container cache refresh for replica verification Key: HDDS-12865 URL: https://issues.apache.org/jira/browse/HDDS-12865 Project: Apache Ozone

[jira] [Updated] (HDDS-12152) Stop testing with Hadoop 3.1.2

2025-04-17 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HDDS-12152: --- Fix Version/s: (was: 2.1.0) Release Note: Ozone now requires the Hadoop 3.4 runtime.

[jira] [Updated] (HDDS-12857) Add config option to specify configuration ini files for OM component

2025-04-17 Thread Jira
[ https://issues.apache.org/jira/browse/HDDS-12857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Gál updated HDDS-12857: Description: In https://issues.apache.org/jira/browse/HDDS-12484 it was enabled to use ini files to

[jira] [Updated] (HDDS-12858) Add config option to specify configuration ini files for SCM component

2025-04-17 Thread Jira
[ https://issues.apache.org/jira/browse/HDDS-12858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Gál updated HDDS-12858: Description: In https://issues.apache.org/jira/browse/HDDS-12484 it was enabled to use ini files to

Re: [PR] HDDS-12808. Implement OM entities of lifecycle configurations [ozone]

2025-04-17 Thread via GitHub
ashishkumar50 commented on code in PR #8275: URL: https://github.com/apache/ozone/pull/8275#discussion_r2048425256 ## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLCRule.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] HDDS-12484. Allow ini files to configure ColumnFamilyOptions for rocksDB [ozone]

2025-04-17 Thread via GitHub
peterxcli commented on code in PR #8173: URL: https://github.com/apache/ozone/pull/8173#discussion_r2048509329 ## hadoop-hdds/managed-rocksdb/src/main/java/org/apache/hadoop/hdds/utils/db/managed/ManagedColumnFamilyOptions.java: ## @@ -49,7 +50,9 @@ public synchronized ManagedCo

[jira] [Assigned] (HDDS-12347) Fix spotbugs warnings in integration tests

2025-04-17 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai reassigned HDDS-12347: --- Assignee: Attila Doroszlai > Fix spotbugs warnings in integration tests > --

  1   2   >