swamirishi commented on code in PR #8203:
URL: https://github.com/apache/ozone/pull/8203#discussion_r2049431347
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreAbstractIterator.java:
##########
@@ -78,32 +82,44 @@ final RAW getPrefix() {
@Override
public final void forEachRemaining(
- Consumer<? super Table.KeyValue<RAW, RAW>> action) {
+ Consumer<? super UncheckedAutoCloseableSupplier<RawKeyValue<RAW>>>
action) {
while (hasNext()) {
- action.accept(next());
+ UncheckedAutoCloseableSupplier<RawKeyValue<RAW>> entry = next();
+ action.accept(entry);
}
}
private void setCurrentEntry() {
- if (rocksDBIterator.get().isValid()) {
+ if (currentEntry != null) {
+ currentEntry.release();
+ }
+
+ boolean isValid = !closed && rocksDBIterator.get().isValid();
+ if (isValid) {
currentEntry = getKeyValue();
+ currentEntry.retain();
} else {
currentEntry = null;
}
+ setHasNext(isValid, currentEntry);
+ }
+
+ public void setHasNext(boolean isValid,
ReferenceCountedObject<RawKeyValue<RAW>> entry) {
+ this.hasNext = isValid && (prefix == null ||
startsWithPrefix(entry.get().getKey()));
}
@Override
public final boolean hasNext() {
- return rocksDBIterator.get().isValid() &&
- (prefix == null || startsWithPrefix(key()));
+ return hasNext;
}
@Override
- public final Table.KeyValue<RAW, RAW> next() {
- setCurrentEntry();
- if (currentEntry != null) {
+ public final UncheckedAutoCloseableSupplier<RawKeyValue<RAW>> next() {
Review Comment:
Table interface will have splitIterator function.
```
public class RDBTable {
// This function would be part of the table interface.
public void performOperationInParallel(byte[] prefix,
Consumer<RawKeyValue<byte[]>> op) {
TableIterator<UncheckAutoCloseableSupplier<RawKeyValue>> itr = ...;
SplitTableIterator itr = new SplitTableIterator(itr);
performOperationInParallel(itr, op);
}
public void performOperationInParallel(CodecBuffer prefix,
Consumer<RawKeyValue<CodecBuffer>> op) {
TableIterator<UncheckAutoCloseableSupplier<RawKeyValue>> itr = ...;
SplitTableIterator itr = new SplitTableIterator(itr);
performOperationInParallel(itr, op)
}
private performOperationInParallel(SplitTableIterator splittableIterator,
Consumer<RawKeyValue<CodecBuffer>> op) {
ThreadPoolExecutor pool = ...;
pool.submit(splittableIterator.tryAdvance());
.....
}
}
```
Just chalking out the high level idea of the interface changes in the next
set of PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
