Re: [PR] HDDS-11530. Support listMultipartUploads max uploads and markers [ozone]

2025-02-18 Thread via GitHub
ivandika3 commented on code in PR #7817: URL: https://github.com/apache/ozone/pull/7817#discussion_r1960893345 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java: ## @@ -820,19 +821,19 @@ public boolean isSstFilteringSvcEnabled() {

[jira] [Created] (HDDS-12368) table iterator in KeyManagerImpl should seek to correct start key

2025-02-18 Thread Swaminathan Balachandran (Jira)
Swaminathan Balachandran created HDDS-12368: --- Summary: table iterator in KeyManagerImpl should seek to correct start key Key: HDDS-12368 URL: https://issues.apache.org/jira/browse/HDDS-12368

Re: [PR] HDDS-12057. Implement command ozone debug replicas verify checksums [ozone]

2025-02-18 Thread via GitHub
ptlrs commented on code in PR #7748: URL: https://github.com/apache/ozone/pull/7748#discussion_r1960862475 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ReplicasVerify.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] HDDS-12057. Implement command ozone debug replicas verify checksums [ozone]

2025-02-18 Thread via GitHub
ptlrs commented on code in PR #7748: URL: https://github.com/apache/ozone/pull/7748#discussion_r1960865757 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ReadReplicas.java: ## @@ -246,4 +204,91 @@ private File createDirectory(String volumeName, String bucketN

[PR] HDDS-12369. Fix site CSP issue which to match Infra team requirement. [ozone-site]

2025-02-18 Thread via GitHub
slfan1989 opened a new pull request, #124: URL: https://github.com/apache/ozone-site/pull/124 ## What changes were proposed in this pull request? Provide a one line summary of the changes in the PR **Title** field above. It should be in the form of `HDDS-1234. Short summary of the c

[jira] [Assigned] (HDDS-12235) Container import processing should respect reserved space at DN

2025-02-18 Thread Krishna Kumar Asawa (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krishna Kumar Asawa reassigned HDDS-12235: -- Assignee: Ashish Kumar > Container import processing should respect reserved s

[jira] [Updated] (HDDS-12369) Fix site CSP issue which to match Infra team requirement.

2025-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-12369: -- Labels: pull-request-available (was: ) > Fix site CSP issue which to match Infra team requirem

[jira] [Created] (HDDS-12369) Fix site CSP issue which to match Infra team requirement.

2025-02-18 Thread Shilun Fan (Jira)
Shilun Fan created HDDS-12369: - Summary: Fix site CSP issue which to match Infra team requirement. Key: HDDS-12369 URL: https://issues.apache.org/jira/browse/HDDS-12369 Project: Apache Ozone Issu

Re: [PR] HDDS-12369. Fix site CSP issue which to match Infra team requirement. [ozone-site]

2025-02-18 Thread via GitHub
slfan1989 commented on PR #124: URL: https://github.com/apache/ozone-site/pull/124#issuecomment-2667520964 @adoroszlai Could you review this PR? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Assigned] (HDDS-12305) Avoid marking container as DELETED if it was due to EMPTY with BCSID=0 containers

2025-02-18 Thread Krishna Kumar Asawa (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krishna Kumar Asawa reassigned HDDS-12305: -- Assignee: Sumit Agrawal > Avoid marking container as DELETED if it was due to

[jira] [Assigned] (HDDS-11539) OzoneClientCache @PreDestroy is never called

2025-02-18 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/HDDS-11539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Lee reassigned HDDS-11539: Assignee: (was: Peter Lee) > OzoneClientCache @PreDestroy is never called > --

[jira] [Created] (HDDS-12372) Remove disabled test which is unhealthy before RATIS-1481

2025-02-18 Thread Peter Lee (Jira)
Peter Lee created HDDS-12372: Summary: Remove disabled test which is unhealthy before RATIS-1481 Key: HDDS-12372 URL: https://issues.apache.org/jira/browse/HDDS-12372 Project: Apache Ozone Issue

[jira] [Assigned] (HDDS-12372) Remove disabled test which is unhealthy before RATIS-1481

2025-02-18 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Lee reassigned HDDS-12372: Assignee: Peter Lee > Remove disabled test which is unhealthy before RATIS-1481 >

[jira] [Updated] (HDDS-12373) Change calculation logic for volume reserved space

2025-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-12373: -- Labels: pull-request-available (was: ) > Change calculation logic for volume reserved space >

[jira] [Created] (HDDS-12373) Change calculation logic for volume reserved space

2025-02-18 Thread Janus Chow (Jira)
Janus Chow created HDDS-12373: - Summary: Change calculation logic for volume reserved space Key: HDDS-12373 URL: https://issues.apache.org/jira/browse/HDDS-12373 Project: Apache Ozone Issue Type:

[PR] HDDS-12373. Change calculation logic for volume reserved space [ozone]

2025-02-18 Thread via GitHub
symious opened a new pull request, #7927: URL: https://github.com/apache/ozone/pull/7927 ## What changes were proposed in this pull request? The current logic for "hdds.datanode.dir.du.reserved" is as follows: ``` private long getRemainingReserved(){ return Math.max(reser

Re: [PR] HDDS-12369. Fix site CSP issue which to match Infra team requirement. [ozone-site]

2025-02-18 Thread via GitHub
adoroszlai merged PR #124: URL: https://github.com/apache/ozone-site/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.a

Re: [PR] HDDS-12369. Fix site CSP issue which to match Infra team requirement. [ozone-site]

2025-02-18 Thread via GitHub
adoroszlai commented on PR #124: URL: https://github.com/apache/ozone-site/pull/124#issuecomment-2667686594 Thanks a lot @slfan1989 for reporting and fixing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Resolved] (HDDS-12369) Fix site CSP issue which to match Infra team requirement.

2025-02-18 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-12369. - Resolution: Fixed Thanks [~slfan1989] for the fix. > Fix site CSP issue which to match I

[jira] [Updated] (HDDS-12372) Enable disabled test which is unhealthy before RATIS-1481

2025-02-18 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Lee updated HDDS-12372: - Summary: Enable disabled test which is unhealthy before RATIS-1481 (was: Remove disabled test which is u

Re: [PR] HDDS-12323. Improve container import failure cleanup flow [ozone]

2025-02-18 Thread via GitHub
ChenSammi commented on PR #7877: URL: https://github.com/apache/ozone/pull/7877#issuecomment-2667696579 > @ChenSammi This change is not able to handle below case, > > 1. if container folder is removed first, and then DN crashed / restarted, the DB entry remains orphan. > >

Re: [PR] HDDS-11901. use om managed index for handling request [ozone]

2025-02-18 Thread via GitHub
sumitagrawl commented on PR #7722: URL: https://github.com/apache/ozone/pull/7722#issuecomment-2667736259 @adoroszlai resolved all comments and fixed license header changes, please review again -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] HDDS-11901. use om managed index for handling request [ozone]

2025-02-18 Thread via GitHub
adoroszlai commented on PR #7722: URL: https://github.com/apache/ozone/pull/7722#issuecomment-2667742199 > fixed license header changes I have already fixed license headers, see: - https://github.com/apache/ozone/commit/7439a51f47096c8e01e7acf631cc2c024839b747 - https://github.c

[jira] [Commented] (HDDS-11532) Sort multipart uploads on ListMultipartUploads response

2025-02-18 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/HDDS-11532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928315#comment-17928315 ] Peter Lee commented on HDDS-11532: -- I think this can be done by changing upload id to us

[jira] [Updated] (HDDS-12372) Enable disabled tests which is unhealthy before RATIS-1481

2025-02-18 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Lee updated HDDS-12372: - Summary: Enable disabled tests which is unhealthy before RATIS-1481 (was: Enable disabled test which is

[jira] [Assigned] (HDDS-12215) Intermittent timeout in testContainerStateMachineRestartWithDNChangePipeline

2025-02-18 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai reassigned HDDS-12215: --- Assignee: Swaminathan Balachandran > Intermittent timeout in testContainerStateMachi

Re: [PR] HDDS-11867. Remove code paths for non-Ratis SCM. [ozone]

2025-02-18 Thread via GitHub
nandakumar131 commented on code in PR #7911: URL: https://github.com/apache/ozone/pull/7911#discussion_r1960992590 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAManagerImpl.java: ## @@ -180,9 +171,7 @@ public SCMSnapshotProvider getSCMSnapshotProvide

[jira] [Created] (HDDS-12370) Remove SCMHAManager#SCMHADBTransactionBuffer

2025-02-18 Thread Nandakumar (Jira)
Nandakumar created HDDS-12370: - Summary: Remove SCMHAManager#SCMHADBTransactionBuffer Key: HDDS-12370 URL: https://issues.apache.org/jira/browse/HDDS-12370 Project: Apache Ozone Issue Type: Sub-t

Re: [PR] HDDS-11867. Remove code paths for non-Ratis SCM. [ozone]

2025-02-18 Thread via GitHub
nandakumar131 commented on code in PR #7911: URL: https://github.com/apache/ozone/pull/7911#discussion_r1960990234 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAManagerImpl.java: ## @@ -180,9 +171,7 @@ public SCMSnapshotProvider getSCMSnapshotProvide

[PR] HDDS-12353. Move SpaceUsage implementations to hdds-server-framework [ozone]

2025-02-18 Thread via GitHub
adoroszlai opened a new pull request, #7926: URL: https://github.com/apache/ozone/pull/7926 ## What changes were proposed in this pull request? Code from `org.apache.hadoop.hdds.fs` package, except `SpaceUsageSource`, can be moved to `hdds-server-framework`. https://issues.apac

[jira] [Resolved] (HDDS-12331) BlockOutputStream.failedServers is not thread-safe

2025-02-18 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-12331. - Fix Version/s: 2.0.0 Resolution: Fixed > BlockOutputStream.failedServers is not th

Re: [PR] HDDS-11867. Remove code paths for non-Ratis SCM. [ozone]

2025-02-18 Thread via GitHub
nandakumar131 commented on code in PR #7911: URL: https://github.com/apache/ozone/pull/7911#discussion_r1961005253 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java: ## @@ -362,15 +362,12 @@ private StorageContainerManager(Ozo

[jira] [Created] (HDDS-12371) Duplicated key scanning on multipartInfo table when listing multipart uploads

2025-02-18 Thread Peter Lee (Jira)
Peter Lee created HDDS-12371: Summary: Duplicated key scanning on multipartInfo table when listing multipart uploads Key: HDDS-12371 URL: https://issues.apache.org/jira/browse/HDDS-12371 Project: Apache O

Re: [PR] HDDS-11530. Support listMultipartUploads max uploads and markers [ozone]

2025-02-18 Thread via GitHub
peterxcli commented on code in PR #7817: URL: https://github.com/apache/ozone/pull/7817#discussion_r1961011648 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/s3/awssdk/v1/AbstractS3SDKV1Tests.java: ## @@ -663,33 +666,93 @@ public void testLowLevelMultipar

[jira] [Updated] (HDDS-12353) Move SpaceUsage implementations to hdds-server-framework

2025-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-12353: -- Labels: pull-request-available (was: ) > Move SpaceUsage implementations to hdds-server-framew

Re: [PR] HDDS-11867. Remove code paths for non-Ratis SCM. [ozone]

2025-02-18 Thread via GitHub
nandakumar131 commented on PR #7911: URL: https://github.com/apache/ozone/pull/7911#issuecomment-2667594612 Thanks @jojochuang for the review, addressed the review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HDDS-12331. BlockOutputStream.failedServers is not thread-safe [ozone]

2025-02-18 Thread via GitHub
adoroszlai merged PR #7885: URL: https://github.com/apache/ozone/pull/7885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

Re: [PR] HDDS-11530. Support listMultipartUploads max uploads and markers [ozone]

2025-02-18 Thread via GitHub
peterxcli commented on code in PR #7817: URL: https://github.com/apache/ozone/pull/7817#discussion_r1961010033 ## hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto: ## @@ -1762,6 +1762,7 @@ message ListMultipartUploadsRequest { optional string keyMarker =

Re: [PR] HDDS-11530. Support listMultipartUploads max uploads and markers [ozone]

2025-02-18 Thread via GitHub
peterxcli commented on code in PR #7817: URL: https://github.com/apache/ozone/pull/7817#discussion_r1961010435 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java: ## @@ -820,19 +821,19 @@ public boolean isSstFilteringSvcEnabled() {

[jira] [Updated] (HDDS-12353) Move SpaceUsage implementations to hdds-server-framework

2025-02-18 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12353: Status: Patch Available (was: Open) > Move SpaceUsage implementations to hdds-server-frame

Re: [PR] HDDS-12185. Enhance FileSizeCountTask for Faster Processing. [ozone]

2025-02-18 Thread via GitHub
adoroszlai commented on PR #7796: URL: https://github.com/apache/ozone/pull/7796#issuecomment-2667645644 Thanks @ArafatKhan2198 for improving the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HDDS-12204. Improve failover logging [ozone]

2025-02-18 Thread via GitHub
SaketaChalamchala commented on code in PR #7867: URL: https://github.com/apache/ozone/pull/7867#discussion_r1960817749 ## hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/ratis/TestServerNotLeaderExceptionMessageParsing.java: ## @@ -30,13 +30,13 @@ public void testServerN

Re: [PR] HDDS-12204. Improve failover logging [ozone]

2025-02-18 Thread via GitHub
SaketaChalamchala commented on code in PR #7867: URL: https://github.com/apache/ozone/pull/7867#discussion_r1960819023 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/protocol/SCMSecurityProtocolServerSideTranslatorPB.java: ## @@ -82,7 +82,7 @@ public SCMSecur

Re: [PR] HDDS-12323. Improve container import failure cleanup flow [ozone]

2025-02-18 Thread via GitHub
sumitagrawl commented on PR #7877: URL: https://github.com/apache/ozone/pull/7877#issuecomment-2666050339 @ChenSammi This change is not able to handle below case, 1. if container folder is removed first, and then DN crashed / restarted, the DB entry remains orphan. Currently t

Re: [PR] HDDS-12359. Bump async profiler to 2.9, awscli to 1.37 [ozone-docker-runner]

2025-02-18 Thread via GitHub
adoroszlai merged PR #38: URL: https://github.com/apache/ozone-docker-runner/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] HDDS-12359. Bump async profiler to 2.9, awscli to 1.37 [ozone-docker-runner]

2025-02-18 Thread via GitHub
adoroszlai commented on PR #38: URL: https://github.com/apache/ozone-docker-runner/pull/38#issuecomment-2666807522 Thanks @jojochuang for the review. My main goal is to create an image that allows testing with the latest awscli. -- This is an automated message from the Apache Git Servic

Re: [PR] HDDS-11901. use om managed index for handling request [ozone]

2025-02-18 Thread via GitHub
sumitagrawl commented on code in PR #7722: URL: https://github.com/apache/ozone/pull/7722#discussion_r1960084517 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/execution/IndexGenerator.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] HDDS-12362. Remove temporary checkstyle suppression file [ozone]

2025-02-18 Thread via GitHub
adoroszlai commented on PR #7920: URL: https://github.com/apache/ozone/pull/7920#issuecomment-2666211391 Thanks @ivanzlenko for the patch, @myskov, @nandakumar131 for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HDDS-12179. Improve Container Log to also capture the Command fired to Datanode [ozone]

2025-02-18 Thread via GitHub
errose28 commented on PR #7858: URL: https://github.com/apache/ozone/pull/7858#issuecomment-2666384299 Thanks for adding this @sreejasahithi. Can you add some sample container log output to the PR description for others to reference? Also please add some tests on the log messages for the re

Re: [PR] HDDS-12236. ContainerStateMachine should not apply or write future transactions in the event of failure [ozone]

2025-02-18 Thread via GitHub
sumitagrawl commented on code in PR #7862: URL: https://github.com/apache/ozone/pull/7862#discussion_r1960007988 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java: ## @@ -554,6 +564,11 @@ pri

[jira] [Commented] (HDDS-12188) Move server-only classes from hdds-common to hdds-server-framework

2025-02-18 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928148#comment-17928148 ] Attila Doroszlai commented on HDDS-12188: - Thanks [~chiacyu] for the contribution

[jira] [Updated] (HDDS-12188) Move server-only classes from hdds-common to hdds-server-framework

2025-02-18 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12188: Fix Version/s: 2.0.0 Resolution: Done Status: Resolved (was: Patch Availa

Re: [PR] HDDS-12188. Move server-only upgrade classes from hdds-common to hdds-server-framework [ozone]

2025-02-18 Thread via GitHub
adoroszlai merged PR #7903: URL: https://github.com/apache/ozone/pull/7903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

Re: [PR] HDDS-11626. Document short-circuit read feature [ozone]

2025-02-18 Thread via GitHub
jojochuang commented on code in PR #7529: URL: https://github.com/apache/ozone/pull/7529#discussion_r1960113015 ## hadoop-hdds/docs/content/feature/Short-Circuit-Read.zh.md: ## @@ -0,0 +1,88 @@ +--- +title: "Datanode 本地短路读" +weight: 2 +menu: + main: + parent: 特性 +summary:

Re: [PR] HDDS-11131. Intermittent timeout in TestSnapshotDeletingService#testSnapshotWithFSO [ozone]

2025-02-18 Thread via GitHub
adoroszlai closed pull request #7068: HDDS-11131. Intermittent timeout in TestSnapshotDeletingService#testSnapshotWithFSO URL: https://github.com/apache/ozone/pull/7068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (HDDS-12363) Update IntelliJ style with import ordering

2025-02-18 Thread Attila Doroszlai (Jira)
Attila Doroszlai created HDDS-12363: --- Summary: Update IntelliJ style with import ordering Key: HDDS-12363 URL: https://issues.apache.org/jira/browse/HDDS-12363 Project: Apache Ozone Issue T

Re: [PR] HDDS-12239. Support read-only volume on DataNode [ozone]

2025-02-18 Thread via GitHub
adoroszlai commented on PR #7830: URL: https://github.com/apache/ozone/pull/7830#issuecomment-2665283056 Thanks @ashishkumar50 for updating the patch, the filtering part LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] HDDS-12286. Fix license headers and imports for ozone-tools [ozone]

2025-02-18 Thread via GitHub
adoroszlai merged PR #7919: URL: https://github.com/apache/ozone/pull/7919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

Re: [PR] HDDS-12362. Remove temporary checkstyle suppression file [ozone]

2025-02-18 Thread via GitHub
ivanzlenko commented on PR #7920: URL: https://github.com/apache/ozone/pull/7920#issuecomment-2665695957 @myskov thanks for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] HDDS-12364. Add missing Override annotation [ozone]

2025-02-18 Thread via GitHub
ivanzlenko commented on PR #7923: URL: https://github.com/apache/ozone/pull/7923#issuecomment-2665696364 @myskov thanks for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] HDDS-12315. Speed up some Freon integration tests [ozone]

2025-02-18 Thread via GitHub
adoroszlai commented on code in PR #7870: URL: https://github.com/apache/ozone/pull/7870#discussion_r1959592269 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/OzoneFileSystemTests.java: ## @@ -33,18 +35,31 @@ import static org.apache.hadoop.ozone.Ozo

[PR] HDDS-12172. Rename Java constants of DFSConfigKeysLegacy keys [ozone]

2025-02-18 Thread via GitHub
sarvekshayr opened a new pull request, #7922: URL: https://github.com/apache/ozone/pull/7922 ## What changes were proposed in this pull request? #7803 renamed config keys previously prefixed with `dfs` to `hdds`. This PR updates the corresponding Java constants in `DFSConfigKeysLegacy`, m

[jira] [Updated] (HDDS-12172) Rename Java constants of DFSConfigKeysLegacy keys

2025-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-12172: -- Labels: pull-request-available (was: ) > Rename Java constants of DFSConfigKeysLegacy keys > -

Re: [PR] HDDS-12343. Fix spotbugs warnings in Recon [ozone]

2025-02-18 Thread via GitHub
adoroszlai merged PR #7902: URL: https://github.com/apache/ozone/pull/7902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

Re: [PR] HDDS-12343. Fix spotbugs warnings in Recon [ozone]

2025-02-18 Thread via GitHub
adoroszlai commented on PR #7902: URL: https://github.com/apache/ozone/pull/7902#issuecomment-2665523443 Thanks @devmadhuu for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Updated] (HDDS-12343) Fix spotbugs warnings in Recon

2025-02-18 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12343: Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Avail

[jira] [Updated] (HDDS-12365) Move IJ code style file into shareable folder

2025-02-18 Thread Ivan Zlenko (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zlenko updated HDDS-12365: --- Status: Patch Available (was: Open) > Move IJ code style file into shareable folder > --

[jira] [Updated] (HDDS-12368) table iterator in KeyManagerImpl should seek to correct start key

2025-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-12368: -- Labels: pull-request-available (was: ) > table iterator in KeyManagerImpl should seek to corre

[PR] HDDS-12368. table iterator in KeyManagerImpl should seek to correct start key [ozone]

2025-02-18 Thread via GitHub
swamirishi opened a new pull request, #7925: URL: https://github.com/apache/ozone/pull/7925 ## What changes were proposed in this pull request? There is a typo in the table iterator seek logic when the start key is passed. The PR fixes this small bug in the private function. Currently the

[jira] [Updated] (HDDS-12359) Bump async profiler to 2.9, awscli to 1.37 in ozone-runner

2025-02-18 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12359: Fix Version/s: runner-20250218-1-jdk21 Resolution: Done Status: Resolved

Re: [PR] HDDS-12185. Enhance FileSizeCountTask for Faster Processing. [ozone]

2025-02-18 Thread via GitHub
ArafatKhan2198 commented on PR #7796: URL: https://github.com/apache/ozone/pull/7796#issuecomment-2666921867 @adoroszlai @devmadhuu New changes :- - A static lock object (`TRUNCATE_LOCK`) was introduced in the helper class. This ensures that when one task is inside this block (perfor

[jira] [Updated] (HDDS-12239) Volume should not be marked as unhealthy when disk full

2025-02-18 Thread Uma Maheswara Rao G (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uma Maheswara Rao G updated HDDS-12239: --- Summary: Volume should not be marked as unhealthy when disk full (was: Volume should

[jira] [Resolved] (HDDS-12317) Volume should not be marked as unhealthy when disk full

2025-02-18 Thread Uma Maheswara Rao G (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uma Maheswara Rao G resolved HDDS-12317. Resolution: Duplicate > Volume should not be marked as unhealthy when disk full > -

[jira] [Updated] (HDDS-12362) Remove file with excludes

2025-02-18 Thread Ivan Zlenko (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zlenko updated HDDS-12362: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Remove file with excludes >

[jira] [Updated] (HDDS-12362) Remove file with excludes

2025-02-18 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12362: Fix Version/s: 2.0.0 > Remove file with excludes > - > >

[jira] [Updated] (HDDS-12323) Improve container import failure cleanup flow

2025-02-18 Thread Rishabh Patel (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishabh Patel updated HDDS-12323: - Parent: HDDS-8161 Issue Type: Sub-task (was: Improvement) > Improve container import fai

Re: [PR] HDDS-12188. Move server-only upgrade classes from hdds-common to hdds-server-framework [ozone]

2025-02-18 Thread via GitHub
adoroszlai commented on PR #7903: URL: https://github.com/apache/ozone/pull/7903#issuecomment-2666255136 Thanks @chiacyu for the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Updated] (HDDS-12367) Change ignorePipeline log level to DEBUG in OmKeyInfo

2025-02-18 Thread Hemant Kumar (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hemant Kumar updated HDDS-12367: Labels: newbie (was: ) > Change ignorePipeline log level to DEBUG in OmKeyInfo > -

[jira] [Created] (HDDS-12367) Change ignorePipeline log level to DEBUG in OmKeyInfo

2025-02-18 Thread Hemant Kumar (Jira)
Hemant Kumar created HDDS-12367: --- Summary: Change ignorePipeline log level to DEBUG in OmKeyInfo Key: HDDS-12367 URL: https://issues.apache.org/jira/browse/HDDS-12367 Project: Apache Ozone Issu

Re: [PR] HDDS-11867. Remove code paths for non-Ratis SCM. [ozone]

2025-02-18 Thread via GitHub
jojochuang commented on PR #7911: URL: https://github.com/apache/ozone/pull/7911#issuecomment-2666551847 I reviewed the PR. Made a few small code style suggestions but overall looks correct. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] HDDS-11867. Remove code paths for non-Ratis SCM. [ozone]

2025-02-18 Thread via GitHub
jojochuang commented on code in PR #7911: URL: https://github.com/apache/ozone/pull/7911#discussion_r1960147326 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestStorageContainerManager.java: ## @@ -302,10 +302,8 @@ private void testBlockDeletionTran

Re: [PR] HDDS-11463. Track and display failed DataNode storage locations in SCM. [ozone]

2025-02-18 Thread via GitHub
adoroszlai commented on PR #7266: URL: https://github.com/apache/ozone/pull/7266#issuecomment-2665380718 Merged from `master`. There will be one checkstyle problem: ``` hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/datanode/package-info.java 18: Missing a Javadoc

[jira] [Assigned] (HDDS-12364) Add PMD.MissingOverride Rule

2025-02-18 Thread Ivan Zlenko (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zlenko reassigned HDDS-12364: -- Assignee: Ivan Zlenko > Add PMD.MissingOverride Rule > > >

[jira] [Created] (HDDS-12364) Add PMD.MissingOverride Rule

2025-02-18 Thread Ivan Zlenko (Jira)
Ivan Zlenko created HDDS-12364: -- Summary: Add PMD.MissingOverride Rule Key: HDDS-12364 URL: https://issues.apache.org/jira/browse/HDDS-12364 Project: Apache Ozone Issue Type: Improvement

Re: [PR] HDDS-12363. Update IJ code style settings [ozone]

2025-02-18 Thread via GitHub
adoroszlai commented on PR #7921: URL: https://github.com/apache/ozone/pull/7921#issuecomment-2665406241 > wouldn't be it better to move this file into IJ Shared settings folder? So it will be .idea/codeStyle/Project.xml. In that case code style will be applied automatically. It migh

Re: [PR] HDDS-12315. Speed up some Freon integration tests [ozone]

2025-02-18 Thread via GitHub
adoroszlai commented on code in PR #7870: URL: https://github.com/apache/ozone/pull/7870#discussion_r1959565204 ## hadoop-ozone/integration-test/src/test/java/org/apache/ozone/test/FreonTests.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[jira] [Created] (HDDS-12365) Move IJ code style file into shareable folder

2025-02-18 Thread Ivan Zlenko (Jira)
Ivan Zlenko created HDDS-12365: -- Summary: Move IJ code style file into shareable folder Key: HDDS-12365 URL: https://issues.apache.org/jira/browse/HDDS-12365 Project: Apache Ozone Issue Type: Im

Re: [PR] HDDS-12363. Update IJ code style settings [ozone]

2025-02-18 Thread via GitHub
ivanzlenko commented on PR #7921: URL: https://github.com/apache/ozone/pull/7921#issuecomment-2665413335 > > wouldn't be it better to move this file into IJ Shared settings folder? So it will be .idea/codeStyle/Project.xml. In that case code style will be applied automatically. > > I

Re: [PR] HDDS-12315. Speed up some Freon integration tests [ozone]

2025-02-18 Thread via GitHub
ivanzlenko commented on code in PR #7870: URL: https://github.com/apache/ozone/pull/7870#discussion_r1959569079 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/OzoneFileSystemTests.java: ## @@ -33,18 +35,31 @@ import static org.apache.hadoop.ozone.Ozo

[jira] [Updated] (HDDS-12365) Move IJ code style file into shareable folder

2025-02-18 Thread Ivan Zlenko (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zlenko updated HDDS-12365: --- Description: IntelliJ Idea support sharing settings file via VCS. To do so we need to place desirabl

[jira] [Updated] (HDDS-12364) Add PMD.MissingOverride Rule

2025-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-12364: -- Labels: pull-request-available (was: ) > Add PMD.MissingOverride Rule > --

[jira] [Commented] (HDDS-12366) Remove SuppressWarnings from ChecksumByteBuffer.update

2025-02-18 Thread Xiao Yang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928100#comment-17928100 ] Xiao Yang commented on HDDS-12366: -- Hi [~izlenko], can I finish it? > Remove SuppressWa

[jira] [Commented] (HDDS-6611) Remove chunksPath and metadataPath from container yaml file

2025-02-18 Thread Ethan Rose (Jira)
[ https://issues.apache.org/jira/browse/HDDS-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928098#comment-17928098 ] Ethan Rose commented on HDDS-6611: -- Do we need a new container schema version? I think ev

Re: [PR] HDDS-11530. Support listMultipartUploads max uploads and markers [ozone]

2025-02-18 Thread via GitHub
peterxcli commented on PR #7817: URL: https://github.com/apache/ozone/pull/7817#issuecomment-2665838707 Thanks @ivandika3 for reviewing. Addressed comments, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] (HDDS-12366) Remove SuppressWarnings from ChecksumByteBuffer.update

2025-02-18 Thread Xiao Yang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12366 ] Xiao Yang deleted comment on HDDS-12366: -- was (Author: JIRAUSER283787): Hi [~izlenko], can I finish it? > Remove SuppressWarnings from ChecksumByteBuffer.update > ---

Re: [PR] HDDS-12284. Fix license headers and imports for ozone-s3-secret-store [ozone]

2025-02-18 Thread via GitHub
myskov merged PR #7917: URL: https://github.com/apache/ozone/pull/7917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.o

[jira] [Updated] (HDDS-12286) Fix checkstyle for hadoop-ozone/tools

2025-02-18 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12286: Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Avail

Re: [PR] HDDS-12286. Fix license headers and imports for ozone-tools [ozone]

2025-02-18 Thread via GitHub
ivanzlenko commented on PR #7919: URL: https://github.com/apache/ozone/pull/7919#issuecomment-2665327336 @adoroszlai enormous thanks to you for all reviews and help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] HDDS-12363. Update IJ code style settings [ozone]

2025-02-18 Thread via GitHub
ivanzlenko commented on PR #7921: URL: https://github.com/apache/ozone/pull/7921#issuecomment-2665332682 @adoroszlai wouldn't be it better to move this file into IJ Shared setting folder? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Updated] (HDDS-12364) Add PMD.MissingOverride Rule

2025-02-18 Thread Ivan Zlenko (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zlenko updated HDDS-12364: --- Status: Patch Available (was: In Progress) > Add PMD.MissingOverride Rule >

  1   2   >