sumitagrawl commented on code in PR #7862:
URL: https://github.com/apache/ozone/pull/7862#discussion_r1960007988
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java:
##########
@@ -554,6 +564,11 @@ private CompletableFuture<Message> writeStateMachineData(
CompletableFuture<ContainerCommandResponseProto> writeChunkFuture =
CompletableFuture.supplyAsync(() -> {
try {
+ try {
+ checkContainerHealthy(write.getBlockID().getContainerID());
+ } catch (StorageContainerException e) {
+ return ContainerUtils.logAndReturnError(LOG, e, requestProto);
Review Comment:
We should follow same exception approach of catch and throw exception as
done below for other failure. This need not follow applyTransaction way of
handling, may have some impact.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java:
##########
@@ -554,6 +564,11 @@ private CompletableFuture<Message> writeStateMachineData(
CompletableFuture<ContainerCommandResponseProto> writeChunkFuture =
CompletableFuture.supplyAsync(() -> {
try {
+ try {
+ checkContainerHealthy(write.getBlockID().getContainerID());
Review Comment:
IMO, If statemachine itself is unhealthy, we should reject any further
writeStateMachineData(), so no need check for specific container. This is valid
for applyTransaction() but not here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
