[PR] Bump com.github.luben:zstd-jni from 1.5.6-10 to 1.5.7-1 [ozone]

2025-02-21 Thread via GitHub
dependabot[bot] opened a new pull request, #7949: URL: https://github.com/apache/ozone/pull/7949 Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.6-10 to 1.5.7-1. Commits https://github.com/luben/zstd-jni/commit/6a6b1b10326557a136cbd0c71c8447d5b8c76

[PR] Bump org.xerial:sqlite-jdbc from 3.49.0.0 to 3.49.1.0 [ozone]

2025-02-21 Thread via GitHub
dependabot[bot] opened a new pull request, #7948: URL: https://github.com/apache/ozone/pull/7948 Bumps [org.xerial:sqlite-jdbc](https://github.com/xerial/sqlite-jdbc) from 3.49.0.0 to 3.49.1.0. Release notes Sourced from https://github.com/xerial/sqlite-jdbc/releases";>org.xerial:s

[PR] Bump org.junit:junit-bom from 5.11.4 to 5.12.0 [ozone]

2025-02-21 Thread via GitHub
dependabot[bot] opened a new pull request, #7947: URL: https://github.com/apache/ozone/pull/7947 Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.11.4 to 5.12.0. Release notes Sourced from https://github.com/junit-team/junit5/releases";>org.junit:junit-bom's

[jira] [Updated] (HDDS-12398) Enable test coverage for PMD

2025-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-12398: -- Labels: pull-request-available (was: ) > Enable test coverage for PMD > --

Re: [PR] HDDS-12398. Enable PMD checks for tests [ozone]

2025-02-21 Thread via GitHub
ivanzlenko closed pull request #7945: HDDS-12398. Enable PMD checks for tests URL: https://github.com/apache/ozone/pull/7945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (HDDS-12399) Enable ForLoopCanBeForeach check in PMD

2025-02-21 Thread Ivan Zlenko (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zlenko updated HDDS-12399: --- Description: We should enable ForLoopCanBeForeach rule since this way for loops are more readable and

[jira] [Created] (HDDS-12399) Enable ForLoopCanBeForeach check in PMD

2025-02-21 Thread Ivan Zlenko (Jira)
Ivan Zlenko created HDDS-12399: -- Summary: Enable ForLoopCanBeForeach check in PMD Key: HDDS-12399 URL: https://issues.apache.org/jira/browse/HDDS-12399 Project: Apache Ozone Issue Type: Improvem

[jira] [Updated] (HDDS-12398) Enable test coverage for PMD

2025-02-21 Thread Ivan Zlenko (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Zlenko updated HDDS-12398: --- Status: Patch Available (was: Open) > Enable test coverage for PMD > >

[jira] [Commented] (HDDS-12109) Transfer leadership should not start until target SCM is out of safe mode

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929314#comment-17929314 ] Ivan Andika commented on HDDS-12109: [~peterxcli] AFAIK, not possible currently. We m

[jira] [Assigned] (HDDS-12109) Transfer leadership should not start until target SCM is out of safe mode

2025-02-21 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Lee reassigned HDDS-12109: Assignee: Peter Lee > Transfer leadership should not start until target SCM is out of safe mode >

[jira] [Created] (HDDS-12398) Enable test coverage for PMD

2025-02-21 Thread Ivan Zlenko (Jira)
Ivan Zlenko created HDDS-12398: -- Summary: Enable test coverage for PMD Key: HDDS-12398 URL: https://issues.apache.org/jira/browse/HDDS-12398 Project: Apache Ozone Issue Type: Improvement

Re: [PR] HDDS-10764. Tarball creation failing on leader OM node. [ozone]

2025-02-21 Thread via GitHub
nandakumar131 merged PR #7941: URL: https://github.com/apache/ozone/pull/7941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.a

[jira] [Resolved] (HDDS-12295) Rename config keys for OM default replication and bucket layout

2025-02-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-12295. - Resolution: Won't Do Validation related to upgrade can only be done in Ozone Manager, so

Re: [PR] HDDS-12353. Move SpaceUsage implementations to hdds-server-framework [ozone]

2025-02-21 Thread via GitHub
adoroszlai commented on PR #7926: URL: https://github.com/apache/ozone/pull/7926#issuecomment-2676017767 Thanks @nandakumar131 for reviewing and merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Commented] (HDDS-11839) Mismatch in leadership transfer node ID

2025-02-21 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/HDDS-11839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929310#comment-17929310 ] Peter Lee commented on HDDS-11839: -- Currently, some information is only known by individ

[jira] [Commented] (HDDS-12109) Transfer leadership should not start until target SCM is out of safe mode

2025-02-21 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929309#comment-17929309 ] Peter Lee commented on HDDS-12109: -- [~ivanandika] Is it possible to query other SCM stat

Re: [PR] HDDS-12353. Move SpaceUsage implementations to hdds-server-framework [ozone]

2025-02-21 Thread via GitHub
nandakumar131 merged PR #7926: URL: https://github.com/apache/ozone/pull/7926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.a

[jira] [Updated] (HDDS-12353) Move SpaceUsage implementations to hdds-server-framework

2025-02-21 Thread Nandakumar (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nandakumar updated HDDS-12353: -- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) The P

[jira] [Updated] (HDDS-11768) Extract SCM failover proxy provider logic

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-11768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-11768: --- Description: There are a lot of duplicated SCM proxy provider logic in * SCMBlockLocationFailoverPro

Re: [PR] HDDS-12353. Move SpaceUsage implementations to hdds-server-framework [ozone]

2025-02-21 Thread via GitHub
nandakumar131 commented on PR #7926: URL: https://github.com/apache/ozone/pull/7926#issuecomment-2676011369 Thanks @adoroszlai for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Resolved] (HDDS-10764) Tarball creation failing on leader OM node

2025-02-21 Thread Nandakumar (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nandakumar resolved HDDS-10764. --- Fix Version/s: 2.0.0 Resolution: Fixed The root cause of this issue is fixed by HDDS-12064.  

Re: [PR] HDDS-10764. Tarball creation failing on leader OM node. [ozone]

2025-02-21 Thread via GitHub
nandakumar131 commented on PR #7941: URL: https://github.com/apache/ozone/pull/7941#issuecomment-2675997481 Thanks @sadanand48 for the contribution and @hemantk-12 for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] HDDS-12236. ContainerStateMachine should not apply or write future transactions in the event of failure [ozone]

2025-02-21 Thread via GitHub
nandakumar131 commented on PR #7862: URL: https://github.com/apache/ozone/pull/7862#issuecomment-2675994701 > Having something in the raft log and not applying it & not having a txn in raft log is one and the same. Why have different states? The difference is `relying on quorum` vs `n

[jira] [Assigned] (HDDS-12109) Transfer leadership should not start until target SCM is out of safe mode

2025-02-21 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Lee reassigned HDDS-12109: Assignee: (was: Peter Lee) > Transfer leadership should not start until target SCM is out of s

[jira] [Updated] (HDDS-11768) Extract SCM failover proxy provider logic

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-11768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-11768: --- Description: There are a lot of duplicated SCM proxy provider logic in * SCMBlockLocationFailoverPro

Re: [PR] HDDS-11658. Skip known tombstones when scanning rocksdb deletedtable in KeyDeletingService [ozone]

2025-02-21 Thread via GitHub
jojochuang commented on code in PR #7436: URL: https://github.com/apache/ozone/pull/7436#discussion_r1966344268 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java: ## @@ -1592,17 +1592,22 @@ private PersistedUserVolumeInfo getVolume

[jira] [Updated] (HDDS-12078) Improve container reconciliation CLIs

2025-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-12078: -- Labels: pull-request-available (was: ) > Improve container reconciliation CLIs > -

[PR] HDDS-12078 improve cli [ozone]

2025-02-21 Thread via GitHub
errose28 opened a new pull request, #7944: URL: https://github.com/apache/ozone/pull/7944 ## What changes were proposed in this pull request? ### Summary Currently ozone admin container reconcile is used to trigger reconciliation for a specific container, but the resulting chec

[jira] [Commented] (HDDS-12394) config browser does not reflect reconfigured values

2025-02-21 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929282#comment-17929282 ] Siyao Meng commented on HDDS-12394: --- Thanks [~adoroszlai] for filing this. I spent a f

[jira] [Commented] (HDDS-12255) Replace deletes with DeleteRange

2025-02-21 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929277#comment-17929277 ] Siyao Meng commented on HDDS-12255: --- Note deleteRange may interfere with snapshot diff

[jira] [Updated] (HDDS-12078) Improve container reconciliation CLIs

2025-02-21 Thread Ethan Rose (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ethan Rose updated HDDS-12078: -- Description: Currently {{ozone admin container reconcile}} is used to trigger reconciliation for a spe

[jira] [Resolved] (HDDS-7415) Unify license headers according to the checkstyle rule

2025-02-21 Thread Ethan Rose (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ethan Rose resolved HDDS-7415. -- Resolution: Fixed > Unify license headers according to the checkstyle rule > ---

[jira] [Updated] (HDDS-12365) Provide editor settings and IDEA run config in standard location

2025-02-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12365: Summary: Provide editor settings and IDEA run config in standard location (was: Move IJ co

[jira] [Created] (HDDS-12396) Enable UnusedPrivateMethod check in PMD

2025-02-21 Thread Maksim Myskov (Jira)
Maksim Myskov created HDDS-12396: Summary: Enable UnusedPrivateMethod check in PMD Key: HDDS-12396 URL: https://issues.apache.org/jira/browse/HDDS-12396 Project: Apache Ozone Issue Type: New

[jira] [Updated] (HDDS-12397) Persist putBlock for closed container

2025-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-12397: -- Labels: pull-request-available (was: ) > Persist putBlock for closed container > -

[PR] HDDS-12397. Persist putBlock for closed container. [ozone]

2025-02-21 Thread via GitHub
aswinshakil opened a new pull request, #7943: URL: https://github.com/apache/ozone/pull/7943 ## What changes were proposed in this pull request? The `putBlock` call for `OPEN` container cannot be used for the `CLOSED` container and needs some modification to update `bscId` and remove chan

[jira] [Created] (HDDS-12397) Persist putBlock for closed container

2025-02-21 Thread Aswin Shakil (Jira)
Aswin Shakil created HDDS-12397: --- Summary: Persist putBlock for closed container Key: HDDS-12397 URL: https://issues.apache.org/jira/browse/HDDS-12397 Project: Apache Ozone Issue Type: Sub-task

Re: [PR] HDDS-11763. Implement container repair logic within datanodes. [ozone]

2025-02-21 Thread via GitHub
kerneltime commented on code in PR #7474: URL: https://github.com/apache/ozone/pull/7474#discussion_r1965988867 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/BlockManagerImpl.java: ## @@ -98,6 +98,86 @@ public long putBlock(Contai

[jira] [Commented] (HDDS-12255) Replace deletes with DeleteRange

2025-02-21 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929240#comment-17929240 ] Wei-Chiu Chuang commented on HDDS-12255: cc [~smeng] > Replace deletes with Dele

Re: [PR] HDDS-12387. Cleanup TestContainerOperations [ozone]

2025-02-21 Thread via GitHub
adoroszlai commented on PR #7940: URL: https://github.com/apache/ozone/pull/7940#issuecomment-2675241184 Thanks @chiacyu for the patch, @nandakumar131 for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Resolved] (HDDS-12387) Cleanup TestContainerOperations

2025-02-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-12387. - Fix Version/s: 2.0.0 Resolution: Done > Cleanup TestContainerOperations >

Re: [PR] HDDS-12387. Cleanup TestContainerOperations [ozone]

2025-02-21 Thread via GitHub
adoroszlai merged PR #7940: URL: https://github.com/apache/ozone/pull/7940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

Re: [PR] HDDS-12236. ContainerStateMachine should not apply or write future transactions in the event of failure [ozone]

2025-02-21 Thread via GitHub
swamirishi commented on code in PR #7862: URL: https://github.com/apache/ozone/pull/7862#discussion_r1965971880 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java: ## @@ -554,6 +564,11 @@ priv

Re: [PR] HDDS-12236. ContainerStateMachine should not apply or write future transactions in the event of failure [ozone]

2025-02-21 Thread via GitHub
swamirishi commented on code in PR #7862: URL: https://github.com/apache/ozone/pull/7862#discussion_r1965967818 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java: ## @@ -554,6 +564,11 @@ priv

Re: [PR] HDDS-12236. ContainerStateMachine should not apply or write future transactions in the event of failure [ozone]

2025-02-21 Thread via GitHub
swamirishi commented on code in PR #7862: URL: https://github.com/apache/ozone/pull/7862#discussion_r1965963102 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java: ## @@ -554,6 +564,11 @@ priv

Re: [PR] HDDS-12236. ContainerStateMachine should not apply or write future transactions in the event of failure [ozone]

2025-02-21 Thread via GitHub
swamirishi commented on PR #7862: URL: https://github.com/apache/ozone/pull/7862#issuecomment-2675205130 > @swamirishi, thanks for the explanation. > > When there is a failure in `applyTransaction` and we add the Container to `unhealthyContainerSet`, no more transactions are applied t

[jira] [Updated] (HDDS-12396) Enable UnusedPrivateMethod check in PMD

2025-02-21 Thread Maksim Myskov (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maksim Myskov updated HDDS-12396: - Description: This check will help to eliminate unused private methods. > Enable UnusedPrivateMeth

Re: [PR] HDDS-11763. Implement container repair logic within datanodes. [ozone]

2025-02-21 Thread via GitHub
kerneltime commented on code in PR #7474: URL: https://github.com/apache/ozone/pull/7474#discussion_r1965904343 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java: ## @@ -1473,24 +1476,210 @@ public void deleteContainer

Re: [PR] HDDS-11763. Implement container repair logic within datanodes. [ozone]

2025-02-21 Thread via GitHub
kerneltime commented on code in PR #7474: URL: https://github.com/apache/ozone/pull/7474#discussion_r1965940647 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java: ## @@ -1473,24 +1476,210 @@ public void deleteContainer

Re: [PR] HDDS-11763. Implement container repair logic within datanodes. [ozone]

2025-02-21 Thread via GitHub
kerneltime commented on code in PR #7474: URL: https://github.com/apache/ozone/pull/7474#discussion_r1965914659 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java: ## @@ -1473,24 +1476,210 @@ public void deleteContainer

Re: [PR] HDDS-11763. Implement container repair logic within datanodes. [ozone]

2025-02-21 Thread via GitHub
kerneltime commented on code in PR #7474: URL: https://github.com/apache/ozone/pull/7474#discussion_r1965896066 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java: ## @@ -1473,24 +1476,210 @@ public void deleteContainer

Re: [PR] HDDS-11763. Implement container repair logic within datanodes. [ozone]

2025-02-21 Thread via GitHub
kerneltime commented on code in PR #7474: URL: https://github.com/apache/ozone/pull/7474#discussion_r1965910277 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java: ## @@ -1473,24 +1476,210 @@ public void deleteContainer

Re: [PR] HDDS-11763. Implement container repair logic within datanodes. [ozone]

2025-02-21 Thread via GitHub
kerneltime commented on code in PR #7474: URL: https://github.com/apache/ozone/pull/7474#discussion_r1965910277 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java: ## @@ -1473,24 +1476,210 @@ public void deleteContainer

Re: [PR] HDDS-11763. Implement container repair logic within datanodes. [ozone]

2025-02-21 Thread via GitHub
kerneltime commented on code in PR #7474: URL: https://github.com/apache/ozone/pull/7474#discussion_r1965909141 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java: ## @@ -1473,24 +1476,210 @@ public void deleteContainer

Re: [PR] HDDS-11763. Implement container repair logic within datanodes. [ozone]

2025-02-21 Thread via GitHub
kerneltime commented on code in PR #7474: URL: https://github.com/apache/ozone/pull/7474#discussion_r1965904343 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java: ## @@ -1473,24 +1476,210 @@ public void deleteContainer

Re: [PR] HDDS-11763. Implement container repair logic within datanodes. [ozone]

2025-02-21 Thread via GitHub
kerneltime commented on code in PR #7474: URL: https://github.com/apache/ozone/pull/7474#discussion_r1965894348 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java: ## @@ -1473,24 +1476,210 @@ public void deleteContainer

Re: [PR] HDDS-11763. Implement container repair logic within datanodes. [ozone]

2025-02-21 Thread via GitHub
kerneltime commented on code in PR #7474: URL: https://github.com/apache/ozone/pull/7474#discussion_r1965901364 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerLogger.java: ## @@ -145,6 +147,16 @@ public static void logRecov

Re: [PR] HDDS-11763. Implement container repair logic within datanodes. [ozone]

2025-02-21 Thread via GitHub
kerneltime commented on code in PR #7474: URL: https://github.com/apache/ozone/pull/7474#discussion_r1965901364 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerLogger.java: ## @@ -145,6 +147,16 @@ public static void logRecov

Re: [PR] HDDS-11763. Implement container repair logic within datanodes. [ozone]

2025-02-21 Thread via GitHub
kerneltime commented on code in PR #7474: URL: https://github.com/apache/ozone/pull/7474#discussion_r1965897754 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java: ## @@ -1473,24 +1476,210 @@ public void deleteContainer

Re: [PR] HDDS-12236. ContainerStateMachine should not apply or write future transactions in the event of failure [ozone]

2025-02-21 Thread via GitHub
nandakumar131 commented on PR #7862: URL: https://github.com/apache/ozone/pull/7862#issuecomment-2675082073 @swamirishi, thanks for the explanation. When there is a failure in `applyTransaction` and we add the Container to `unhealthyContainerSet`, no more transactions are applied to t

[jira] [Updated] (HDDS-12365) Move IJ code style file into shareable folder

2025-02-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12365: Fix Version/s: 2.0.0 Resolution: Implemented Status: Resolved (was: Patch

Re: [PR] HDDS-12365. Sync IJ code style and run config via git [ozone]

2025-02-21 Thread via GitHub
adoroszlai merged PR #7924: URL: https://github.com/apache/ozone/pull/7924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

[jira] [Assigned] (HDDS-11768) Extract SCM failover proxy provider logic

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-11768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika reassigned HDDS-11768: -- Assignee: Ivan Andika > Extract SCM failover proxy provider logic > --

Re: [PR] HDDS-11887. Recon - Identify container replicas difference based on content checksums [ozone]

2025-02-21 Thread via GitHub
devmadhuu commented on code in PR #7942: URL: https://github.com/apache/ozone/pull/7942#discussion_r1965565445 ## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthTask.java: ## @@ -650,6 +665,17 @@ private static boolean keepMisReplicatedRecord(

[jira] [Commented] (HDDS-12388) Key rewrite tests should be skipped if feature is disabled

2025-02-21 Thread Chia-Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929174#comment-17929174 ] Chia-Chuan Yu commented on HDDS-12388: -- Will do, huge thanks to the hints! > Key re

[jira] [Comment Edited] (HDDS-12388) Key rewrite tests should be skipped if feature is disabled

2025-02-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929168#comment-17929168 ] Attila Doroszlai edited comment on HDDS-12388 at 2/21/25 2:24 PM: -

[jira] [Commented] (HDDS-12388) Key rewrite tests should be skipped if feature is disabled

2025-02-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929168#comment-17929168 ] Attila Doroszlai commented on HDDS-12388: - Thanks [~chiacyu] for picking this up.

[jira] [Commented] (HDDS-12388) Key rewrite tests should be skipped if feature is disabled

2025-02-21 Thread Chia-Chuan Yu (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17929163#comment-17929163 ] Chia-Chuan Yu commented on HDDS-12388: -- Hi, [~adoroszlai]  May I also help on this

[jira] [Assigned] (HDDS-12388) Key rewrite tests should be skipped if feature is disabled

2025-02-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai reassigned HDDS-12388: --- Assignee: Chia-Chuan Yu (was: Attila Doroszlai) > Key rewrite tests should be skipp

Re: [PR] HDDS-12357. Add indicators to Overview page data for OmInsightTask [ozone]

2025-02-21 Thread via GitHub
devmadhuu commented on code in PR #7912: URL: https://github.com/apache/ozone/pull/7912#discussion_r1965407198 ## hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/pages/overview/components/SummaryCardGroup.tsx: ## @@ -0,0 +1,149 @@ +/* + * Licensed to t

Re: [PR] HDDS-12062. Recon - Error handling in NSSummaryTask to avoid data inconsistencies. [ozone]

2025-02-21 Thread via GitHub
devmadhuu commented on PR #7723: URL: https://github.com/apache/ozone/pull/7723#issuecomment-2674453640 @ArafatKhan2198 merge conflicts resolved after merging of [PR #7796 ](https://github.com/apache/ozone/pull/7796) . Kindly review. -- This is an automated message from the Apache Git Se

[jira] [Updated] (HDDS-11887) Recon - Identify container replicas difference based on content checksums

2025-02-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-11887: Summary: Recon - Identify container replicas difference based on content checksums (was: O

[jira] [Updated] (HDDS-11887) Ozone Recon - Identify container replicas difference based on content checksums

2025-02-21 Thread Zita Dombi (Jira)
[ https://issues.apache.org/jira/browse/HDDS-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zita Dombi updated HDDS-11887: -- Status: Patch Available (was: Open) > Ozone Recon - Identify container replicas difference based on co

[jira] [Updated] (HDDS-11887) Ozone Recon - Identify container replicas difference based on content checksums

2025-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-11887: -- Labels: pull-request-available (was: ) > Ozone Recon - Identify container replicas difference

Re: [PR] HDDS-12373. Change calculation logic for volume reserved space [ozone]

2025-02-21 Thread via GitHub
adoroszlai commented on PR #7927: URL: https://github.com/apache/ozone/pull/7927#issuecomment-2674238198 > IMO, the reserved configuration is to make sure there are enough space left for Ozone usage, and for this goal, a 50GB space left would be enough. According to config doc, `hdds.

Re: [PR] HDDS-12365. Sync IJ code style and run config via git [ozone]

2025-02-21 Thread via GitHub
ivanzlenko commented on PR #7924: URL: https://github.com/apache/ozone/pull/7924#issuecomment-2674233965 @adoroszlai thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] HDDS-12365. Sync IJ code style and run config via git [ozone]

2025-02-21 Thread via GitHub
ivanzlenko commented on code in PR #7924: URL: https://github.com/apache/ozone/pull/7924#discussion_r1965282137 ## .editorconfig: ## @@ -0,0 +1,61 @@ +[*] +charset = utf-8 +end_of_line = lf +indent_size = 2 +indent_style = space +insert_final_newline = false Review Comment:

[jira] [Updated] (HDDS-9174) Native library loader fails when system property "native.lib.tmp.dir" is not set

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-9174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-9174: -- Fix Version/s: 1.4.0 > Native library loader fails when system property "native.lib.tmp.dir" is not > s

Re: [PR] HDDS-12373. Change calculation logic for volume reserved space [ozone]

2025-02-21 Thread via GitHub
symious commented on code in PR #7927: URL: https://github.com/apache/ozone/pull/7927#discussion_r1965238743 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeUsage.java: ## @@ -68,23 +68,24 @@ SpaceUsageSource realUsage() {

Re: [PR] HDDS-12373. Change calculation logic for volume reserved space [ozone]

2025-02-21 Thread via GitHub
symious commented on code in PR #7927: URL: https://github.com/apache/ozone/pull/7927#discussion_r1965202257 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeUsage.java: ## @@ -68,23 +68,24 @@ SpaceUsageSource realUsage() {

[jira] [Updated] (HDDS-8818) Intermittent timeout in TestManagedSstFileReader

2025-02-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-8818: --- Summary: Intermittent timeout in TestManagedSstFileReader (was: [disabled] Intermittent timeo

[jira] [Updated] (HDDS-12293) Make ozone.om.server.list.max.size reconfigurable

2025-02-21 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-12293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-12293: Fix Version/s: 2.0.0 Resolution: Implemented Status: Resolved (was: Patch

Re: [PR] HDDS-12293. Make ozone.om.server.list.max.size reconfigurable [ozone]

2025-02-21 Thread via GitHub
adoroszlai merged PR #7938: URL: https://github.com/apache/ozone/pull/7938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apac

Re: [PR] [Branch rebase] Merge master into disk balancer feature branch HDDS-5713 [ozone]

2025-02-21 Thread via GitHub
ChenSammi merged PR #7935: URL: https://github.com/apache/ozone/pull/7935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apach

Re: [PR] HDDS-12373. Change calculation logic for volume reserved space [ozone]

2025-02-21 Thread via GitHub
adoroszlai commented on code in PR #7927: URL: https://github.com/apache/ozone/pull/7927#discussion_r1965140992 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeUsage.java: ## @@ -68,23 +68,24 @@ SpaceUsageSource realUsage() {

[jira] [Updated] (HDDS-9209) Re-enable check for backup compaction files pruning

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-9209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-9209: -- Fix Version/s: 1.4.0 > Re-enable check for backup compaction files pruning > ---

Re: [PR] HDDS-12373. Change calculation logic for volume reserved space [ozone]

2025-02-21 Thread via GitHub
symious commented on PR #7927: URL: https://github.com/apache/ozone/pull/7927#issuecomment-2674029430 > User may set the "hdds.datanode.dir.du.reserved.percent" to 20% or 30%. Then it will be too much for this new calculation logic. IMO, the reserved configuration is to make sure ther

[jira] [Updated] (HDDS-8904) Fix Snapdiff output for key renames

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-8904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-8904: -- Fix Version/s: 1.4.0 > Fix Snapdiff output for key renames > --- > >

[jira] [Updated] (HDDS-9215) Snapshot Chain corruption because snapshot chain need not be created in increasing order of CreatedTime

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-9215: -- Fix Version/s: 1.4.0 > Snapshot Chain corruption because snapshot chain need not be created in > increa

[jira] [Updated] (HDDS-11408) Snapshot rename table entries are propagated incorrectly on snapshot deletes

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-11408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-11408: --- Fix Version/s: 2.0.0 > Snapshot rename table entries are propagated incorrectly on snapshot deletes >

[jira] [Updated] (HDDS-11818) Efficient diff falls back to full diff is there is no difference in DAG

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-11818: --- Fix Version/s: 2.0.0 > Efficient diff falls back to full diff is there is no difference in DAG >

[jira] [Updated] (HDDS-8863) Snapdiff should read only keys with the bucket prefix

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-8863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-8863: -- Fix Version/s: 1.4.0 > Snapdiff should read only keys with the bucket prefix > -

[jira] [Updated] (HDDS-9236) Fix snapdiff output for key modification

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-9236: -- Fix Version/s: 1.4.0 > Fix snapdiff output for key modification > --

[jira] [Updated] (HDDS-8818) [disabled] Intermittent timeout in TestManagedSstFileReader

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-8818: -- Fix Version/s: 2.0.0 > [disabled] Intermittent timeout in TestManagedSstFileReader > ---

[jira] [Updated] (HDDS-10434) Add permission check for snapshot diff

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-10434: --- Fix Version/s: 2.0.0 > Add permission check for snapshot diff > -

[jira] [Updated] (HDDS-10833) SnapshotDiff CLI should provide Json output option

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-10833: --- Fix Version/s: 2.0.0 > SnapshotDiff CLI should provide Json output option > -

[jira] [Updated] (HDDS-9317) [snapshot] Ozone snapshot diff should provide an option for displaying output as json format

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-9317: -- Fix Version/s: 2.0.0 > [snapshot] Ozone snapshot diff should provide an option for displaying output >

[jira] [Updated] (HDDS-11818) Efficient diff falls back to full diff is there is no difference in DAG

2025-02-21 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-11818: --- Fix Version/s: (was: 2.0.0) > Efficient diff falls back to full diff is there is no difference in

[jira] [Updated] (HDDS-10764) Tarball creation failing on leader OM node

2025-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-10764: -- Labels: pull-request-available (was: ) > Tarball creation failing on leader OM node >

Re: [PR] HDDS-12373. Change calculation logic for volume reserved space [ozone]

2025-02-21 Thread via GitHub
ChenSammi commented on PR #7927: URL: https://github.com/apache/ozone/pull/7927#issuecomment-2673908021 One thing I just thought about is, with this new change, if user has ever set the "hdds.datanode.dir.du.reserved" or "hdds.datanode.dir.du.reserved.percent", for those non ozone services,

  1   2   >