Re: [PR] NIFI-14469 - Support custom fields in AccessToken [nifi]

2025-04-17 Thread via GitHub
exceptionfactory merged PR #9872: URL: https://github.com/apache/nifi/pull/9872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.

Re: [PR] NIFI-14469 - Support custom fields in AccessToken [nifi]

2025-04-17 Thread via GitHub
pvillard31 commented on PR #9872: URL: https://github.com/apache/nifi/pull/9872#issuecomment-2812227447 Changes LGTM, thanks @exceptionfactory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] NIFI-14469 - Support custom fields in AccessToken [nifi]

2025-04-15 Thread via GitHub
pvillard31 commented on PR #9872: URL: https://github.com/apache/nifi/pull/9872#issuecomment-2806946057 Addressed your comments - this concept of JsonView is new to me, appreciate the guidance! -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] NIFI-14469 - Support custom fields in AccessToken [nifi]

2025-04-15 Thread via GitHub
exceptionfactory commented on code in PR #9872: URL: https://github.com/apache/nifi/pull/9872#discussion_r2044727847 ## nifi-extension-bundles/nifi-standard-services/nifi-oauth2-provider-api/src/main/java/org/apache/nifi/oauth2/AccessTokenViews.java: ## @@ -0,0 +1,28 @@ +/* + *

Re: [PR] NIFI-14469 - Support custom fields in AccessToken [nifi]

2025-04-15 Thread via GitHub
pvillard31 commented on PR #9872: URL: https://github.com/apache/nifi/pull/9872#issuecomment-2804502215 Thanks @exceptionfactory - I was not aware of the JsonView annotation. I just pushed a commit to leverage it. Let me know if this is what you had in mind. -- This is an automated messa

Re: [PR] NIFI-14469 - Support custom fields in AccessToken [nifi]

2025-04-14 Thread via GitHub
pvillard31 commented on PR #9872: URL: https://github.com/apache/nifi/pull/9872#issuecomment-2802061487 Thanks for the review @exceptionfactory - I just pushed a commit where I'm instead using a custom deserializer to not add a Jackson dependency on the API. The only downside I see with thi

Re: [PR] NIFI-14469 - Support custom fields in AccessToken [nifi]

2025-04-11 Thread via GitHub
exceptionfactory commented on code in PR #9872: URL: https://github.com/apache/nifi/pull/9872#discussion_r2040320537 ## nifi-extension-bundles/nifi-standard-services/nifi-oauth2-provider-api/pom.xml: ## @@ -22,4 +22,10 @@ nifi-oauth2-provider-api jar + +