exceptionfactory commented on code in PR #9872: URL: https://github.com/apache/nifi/pull/9872#discussion_r2040320537
########## nifi-extension-bundles/nifi-standard-services/nifi-oauth2-provider-api/pom.xml: ########## @@ -22,4 +22,10 @@ </parent> <artifactId>nifi-oauth2-provider-api</artifactId> <packaging>jar</packaging> + <dependencies> + <dependency> + <groupId>com.fasterxml.jackson.core</groupId> + <artifactId>jackson-databind</artifactId> Review Comment: Introducing this dependency at the API level seems problematic. At minimum, this should be limited to the jackson-annotation library. However, I recommend an alternative approach that handles the custom fields through an ObjectMapper configuration in the implementation class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org