Re: [PR] NIFI-14458 - Added run command to nifi.cmd [nifi]

2025-04-23 Thread via GitHub
philci52 commented on PR #9869: URL: https://github.com/apache/nifi/pull/9869#issuecomment-2824197142 I can work on this, but it will take me a few weeks to get back to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] NIFI-14458 - Added run command to nifi.cmd [nifi]

2025-04-21 Thread via GitHub
exceptionfactory commented on PR #9869: URL: https://github.com/apache/nifi/pull/9869#issuecomment-2818531634 Thanks for checking @philci52, I evaluated some options last week using the existing run command, but didn't find a satisfactory solution. At the moment, evaluating the impact

Re: [PR] NIFI-14458 - Added run command to nifi.cmd [nifi]

2025-04-21 Thread via GitHub
philci52 commented on PR #9869: URL: https://github.com/apache/nifi/pull/9869#issuecomment-2818469270 @exceptionfactory Any updates on how you want to handle the issues here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] NIFI-14458 - Added run command to nifi.cmd [nifi]

2025-04-11 Thread via GitHub
philci52 commented on PR #9869: URL: https://github.com/apache/nifi/pull/9869#issuecomment-2797958617 Here is a comment from some of our internal code regarding the use of process builder and windows/linux differences. This application uses an XML file for configuration, but I figured it w

Re: [PR] NIFI-14458 - Added run command to nifi.cmd [nifi]

2025-04-11 Thread via GitHub
exceptionfactory commented on PR #9869: URL: https://github.com/apache/nifi/pull/9869#issuecomment-2797836723 Good question @philci52, the `List command` property of `ProcessBuilder` may not need the escaping. I will take a closer look at this and follow up soon. One other pote

Re: [PR] NIFI-14458 - Added run command to nifi.cmd [nifi]

2025-04-11 Thread via GitHub
philci52 commented on PR #9869: URL: https://github.com/apache/nifi/pull/9869#issuecomment-2797676195 @exceptionfactory Thank you for the quick feedback. There is one other path that may need to be quoted and that is the (7) path to java itself. With regards to using StandardProcessB

Re: [PR] NIFI-14458 - Added run command to nifi.cmd [nifi]

2025-04-11 Thread via GitHub
exceptionfactory commented on PR #9869: URL: https://github.com/apache/nifi/pull/9869#issuecomment-2797408560 Thanks for the thoughtful evaluation of options @philci52. I think there are two different elements to consider. The first aspect is bootstrap.conf. Property values usin

Re: [PR] NIFI-14458 - Added run command to nifi.cmd [nifi]

2025-04-11 Thread via GitHub
philci52 commented on PR #9869: URL: https://github.com/apache/nifi/pull/9869#issuecomment-2797338210 @exceptionfactory Fixing the issue with the paths that have spaces in the GetRunCommandBootstrapCommand.java is a potentially breaking change. If I just surround all arguments with double

Re: [PR] NIFI-14458 - Added run command to nifi.cmd [nifi]

2025-04-10 Thread via GitHub
philci52 commented on PR #9869: URL: https://github.com/apache/nifi/pull/9869#issuecomment-2794674464 Looks like there will be more issues with paths that have spaces (probably an issue on linux too). https://github.com/apache/nifi/blob/main/nifi-bootstrap/src/main/java/org/apache/nifi/boo

Re: [PR] NIFI-14458 - Added run command to nifi.cmd [nifi]

2025-04-10 Thread via GitHub
philci52 commented on PR #9869: URL: https://github.com/apache/nifi/pull/9869#issuecomment-2794619852 I guess I don't understand the difference. Is it in the Java code? Will I still be able to run "nifi stop" to stop the application if run that way? -- This is an automated message from

Re: [PR] NIFI-14458 - Added run command to nifi.cmd [nifi]

2025-04-10 Thread via GitHub
exceptionfactory commented on PR #9869: URL: https://github.com/apache/nifi/pull/9869#issuecomment-2794628783 Here's the section of `nifi.sh` that handles the `run` command: https://github.com/apache/nifi/blob/main/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources