philci52 commented on PR #9869: URL: https://github.com/apache/nifi/pull/9869#issuecomment-2797338210
@exceptionfactory Fixing the issue with the paths that have spaces in the GetRunCommandBootstrapCommand.java is a potentially breaking change. If I just surround all arguments with double quotes, while that works for me, it will break any users who have figured out that they need quotes in bootstrap.conf. I'm not sure how common this use case is. For example, if I have `java.arg.7="-Dtest=test test"` in my boostrap.conf to get around this existing bug, then simply wrapping the arguments with double quotes would result in the following in the returned command: `""-Dtest=test test""` rather than then previous `"-Dtest=test test"`. Additionally, another way to get around this on windows would have been to use the caret to escape the next character, for example, I could have used `java.arg.7=-Dtest=test^ test` to get around the existing bug. Surrounding this with double quotes would result in keeping the carat in the string. I don't think this solution is used a lot, but its a possibility. So, this leaves a few courses of action that I see 1) Introduce the double quotes, potentially breaking things and let users update their bootstrap.conf when conflicts occur. 2) Check to see if an argument is already wrapped in double quotes before wrapping it, which would not find all cases (for example `-Dtest=test" "test,`) but would allow most of the existing cases to work as is. This does introduce an inconsistency in how things work though 3) Add a java or bootstrap property to determine if commands should be wrapped. I'm not a fan of this myself as it creates some potential issues, documentation, maintenance, etc 4) Other options similar to 2 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
