Re: [PR] MINIFICPP-2542 ConsumeKafka late offset commit [nifi-minifi-cpp]

szaszm commented on code in PR #1946: URL: https://github.com/apache/nifi-minifi-cpp/pull/1946#discussion_r2085024024 ## docker/DockerVerify.sh: ## @@ -177,7 +177,7 @@ TEST_DIRECTORY="${docker_dir}/test/integration" export TEST_DIRECTORY # Add --no-logcapture to see logs int

Re: [PR] MINIFICPP-2542 ConsumeKafka late offset commit [nifi-minifi-cpp]

martinzink commented on code in PR #1946: URL: https://github.com/apache/nifi-minifi-cpp/pull/1946#discussion_r2081519477 ## thirdparty/fmt/add_error_message_to_std__error_code_formatter.patch: ## Review Comment: thats a good idea, I've removed the patch and added a wrapepr

Re: [PR] MINIFICPP-2542 ConsumeKafka late offset commit [nifi-minifi-cpp]

szaszm commented on code in PR #1946: URL: https://github.com/apache/nifi-minifi-cpp/pull/1946#discussion_r2075361065 ## thirdparty/fmt/add_error_message_to_std__error_code_formatter.patch: ## Review Comment: Looking at the error code ostream writer operator, it doesn't pri

Re: [PR] MINIFICPP-2542 ConsumeKafka late offset commit [nifi-minifi-cpp]

martinzink commented on code in PR #1946: URL: https://github.com/apache/nifi-minifi-cpp/pull/1946#discussion_r2073744732 ## thirdparty/fmt/add_error_message_to_std__error_code_formatter.patch: ## Review Comment: I rather keep it this way, its a smaller divergence from soon

Re: [PR] MINIFICPP-2542 ConsumeKafka late offset commit [nifi-minifi-cpp]

martinzink commented on code in PR #1946: URL: https://github.com/apache/nifi-minifi-cpp/pull/1946#discussion_r2073741726 ## extensions/standard-processors/tests/unit/SplitTextTests.cpp: ## @@ -192,7 +192,7 @@ void runSplitTextTest(const std::string& input, const std::vector("S

Re: [PR] MINIFICPP-2542 ConsumeKafka late offset commit [nifi-minifi-cpp]

martinzink commented on code in PR #1946: URL: https://github.com/apache/nifi-minifi-cpp/pull/1946#discussion_r2073741222 ## extensions/kafka/ConsumeKafka.cpp: ## @@ -18,68 +18,72 @@ #include "ConsumeKafka.h" #include +#include #include "core/FlowFile.h" #include "core

Re: [PR] MINIFICPP-2542 ConsumeKafka late offset commit [nifi-minifi-cpp]

szaszm commented on PR #1946: URL: https://github.com/apache/nifi-minifi-cpp/pull/1946#issuecomment-2835805303 finished with the review, I don't have objections other than the existing open threads -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] MINIFICPP-2542 ConsumeKafka late offset commit [nifi-minifi-cpp]

martinzink commented on code in PR #1946: URL: https://github.com/apache/nifi-minifi-cpp/pull/1946#discussion_r2058203285 ## extensions/kafka/ConsumeKafka.h: ## @@ -20,206 +20,274 @@ #include #include #include -#include #include +#include "KafkaConnection.h" #include

Re: [PR] MINIFICPP-2542 ConsumeKafka late offset commit [nifi-minifi-cpp]

szaszm commented on code in PR #1946: URL: https://github.com/apache/nifi-minifi-cpp/pull/1946#discussion_r2056305505 ## extensions/kafka/ConsumeKafka.cpp: ## @@ -18,68 +18,72 @@ #include "ConsumeKafka.h" #include +#include #include "core/FlowFile.h" #include "core/Pro

Re: [PR] MINIFICPP-2542 ConsumeKafka late offset commit [nifi-minifi-cpp]

szaszm commented on code in PR #1946: URL: https://github.com/apache/nifi-minifi-cpp/pull/1946#discussion_r2039710124 ## utils/include/utils/AttributeErrors.h: ## @@ -0,0 +1,48 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic