szaszm commented on code in PR #1946: URL: https://github.com/apache/nifi-minifi-cpp/pull/1946#discussion_r2039710124
########## utils/include/utils/AttributeErrors.h: ########## @@ -0,0 +1,48 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <string> +#include <system_error> + +#include "fmt/format.h" +#include "magic_enum.hpp" + +namespace org::apache::nifi::minifi::core { + +enum class AttributeErrorCode : std::underlying_type_t<std::byte> { MissingAttribute }; + +struct AttributeErrorCategory final : std::error_category { + [[nodiscard]] const char* name() const noexcept override { return "MiNiFi Attribute Error Category"; } + + [[nodiscard]] std::string message(int ev) const override { + const auto ec = static_cast<AttributeErrorCode>(ev); + auto e_str = std::string{magic_enum::enum_name<AttributeErrorCode>(ec)}; + if (e_str.empty()) { return fmt::format("UNKNOWN ERROR {}", ev); } + return e_str; + } +}; + +const AttributeErrorCategory& attribute_error_category() noexcept; +std::error_code make_error_code(AttributeErrorCode c); + +} // namespace org::apache::nifi::minifi::core + +template<> +struct std::is_error_code_enum<org::apache::nifi::minifi::core::AttributeErrorCode> : std::true_type {}; Review Comment: ```suggestion struct std::is_error_code_enum<org::apache::nifi::minifi::core::AttributeErrorCode> : std::true_type {}; ``` ########## extensions/standard-processors/tests/unit/SplitTextTests.cpp: ########## @@ -192,7 +192,7 @@ void runSplitTextTest(const std::string& input, const std::vector<ExpectedSplitT TEST_CASE("Line Split Count property is required") { SingleProcessorTestController controller{std::make_unique<processors::SplitText>("SplitText")}; - REQUIRE_THROWS_WITH(controller.trigger("", {}), "Expected parsable uint64_t from SplitText::Line Split Count: property error: PropertyNotSet (2)"); + REQUIRE_THROWS_WITH(controller.trigger("", {}), "Expected parsable uint64_t from \"SplitText::Line Split Count\", but got MiNiFi Property Error Category:2 (PropertyNotSet)"); Review Comment: The category words are unnecessary, and I'm not sure about including MiNiFi either: it's probably obvious from the context, and shorter errors are better when they convey the same meaning. ########## thirdparty/fmt/add_error_message_to_std__error_code_formatter.patch: ########## Review Comment: If we're patching it anyway, we might as well put the message first and the integer error code in parens, similar to how it was before in SplitTextTests.cpp:195. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
